155510 2016-03-15 14:02:12 -0700 Silence leaks in ParkingLot 2016-03-17 11:54:46 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo ap benjamin cdumez cmarcelo commit-queue oldest_to_newest 1175097 0 fpizlo 2016-03-15 14:02:12 -0700 Patch forthcoming. 1175098 1 274125 fpizlo 2016-03-15 14:07:49 -0700 Created attachment 274125 the patch 1175102 2 274125 ap 2016-03-15 14:13:06 -0700 Comment on attachment 274125 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=274125&action=review > Source/WTF/wtf/ParkingLot.cpp:183 > +Vector<Hashtable*>* hashtables; Should this be static? 1175103 3 fpizlo 2016-03-15 14:13:44 -0700 (In reply to comment #2) > Comment on attachment 274125 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=274125&action=review > > > Source/WTF/wtf/ParkingLot.cpp:183 > > +Vector<Hashtable*>* hashtables; > > Should this be static? The whole thing is in an anonymous namespace, so it doesn't have to be. 1175112 4 ap 2016-03-15 14:31:36 -0700 Indeed. See also: <https://lists.macosforge.org/pipermail/webkit-dev/2011-October/018303.html>. 1175798 5 fpizlo 2016-03-17 11:54:46 -0700 Landed in http://trac.webkit.org/changeset/198345 274125 2016-03-15 14:07:49 -0700 2016-03-15 14:13:06 -0700 the patch blah.patch text/plain 7016 fpizlo SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxOTgyMjgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDQ1IEBACisyMDE2LTAzLTE1ICBGaWxpcCBQaXpsbyAgPGZwaXps b0BhcHBsZS5jb20+CisKKyAgICAgICAgU2lsZW5jZSBsZWFrcyBpbiBQYXJraW5nTG90CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU1MTAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYXJraW5nTG90IGhh cyBhIGNvbmN1cnJlbnQgaGFzaHRhYmxlIHRoYXQgaXQgcmVhbGxvY2F0ZXMgb24gZGVtYW5kLiBJ dCB3aWxsIG5vdCByZWFsbG9jYXRlCisgICAgICAgIGl0IGluIHN0ZWFkeSBzdGF0ZS4gVGhlIGhh c2h0YWJsZSBpcyBzaXplZCB0byBhY2NvbW1vZGF0ZSB0aGUgaGlnaCB3YXRlcm1hcmsgb2YgdGhl IG51bWJlcgorICAgICAgICBvZiBhY3RpdmUgdGhyZWFkcyAtIHNvIGxvbmcgYXMgdGhlIHByb2dy YW0gZG9lc24ndCBqdXN0IGtlZXAgc3RhcnRpbmcgYW4gdW5ib3VuZGVkIG51bWJlcgorICAgICAg ICBvZiB0aHJlYWRzIHRoYXQgYXJlIGFsbCBhY3RpdmUsIHRoZSBoYXNodGFibGUgd2lsbCBzdG9w IHJlc2l6aW5nLiBFYWNoIHJlc2l6ZSBvcGVyYXRpb24gaXMKKyAgICAgICAgZGVzaWduZWQgdG8g c3RheSBvdXQgb2YgdGhlIHdheSBvZiB0aGUgZGF0YS1hY2Nlc3MtcGFyYWxsZWwgbm9ybWFsIHBh dGgsIGluIHdoaWNoIHR3bworICAgICAgICB0aHJlYWRzIG9wZXJhdGluZyBvbiBkaWZmZXJlbnQg bG9jayBhZGRyZXNzZXMgZG9uJ3QgaGF2ZSB0byBzeW5jaHJvbml6ZS4gVG8gZG8gdGhpcywgaXQK KyAgICAgICAgc2ltcGx5IGRyb3BzIHRoZSBvbGQgaGFzaHRhYmxlIHdpdGhvdXQgZGVsZXRpbmcg aXQsIHNvIHRoYXQgdGhyZWFkcyB0aGF0IHdlcmUgc3RpbGwgdXNpbmcKKyAgICAgICAgaXQgZG9u J3QgY3Jhc2guIFRoZXkgd2lsbCByZWFsaXplIHRoYXQgdGhleSBoYXZlIHRoZSB3cm9uZyBoYXNo dGFibGUgYmVmb3JlIGRvaW5nIGFueXRoaW5nCisgICAgICAgIGJhZCwgYnV0IHdlIGRvbid0IGhh dmUgYSB3YXkgb2YgcHJvdmluZyB3aGVuIGFsbCBvZiB0aG9zZSB0aHJlYWRzIGFyZSBubyBsb25n ZXIgZ29pbmcgdG8KKyAgICAgICAgcmVhZCBmcm9tIHRoZSBvbGQgaGFzaHRhYmxlcy4gU28sIHdl IGp1c3QgbGVhayB0aGVtLgorCisgICAgICAgIFRoaXMgaXMgYSBib3VuZGVkIGxlYWssIHNpbmNl IHRoZSBoYXNodGFibGUgcmVzaXplcyBleHBvbmVudGlhbGx5LiBUaHVzIHRoZSB0b3RhbCBtZW1v cnkKKyAgICAgICAgdXRpbGl6YXRpb24gb2YgYWxsIGhhc2h0YWJsZXMsIGluY2x1ZGluZyB0aGUg bGVha2VkIG9uZXMsIGNvbnZlcmdlcyB0byBhIGxpbmVhciBmdW5jdGlvbiBvZgorICAgICAgICB0 aGUgY3VycmVudCBoYXNodGFibGUncyBzaXplIChpdCdzIDIgKiBzaXplIG9mIGN1cnJlbnQgaGFz aHRhYmxlKS4KKworICAgICAgICBCdXQgdGhpcyBsZWFrIGlzIGEgcHJvYmxlbSBmb3IgbGVha3Mg dG9vbHMsIHdoaWNoIHdpbGwgYWx3YXlzIHJlcG9ydCB0aGlzIGxlYWsuIFRoaXMgaXMgbm90Cisg ICAgICAgIHVzZWZ1bC4gSXQncyBiZXR0ZXIgdG8gc2lsZW5jZSB0aGUgbGVhay4gVGhhdCdzIHdo YXQgdGhpcyBwYXRjaCBkb2VzIGJ5IGVuc3VyaW5nIHRoYXQgYWxsCisgICAgICAgIGhhc2h0YWJs ZXMsIGluY2x1ZGluZyBsZWFrZWQgb25lcywgZW5kIHVwIGluIGEgZ2xvYmFsIHZlY3Rvci4gVGhp cyBpcyBwZXJmLW5ldXRyYWwuCisKKyAgICAgICAgVGhpcyByZXF1aXJlcyBtYWtpbmcgYSBTdGF0 aWNXb3JkTG9jayB2YXJpYW50IG9mIFdvcmRMb2NrLiBUaGF0J3MgcHJvYmFibHkgdGhlIGJpZ2dl c3QgcGFydAorICAgICAgICBvZiB0aGlzIGNoYW5nZS4KKworICAgICAgICAqIHd0Zi9QYXJraW5n TG90LmNwcDoKKyAgICAgICAgKiB3dGYvV29yZExvY2suY3BwOgorICAgICAgICAoV1RGOjpXb3Jk TG9ja0Jhc2U6OmxvY2tTbG93KToKKyAgICAgICAgKFdURjo6V29yZExvY2tCYXNlOjp1bmxvY2tT bG93KToKKyAgICAgICAgKFdURjo6V29yZExvY2s6OmxvY2tTbG93KTogRGVsZXRlZC4KKyAgICAg ICAgKFdURjo6V29yZExvY2s6OnVubG9ja1Nsb3cpOiBEZWxldGVkLgorICAgICAgICAqIHd0Zi9X b3JkTG9jay5oOgorICAgICAgICAoV1RGOjpXb3JkTG9ja0Jhc2U6OmxvY2spOgorICAgICAgICAo V1RGOjpXb3JkTG9ja0Jhc2U6OmlzTG9ja2VkKToKKyAgICAgICAgKFdURjo6V29yZExvY2s6Oldv cmRMb2NrKToKKyAgICAgICAgKFdURjo6V29yZExvY2s6OmxvY2spOiBEZWxldGVkLgorICAgICAg ICAoV1RGOjpXb3JkTG9jazo6aXNMb2NrZWQpOiBEZWxldGVkLgorCiAyMDE2LTAzLTE0ICBNYXJr IExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBOZWVkIHRvIGRpc3Rpbmd1aXNo IGJldHdlZW4gU3ltYm9sKCkgYW5kIFN5bWJvbCgiIikuCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9Q YXJraW5nTG90LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9QYXJraW5nTG90LmNw cAkocmV2aXNpb24gMTk4MjI0KQorKysgU291cmNlL1dURi93dGYvUGFya2luZ0xvdC5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDE1IEFw cGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxNS0yMDE2 IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBh bmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1v ZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29u ZGl0aW9ucwpAQCAtMTc3LDYgKzE3NywxMiBAQCBwdWJsaWM6CiAgICAgY2hhciBwYWRkaW5nWzY0 XTsKIH07CiAKK3N0cnVjdCBIYXNodGFibGU7CisKKy8vIFdlIHRyYWNrIGFsbCBhbGxvY2F0ZWQg aGFzaHRhYmxlcyBzbyB0aGF0IGhhc2h0YWJsZSByZXNpemluZyBkb2Vzbid0IGFuZ2VyIGxlYWsg ZGV0ZWN0b3JzLgorVmVjdG9yPEhhc2h0YWJsZSo+KiBoYXNodGFibGVzOworU3RhdGljV29yZExv Y2sgaGFzaHRhYmxlc0xvY2s7CisKIHN0cnVjdCBIYXNodGFibGUgewogICAgIHVuc2lnbmVkIHNp emU7CiAgICAgQXRvbWljPEJ1Y2tldCo+IGRhdGFbMV07CkBAIC0xODgsMTEgKzE5NCwyOCBAQCBz dHJ1Y3QgSGFzaHRhYmxlIHsKICAgICAgICAgSGFzaHRhYmxlKiByZXN1bHQgPSBzdGF0aWNfY2Fz dDxIYXNodGFibGUqPigKICAgICAgICAgICAgIGZhc3RaZXJvZWRNYWxsb2Moc2l6ZW9mKEhhc2h0 YWJsZSkgKyBzaXplb2YoQXRvbWljPEJ1Y2tldCo+KSAqIChzaXplIC0gMSkpKTsKICAgICAgICAg cmVzdWx0LT5zaXplID0gc2l6ZTsKKworICAgICAgICB7CisgICAgICAgICAgICAvLyBUaGlzIGlz IG5vdCBmYXN0IGFuZCBpdCdzIG5vdCBkYXRhLWFjY2VzcyBwYXJhbGxlbCwgYnV0IHRoYXQncyBm aW5lLCBiZWNhdXNlCisgICAgICAgICAgICAvLyBoYXNodGFibGUgcmVzaXppbmcgaXMgZ3VhcmFu dGVlZCB0byBiZSByYXJlIGFuZCBpdCB3aWxsIG5ldmVyIGhhcHBlbiBpbiBzdGVhZHkKKyAgICAg ICAgICAgIC8vIHN0YXRlLgorICAgICAgICAgICAgV29yZExvY2tIb2xkZXIgbG9ja2VyKGhhc2h0 YWJsZXNMb2NrKTsKKyAgICAgICAgICAgIGlmICghaGFzaHRhYmxlcykKKyAgICAgICAgICAgICAg ICBoYXNodGFibGVzID0gbmV3IFZlY3RvcjxIYXNodGFibGUqPigpOworICAgICAgICAgICAgaGFz aHRhYmxlcy0+YXBwZW5kKHJlc3VsdCk7CisgICAgICAgIH0KKyAgICAgICAgCiAgICAgICAgIHJl dHVybiByZXN1bHQ7CiAgICAgfQogCiAgICAgc3RhdGljIHZvaWQgZGVzdHJveShIYXNodGFibGUq IGhhc2h0YWJsZSkKICAgICB7CisgICAgICAgIHsKKyAgICAgICAgICAgIC8vIFRoaXMgaXMgbm90 IGZhc3QsIGJ1dCB0aGF0J3MgT0suIFNlZSBjb21tZW50IGluIGNyZWF0ZSgpLgorICAgICAgICAg ICAgV29yZExvY2tIb2xkZXIgbG9ja2VyKGhhc2h0YWJsZXNMb2NrKTsKKyAgICAgICAgICAgIGhh c2h0YWJsZXMtPnJlbW92ZUZpcnN0KGhhc2h0YWJsZSk7CisgICAgICAgIH0KKyAgICAgICAgCiAg ICAgICAgIGZhc3RGcmVlKGhhc2h0YWJsZSk7CiAgICAgfQogfTsKSW5kZXg6IFNvdXJjZS9XVEYv d3RmL1dvcmRMb2NrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9Xb3JkTG9jay5j cHAJKHJldmlzaW9uIDE5ODIyNCkKKysrIFNvdXJjZS9XVEYvd3RmL1dvcmRMb2NrLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTUgQXBw bGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDE1LTIwMTYg QXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFu ZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9k aWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25k aXRpb25zCkBAIC03Nyw3ICs3Nyw3IEBAIFRocmVhZERhdGEqIG15VGhyZWFkRGF0YSgpCiAKIH0g Ly8gYW5vbnltb3VzIG5hbWVzcGFjZQogCi1ORVZFUl9JTkxJTkUgdm9pZCBXb3JkTG9jazo6bG9j a1Nsb3coKQorTkVWRVJfSU5MSU5FIHZvaWQgV29yZExvY2tCYXNlOjpsb2NrU2xvdygpCiB7CiAg ICAgdW5zaWduZWQgc3BpbkNvdW50ID0gMDsKIApAQCAtMTc4LDcgKzE3OCw3IEBAIE5FVkVSX0lO TElORSB2b2lkIFdvcmRMb2NrOjpsb2NrU2xvdygpCiAgICAgfQogfQogCi1ORVZFUl9JTkxJTkUg dm9pZCBXb3JkTG9jazo6dW5sb2NrU2xvdygpCitORVZFUl9JTkxJTkUgdm9pZCBXb3JkTG9ja0Jh c2U6OnVubG9ja1Nsb3coKQogewogICAgIC8vIFRoZSBmYXN0IHBhdGggY2FuIGZhaWwgZWl0aGVy IGJlY2F1c2Ugb2Ygc3B1cmlvdXMgd2VhayBDQVMgZmFpbHVyZSwgb3IgYmVjYXVzZSBzb21lb25l IHB1dCBhCiAgICAgLy8gdGhyZWFkIG9uIHRoZSBxdWV1ZSwgb3IgdGhlIHF1ZXVlIGxvY2sgaXMg aGVsZC4gSWYgdGhlIHF1ZXVlIGxvY2sgaXMgaGVsZCwgaXQgY2FuIG9ubHkgYmUKSW5kZXg6IFNv dXJjZS9XVEYvd3RmL1dvcmRMb2NrLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvV29y ZExvY2suaAkocmV2aXNpb24gMTk4MjI0KQorKysgU291cmNlL1dURi93dGYvV29yZExvY2suaAko d29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTUg QXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDE1LTIw MTYgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9u IGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICog bW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBj b25kaXRpb25zCkBAIC00MiwxNCArNDIsNyBAQCBuYW1lc3BhY2UgV1RGIHsKIC8vIExvY2sgaW5z dGVhZC4gV29yZExvY2sgc2l0cyBsb3dlciBpbiB0aGUgc3RhY2sgYW5kIGlzIHVzZWQgdG8gaW1w bGVtZW50IExvY2ssIHNvIExvY2sgaXMgdGhlIG1haW4KIC8vIGNsaWVudCBvZiBXb3JkTG9jay4K IAotY2xhc3MgV29yZExvY2sgewotICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKFdvcmRMb2NrKTsK LXB1YmxpYzoKLSAgICBXb3JkTG9jaygpCi0gICAgewotICAgICAgICBtX3dvcmQuc3RvcmUoMCwg c3RkOjptZW1vcnlfb3JkZXJfcmVsYXhlZCk7Ci0gICAgfQotCitzdHJ1Y3QgV29yZExvY2tCYXNl IHsKICAgICB2b2lkIGxvY2soKQogICAgIHsKICAgICAgICAgaWYgKExJS0VMWShtX3dvcmQuY29t cGFyZUV4Y2hhbmdlV2VhaygwLCBpc0xvY2tlZEJpdCwgc3RkOjptZW1vcnlfb3JkZXJfYWNxdWly ZSkpKSB7CkBAIC04MCw3ICs3Myw3IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIGlzSGVsZCgp OwogICAgIH0KIAotcHJpdmF0ZToKK3Byb3RlY3RlZDoKICAgICBmcmllbmQgc3RydWN0IFRlc3RX ZWJLaXRBUEk6OkxvY2tJbnNwZWN0b3I7CiAgICAgCiAgICAgc3RhdGljIGNvbnN0IHVpbnRwdHJf dCBpc0xvY2tlZEJpdCA9IDE7CkBAIC05OSwxMiArOTIsMjMgQEAgcHJpdmF0ZToKICAgICBBdG9t aWM8dWludHB0cl90PiBtX3dvcmQ7CiB9OwogCi10eXBlZGVmIExvY2tlcjxXb3JkTG9jaz4gV29y ZExvY2tIb2xkZXI7CitjbGFzcyBXb3JkTG9jayA6IHB1YmxpYyBXb3JkTG9ja0Jhc2UgeworICAg IFdURl9NQUtFX05PTkNPUFlBQkxFKFdvcmRMb2NrKTsKK3B1YmxpYzoKKyAgICBXb3JkTG9jaygp CisgICAgeworICAgICAgICBtX3dvcmQuc3RvcmUoMCwgc3RkOjptZW1vcnlfb3JkZXJfcmVsYXhl ZCk7CisgICAgfQorfTsKKwordHlwZWRlZiBXb3JkTG9ja0Jhc2UgU3RhdGljV29yZExvY2s7Cit0 eXBlZGVmIExvY2tlcjxXb3JkTG9ja0Jhc2U+IFdvcmRMb2NrSG9sZGVyOwogCiB9IC8vIG5hbWVz cGFjZSBXVEYKIAogdXNpbmcgV1RGOjpXb3JkTG9jazsKIHVzaW5nIFdURjo6V29yZExvY2tIb2xk ZXI7Cit1c2luZyBXVEY6OlN0YXRpY1dvcmRMb2NrOwogCiAjZW5kaWYgLy8gV1RGX1dvcmRMb2Nr X2gKIAo=