155464 2016-03-14 14:25:40 -0700 Web Inspector: cssmin.py does not handle calc(var(--toolbar-height) + var(--tab-bar-height)) 2016-03-14 15:22:14 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1174705 0 timothy 2016-03-14 14:25:40 -0700 It outputs calc(var(--toolbar-height)+var(--tab-bar-height)), which is not valid. This is breaking the UI after http://trac.webkit.org/changeset/198065. 1174707 1 webkit-bug-importer 2016-03-14 14:26:43 -0700 <rdar://problem/25152196> 1174709 2 274029 timothy 2016-03-14 14:30:17 -0700 Created attachment 274029 Patch 1174710 3 274029 joepeck 2016-03-14 14:30:52 -0700 Comment on attachment 274029 Patch r=me! 1174743 4 274029 commit-queue 2016-03-14 15:22:10 -0700 Comment on attachment 274029 Patch Clearing flags on attachment: 274029 Committed r198164: <http://trac.webkit.org/changeset/198164> 1174744 5 commit-queue 2016-03-14 15:22:14 -0700 All reviewed patches have been landed. Closing bug. 274029 2016-03-14 14:30:17 -0700 2016-03-14 15:22:10 -0700 Patch bug-155464-20160314143006.patch text/plain 3167 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4MDAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBh YzA4NmYzZjA2NmY1NWQzZTdmN2EwZmYwZjZhMDNjYWNmOWRkODNhLi42ODFlMTFiZmUxOWMwODA0 YTNjZWE4NzAwOTU5MzcyOWJhNzE2YzVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNi0wMy0xNCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogY3NzbWluLnB5IGRvZXMgbm90IGhhbmRsZSBj YWxjKHZhcigtLXRvb2xiYXItaGVpZ2h0KSArIHZhcigtLXRhYi1iYXItaGVpZ2h0KSkKKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1NDY0CisgICAg ICAgIHJkYXI6Ly9wcm9ibGVtLzI1MTUyMTk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2Nzc21pbi5weToKKyAgICAgICAgKGNzc21p bmlmeSk6IENoZWNrIGZvciB2YXIgd2hlbiBzdHJpcHBpbmcgc3BhY2VzIGFyb3VuZCArIGFuZCAt LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZU92ZXJ2aWV3LmpzOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lT3ZlcnZpZXcucHJvdG90eXBlLl92aWV3TW9k ZURpZENoYW5nZSk6CisgICAgICAgIERyaXZlLWJ5IGZpeCB0byBhZGQgYSBtaXNzaW5nIHNlbWkt Y29sb24gZm91bmQgYnkgdGhlIGNvcHktdXNlci1pbnRlcmZhY2UtcmVzb3VyY2VzLWRyeXJ1bi5y YiBzY3JpcHQuCisKIDIwMTYtMDMtMTAgIERhbmllbCBTdHJva2lzICA8ZHN0cm9raXNAaWNsb3Vk LmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBjb2xvciBzd2F0Y2ggYW5kIGJvcmRlciBh cmUgbWlzYWxpZ25lZCBpbiBWaXN1YWwgU3R5bGVzIHNpZGViYXIKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9TY3JpcHRzL2Nzc21pbi5weSBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9TY3JpcHRzL2Nzc21pbi5weQppbmRleCBjZTBkNWEyZjlmYWNlNWM1NTRmMjg3MThjYzk4MzU3 ZGM1NDFjMzE5Li4xODYzMjdhMmY0NmU3NzY5NTM1OWI2MWNlOWFmZjc1MTNkYjQ4ZWJmIDEwMDc1 NQotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvU2NyaXB0cy9jc3NtaW4ucHkKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1NjcmlwdHMvY3NzbWluLnB5CkBAIC0zMiw3ICszMiw3IEBAIGRl ZiBjc3NtaW5pZnkoY3NzKToKICAgICAgICAgKHIiXHMrIiwgIiAiKSwgICAgICAgICAgICAgICAg ICMgY2hhbmdlIG11bHRpcGxlIHNwYWNlcyB0byBvbmUgc3BhY2UKICAgICAgICAgKHIiXHM/KFs7 e30sfj4hXSlccz8iLCByIlwxIiksICMgZGVsZXRlIHNwYWNlIHdoZXJlIGl0IGlzIG5vdCBuZWVk ZWQKICAgICAgICAgKHIiOlxzIiwgIjoiKSwgICAgICAgICAgICAgICAgICMgZGVsZXRlIHNwYWNl cyBhZnRlciBjb2xvbnMsIGJ1dCBub3QgYmVmb3JlLiBFLmcuIGRvIG5vdCBicmVhayBzZWxlY3Rv cnMgImEgOmZvY3VzIiwgImIgOm1hdGNoZXMoLi4uKSIsICJjIDpub3QoLi4uKSIgd2hlcmUgdGhl IGxlYWRpbmcgc3BhY2UgaXMgc2lnbmlmaWNhbnQKLSAgICAgICAgKHIiXHM/KFstK10pKD86XHMo PyFbMC05KF0pKSIsIHIiXDEiKSwgIyBkZWxldGUgd2hpdGVzcGFjZSBhcm91bmQgKyBhbmQgLSB3 aGVuIG5vdCBmb2xsb3dlZCBieSBhIG51bWJlciBvciBwYXJlbi4gRS5nLiBzdHJpcCBmb3Igc2Vs ZWN0b3IgImEgKyBiIiBidXQgbm90ICJjYWxjKGEgKyBiKSIgd2hpY2ggcmVxdWlyZXMgc3BhY2Vz LgorICAgICAgICAociJccz8oWy0rXSkoPzpccyg/IVswLTkoXSkoPyF2YXIpKSIsIHIiXDEiKSwg IyBkZWxldGUgd2hpdGVzcGFjZSBhcm91bmQgKyBhbmQgLSB3aGVuIG5vdCBmb2xsb3dlZCBieSBh IG51bWJlciwgcGFyZW4sIG9yIHZhcigpLiBFLmcuIHN0cmlwIGZvciBzZWxlY3RvciAiYSArIGIi IGJ1dCBub3QgImNhbGMoYSArIGIpIiB3aGljaCByZXF1aXJlcyBzcGFjZXMuCiAgICAgICAgIChy Ijt9IiwgIn0iKSAgICAgICAgICAgICAgICAgICAjIGNoYW5nZSAnO30nIHRvICd9JyBiZWNhdXNl IHRoZSBzZW1pY29sb24gaXMgbm90IG5lZWRlZAogICAgICkKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVPdmVydmlldy5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lT3ZlcnZp ZXcuanMKaW5kZXggZDI0YWI4YWU2ODU2M2VlMWMzNWFlMzk5ZTMxYWYyMDg2MmE2M2M3MC4uMjUy YTU3ZWM5MDczOTBjNWJjODE4NWQxMmZhOTdmOGUxMTc3NWM5YyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVPdmVydmlldy5qcwor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZU92 ZXJ2aWV3LmpzCkBAIC03MzgsNyArNzM4LDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lT3ZlcnZp ZXcgPSBjbGFzcyBUaW1lbGluZU92ZXJ2aWV3IGV4dGVuZHMgV2ViSW5zcGVjdG9yLlZpZXcKIAog ICAgICAgICBmb3IgKGxldCBbdHlwZSwgb3ZlcnZpZXdHcmFwaF0gb2YgdGhpcy5fb3ZlcnZpZXdH cmFwaHNCeVR5cGVNYXApIHsKICAgICAgICAgICAgIGxldCB0cmVlRWxlbWVudCA9IHRoaXMuX3Ry ZWVFbGVtZW50c0J5VHlwZU1hcC5nZXQodHlwZSk7Ci0gICAgICAgICAgICBjb25zb2xlLmFzc2Vy dCh0cmVlRWxlbWVudCwgIk1pc3NpbmcgdHJlZSBlbGVtZW50IGZvciB0aW1lbGluZSB0eXBlIiwg dHlwZSkKKyAgICAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHRyZWVFbGVtZW50LCAiTWlzc2luZyB0 cmVlIGVsZW1lbnQgZm9yIHRpbWVsaW5lIHR5cGUiLCB0eXBlKTsKIAogICAgICAgICAgICAgdHJl ZUVsZW1lbnQuaGlkZGVuID0gIXRoaXMuX2NhblNob3dUaW1lbGluZVR5cGUodHlwZSk7CiAgICAg ICAgICAgICBpZiAodHJlZUVsZW1lbnQuaGlkZGVuKQo=