155463 2016-03-14 14:15:28 -0700 [WinCairo] Compile fix. 2016-03-15 09:57:23 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham cdumez commit-queue japhet sam oldest_to_newest 1174699 0 peavo 2016-03-14 14:15:28 -0700 We need to provide a session id when constructing a NetworkStorageSession object. 1174701 1 274027 peavo 2016-03-14 14:22:03 -0700 Created attachment 274027 Patch 1174712 2 achristensen 2016-03-14 14:31:54 -0700 Is there a way we could use the same LOCAL_SESSION definition as everyone else in WinCairo? 1174728 3 peavo 2016-03-14 14:51:17 -0700 (In reply to comment #2) > Is there a way we could use the same LOCAL_SESSION definition as everyone > else in WinCairo? Yes, I think so. I will look into it :) 1174768 4 274045 peavo 2016-03-14 15:57:16 -0700 Created attachment 274045 Patch 1174893 5 274045 achristensen 2016-03-14 21:51:26 -0700 Comment on attachment 274045 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=274045&action=review Ahhh, that feels so much better. > Source/WebCore/loader/CookieJar.cpp:56 > #define LOCAL_SESSION(document) NetworkStorageSession& session = storageSession(document); We could probably even get rid of this, too. auto session = storageSession(document) 1174894 6 achristensen 2016-03-14 21:59:51 -0700 http://trac.webkit.org/changeset/198195 1174901 7 achristensen 2016-03-14 22:26:06 -0700 Cleanup in https://bugs.webkit.org/show_bug.cgi?id=155484 1174904 8 achristensen 2016-03-14 22:32:51 -0700 Build fix in http://trac.webkit.org/changeset/198197 1175000 9 peavo 2016-03-15 09:57:23 -0700 Thank you! 274027 2016-03-14 14:22:03 -0700 2016-03-14 15:57:07 -0700 Patch bug-155463-20160314222158.patch text/plain 1391 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODE1NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAzLTE0ICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dIENvbXBp bGUgZml4LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU1NDYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2UgbmVlZCB0byBwcm92aWRlIGEgc2Vzc2lvbiBpZCB3aGVuIGNvbnN0cnVjdGluZyBhIE5ldHdv cmtTdG9yYWdlU2Vzc2lvbiBvYmplY3QuCisKKyAgICAgICAgKiBsb2FkZXIvQ29va2llSmFyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OnN0b3JhZ2VTZXNzaW9uKToKKyAgICAgICAgKFdlYkNvcmU6 OmNvb2tpZXMpOgorCiAyMDE2LTAzLTE0ICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29r LmNvbT4KIAogICAgICAgICBbV2luQ2Fpcm9dW01lZGlhRm91bmRhdGlvbl0gSW1wbGVtZW50IGZs b2F0IHZlcnNpb25zIG9mIE1lZGlhUGxheWVyIG1ldGhvZHMuCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9sb2FkZXIvQ29va2llSmFyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvQ29va2llSmFyLmNwcAkocmV2aXNpb24gMTk4MTU1KQorKysgU291cmNlL1dlYkNvcmUvbG9h ZGVyL0Nvb2tpZUphci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU2LDcgKzU2LDcgQEAgaW5saW5l IE5ldHdvcmtTdG9yYWdlU2Vzc2lvbiYgc3RvcmFnZVNlcwogfQogI2RlZmluZSBMT0NBTF9TRVNT SU9OKGRvY3VtZW50KSBOZXR3b3JrU3RvcmFnZVNlc3Npb24mIHNlc3Npb24gPSBzdG9yYWdlU2Vz c2lvbihkb2N1bWVudCk7CiAjZWxzZQotI2RlZmluZSBMT0NBTF9TRVNTSU9OKGRvY3VtZW50KSBO ZXR3b3JrU3RvcmFnZVNlc3Npb24gc2Vzc2lvbihuZXR3b3JraW5nQ29udGV4dChkb2N1bWVudCkp OworI2RlZmluZSBMT0NBTF9TRVNTSU9OKGRvY3VtZW50KSBOZXR3b3JrU3RvcmFnZVNlc3Npb24g c2Vzc2lvbihTZXNzaW9uSUQ6OmRlZmF1bHRTZXNzaW9uSUQoKSwgbmV0d29ya2luZ0NvbnRleHQo ZG9jdW1lbnQpKTsKICNlbmRpZgogCiBTdHJpbmcgY29va2llcyhjb25zdCBEb2N1bWVudCogZG9j dW1lbnQsIGNvbnN0IFVSTCYgdXJsKQo= 274045 2016-03-14 15:57:16 -0700 2016-03-14 21:59:39 -0700 Patch bug-155463-20160314235711.patch text/plain 3686 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODE2MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTAzLTE0ICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dIENvbXBp bGUgZml4LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU1NDYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg R2V0IHRoZSBOZXR3b3JrU3RvcmFnZVNlc3Npb24gb2JqZWN0IGZyb20gdGhlIGRvY3VtZW50IGlu IHRoZSBzYW1lIHdheSBhcyBvdGhlciBwbGF0Zm9ybXMgZG8uCisKKyAgICAgICAgKiBsb2FkZXIv Q29va2llSmFyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnN0b3JhZ2VTZXNzaW9uKToKKwogMjAx Ni0wMy0xMCAgQW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3ZWJraXQub3JnPgogCiAgICAgICAg IFNlbGVjdGluZyB3aXRoIHNoaWZ0K2RyYWcgcmVzdWx0cyBpbiB1bmV4cGVjdGVkIGRyYWctbi1k cm9wCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvQ29va2llSmFyLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvQ29va2llSmFyLmNwcAkocmV2aXNpb24gMTk4MTYz KQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVyL0Nvb2tpZUphci5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTQ4LDE2ICs0OCwxMiBAQCBzdGF0aWMgTmV0d29ya2luZ0NvbnRleHQqIG5ldHdvcmtpbmdD b250CiAgICAgcmV0dXJuIGZyYW1lLT5sb2FkZXIoKS5uZXR3b3JraW5nQ29udGV4dCgpOwogfQog Ci0jaWYgUExBVEZPUk0oQ09DT0EpIHx8IFVTRShDRk5FVFdPUkspIHx8IFVTRShTT1VQKQogaW5s aW5lIE5ldHdvcmtTdG9yYWdlU2Vzc2lvbiYgc3RvcmFnZVNlc3Npb24oY29uc3QgRG9jdW1lbnQq IGRvY3VtZW50KQogewogICAgIE5ldHdvcmtpbmdDb250ZXh0KiBjb250ZXh0ID0gbmV0d29ya2lu Z0NvbnRleHQoZG9jdW1lbnQpOwogICAgIHJldHVybiBjb250ZXh0ID8gY29udGV4dC0+c3RvcmFn ZVNlc3Npb24oKSA6IE5ldHdvcmtTdG9yYWdlU2Vzc2lvbjo6ZGVmYXVsdFN0b3JhZ2VTZXNzaW9u KCk7CiB9CiAjZGVmaW5lIExPQ0FMX1NFU1NJT04oZG9jdW1lbnQpIE5ldHdvcmtTdG9yYWdlU2Vz c2lvbiYgc2Vzc2lvbiA9IHN0b3JhZ2VTZXNzaW9uKGRvY3VtZW50KTsKLSNlbHNlCi0jZGVmaW5l IExPQ0FMX1NFU1NJT04oZG9jdW1lbnQpIE5ldHdvcmtTdG9yYWdlU2Vzc2lvbiBzZXNzaW9uKG5l dHdvcmtpbmdDb250ZXh0KGRvY3VtZW50KSk7Ci0jZW5kaWYKIAogU3RyaW5nIGNvb2tpZXMoY29u c3QgRG9jdW1lbnQqIGRvY3VtZW50LCBjb25zdCBVUkwmIHVybCkKIHsKSW5kZXg6IFNvdXJjZS9X ZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3dpbi9DaGFu Z2VMb2cJKHJldmlzaW9uIDE5ODE2NCkKKysrIFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE2LTAzLTE0ICBQZXIgQXJuZSBWb2xs YW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dIENvbXBpbGUgZml4 LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1NDYz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR2V0IHRo ZSBOZXR3b3JrU3RvcmFnZVNlc3Npb24gb2JqZWN0IGZyb20gdGhlIGRvY3VtZW50IGluIHRoZSBz YW1lIHdheSBhcyBvdGhlciBwbGF0Zm9ybXMgZG8uCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9y dC9XZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkZyYW1lTmV0d29y a2luZ0NvbnRleHQ6OnN0b3JhZ2VTZXNzaW9uKToKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9X ZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0Lmg6CisgICAgICAgIChXZWJGcmFtZU5ldHdvcmtpbmdD b250ZXh0OjpzdG9yYWdlU2Vzc2lvbik6CisKIDIwMTYtMDMtMTIgIFNhbSBXZWluaWcgIDxzYW1A d2Via2l0Lm9yZz4KIAogICAgICAgICBXZWJLaXQgY2FuIGVhc2lseSBjcmFzaCBiZWxvdyBOZXR3 b3JrU2Vzc2lvbjo6ZGF0YVRhc2tGb3JJZGVudGlmaWVyKCkgd2l0aCBOU1VSTFNlc3Npb24gZW5h YmxlZApJbmRleDogU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVOZXR3 b3JraW5nQ29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW4vV2ViQ29y ZVN1cHBvcnQvV2ViRnJhbWVOZXR3b3JraW5nQ29udGV4dC5jcHAJKHJldmlzaW9uIDE5ODE2MykK KysrIFNvdXJjZS9XZWJLaXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTmV0d29ya2luZ0Nv bnRleHQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDMsNyArMTAzLDYgQEAgUmVzb3VyY2VFcnJv ciBXZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0OgogICAgIHJldHVybiBmcmFtZSgpLT5sb2FkZXIo KS5jbGllbnQoKS5ibG9ja2VkRXJyb3IocmVxdWVzdCk7CiB9CiAKLSNpZiBVU0UoQ0ZORVRXT1JL KQogTmV0d29ya1N0b3JhZ2VTZXNzaW9uJiBXZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0OjpzdG9y YWdlU2Vzc2lvbigpIGNvbnN0CiB7CiAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKQEAgLTEx Myw0ICsxMTIsMyBAQCBOZXR3b3JrU3RvcmFnZVNlc3Npb24mIFdlYkZyYW1lTmV0d29ya2luCiAK ICAgICByZXR1cm4gTmV0d29ya1N0b3JhZ2VTZXNzaW9uOjpkZWZhdWx0U3RvcmFnZVNlc3Npb24o KTsKIH0KLSNlbmRpZgpJbmRleDogU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvV2Vi RnJhbWVOZXR3b3JraW5nQ29udGV4dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvd2lu L1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQuaAkocmV2aXNpb24gMTk4 MTYzKQorKysgU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVOZXR3b3Jr aW5nQ29udGV4dC5oCSh3b3JraW5nIGNvcHkpCkBAIC00OCw5ICs0OCw3IEBAIHByaXZhdGU6CiAg ICAgfQogCiAgICAgV2ViQ29yZTo6UmVzb3VyY2VFcnJvciBibG9ja2VkRXJyb3IoY29uc3QgV2Vi Q29yZTo6UmVzb3VyY2VSZXF1ZXN0JikgY29uc3Qgb3ZlcnJpZGU7Ci0jaWYgVVNFKENGTkVUV09S SykKICAgICBXZWJDb3JlOjpOZXR3b3JrU3RvcmFnZVNlc3Npb24mIHN0b3JhZ2VTZXNzaW9uKCkg Y29uc3Qgb3ZlcnJpZGU7Ci0jZW5kaWYKIH07CiAKICNlbmRpZgo=