155429 2016-03-14 03:37:48 -0700 [mips] Implemented moveZeroToDouble. 2016-04-16 10:59:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen webkit-unassigned commit-queue guijemont jbriance keith_miller mark.lam msaboff saam oldest_to_newest 1174384 0 annulen 2016-03-14 03:37:48 -0700 This function is required to fix compilation after r197687. 1174386 1 273953 annulen 2016-03-14 03:39:37 -0700 Created attachment 273953 Patch 1174396 2 273953 jbriance 2016-03-14 04:09:59 -0700 Comment on attachment 273953 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273953&action=review > Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:2504 > + m_assembler.mtc1(MIPSRegisters::zero, reg); This will set to 0 only one FP register, which is not enough for double precision. I think it would be easier to put something like this: convertInt32ToDouble(MIPSRegisters::zero, reg); I also thought of this, but I'm not sure it's a good idea: subDouble(reg, reg); 1183465 3 guijemont 2016-04-13 11:31:47 -0700 Konstantin, are you still planning to work on this? 1183469 4 annulen 2016-04-13 11:44:40 -0700 Yes, starting now. Sorry for being late 1183529 5 guijemont 2016-04-13 14:03:26 -0700 (In reply to comment #4) > Yes, starting now. Sorry for being late No worries! It was just to know if I should take over on that. Thanks for taking care of it! 1184348 6 276554 annulen 2016-04-16 07:37:40 -0700 Created attachment 276554 Patch 1184349 7 annulen 2016-04-16 07:39:04 -0700 I've checked subDouble(reg, reg) and found that it fails to zero reg with INFINITY or NAN. So the only remaining option is convertInt32ToDouble(MIPSRegisters::zero, reg). 1184373 8 276554 commit-queue 2016-04-16 10:59:42 -0700 Comment on attachment 276554 Patch Clearing flags on attachment: 276554 Committed r199626: <http://trac.webkit.org/changeset/199626> 1184374 9 commit-queue 2016-04-16 10:59:45 -0700 All reviewed patches have been landed. Closing bug. 273953 2016-03-14 03:39:37 -0700 2016-04-16 07:37:31 -0700 Patch bug-155429-20160314133924.patch text/plain 1413 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4MTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx MDE5ZDIzYTEwZGQ5ZWEwYjcwN2Y3NWYyZjQ1NzM1NWZmZmMzYzgyLi4xZDQ4MWUyNDFkMDhiZTIx ZWY2NzU5ODQ2YTY2M2RjMWYwNGRmZjA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNi0wMy0xNCAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5k ZXgucnU+CisKKyAgICAgICAgW21pcHNdIEltcGxlbWVudGVkIG1vdmVaZXJvVG9Eb3VibGUuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU0MjkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGZ1bmN0 aW9uIGlzIHJlcXVpcmVkIHRvIGZpeCBjb21waWxhdGlvbiBhZnRlciByMTk3Njg3LgorCisgICAg ICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oOgorICAgICAgICAoSlNDOjpNYWNy b0Fzc2VtYmxlck1JUFM6Om1vdmVaZXJvVG9Eb3VibGUpOgorCiAyMDE2LTAzLTEzICBKb3NlcGgg UGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIEVOQUJMRShF UzZfVEVNUExBVEVfTElURVJBTF9TWU5UQVgpIGd1YXJkcwpkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaCBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgKaW5kZXggN2M0YmQwODBk ZjEzNDNiOGVhZWQwZjUwMjI0ZDJhMmE5OWJkZTk5Ni4uZTgzZjZmYmMwYjc5MzhiOTViYWM0YmZm OTM2ZmRmOTM3ODEyNTRlZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2Vt Ymxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNz ZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCkBAIC0yNDk5LDYgKzI0OTksMTEgQEAgcHVibGlj OgogICAgICAgICAgICAgbV9hc3NlbWJsZXIubW92ZChkZXN0LCBzcmMpOwogICAgIH0KIAorICAg IHZvaWQgbW92ZVplcm9Ub0RvdWJsZShGUFJlZ2lzdGVySUQgcmVnKQorICAgIHsKKyAgICAgICAg bV9hc3NlbWJsZXIubXRjMShNSVBTUmVnaXN0ZXJzOjp6ZXJvLCByZWcpOworICAgIH0KKwogICAg IHZvaWQgc3dhcERvdWJsZShGUFJlZ2lzdGVySUQgZnIxLCBGUFJlZ2lzdGVySUQgZnIyKQogICAg IHsKICAgICAgICAgbW92ZURvdWJsZShmcjEsIGZwVGVtcFJlZ2lzdGVyKTsK 276554 2016-04-16 07:37:40 -0700 2016-04-16 10:59:42 -0700 Patch bug-155429-20160416173754.patch text/plain 1404 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5NjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 Y2NiMDkyMjk0ZWU3YjQ5MTY3NWY5ODllMzNmNGYyZDMzMGYwNjViLi42MzRjYWM2NjZlNDdmOWMy OTA2ZDU4MDcyYWI0Y2MzMjQ3OGQyZDJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNi0wMy0xNCAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5k ZXgucnU+CisKKyAgICAgICAgW21pcHNdIEltcGxlbWVudGVkIG1vdmVaZXJvVG9Eb3VibGUuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU0MjkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGZ1bmN0 aW9uIGlzIHJlcXVpcmVkIHRvIGZpeCBjb21waWxhdGlvbiBhZnRlciByMTk3Njg3LgorCisgICAg ICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oOgorICAgICAgICAoSlNDOjpNYWNy b0Fzc2VtYmxlck1JUFM6Om1vdmVaZXJvVG9Eb3VibGUpOgorCiAyMDE2LTA0LTE1ICBEYXJpbiBB ZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZWR1Y2UgdXNlIG9mIERlcHJlY2F0 ZWQ6OlNjcmlwdFhYWCBjbGFzc2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fz c2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAppbmRleCBhMzcxNjZjODM5YTk2M2UwMWZiNmI3 OGUyMTdlNDUwOWY1ZWFlMmE0Li4xNGFjMGQwM2IwMGI1Y2YxOWQ0OTY3YWZiZDU5YmQ1MzZiYjgx MzcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNz ZW1ibGVyTUlQUy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9B c3NlbWJsZXJNSVBTLmgKQEAgLTI1NDgsNiArMjU0OCwxMSBAQCBwdWJsaWM6CiAgICAgICAgICAg ICBtX2Fzc2VtYmxlci5tb3ZkKGRlc3QsIHNyYyk7CiAgICAgfQogCisgICAgdm9pZCBtb3ZlWmVy b1RvRG91YmxlKEZQUmVnaXN0ZXJJRCByZWcpCisgICAgeworICAgICAgICBjb252ZXJ0SW50MzJU b0RvdWJsZShNSVBTUmVnaXN0ZXJzOjp6ZXJvLCByZWcpOworICAgIH0KKwogICAgIHZvaWQgc3dh cERvdWJsZShGUFJlZ2lzdGVySUQgZnIxLCBGUFJlZ2lzdGVySUQgZnIyKQogICAgIHsKICAgICAg ICAgbW92ZURvdWJsZShmcjEsIGZwVGVtcFJlZ2lzdGVyKTsK