155411 2016-03-13 14:14:29 -0700 REGRESSION: ASSERTION FAILED: !m_lastActiveBlock on js/function-apply.html 2016-03-15 14:48:08 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 1 ap joepeck commit-queue fpizlo ggaren joepeck keith_miller mark.lam msaboff oliver ryanhaddad saam webkit-bug-importer oldest_to_newest 1174221 0 ap 2016-03-13 14:14:29 -0700 js/function-apply.html has started to sometimes assert around March 9. It's not frequent enough to pinpoint the exact revision, but it seems to be frequent enough to confuse EWS (see bug 155388). Perhaps bug 155178? ASSERTION FAILED: !m_lastActiveBlock /Volumes/Data/slave/yosemite-debug/build/Source/JavaScriptCore/heap/MarkedAllocator.h(131) : void JSC::MarkedAllocator::stopAllocating() 1 0x108805030 WTFCrash 2 0x108446e1a JSC::MarkedAllocator::stopAllocating() 3 0x108446dc9 JSC::StopAllocatingFunctor::operator()(JSC::MarkedAllocator&) 4 0x108446d86 void JSC::MarkedSpace::forEachAllocator<JSC::StopAllocatingFunctor>(JSC::StopAllocatingFunctor&) 5 0x108445bd9 void JSC::MarkedSpace::forEachAllocator<JSC::StopAllocatingFunctor>() 6 0x108444c8c JSC::MarkedSpace::stopAllocating() 7 0x10844558c JSC::MarkedSpace::willStartIterating() 8 0x108107a6c JSC::Heap::willStartIterating() 9 0x107bef0d3 JSC::HeapIterationScope::HeapIterationScope(JSC::Heap&) 10 0x107bdf40d JSC::HeapIterationScope::HeapIterationScope(JSC::Heap&) 11 0x108109085 JSC::Heap::removeDeadHeapSnapshotNodes(JSC::HeapProfiler&) 12 0x10810a279 JSC::Heap::collectImpl(JSC::HeapOperation, void*, void*, int (&) [37]) 13 0x108109c4d JSC::Heap::collect(JSC::HeapOperation) 14 0x107fe0805 JSC::EdenGCActivityCallback::doCollection() 15 0x1080f8620 JSC::GCActivityCallback::doWork() 16 0x1081248cf JSC::HeapTimer::timerDidFire(__CFRunLoopTimer*, void*) 17 0x7fff8ade12e4 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ 1174222 1 webkit-bug-importer 2016-03-13 14:14:52 -0700 <rdar://problem/25134537> 1174756 2 ggaren 2016-03-14 15:39:30 -0700 Joe, is this you? Are you sure it's OK for removeDeadHeapSnapshotNodes to iterate the heap during GC? Maybe you can move this to after GC instead? 1174757 3 ryanhaddad 2016-03-14 15:39:52 -0700 Marked this test as flaky to unblock EWS <http://trac.webkit.org/projects/webkit/changeset/198165> 1174771 4 joepeck 2016-03-14 16:04:13 -0700 (In reply to comment #2) > Joe, is this you? Seems likely! > Are you sure it's OK for removeDeadHeapSnapshotNodes to iterate the heap > during GC? Maybe you can move this to after GC instead? Yes, I think the problem is that both Heap::gatherExtraHeapSnapshotData and Heap::removeDeadHeapSnapshotNodes take a HeapIterationScope (which does a stopAllocating/resumeAllocating) but Heap::collectImpl has already done a stopAllocating and will do a resetAllocators. Duplicate stopAllocating calls looks like it would cause this ASSERT. I will see if it makes sense to just drop the HeapIterationScopes here given the Heap is already stopped. It looks like it would be perfectly fine to move these snapshot operations after resetAllocators where they won't mess with the state of the allocator between the normal stop/reset of collection. Given this test is encountering the removeDeadHeapSnapshotNodes path at all, it means imply that this VM had previously run a test that created a HeapProfiler. So that would mean the bot ran an LayoutTests/inspector/heap test and then ran this LayoutTests/js/function-apply.html, so I'll try to reproduce locally with this in mind. While the HeapProfiler will still exist for the VM, the HeapSnapshots should have been cleared when the page changed so there should essentially be no work. 1174806 5 joepeck 2016-03-14 16:48:26 -0700 (In reply to comment #4) > I will see if it makes sense to just drop the HeapIterationScopes here given > the Heap is already stopped. It looks like it would be perfectly fine to > move these snapshot operations after resetAllocators where they won't mess > with the state of the allocator between the normal stop/reset of collection. Bah, MarkedSpace::forEachLiveCell/DeadCell expects a HeapIterationScope& in its API to ensure callers have stopped allocation. So just moving the HeapProfiler work to the end of GC (after allocators are resumed) seems easiest/safest. 1174807 6 274053 joepeck 2016-03-14 16:49:12 -0700 Created attachment 274053 [PATCH] Proposed Fix 1174808 7 joepeck 2016-03-14 16:51:22 -0700 (In reply to comment #4) > So that would mean the bot ran an LayoutTests/inspector/heap > test and then ran this LayoutTests/js/function-apply.html, so I'll try to > reproduce locally with this in mind. I was unable to reproduce this locally running lots of iterations of these kind of combinations. 1174915 8 274053 ap 2016-03-14 23:53:54 -0700 Comment on attachment 274053 [PATCH] Proposed Fix Please also unmark the test in TestExpectations when landing this. FWIW, js/function-call-aliased.html is another affected test. 1175058 9 ryanhaddad 2016-03-15 12:48:37 -0700 Can we update the patch and land this soon? js/function-call-aliased.html is wreaking havoc on Mac EWS results. 1175078 10 274053 mark.lam 2016-03-15 13:29:16 -0700 Comment on attachment 274053 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=274053&action=review > Source/JavaScriptCore/heap/Heap.cpp:1201 > + if (HeapProfiler* heapProfiler = m_vm->heapProfiler()) { > + gatherExtraHeapSnapshotData(*heapProfiler); > + removeDeadHeapSnapshotNodes(*heapProfiler); > + } > + Let's put this in didFinishCollection() (at the bottom) instead. We do many heap iterations in there and collect statistics. That would be the proper place for this. 1175085 11 274121 joepeck 2016-03-15 13:43:49 -0700 Created attachment 274121 [PATCH] Proposed Fix 1175095 12 274121 mark.lam 2016-03-15 13:56:49 -0700 Comment on attachment 274121 [PATCH] Proposed Fix r=me 1175121 13 274121 commit-queue 2016-03-15 14:48:02 -0700 Comment on attachment 274121 [PATCH] Proposed Fix Clearing flags on attachment: 274121 Committed r198229: <http://trac.webkit.org/changeset/198229> 1175122 14 commit-queue 2016-03-15 14:48:08 -0700 All reviewed patches have been landed. Closing bug. 274053 2016-03-14 16:49:12 -0700 2016-03-15 13:43:49 -0700 [PATCH] Proposed Fix fix-assert.patch text/plain 2234 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDI5YWFmZjIuLjJiZWM0YzEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE2LTAzLTE0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgUkVHUkVTU0lPTjogQVNTRVJUSU9O IEZBSUxFRDogIW1fbGFzdEFjdGl2ZUJsb2NrIG9uIGpzL2Z1bmN0aW9uLWFwcGx5Lmh0bWwKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTQxMQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMjUxMzQ1Mzc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBoZWFwL0hlYXAuY3BwOgorICAgICAgICAoSlNDOjpI ZWFwOjpjb2xsZWN0SW1wbCk6CisgICAgICAgIE1vdmUgdGhlIEhlYXBQcm9maWxlciBnYXRoZXJF eHRyYURhdGEvcmVtb3ZlRGVhZE5vZGVzIGxvZ2ljIGltbWVkaWF0ZWx5CisgICAgICAgIGFmdGVy IGNvbGxlY3Rpb24gZmluaXNoZXMuIER1cmluZyBjb2xsZWN0aW9uIGFsbG9jYXRvcnMgYXJlIHN0 b3AvcmVzZXQuCisgICAgICAgIFRoZSBIZWFwUHJvZmlsZXIgcGF0aCB1c2VzIEhlYXBJdGVyYXRp b25TY29wZSAodG8gc2F0aXNmeSBNYXJrZWRTcGFjZQorICAgICAgICBmb3JFYWNoQ2VsbCBBUEkg Y29udHJhY3RzKSB3aGljaCB3YXMgZG9pbmcgaXRzIG93biBzdG9wL3Jlc3VtZSBvZgorICAgICAg ICBhbGxvY2F0b3JzLiBEb2luZyBhIHN0b3AvcmVzdW1lIGluIGJldHdlZW4gdGhlIG5vcm1hbCBz dG9wL3Jlc2V0IG9mCisgICAgICAgIGNvbGxlY3Rpb24gaXMgdW5leHBlY3RlZC4KKworMjAxNi0w My0xNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFJl ZHVjZSBnZW5lcmF0ZWQgSlNPTiBIZWFwU25hcHNob3Qgc2l6ZQogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1NDYwCiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAvSGVhcC5jcHAKaW5kZXggZWUxN2VkZC4uY2Y4MzdiYyAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAvSGVhcC5jcHAKQEAgLTExODYsMTEgKzExODYsNiBAQCBORVZFUl9JTkxJTkUgdm9pZCBIZWFw Ojpjb2xsZWN0SW1wbChIZWFwT3BlcmF0aW9uIGNvbGxlY3Rpb25UeXBlLCB2b2lkKiBzdGFja09y aQogICAgIGRlbGV0ZVVubWFya2VkQ29tcGlsZWRDb2RlKCk7CiAgICAgZGVsZXRlU291cmNlUHJv dmlkZXJDYWNoZXMoKTsKIAotICAgIGlmIChIZWFwUHJvZmlsZXIqIGhlYXBQcm9maWxlciA9IG1f dm0tPmhlYXBQcm9maWxlcigpKSB7Ci0gICAgICAgIGdhdGhlckV4dHJhSGVhcFNuYXBzaG90RGF0 YSgqaGVhcFByb2ZpbGVyKTsKLSAgICAgICAgcmVtb3ZlRGVhZEhlYXBTbmFwc2hvdE5vZGVzKCpo ZWFwUHJvZmlsZXIpOwotICAgIH0KLQogICAgIG5vdGlmeUluY3JlbWVudGFsU3dlZXBlcigpOwog ICAgIHdyaXRlQmFycmllckN1cnJlbnRseUV4ZWN1dGluZ0NvZGVCbG9ja3MoKTsKIApAQCAtMTE5 OSw2ICsxMTk0LDExIEBAIE5FVkVSX0lOTElORSB2b2lkIEhlYXA6OmNvbGxlY3RJbXBsKEhlYXBP cGVyYXRpb24gY29sbGVjdGlvblR5cGUsIHZvaWQqIHN0YWNrT3JpCiAgICAgZGlkRmluaXNoQ29s bGVjdGlvbihnY1N0YXJ0VGltZSk7CiAgICAgcmVzdW1lQ29tcGlsZXJUaHJlYWRzKCk7CiAKKyAg ICBpZiAoSGVhcFByb2ZpbGVyKiBoZWFwUHJvZmlsZXIgPSBtX3ZtLT5oZWFwUHJvZmlsZXIoKSkg eworICAgICAgICBnYXRoZXJFeHRyYUhlYXBTbmFwc2hvdERhdGEoKmhlYXBQcm9maWxlcik7Cisg ICAgICAgIHJlbW92ZURlYWRIZWFwU25hcHNob3ROb2RlcygqaGVhcFByb2ZpbGVyKTsKKyAgICB9 CisKICAgICBpZiAobV92ZXJpZmllcikgewogICAgICAgICBtX3ZlcmlmaWVyLT50cmltRGVhZE9i amVjdHMoKTsKICAgICAgICAgbV92ZXJpZmllci0+dmVyaWZ5KEhlYXBWZXJpZmllcjo6UGhhc2U6 OkFmdGVyR0MpOwo= 274121 2016-03-15 13:43:49 -0700 2016-03-15 14:48:02 -0700 [PATCH] Proposed Fix heap-collect.patch text/plain 3764 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlZDE3ZjJjLi5hMzBkMTBhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTYtMDMt MTUgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdS RVNTSU9OOiBBU1NFUlRJT04gRkFJTEVEOiAhbV9sYXN0QWN0aXZlQmxvY2sgb24ganMvZnVuY3Rp b24tYXBwbHkuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTU1NDExCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNTEzNDUzNz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9U ZXN0RXhwZWN0YXRpb25zOgorICAgICAgICBVbm1hcmsgdGVzdCBhcyBmbGFrZXkuCisKIDIwMTYt MDMtMTUgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAgICAgICAgRml4 aW5nIGV4cGVjdGF0aW9uIGZvciBjc3MzL21hc2tpbmcvbWFzay1zdmctc2NyaXB0LW5vbmUtdG8t cG5nLmh0bWwgb24gaW9zLXNpbXVsYXRvcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4 cGVjdGF0aW9ucwppbmRleCBiNDgwZTFiLi5mMjcyZDMyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTM0Miw1ICsxMzQyLDMgQEAgd2Via2l0Lm9yZy9i LzE1NTE0MCBqcy9wcm9taXNlcy10ZXN0cy9wcm9taXNlcy10ZXN0cy0yLTMtMy5odG1sIFsgUGFz cyBGYWlsdXJlIF0KIFsgWW9zZW1pdGUgRWxDYXBpdGFuIF0gZmFzdC9zY3JvbGxpbmcvcnRsLXNj cm9sbGJhcnMtb3ZlcmZsb3ctcGFkZGluZy5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiBbIFlv c2VtaXRlIEVsQ2FwaXRhbiBdIGZhc3Qvc2Nyb2xsaW5nL3J0bC1zY3JvbGxiYXJzLW92ZXJmbG93 LXNpbXBsZS5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiBbIFlvc2VtaXRlIEVsQ2FwaXRhbiBd IGZhc3Qvc2Nyb2xsaW5nL3J0bC1zY3JvbGxiYXJzLW92ZXJmbG93Lmh0bWwgWyBJbWFnZU9ubHlG YWlsdXJlIF0KLQotd2Via2l0Lm9yZy9iLzE1NTQxMSBbIERlYnVnIF0ganMvZnVuY3Rpb24tYXBw bHkuaHRtbCBbIFBhc3MgQ3Jhc2ggXQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggYTBjM2I3 ZS4uMTc3YjQ3NSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIw MTYtMDMtMTQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAg ICBSRUdSRVNTSU9OOiBBU1NFUlRJT04gRkFJTEVEOiAhbV9sYXN0QWN0aXZlQmxvY2sgb24ganMv ZnVuY3Rpb24tYXBwbHkuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTU1NDExCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNTEzNDUzNz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGhlYXAvSGVh cC5jcHA6CisgICAgICAgIChKU0M6OkhlYXA6OmNvbGxlY3RJbXBsKToKKyAgICAgICAgKEpTQzo6 SGVhcDo6ZGlkRmluaXNoQ29sbGVjdGlvbik6CisgICAgICAgIER1cmluZyBjb2xsZWN0aW9uIGFs bG9jYXRvcnMgYXJlIHN0b3AvcmVzZXQuIFRoZSBIZWFwUHJvZmlsZXIgdGFza3MKKyAgICAgICAg d2VyZSB1c2luZyBIZWFwSXRlcmF0aW9uU2NvcGUgKHRvIHNhdGlzZnkgTWFya2VkU3BhY2UgZm9y RWFjaENlbGwgQVBJCisgICAgICAgIGNvbnRyYWN0cykgd2hpY2ggd2FzIGRvaW5nIGl0cyBvd24g c3RvcC9yZXN1bWUgb2YgYWxsb2NhdG9ycy4gRG9pbmcgYQorICAgICAgICBzdG9wL3Jlc3VtZSBp biBiZXR3ZWVuIHRoZSBub3JtYWwgc3RvcC9yZXNldCBvZiBjb2xsZWN0aW9uIGlzIHVuZXhwZWN0 ZWQuCisKKyAgICAgICAgTW92ZSB0aGlzIHRvIGRpZEZpbmlzaENvbGxlY3Rpb24sIGFsb25nc2lk ZSBvdGhlciBoZWFwIGl0ZXJhdGlvbnMKKyAgICAgICAgbGlrZSB6b21iaWVzIGFuZCBpbW1vcnRh bCBvYmplY3RzLiBQdXR0aW5nIHRoaXMgYWZ0ZXIgdGhvc2UgdGFza3MKKyAgICAgICAgYWxzbyBt ZWFucyB0aGUgaGVhcCBzbmFwc2hvdHMgd2lsbCByZXNwZWN0IHRoZSB6b21iaWVzL2ltbW9ydGFs IG9wdGlvbnMKKyAgICAgICAgd2hlbiBkZWNpZGluZyBpZiB0aGUgY2VsbCBpcyBhbGl2ZSBvciBu b3QuCisKIDIwMTYtMDMtMTUgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZW1vdmUgdGhlIEJha2VyIGJhcnJpZXIgZnJvbSBKU0MKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAvSGVhcC5jcHAKaW5kZXggOTVhZmQ2NC4uMzMzNzk5MyAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAvSGVhcC5jcHAKQEAgLTExNzYsMTEgKzExNzYsNiBAQCBORVZFUl9JTkxJTkUgdm9pZCBIZWFw Ojpjb2xsZWN0SW1wbChIZWFwT3BlcmF0aW9uIGNvbGxlY3Rpb25UeXBlLCB2b2lkKiBzdGFja09y aQogICAgIGRlbGV0ZVVubWFya2VkQ29tcGlsZWRDb2RlKCk7CiAgICAgZGVsZXRlU291cmNlUHJv dmlkZXJDYWNoZXMoKTsKIAotICAgIGlmIChIZWFwUHJvZmlsZXIqIGhlYXBQcm9maWxlciA9IG1f dm0tPmhlYXBQcm9maWxlcigpKSB7Ci0gICAgICAgIGdhdGhlckV4dHJhSGVhcFNuYXBzaG90RGF0 YSgqaGVhcFByb2ZpbGVyKTsKLSAgICAgICAgcmVtb3ZlRGVhZEhlYXBTbmFwc2hvdE5vZGVzKCpo ZWFwUHJvZmlsZXIpOwotICAgIH0KLQogICAgIG5vdGlmeUluY3JlbWVudGFsU3dlZXBlcigpOwog ICAgIHdyaXRlQmFycmllckN1cnJlbnRseUV4ZWN1dGluZ0NvZGVCbG9ja3MoKTsKIApAQCAtMTQ2 Miw2ICsxNDU3LDExIEBAIHZvaWQgSGVhcDo6ZGlkRmluaXNoQ29sbGVjdGlvbihkb3VibGUgZ2NT dGFydFRpbWUpCiAgICAgaWYgKE9wdGlvbnM6OmxvZ0dDKCkgPT0gR0NMb2dnaW5nOjpWZXJib3Nl KQogICAgICAgICBHQ0xvZ2dpbmc6OmR1bXBPYmplY3RHcmFwaCh0aGlzKTsKIAorICAgIGlmIChI ZWFwUHJvZmlsZXIqIGhlYXBQcm9maWxlciA9IG1fdm0tPmhlYXBQcm9maWxlcigpKSB7CisgICAg ICAgIGdhdGhlckV4dHJhSGVhcFNuYXBzaG90RGF0YSgqaGVhcFByb2ZpbGVyKTsKKyAgICAgICAg cmVtb3ZlRGVhZEhlYXBTbmFwc2hvdE5vZGVzKCpoZWFwUHJvZmlsZXIpOworICAgIH0KKwogICAg IFJFTEVBU0VfQVNTRVJUKG1fb3BlcmF0aW9uSW5Qcm9ncmVzcyA9PSBFZGVuQ29sbGVjdGlvbiB8 fCBtX29wZXJhdGlvbkluUHJvZ3Jlc3MgPT0gRnVsbENvbGxlY3Rpb24pOwogICAgIG1fb3BlcmF0 aW9uSW5Qcm9ncmVzcyA9IE5vT3BlcmF0aW9uOwogICAgIEpBVkFTQ1JJUFRDT1JFX0dDX0VORCgp Owo=