155380 2016-03-11 14:38:20 -0800 Use only selected text for Look up 2016-03-11 14:50:26 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enrica enrica sam thorton oldest_to_newest 1173876 0 enrica 2016-03-11 14:38:20 -0800 The WK2 implementation uses an extended context for lookup, but the corresponding piece is not ready yet. Default to the selected text. 1173879 1 273771 enrica 2016-03-11 14:46:06 -0800 Created attachment 273771 Patch 1173885 2 enrica 2016-03-11 14:50:26 -0800 Committed revision 198049. 273771 2016-03-11 14:46:06 -0800 2016-03-11 14:47:45 -0800 Patch lookuponselectedtext.txt text/plain 1660 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODA0NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAzLTExICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIG9ubHkgc2VsZWN0ZWQg dGV4dCBmb3IgTG9vayB1cC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE1NTM4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoZSBjb3JyZXNwb25kaW5nIHBpZWNlIHRoYXQgdXNlcyB0aGUgZXh0ZW5kZWQg Y29udGV4dCBmb3IgTG9vayB1cAorICAgICAgICBpcyBub3QgcmVhZHkgeWV0LiBGb3IgdGhlIG1v bWVudCBkZWZhdWx0IHRvIHJldHJpZXZpbmcgdGhlIHNlbGVjdGVkIHRleHQuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1b V0tDb250ZW50VmlldyBfbG9va3VwOl0pOgorCiAyMDE2LTAzLTExICBDaGVsc2VhIFB1Z2ggIDxj cHVnaEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gQWxsb3cgY2xpZW50cyB0byBzcGVjaWZ5 IHRleHQgc3VnZ2VzdGlvbnMgdG8gYmUgdXNlZCBmb3IgYSBmb3JtIGlucHV0IHNlc3Npb24KSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9u Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50 Vmlld0ludGVyYWN0aW9uLm1tCShyZXZpc2lvbiAxOTgwMjcpCisrKyBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQkod29ya2luZyBjb3B5KQpA QCAtMTU5MSwxMCArMTU5MSwxMCBAQCAtIChOU0FycmF5ICopc3VwcG9ydGVkUGFzdGVib2FyZFR5 cGVzRm9yCiAgICAgcmV0dXJuIChfcGFnZS0+ZWRpdG9yU3RhdGUoKS5pc0NvbnRlbnRSaWNobHlF ZGl0YWJsZSkgPyByaWNoVHlwZXMgOiBwbGFpblRleHRUeXBlczsKIH0KIAotLSAodm9pZClfbG9v a3VwOihDR1BvaW50KXBvaW50CistICh2b2lkKV9sb29rdXA6KGlkKXNlbmRlcgogewogICAgIFJl dGFpblB0cjxXS0NvbnRlbnRWaWV3PiB2aWV3ID0gc2VsZjsKLSAgICBfcGFnZS0+Z2V0TG9va3Vw Q29udGV4dEF0UG9pbnQoV2ViQ29yZTo6SW50UG9pbnQocG9pbnQpLCBbdmlld10oY29uc3QgU3Ry aW5nJiBzdHJpbmcsIENhbGxiYWNrQmFzZTo6RXJyb3IgZXJyb3IpIHsKKyAgICBfcGFnZS0+Z2V0 U2VsZWN0aW9uT3JDb250ZW50c0FzU3RyaW5nKFt2aWV3XShjb25zdCBTdHJpbmcmIHN0cmluZywg Q2FsbGJhY2tCYXNlOjpFcnJvciBlcnJvcikgewogICAgICAgICBpZiAoZXJyb3IgIT0gQ2FsbGJh Y2tCYXNlOjpFcnJvcjo6Tm9uZSkKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgaWYgKCFz dHJpbmcpCg==