155374 2016-03-11 11:43:59 -0800 [AX] SVG element with child desc not exposed 2016-03-14 10:18:44 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jdiggs jdiggs aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig mario samuel_white webkit-bug-importer oldest_to_newest 1173811 0 jdiggs 2016-03-11 11:43:59 -0800 [AX] SVG element with child desc not exposed 1173813 1 273750 jdiggs 2016-03-11 11:48:05 -0800 Created attachment 273750 Patch 1173814 2 webkit-bug-importer 2016-03-11 11:49:23 -0800 <rdar://problem/25114469> 1173857 3 273750 darin 2016-03-11 13:56:11 -0800 Comment on attachment 273750 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273750&action=review > Source/WebCore/accessibility/AccessibilitySVGElement.h:35 > +class AccessibilitySVGElement : public AccessibilityRenderObject { Since the class is no longer final, best practice would be to mark the overrides of virtual functions here final, instead of override, unless we need to override them further in the derived class. I believe that’s true for *all* the override functions in this class. Further, everything in this class except the constructor that is currently protected seems like it should be private instead. 1174474 4 273979 jdiggs 2016-03-14 08:33:34 -0700 Created attachment 273979 Patch 1174492 5 jdiggs 2016-03-14 09:22:18 -0700 @Darin: Changes made. Thanks for the review! @Chris: Accessibility sanity check? :) 1174493 6 cfleizach 2016-03-14 09:25:28 -0700 (In reply to comment #5) > @Darin: Changes made. Thanks for the review! > > @Chris: Accessibility sanity check? :) LGTM 1174514 7 273979 commit-queue 2016-03-14 10:18:40 -0700 Comment on attachment 273979 Patch Clearing flags on attachment: 273979 Committed r198137: <http://trac.webkit.org/changeset/198137> 1174515 8 commit-queue 2016-03-14 10:18:44 -0700 All reviewed patches have been landed. Closing bug. 273750 2016-03-11 11:48:05 -0800 2016-03-14 08:33:29 -0700 Patch bug-155374-20160311144752.patch text/plain 5098 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4MDI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzA5YThjNjYxNTNmYjE2 OGRkMGRkNzZhZjYyOWVjMTk2M2Q0ZGRhYi4uN2E5Nzk0YzZmNGQ4MDMxYTYyM2RhMzM2NWNjMGEx ZmYyOWY2YjQzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTAzLTExICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBbQVhdIFNWRyBlbGVt ZW50IHdpdGggY2hpbGQgZGVzYyBub3QgZXhwb3NlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1Mzc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSB0aGUgYWNjZXNzaWJpbGl0eS93M2Mt c3ZnLXJvbGVzLmh0bWwgdGVzdCwgd2hpY2ggd2FzIHVwZGF0ZWQuCisKKyAgICAgICAgQWNjZXNz aWJpbGl0eVNWR1Jvb3QgaXMgbm93IGEgc3ViY2xhc3Mgb2YgQWNjZXNzaWJpbGl0eVNWR0VsZW1l bnQsIHdoaWNoCisgICAgICAgIGV4cG9zZXMgU1ZHIGVsZW1lbnRzIHdpdGggYSBjaGlsZCBkZXNj IGVsZW1lbnQgYXMgcGVyIHRoZSBzcGVjaWZpY2F0aW9uLgorCisgICAgICAgICogYWNjZXNzaWJp bGl0eS9BY2Nlc3NpYmlsaXR5U1ZHRWxlbWVudC5oOgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkv QWNjZXNzaWJpbGl0eVNWR1Jvb3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0 eVNWR1Jvb3Q6OkFjY2Vzc2liaWxpdHlTVkdSb290KToKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vz c2liaWxpdHlTVkdSb290OjpwYXJlbnRPYmplY3QpOgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkv QWNjZXNzaWJpbGl0eVNWR1Jvb3QuaDoKKwogMjAxNi0wMy0xMSAgWXVzdWtlIFN1enVraSAgPHV0 YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbRVM2XSBJbXBsZW1lbnQgUmVmbGVjdC5z ZXQgd2l0aG91dCByZWNlaXZlciBzdXBwb3J0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlTVkdFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlTVkdFbGVtZW50LmgKaW5kZXggY2RiYzczM2Q5ZWY3 NGM4NmYwMWFhMTk2NmM0MmEzMmFlZmJjNzBiZC4uZDRmOWEyZTZhN2I1YzlkMjY4MjI4ODZhY2Nm NzQ3MzA5NWUzNWRjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B Y2Nlc3NpYmlsaXR5U1ZHRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxp dHkvQWNjZXNzaWJpbGl0eVNWR0VsZW1lbnQuaApAQCAtMzIsNyArMzIsNyBAQAogCiBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKLWNsYXNzIEFjY2Vzc2liaWxpdHlTVkdFbGVtZW50IGZpbmFsIDogcHVi bGljIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QgeworY2xhc3MgQWNjZXNzaWJpbGl0eVNWR0Vs ZW1lbnQgOiBwdWJsaWMgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdCB7CiAKIHB1YmxpYzoKICAg ICBzdGF0aWMgUmVmPEFjY2Vzc2liaWxpdHlTVkdFbGVtZW50PiBjcmVhdGUoUmVuZGVyT2JqZWN0 Kik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxp dHlTVkdSb290LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0 eVNWR1Jvb3QuY3BwCmluZGV4IDJiNjJkOTJmMjdjZGJiODc2OWRlYTVjM2Q4ZmQ1MDFiNjA1NDYy MmEuLjNkYWIzMjBjYmI2ODE0ZDBhZGZkZjc3MDlmNzFlNGQ2NzhkNGM3MzQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVNWR1Jvb3QuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVNWR1Jvb3QuY3Bw CkBAIC0zNCw3ICszNCw3IEBACiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIEFjY2Vzc2liaWxpdHlT VkdSb290OjpBY2Nlc3NpYmlsaXR5U1ZHUm9vdChSZW5kZXJPYmplY3QqIHJlbmRlcmVyKQotICAg IDogQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdChyZW5kZXJlcikKKyAgICA6IEFjY2Vzc2liaWxp dHlTVkdFbGVtZW50KHJlbmRlcmVyKQogICAgICwgbV9wYXJlbnQobnVsbHB0cikKIHsKIH0KQEAg LTU1LDcgKzU1LDcgQEAgQWNjZXNzaWJpbGl0eU9iamVjdCogQWNjZXNzaWJpbGl0eVNWR1Jvb3Q6 OnBhcmVudE9iamVjdCgpIGNvbnN0CiAgICAgaWYgKG1fcGFyZW50KQogICAgICAgICByZXR1cm4g bV9wYXJlbnQ7CiAgICAgCi0gICAgcmV0dXJuIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnBh cmVudE9iamVjdCgpOworICAgIHJldHVybiBBY2Nlc3NpYmlsaXR5U1ZHRWxlbWVudDo6cGFyZW50 T2JqZWN0KCk7CiB9CiAKICAgICAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvQWNjZXNzaWJpbGl0eVNWR1Jvb3QuaCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxp dHkvQWNjZXNzaWJpbGl0eVNWR1Jvb3QuaAppbmRleCA0ZmY1ZTQ3YzY3MjA5YWM1YTRlNThkMmRi ODNjZTczN2UwOTUzYTJmLi5jZjE2YjVlNmNhNDAyYTBiYTc5OGQ1YWRiZDMyNGE5YTA1NTE4NTc3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlT VkdSb290LmgKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5 U1ZHUm9vdC5oCkBAIC0yOSwxMSArMjksMTEgQEAKICNpZm5kZWYgQWNjZXNzaWJpbGl0eVNWR1Jv b3RfaAogI2RlZmluZSBBY2Nlc3NpYmlsaXR5U1ZHUm9vdF9oCiAKLSNpbmNsdWRlICJBY2Nlc3Np YmlsaXR5UmVuZGVyT2JqZWN0LmgiCisjaW5jbHVkZSAiQWNjZXNzaWJpbGl0eVNWR0VsZW1lbnQu aCIKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1jbGFzcyBBY2Nlc3NpYmlsaXR5U1ZHUm9vdCBm aW5hbCA6IHB1YmxpYyBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0IHsKK2NsYXNzIEFjY2Vzc2li aWxpdHlTVkdSb290IGZpbmFsIDogcHVibGljIEFjY2Vzc2liaWxpdHlTVkdFbGVtZW50IHsKIHB1 YmxpYzoKICAgICBzdGF0aWMgUmVmPEFjY2Vzc2liaWxpdHlTVkdSb290PiBjcmVhdGUoUmVuZGVy T2JqZWN0Kik7CiAgICAgdmlydHVhbCB+QWNjZXNzaWJpbGl0eVNWR1Jvb3QoKTsKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBj OGYwZmI0OTM3OTQ4NTRiODBmZmUyNGNkMmQyM2FiYzMzNDY3NzYwLi4xZDE5YmU4ODlkNDlmODNl M2U1NDVmMTI2Yzc4MTIxM2RjZDQyNmVlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTYtMDMt MTEgIEpvYW5tYXJpZSBEaWdncyAgPGpkaWdnc0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtBWF0g U1ZHIGVsZW1lbnQgd2l0aCBjaGlsZCBkZXNjIG5vdCBleHBvc2VkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTUzNzQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9hY2Nlc3NpYmls aXR5L3czYy1zdmctcm9sZXMtZXhwZWN0ZWQudHh0OiBVcGRhdGVkLgorICAgICAgICAqIHBsYXRm b3JtL21hYy9hY2Nlc3NpYmlsaXR5L3czYy1zdmctcm9sZXMtZXhwZWN0ZWQudHh0OiBVcGRhdGVk LgorCiAyMDE2LTAzLTExICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgog CiAgICAgICAgIFtFUzZdIEltcGxlbWVudCBSZWZsZWN0LnNldCB3aXRob3V0IHJlY2VpdmVyIHN1 cHBvcnQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5 L3czYy1zdmctcm9sZXMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Fj Y2Vzc2liaWxpdHkvdzNjLXN2Zy1yb2xlcy1leHBlY3RlZC50eHQKaW5kZXggMDk4MWMxOTdhOGU0 ZTVmODliNTBkNGFhMjQxN2YwNWIyNDk2YTdjYy4uZjM1NDliMzQ2OTkzYjQ4ODFlNTFlMDAxYTI4 NTAwMTc2ZjNkZGIyYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vz c2liaWxpdHkvdzNjLXN2Zy1yb2xlcy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvdzNjLXN2Zy1yb2xlcy1leHBlY3RlZC50eHQKQEAgLTgz LDcgKzgzLDcgQEAgdGVzdDI2OgogCUFYUm9sZTogQVhJbWFnZQogdGVzdDI3OgogCUV4cGVjdGVk IHJvbGU6IGdyb3VwCi0JRWxlbWVudCBub3QgZXhwb3NlZAorCUFYUm9sZTogQVhHcm91cAogdGVz dDI4OgogCUV4cGVjdGVkIHJvbGU6IGltZwogCUFYUm9sZTogQVhJbWFnZQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvdzNjLXN2Zy1yb2xlcy1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS93M2Mtc3Zn LXJvbGVzLWV4cGVjdGVkLnR4dAppbmRleCBmMzdhYjhmYjEzM2IxZjNjMTIzOWVjOWYzNTFmZTNh NDI5MDgwMmRhLi43ZDk0Y2VmMzdhNDQxY2Y2ZTE2ZTlmMjE4ZjE3NjdiZTE1ZjNjYmQ5IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS93M2Mtc3ZnLXJv bGVzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJp bGl0eS93M2Mtc3ZnLXJvbGVzLWV4cGVjdGVkLnR4dApAQCAtODMsNyArODMsNyBAQCB0ZXN0MjY6 CiAJQVhSb2xlOiBBWEltYWdlCiB0ZXN0Mjc6CiAJRXhwZWN0ZWQgcm9sZTogZ3JvdXAKLQlFbGVt ZW50IG5vdCBleHBvc2VkCisJQVhSb2xlOiBBWEdyb3VwCiB0ZXN0Mjg6CiAJRXhwZWN0ZWQgcm9s ZTogaW1nCiAJQVhSb2xlOiBBWEltYWdlCg== 273979 2016-03-14 08:33:34 -0700 2016-03-14 10:18:40 -0700 Patch bug-155374-20160314113322.patch text/plain 6172 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4MTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjk5NmJmZTMyNTgyNWZm NjNiMDUyNDljMGNiMWUwMDM4NzRkNGRmNi4uNjJmNzg3ZTg0NzU0YjhiZGM0YTVlZjI3ZTQwOTVm ZGMxZjFhZmM5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTAzLTE0ICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBbQVhdIFNWRyBlbGVt ZW50IHdpdGggY2hpbGQgZGVzYyBub3QgZXhwb3NlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1Mzc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFy aW4gQWRsZXIuCisKKyAgICAgICAgQ292ZXJlZCBieSB0aGUgYWNjZXNzaWJpbGl0eS93M2Mtc3Zn LXJvbGVzLmh0bWwgdGVzdCwgd2hpY2ggd2FzIHVwZGF0ZWQuCisKKyAgICAgICAgQWNjZXNzaWJp bGl0eVNWR1Jvb3QgaXMgbm93IGEgc3ViY2xhc3Mgb2YgQWNjZXNzaWJpbGl0eVNWR0VsZW1lbnQs IHdoaWNoCisgICAgICAgIGV4cG9zZXMgU1ZHIGVsZW1lbnRzIHdpdGggYSBjaGlsZCBkZXNjIGVs ZW1lbnQgYXMgcGVyIHRoZSBzcGVjaWZpY2F0aW9uLgorICAgICAgICBBbHNvIG1hZGUgZXhpc3Rp bmcgcHJvdGVjdGVkIG1ldGhvZHMgcHJpdmF0ZS4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkv QWNjZXNzaWJpbGl0eVNWR0VsZW1lbnQuaDoKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vz c2liaWxpdHlTVkdSb290LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlTVkdS b290OjpBY2Nlc3NpYmlsaXR5U1ZHUm9vdCk6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmls aXR5U1ZHUm9vdDo6cGFyZW50T2JqZWN0KToKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vz c2liaWxpdHlTVkdSb290Lmg6CisKIDIwMTYtMDMtMTQgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdl YmtpdC5vcmc+CiAKICAgICAgICAgQWRkIHNsb3RjaGFuZ2UgZXZlbnQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVNWR0VsZW1lbnQuaCBiL1Nv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVNWR0VsZW1lbnQuaAppbmRl eCBjZGJjNzMzZDllZjc0Yzg2ZjAxYWExOTY2YzQyYTMyYWVmYmM3MGJkLi4zY2NmYjk1NWMxNzcy ZDkzMTU1Y2I0ZmIzZjA3MTUwYjUxNDlkNjQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlTVkdFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5U1ZHRWxlbWVudC5oCkBAIC0zMiwyNSArMzIs MjUgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1jbGFzcyBBY2Nlc3NpYmlsaXR5U1ZHRWxl bWVudCBmaW5hbCA6IHB1YmxpYyBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0IHsKK2NsYXNzIEFj Y2Vzc2liaWxpdHlTVkdFbGVtZW50IDogcHVibGljIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Qg ewogCiBwdWJsaWM6CiAgICAgc3RhdGljIFJlZjxBY2Nlc3NpYmlsaXR5U1ZHRWxlbWVudD4gY3Jl YXRlKFJlbmRlck9iamVjdCopOwogICAgIHZpcnR1YWwgfkFjY2Vzc2liaWxpdHlTVkdFbGVtZW50 KCk7CiAKLSAgICBTdHJpbmcgYWNjZXNzaWJpbGl0eURlc2NyaXB0aW9uKCkgY29uc3Qgb3ZlcnJp ZGU7Ci0gICAgU3RyaW5nIGhlbHBUZXh0KCkgY29uc3Qgb3ZlcnJpZGU7CisgICAgU3RyaW5nIGFj Y2Vzc2liaWxpdHlEZXNjcmlwdGlvbigpIGNvbnN0IGZpbmFsOworICAgIFN0cmluZyBoZWxwVGV4 dCgpIGNvbnN0IGZpbmFsOwogCiBwcm90ZWN0ZWQ6CiAgICAgZXhwbGljaXQgQWNjZXNzaWJpbGl0 eVNWR0VsZW1lbnQoUmVuZGVyT2JqZWN0Kik7Ci0gICAgYm9vbCBpc0FjY2Vzc2liaWxpdHlTVkdF bGVtZW50KCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gdHJ1ZTsgfQotICAgIGJvb2wgY29tcHV0 ZUFjY2Vzc2liaWxpdHlJc0lnbm9yZWQoKSBjb25zdCBvdmVycmlkZTsKLSAgICBBY2Nlc3NpYmls aXR5Um9sZSBkZXRlcm1pbmVBcmlhUm9sZUF0dHJpYnV0ZSgpIGNvbnN0OwogCiBwcml2YXRlOgot ICAgIHZvaWQgYWNjZXNzaWJpbGl0eVRleHQoVmVjdG9yPEFjY2Vzc2liaWxpdHlUZXh0PiYpIG92 ZXJyaWRlOwotICAgIEFjY2Vzc2liaWxpdHlSb2xlIGRldGVybWluZUFjY2Vzc2liaWxpdHlSb2xl KCkgb3ZlcnJpZGU7Ci0gICAgYm9vbCBpbmhlcml0c1ByZXNlbnRhdGlvbmFsUm9sZSgpIGNvbnN0 IG92ZXJyaWRlOworICAgIHZvaWQgYWNjZXNzaWJpbGl0eVRleHQoVmVjdG9yPEFjY2Vzc2liaWxp dHlUZXh0PiYpIGZpbmFsOworICAgIEFjY2Vzc2liaWxpdHlSb2xlIGRldGVybWluZUFjY2Vzc2li aWxpdHlSb2xlKCkgZmluYWw7CisgICAgdmlydHVhbCBBY2Nlc3NpYmlsaXR5Um9sZSBkZXRlcm1p bmVBcmlhUm9sZUF0dHJpYnV0ZSgpIGNvbnN0OworICAgIGJvb2wgaW5oZXJpdHNQcmVzZW50YXRp b25hbFJvbGUoKSBjb25zdCBmaW5hbDsKKyAgICBib29sIGlzQWNjZXNzaWJpbGl0eVNWR0VsZW1l bnQoKSBjb25zdCBmaW5hbCB7IHJldHVybiB0cnVlOyB9CisgICAgYm9vbCBjb21wdXRlQWNjZXNz aWJpbGl0eUlzSWdub3JlZCgpIGNvbnN0IGZpbmFsOwogCiAgICAgQWNjZXNzaWJpbGl0eU9iamVj dCogdGFyZ2V0Rm9yVXNlRWxlbWVudCgpIGNvbnN0OwogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVNWR1Jvb3QuY3BwIGIvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5U1ZHUm9vdC5jcHAKaW5kZXggMmI2MmQ5 MmYyN2NkYmI4NzY5ZGVhNWMzZDhmZDUwMWI2MDU0NjIyYS4uM2RhYjMyMGNiYjY4MTRkMGFkZmRm NzcwOWY3MWU0ZDY3OGQ0YzczNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJp bGl0eS9BY2Nlc3NpYmlsaXR5U1ZHUm9vdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9BY2Nlc3NpYmlsaXR5U1ZHUm9vdC5jcHAKQEAgLTM0LDcgKzM0LDcgQEAKIG5hbWVz cGFjZSBXZWJDb3JlIHsKIAogQWNjZXNzaWJpbGl0eVNWR1Jvb3Q6OkFjY2Vzc2liaWxpdHlTVkdS b290KFJlbmRlck9iamVjdCogcmVuZGVyZXIpCi0gICAgOiBBY2Nlc3NpYmlsaXR5UmVuZGVyT2Jq ZWN0KHJlbmRlcmVyKQorICAgIDogQWNjZXNzaWJpbGl0eVNWR0VsZW1lbnQocmVuZGVyZXIpCiAg ICAgLCBtX3BhcmVudChudWxscHRyKQogewogfQpAQCAtNTUsNyArNTUsNyBAQCBBY2Nlc3NpYmls aXR5T2JqZWN0KiBBY2Nlc3NpYmlsaXR5U1ZHUm9vdDo6cGFyZW50T2JqZWN0KCkgY29uc3QKICAg ICBpZiAobV9wYXJlbnQpCiAgICAgICAgIHJldHVybiBtX3BhcmVudDsKICAgICAKLSAgICByZXR1 cm4gQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6cGFyZW50T2JqZWN0KCk7CisgICAgcmV0dXJu IEFjY2Vzc2liaWxpdHlTVkdFbGVtZW50OjpwYXJlbnRPYmplY3QoKTsKIH0KIAogICAgIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5U1ZHUm9v dC5oIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5U1ZHUm9vdC5o CmluZGV4IDRmZjVlNDdjNjcyMDlhYzVhNGU1OGQyZGI4M2NlNzM3ZTA5NTNhMmYuLmNmMTZiNWU2 Y2E0MDJhMGJhNzk4ZDVhZGJkMzI0YTlhMDU1MTg1NzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVNWR1Jvb3QuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlTVkdSb290LmgKQEAgLTI5LDExICsyOSwx MSBAQAogI2lmbmRlZiBBY2Nlc3NpYmlsaXR5U1ZHUm9vdF9oCiAjZGVmaW5lIEFjY2Vzc2liaWxp dHlTVkdSb290X2gKIAotI2luY2x1ZGUgIkFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuaCIKKyNp bmNsdWRlICJBY2Nlc3NpYmlsaXR5U1ZHRWxlbWVudC5oIgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKLWNsYXNzIEFjY2Vzc2liaWxpdHlTVkdSb290IGZpbmFsIDogcHVibGljIEFjY2Vzc2liaWxp dHlSZW5kZXJPYmplY3QgeworY2xhc3MgQWNjZXNzaWJpbGl0eVNWR1Jvb3QgZmluYWwgOiBwdWJs aWMgQWNjZXNzaWJpbGl0eVNWR0VsZW1lbnQgewogcHVibGljOgogICAgIHN0YXRpYyBSZWY8QWNj ZXNzaWJpbGl0eVNWR1Jvb3Q+IGNyZWF0ZShSZW5kZXJPYmplY3QqKTsKICAgICB2aXJ0dWFsIH5B Y2Nlc3NpYmlsaXR5U1ZHUm9vdCgpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGIxMDUyYWFlMDU3NTZjNmRiMjVmYzhjMTcx ZDBhOGJjNDEwOTVlMjIuLjZjMjA1MTBhY2EzYzE1MTljODEzMzYwMGU1MjI3YjczNDA5NzliNTYg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNi0wMy0xNCAgSm9hbm1hcmllIERpZ2dzICA8amRp Z2dzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0FYXSBTVkcgZWxlbWVudCB3aXRoIGNoaWxkIGRl c2Mgbm90IGV4cG9zZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE1NTM3NAorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvdzNjLXN2Zy1yb2xlcy1leHBlY3RlZC50 eHQ6IFVwZGF0ZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvdzNjLXN2 Zy1yb2xlcy1leHBlY3RlZC50eHQ6IFVwZGF0ZWQuCisKIDIwMTYtMDMtMTQgIFJ5b3N1a2UgTml3 YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIHNsb3RjaGFuZ2UgZXZlbnQKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3czYy1zdmct cm9sZXMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxp dHkvdzNjLXN2Zy1yb2xlcy1leHBlY3RlZC50eHQKaW5kZXggMDk4MWMxOTdhOGU0ZTVmODliNTBk NGFhMjQxN2YwNWIyNDk2YTdjYy4uZjM1NDliMzQ2OTkzYjQ4ODFlNTFlMDAxYTI4NTAwMTc2ZjNk ZGIyYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkv dzNjLXN2Zy1yb2xlcy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3Rr L2FjY2Vzc2liaWxpdHkvdzNjLXN2Zy1yb2xlcy1leHBlY3RlZC50eHQKQEAgLTgzLDcgKzgzLDcg QEAgdGVzdDI2OgogCUFYUm9sZTogQVhJbWFnZQogdGVzdDI3OgogCUV4cGVjdGVkIHJvbGU6IGdy b3VwCi0JRWxlbWVudCBub3QgZXhwb3NlZAorCUFYUm9sZTogQVhHcm91cAogdGVzdDI4OgogCUV4 cGVjdGVkIHJvbGU6IGltZwogCUFYUm9sZTogQVhJbWFnZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvdzNjLXN2Zy1yb2xlcy1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS93M2Mtc3ZnLXJvbGVzLWV4 cGVjdGVkLnR4dAppbmRleCBmMzdhYjhmYjEzM2IxZjNjMTIzOWVjOWYzNTFmZTNhNDI5MDgwMmRh Li43ZDk0Y2VmMzdhNDQxY2Y2ZTE2ZTlmMjE4ZjE3NjdiZTE1ZjNjYmQ5IDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS93M2Mtc3ZnLXJvbGVzLWV4cGVj dGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS93M2Mt c3ZnLXJvbGVzLWV4cGVjdGVkLnR4dApAQCAtODMsNyArODMsNyBAQCB0ZXN0MjY6CiAJQVhSb2xl OiBBWEltYWdlCiB0ZXN0Mjc6CiAJRXhwZWN0ZWQgcm9sZTogZ3JvdXAKLQlFbGVtZW50IG5vdCBl eHBvc2VkCisJQVhSb2xlOiBBWEdyb3VwCiB0ZXN0Mjg6CiAJRXhwZWN0ZWQgcm9sZTogaW1nCiAJ QVhSb2xlOiBBWEltYWdlCg==