155367 2016-03-11 09:45:38 -0800 Python test webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process is flaky 2016-04-12 20:57:33 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=54790 https://bugs.webkit.org/show_bug.cgi?id=98196 P2 Normal --- 1 ryanhaddad ap ap commit-queue dbates glenn oldest_to_newest 1173753 0 ryanhaddad 2016-03-11 09:45:38 -0800 webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process is flaky This webkitpy test has been flaky and failing intermittently. https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20%28Tests%29/builds/4200 https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20%28Tests%29/builds/4168 https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20%28Tests%29/builds/4156 https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20WK2%20%28Tests%29/builds/3909 https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20WK2%20%28Tests%29/builds/3893 https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20WK2%20%28Tests%29/builds/3886 [1446/1451] webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process failed: Traceback (most recent call last): File "/Volumes/Data/slave/elcapitan-release-tests-wk2/build/Tools/Scripts/webkitpy/common/system/executive_unittest.py", line 184, in serial_test_kill_process self.assertEqual(process.wait(), expected_exit_code) AssertionError: 0 != -15 1183211 1 ap 2016-04-12 13:39:21 -0700 I think that this was introduced by this change, unclear if it was even intentional: <http://trac.webkit.org/changeset/89400/trunk/Tools/Scripts/webkitpy/common/system/executive.py> Doing a non-blocking waitpid followed by another waitpid is super racy, and no wonder that the second one sometimes fails. Can't say that I like overall design of this code either - it relies on an exception as part of normal operation. 1183220 2 276272 ap 2016-04-12 13:48:24 -0700 Created attachment 276272 proposed fix Tests pass on Mac without this. I didn't test on Windows. 1183222 3 commit-queue 2016-04-12 13:50:54 -0700 Attachment 276272 did not pass style-queue: ERROR: Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 1183247 4 276276 ap 2016-04-12 14:28:47 -0700 Created attachment 276276 proposed fix With a proper ChangeLog. 1183333 5 276276 commit-queue 2016-04-12 20:57:29 -0700 Comment on attachment 276276 proposed fix Clearing flags on attachment: 276276 Committed r199403: <http://trac.webkit.org/changeset/199403> 1183334 6 commit-queue 2016-04-12 20:57:33 -0700 All reviewed patches have been landed. Closing bug. 276272 2016-04-12 13:48:24 -0700 2016-04-12 14:28:47 -0700 proposed fix ExecutiveTest.txt text/plain 1221 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5OTM4MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE2LTA0LTEyICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIE5lZWQgYSBzaG9ydCBkZXNjcmlwdGlvbiAoT09QUyEpLgorICAgICAgICBO ZWVkIHRoZSBidWcgVVJMIChPT1BTISkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0 aXZlLnB5OgorICAgICAgICAoRXhlY3V0aXZlLmtpbGxfcHJvY2Vzcyk6CisKIDIwMTYtMDQtMTIg IE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBbT1Mg WF0gRmxha2V5IGNyYXNoIGFmdGVyIFNjcm9sbEFuaW1hdG9yTWFjIGRlc3RydWN0aW9uCkluZGV4 OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmUu cHkJKHJldmlzaW9uIDE5OTE4MSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5 c3RlbS9leGVjdXRpdmUucHkJKHdvcmtpbmcgY29weSkKQEAgLTIwNSw3ICsyMDUsNiBAQCBjbGFz cyBFeGVjdXRpdmUob2JqZWN0KToKICAgICAgICAgICAgICAgICAjIGFscmVhZHkgZXhpdGVkLCBh bmQgZm9yY2VmdWxseSBraWxsIGl0IGlmIFNJR1RFUk0gd2Fzbid0IGVub3VnaC4KICAgICAgICAg ICAgICAgICBvcy5raWxsKHBpZCwgc2lnbmFsLlNJR1RFUk0pCiAgICAgICAgICAgICAgICAgb3Mu a2lsbChwaWQsIHNpZ25hbC5TSUdLSUxMKQotICAgICAgICAgICAgICAgIF8gPSBvcy53YWl0cGlk KHBpZCwgb3MuV05PSEFORykKICAgICAgICAgICAgIGV4Y2VwdCBPU0Vycm9yLCBlOgogICAgICAg ICAgICAgICAgIGlmIGUuZXJybm8gPT0gZXJybm8uRUFHQUlOOgogICAgICAgICAgICAgICAgICAg ICBpZiByZXRyaWVzX2xlZnQgPD0gMDoK 276276 2016-04-12 14:28:47 -0700 2016-04-12 20:57:29 -0700 proposed fix ExecutiveTest.txt text/plain 1464 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5OTM4MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE2LTA0LTEyICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFB5dGhvbiB0ZXN0IHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0uZXhlY3V0aXZl X3VuaXR0ZXN0LkV4ZWN1dGl2ZVRlc3Quc2VyaWFsX3Rlc3Rfa2lsbF9wcm9jZXNzIGlzIGZsYWt5 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTUzNjcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmUucHk6IChFeGVjdXRpdmUua2lsbF9w cm9jZXNzKToKKyAgICAgICAgRG9uJ3QgZmxha2lseSBjb25zdW1lIHRoZSByZXR1cm4gY29kZSB3 aXRoIHdhaXRwaWQsIGNhbGxlcnMgbmVlZCB0byBkbyB3YWl0cGlkIG9uCisgICAgICAgIHRoZWly IG93bi4gTm90IHN1cmUgaWYgdGhpcyBsaW5lIG9mIGNvZGUgd2FzIGV2ZW4gaW50ZW50aW9uYWwu CisKIDIwMTYtMDQtMTIgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4K IAogICAgICAgICBbT1MgWF0gRmxha2V5IGNyYXNoIGFmdGVyIFNjcm9sbEFuaW1hdG9yTWFjIGRl c3RydWN0aW9uCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhl Y3V0aXZlLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5 c3RlbS9leGVjdXRpdmUucHkJKHJldmlzaW9uIDE5OTE4MSkKKysrIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmUucHkJKHdvcmtpbmcgY29weSkKQEAgLTIwNSw3 ICsyMDUsNiBAQCBjbGFzcyBFeGVjdXRpdmUob2JqZWN0KToKICAgICAgICAgICAgICAgICAjIGFs cmVhZHkgZXhpdGVkLCBhbmQgZm9yY2VmdWxseSBraWxsIGl0IGlmIFNJR1RFUk0gd2Fzbid0IGVu b3VnaC4KICAgICAgICAgICAgICAgICBvcy5raWxsKHBpZCwgc2lnbmFsLlNJR1RFUk0pCiAgICAg ICAgICAgICAgICAgb3Mua2lsbChwaWQsIHNpZ25hbC5TSUdLSUxMKQotICAgICAgICAgICAgICAg IF8gPSBvcy53YWl0cGlkKHBpZCwgb3MuV05PSEFORykKICAgICAgICAgICAgIGV4Y2VwdCBPU0Vy cm9yLCBlOgogICAgICAgICAgICAgICAgIGlmIGUuZXJybm8gPT0gZXJybm8uRUFHQUlOOgogICAg ICAgICAgICAgICAgICAgICBpZiByZXRyaWVzX2xlZnQgPD0gMDoK