155343 2016-03-10 18:59:21 -0800 [iOS] Allow clients to specify text suggestions to be used for a form input session 2016-03-11 14:13:41 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build iPhone / iPad Unspecified RESOLVED FIXED P2 Enhancement --- 1 cpugh webkit-unassigned adele commit-queue cpugh enrica mitz oldest_to_newest 1173523 0 cpugh 2016-03-10 18:59:21 -0800 Allow clients to specify text suggestions to be used for a form input session. Patch forthcoming. 1173589 1 273685 cpugh 2016-03-10 21:35:03 -0800 Created attachment 273685 Patch to resolve [iOS] Allow clients to specify text suggestions to be used for a form input session 1173593 2 273685 mitz 2016-03-10 21:47:33 -0800 Comment on attachment 273685 Patch to resolve [iOS] Allow clients to specify text suggestions to be used for a form input session View in context: https://bugs.webkit.org/attachment.cgi?id=273685&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:313 > + id <UITextInputSuggestionDelegate> suggestionDelegate = (id <UITextInputSuggestionDelegate>)_contentView.inputDelegate; Should we assert that this was a valid cast? > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:314 > + _suggestions = suggestions; You should adhere to the API contract and copy the array here. 1173861 3 273765 cpugh 2016-03-11 14:03:39 -0800 Created attachment 273765 patch version 2 1173863 4 commit-queue 2016-03-11 14:05:28 -0800 Attachment 273765 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:324: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1173864 5 273765 mitz 2016-03-11 14:07:04 -0800 Comment on attachment 273765 patch version 2 View in context: https://bugs.webkit.org/attachment.cgi?id=273765&action=review > Source/WebKit2/UIProcess/API/Cocoa/_WKInputDelegate.h:48 > - (BOOL)_webView:(WKWebView *)webView hasSuggestionsForCurrentStringInInputSession:(id <_WKFormInputSession>)inputSession; > - (NSArray *)_webView:(WKWebView *)webView suggestionsForString:(NSString *)string inInputSession:(id <_WKFormInputSession>)inputSession; Shouldn’t be part of this bug, but I think we can get rid of this old suggestions API, since we never ended up invoking these methods. 1173867 6 mitz 2016-03-11 14:13:41 -0800 Committed <http://trac.webkit.org/r198046>. 273685 2016-03-10 21:35:03 -0800 2016-03-11 14:03:39 -0800 Patch to resolve [iOS] Allow clients to specify text suggestions to be used for a form input session cpugh-[iOS]-Allow-clients-to-specify-text-suggestions-to-.patch text/plain 5103 cpugh ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmNDg5MjNjLi45YTQwYTIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTYtMDMtMTAgIENoZWxzZWEgUHVnaCAgPGNwdWdoQGFwcGxlLmNvbT4KKworICAgICAg ICBbaU9TXSBBbGxvdyBjbGllbnRzIHRvIHNwZWNpZnkgdGV4dCBzdWdnZXN0aW9ucyB0byBiZSB1 c2VkIGZvciBhIGZvcm0gaW5wdXQgc2Vzc2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1MzQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL19XS0Zvcm1JbnB1dFNl c3Npb24uaDogQWRkZWQgc3VnZ2VzdGlvbnMgcHJvcGVydHkgdG8gdGhlIHByb3RvY29sLgorICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLSW5wdXREZWxlZ2F0ZS5oOgorICAgICAgICAq IFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtX S0Zvcm1JbnB1dFNlc3Npb24gc3VnZ2VzdGlvbnNdKTogQWRkIGEgZ2V0dGVyIGZvciBzdWdnZXN0 aW9ucy4KKyAgICAgICAgKC1bV0tGb3JtSW5wdXRTZXNzaW9uIHNldFN1Z2dlc3Rpb25zOl0pOiBB ZGQgYSBzZXR0ZXIsIHdoaWNoIGNhbGxzIHNldFN1Z2dlc3Rpb25zIHdpdGggb3VyIHN1Z2dlc3Rp b25zIG9uIHRoZSBpbnB1dCBkZWxlZ2F0ZS4KKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBpbnNl cnRUZXh0U3VnZ2VzdGlvbjpdKTogQ2FsbCBfd2ViVmlldzppbnNlcnRUZXh0U3VnZ2VzdGlvbjpp bklucHV0U2Vzc2lvbjogb24gb3VyIGlucHV0IGRlbGVnYXRlIHNvIGNsaWVudHMga25vdworICAg ICAgICBhIHRleHQgc3VnZ2VzdGlvbiB3YXMgdGFwcGVkLgorCiAyMDE2LTAzLTA5ICBEYXZpZCBL aWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjE5NzE0 OSk6IE1pc3NpbmcgYXZhaWxhYmlsaXR5IGNoZWNrcyB3aGVuIHNvZnQtbGlua2luZyBEYXRhRGV0 ZWN0b3JzLmZyYW1ld29yawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9Db2NvYS9fV0tGb3JtSW5wdXRTZXNzaW9uLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL0NvY29hL19XS0Zvcm1JbnB1dFNlc3Npb24uaAppbmRleCAyODRiZTllLi42YTE1OTYwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0Zvcm1JbnB1 dFNlc3Npb24uaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0Zv cm1JbnB1dFNlc3Npb24uaApAQCAtMzksNiArMzksNyBAQAogI2lmIFRBUkdFVF9PU19JUEhPTkUK IEBwcm9wZXJ0eSAobm9uYXRvbWljLCBjb3B5KSBOU1N0cmluZyAqYWNjZXNzb3J5Vmlld0N1c3Rv bUJ1dHRvblRpdGxlOwogQHByb3BlcnR5IChub25hdG9taWMsIHN0cm9uZykgVUlWaWV3ICpjdXN0 b21JbnB1dFZpZXcgV0tfQVZBSUxBQkxFKE5BLCBXS19JT1NfVEJBKTsKK0Bwcm9wZXJ0eSAobm9u YXRvbWljLCBjb3B5KSBOU0FycmF5PFVJVGV4dFN1Z2dlc3Rpb24gKj4gKnN1Z2dlc3Rpb25zIFdL X0FWQUlMQUJMRShOQSwgV0tfSU9TX1RCQSk7CiAjZW5kaWYKIAogQGVuZApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tJbnB1dERlbGVnYXRlLmggYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0lucHV0RGVsZWdhdGUuaAppbmRl eCBhZTEyMTc3Li4wNjIxOWJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL0NvY29hL19XS0lucHV0RGVsZWdhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL0NvY29hL19XS0lucHV0RGVsZWdhdGUuaApAQCAtMjksNiArMjksNyBAQAogCiAjaW1w b3J0IDxGb3VuZGF0aW9uL0ZvdW5kYXRpb24uaD4KIAorQGNsYXNzIFVJVGV4dFN1Z2dlc3Rpb247 CiBAY2xhc3MgV0tXZWJWaWV3OwogQHByb3RvY29sIF9XS0ZvY3VzZWRFbGVtZW50SW5mbzsKIEBw cm90b2NvbCBfV0tGb3JtSW5wdXRTZXNzaW9uOwpAQCAtNDUsNiArNDYsNyBAQAogLSAodm9pZClf d2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBhY2Nlc3NvcnlWaWV3Q3VzdG9tQnV0dG9uVGFw cGVkSW5Gb3JtSW5wdXRTZXNzaW9uOihpZCA8X1dLRm9ybUlucHV0U2Vzc2lvbj4paW5wdXRTZXNz aW9uOwogLSAoQk9PTClfd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBoYXNTdWdnZXN0aW9u c0ZvckN1cnJlbnRTdHJpbmdJbklucHV0U2Vzc2lvbjooaWQgPF9XS0Zvcm1JbnB1dFNlc3Npb24+ KWlucHV0U2Vzc2lvbjsKIC0gKE5TQXJyYXkgKilfd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmll dyBzdWdnZXN0aW9uc0ZvclN0cmluZzooTlNTdHJpbmcgKilzdHJpbmcgaW5JbnB1dFNlc3Npb246 KGlkIDxfV0tGb3JtSW5wdXRTZXNzaW9uPilpbnB1dFNlc3Npb247CistICh2b2lkKV93ZWJWaWV3 OihXS1dlYlZpZXcgKil3ZWJWaWV3IGluc2VydFRleHRTdWdnZXN0aW9uOihVSVRleHRTdWdnZXN0 aW9uICopc3VnZ2VzdGlvbiBpbklucHV0U2Vzc2lvbjooaWQgPF9XS0Zvcm1JbnB1dFNlc3Npb24+ KWlucHV0U2Vzc2lvbiBXS19BVkFJTEFCTEUoTkEsIFdLX0lPU19UQkEpOwogI2VuZGlmCiAKIEBl bmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmll d0ludGVyYWN0aW9uLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRW aWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggNDNmZTUyNC4uMjE1MmM0NyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u bW0KQEAgLTI1Nyw2ICsyNTcsNyBAQCBjb25zdCBDR0Zsb2F0IG1pbmltdW1UYXBIaWdobGlnaHRS YWRpdXMgPSAyLjA7CiAgICAgUmV0YWluUHRyPE5TT2JqZWN0IDxOU1NlY3VyZUNvZGluZz4+IF91 c2VyT2JqZWN0OwogICAgIFJldGFpblB0cjxXS0ZvY3VzZWRFbGVtZW50SW5mbz4gX2ZvY3VzZWRF bGVtZW50SW5mbzsKICAgICBSZXRhaW5QdHI8VUlWaWV3PiBfY3VzdG9tSW5wdXRWaWV3OworICAg IFJldGFpblB0cjxOU0FycmF5PFVJVGV4dFN1Z2dlc3Rpb24gKj4+IF9zdWdnZXN0aW9uczsKIH0K IAogLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoQ29udGVudFZpZXc6KFdLQ29udGVudFZpZXcgKil2 aWV3IGZvY3VzZWRFbGVtZW50SW5mbzooV0tGb2N1c2VkRWxlbWVudEluZm8gKillbGVtZW50SW5m byB1c2VyT2JqZWN0OihOU09iamVjdCA8TlNTZWN1cmVDb2Rpbmc+ICopdXNlck9iamVjdApAQCAt MzAxLDYgKzMwMiwyNCBAQCBjb25zdCBDR0Zsb2F0IG1pbmltdW1UYXBIaWdobGlnaHRSYWRpdXMg PSAyLjA7CiAgICAgICAgIFtfY29udGVudFZpZXcgcmVsb2FkSW5wdXRWaWV3c107CiB9CiAKKy0g KE5TQXJyYXk8VUlUZXh0U3VnZ2VzdGlvbiAqPiAqKXN1Z2dlc3Rpb25zCit7CisgICAgcmV0dXJu IF9zdWdnZXN0aW9ucy5nZXQoKTsKK30KKworLSAodm9pZClzZXRTdWdnZXN0aW9uczooTlNBcnJh eTxVSVRleHRTdWdnZXN0aW9uICo+ICopc3VnZ2VzdGlvbnMKK3sKKyNpZiBfX0lQSE9ORV9PU19W RVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDAwMDAKKyAgICBpZCA8VUlUZXh0SW5wdXRTdWdnZXN0 aW9uRGVsZWdhdGU+IHN1Z2dlc3Rpb25EZWxlZ2F0ZSA9IChpZCA8VUlUZXh0SW5wdXRTdWdnZXN0 aW9uRGVsZWdhdGU+KV9jb250ZW50Vmlldy5pbnB1dERlbGVnYXRlOworICAgIF9zdWdnZXN0aW9u cyA9IHN1Z2dlc3Rpb25zOworICAgIC8vIEZJWE1FIDI1MTAyMjI0OiBSZW1vdmUgdGhpcyBkaXNw YXRjaF9hZnRlciBvbmNlIHJhY2UgY29uZGl0aW9uIGNhdXNpbmcga2V5Ym9hcmQgc3VnZ2VzdGlv bnMgdG8gb3ZlcndyaXRlCisgICAgLy8gdGhlIHN1Z2dlc3Rpb25zIGJlaW5nIHNldCBpcyByZXNv bHZlZAorICAgIGRpc3BhdGNoX2FmdGVyKGRpc3BhdGNoX3RpbWUoRElTUEFUQ0hfVElNRV9OT1cs IChpbnQ2NF90KSgyMCAqIE5TRUNfUEVSX01TRUMpKSwgZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUo KSwgXnsKKyAgICAgICAgW3N1Z2dlc3Rpb25EZWxlZ2F0ZSBzZXRTdWdnZXN0aW9uczpzdWdnZXN0 aW9uc107CisgICAgfSk7CisjZW5kaWYKK30KKwogLSAoVUlWaWV3ICopY3VzdG9tSW5wdXRWaWV3 CiB7CiAgICAgcmV0dXJuIF9jdXN0b21JbnB1dFZpZXcuZ2V0KCk7CkBAIC0yNjAxLDYgKzI2MjAs MTUgQEAgc3RhdGljIHZvaWQgc2VsZWN0aW9uQ2hhbmdlZFdpdGhUb3VjaChXS0NvbnRlbnRWaWV3 ICp2aWV3LCBjb25zdCBXZWJDb3JlOjpJbnRQb2kKICAgICBbc2VsZi5pbnB1dERlbGVnYXRlIHNl bGVjdGlvbkRpZENoYW5nZTpzZWxmXTsKIH0KIAorI2lmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlO X1JFUVVJUkVEID49IDEwMDAwMAorLSAodm9pZClpbnNlcnRUZXh0U3VnZ2VzdGlvbjooVUlUZXh0 U3VnZ2VzdGlvbiAqKXRleHRTdWdnZXN0aW9uCit7CisgICAgaWQgPF9XS0lucHV0RGVsZWdhdGU+ IGlucHV0RGVsZWdhdGUgPSBbX3dlYlZpZXcgX2lucHV0RGVsZWdhdGVdOworICAgIGlmIChbaW5w dXREZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKF93ZWJWaWV3Omluc2VydFRl eHRTdWdnZXN0aW9uOmluSW5wdXRTZXNzaW9uOildKQorICAgICAgICBbaW5wdXREZWxlZ2F0ZSBf d2ViVmlldzpfd2ViVmlldyBpbnNlcnRUZXh0U3VnZ2VzdGlvbjp0ZXh0U3VnZ2VzdGlvbiBpbklu cHV0U2Vzc2lvbjpfZm9ybUlucHV0U2Vzc2lvbi5nZXQoKV07Cit9CisjZW5kaWYKKwogLSAoTlNT dHJpbmcgKil0ZXh0SW5SYW5nZTooVUlUZXh0UmFuZ2UgKilyYW5nZQogewogICAgIHJldHVybiBu aWw7Ci0tIAoyLjYuNCAoQXBwbGUgR2l0LTYzKQoK 273765 2016-03-11 14:03:39 -0800 2016-03-11 14:09:21 -0800 patch version 2 [iOS] Allow clients to specify text suggestions to be used for a form input session v2.patch text/plain 5169 cpugh SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODA0MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE2LTAzLTExICBDaGVsc2Vh IFB1Z2ggIDxjcHVnaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gQWxsb3cgY2xpZW50cyB0 byBzcGVjaWZ5IHRleHQgc3VnZ2VzdGlvbnMgdG8gYmUgdXNlZCBmb3IgYSBmb3JtIGlucHV0IHNl c3Npb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 NTM0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tGb3JtSW5wdXRTZXNzaW9uLmg6CisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9Db2NvYS9fV0tJbnB1dERlbGVnYXRlLmg6CisgICAgICAgICogVUlQcm9jZXNz L2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLRm9ybUlucHV0 U2Vzc2lvbiBzdWdnZXN0aW9uc10pOiBBZGQgYSBnZXR0ZXIgZm9yIHN1Z2dlc3Rpb25zLgorICAg ICAgICAoLVtXS0Zvcm1JbnB1dFNlc3Npb24gc2V0U3VnZ2VzdGlvbnM6XSk6IEFkZCBhIHNldHRl ciwgd2hpY2ggY2FsbHMgc2V0U3VnZ2VzdGlvbnMgd2l0aCBvdXIgc3VnZ2VzdGlvbnMgb24gdGhl IGlucHV0IGRlbGVnYXRlLgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGluc2VydFRleHRTdWdn ZXN0aW9uOl0pOiBDYWxsIF93ZWJWaWV3Omluc2VydFRleHRTdWdnZXN0aW9uOmluSW5wdXRTZXNz aW9uOiBvbiBvdXIgaW5wdXQgZGVsZWdhdGUgc28gY2xpZW50cyBrbm93IAorICAgICAgICBhIHRl eHQgc3VnZ2VzdGlvbiB3YXMgdGFwcGVkLgorCiAyMDE2LTAzLTExICBBbmRlcnMgQ2FybHNzb24g IDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgQ3JlYXRpbmcgYW5kIHJlbGVhc2luZyBh IFdLQmFja0ZvcndhcmRMaXN0SXRlbSBjcmFzaGVzCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL0NvY29hL19XS0Zvcm1JbnB1dFNlc3Npb24uaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0Zvcm1JbnB1dFNlc3Npb24uaAkocmV2 aXNpb24gMTk4MDQxKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tG b3JtSW5wdXRTZXNzaW9uLmgJKHdvcmtpbmcgY29weSkKQEAgLTMwLDYgKzMwLDggQEAKICNpbXBv cnQgPEZvdW5kYXRpb24vRm91bmRhdGlvbi5oPgogI2ltcG9ydCA8V2ViS2l0L19XS0ZvY3VzZWRF bGVtZW50SW5mby5oPgogCitAY2xhc3MgVUlUZXh0U3VnZ2VzdGlvbjsKKwogQHByb3RvY29sIF9X S0Zvcm1JbnB1dFNlc3Npb24gPE5TT2JqZWN0PgogCiBAcHJvcGVydHkgKG5vbmF0b21pYywgcmVh ZG9ubHksIGdldHRlcj1pc1ZhbGlkKSBCT09MIHZhbGlkOwpAQCAtMzksNiArNDEsNyBAQAogI2lm IFRBUkdFVF9PU19JUEhPTkUKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBjb3B5KSBOU1N0cmluZyAq YWNjZXNzb3J5Vmlld0N1c3RvbUJ1dHRvblRpdGxlOwogQHByb3BlcnR5IChub25hdG9taWMsIHN0 cm9uZykgVUlWaWV3ICpjdXN0b21JbnB1dFZpZXcgV0tfQVZBSUxBQkxFKE5BLCBXS19JT1NfVEJB KTsKK0Bwcm9wZXJ0eSAobm9uYXRvbWljLCBjb3B5KSBOU0FycmF5PFVJVGV4dFN1Z2dlc3Rpb24g Kj4gKnN1Z2dlc3Rpb25zIFdLX0FWQUlMQUJMRShOQSwgV0tfSU9TX1RCQSk7CiAjZW5kaWYKIAog QGVuZApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tJbnB1dERl bGVnYXRlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2Nv YS9fV0tJbnB1dERlbGVnYXRlLmgJKHJldmlzaW9uIDE5ODA0MSkKKysrIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLSW5wdXREZWxlZ2F0ZS5oCSh3b3JraW5nIGNvcHkpCkBA IC0yOSw2ICsyOSw3IEBACiAKICNpbXBvcnQgPEZvdW5kYXRpb24vRm91bmRhdGlvbi5oPgogCitA Y2xhc3MgVUlUZXh0U3VnZ2VzdGlvbjsKIEBjbGFzcyBXS1dlYlZpZXc7CiBAcHJvdG9jb2wgX1dL Rm9jdXNlZEVsZW1lbnRJbmZvOwogQHByb3RvY29sIF9XS0Zvcm1JbnB1dFNlc3Npb247CkBAIC00 NSw2ICs0Niw3IEBACiAtICh2b2lkKV93ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IGFjY2Vz c29yeVZpZXdDdXN0b21CdXR0b25UYXBwZWRJbkZvcm1JbnB1dFNlc3Npb246KGlkIDxfV0tGb3Jt SW5wdXRTZXNzaW9uPilpbnB1dFNlc3Npb247CiAtIChCT09MKV93ZWJWaWV3OihXS1dlYlZpZXcg Kil3ZWJWaWV3IGhhc1N1Z2dlc3Rpb25zRm9yQ3VycmVudFN0cmluZ0luSW5wdXRTZXNzaW9uOihp ZCA8X1dLRm9ybUlucHV0U2Vzc2lvbj4paW5wdXRTZXNzaW9uOwogLSAoTlNBcnJheSAqKV93ZWJW aWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IHN1Z2dlc3Rpb25zRm9yU3RyaW5nOihOU1N0cmluZyAq KXN0cmluZyBpbklucHV0U2Vzc2lvbjooaWQgPF9XS0Zvcm1JbnB1dFNlc3Npb24+KWlucHV0U2Vz c2lvbjsKKy0gKHZvaWQpX3dlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcgaW5zZXJ0VGV4dFN1 Z2dlc3Rpb246KFVJVGV4dFN1Z2dlc3Rpb24gKilzdWdnZXN0aW9uIGluSW5wdXRTZXNzaW9uOihp ZCA8X1dLRm9ybUlucHV0U2Vzc2lvbj4paW5wdXRTZXNzaW9uIFdLX0FWQUlMQUJMRShOQSwgV0tf SU9TX1RCQSk7CiAjZW5kaWYKIAogQGVuZApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0JKHJldmlzaW9u IDE5ODA0MSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0lu dGVyYWN0aW9uLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yNjAsNiArMjYwLDcgQEAgLSAodm9pZClp bnZhbGlkYXRlOwogICAgIFJldGFpblB0cjxOU09iamVjdCA8TlNTZWN1cmVDb2Rpbmc+PiBfdXNl ck9iamVjdDsKICAgICBSZXRhaW5QdHI8V0tGb2N1c2VkRWxlbWVudEluZm8+IF9mb2N1c2VkRWxl bWVudEluZm87CiAgICAgUmV0YWluUHRyPFVJVmlldz4gX2N1c3RvbUlucHV0VmlldzsKKyAgICBS ZXRhaW5QdHI8TlNBcnJheTxVSVRleHRTdWdnZXN0aW9uICo+PiBfc3VnZ2VzdGlvbnM7CiB9CiAK IC0gKGluc3RhbmNldHlwZSlpbml0V2l0aENvbnRlbnRWaWV3OihXS0NvbnRlbnRWaWV3ICopdmll dyBmb2N1c2VkRWxlbWVudEluZm86KFdLRm9jdXNlZEVsZW1lbnRJbmZvICopZWxlbWVudEluZm8g dXNlck9iamVjdDooTlNPYmplY3QgPE5TU2VjdXJlQ29kaW5nPiAqKXVzZXJPYmplY3QKQEAgLTMx OCw2ICszMTksMjQgQEAgLSAodm9pZClzZXRDdXN0b21JbnB1dFZpZXc6KFVJVmlldyAqKWN1cwog ICAgIFtfY29udGVudFZpZXcgcmVsb2FkSW5wdXRWaWV3c107CiB9CiAKKy0gKE5TQXJyYXk8VUlU ZXh0U3VnZ2VzdGlvbiAqPiAqKXN1Z2dlc3Rpb25zCit7CisgICAgIHJldHVybiBfc3VnZ2VzdGlv bnMuZ2V0KCk7Cit9CisKKy0gKHZvaWQpc2V0U3VnZ2VzdGlvbnM6KE5TQXJyYXk8VUlUZXh0U3Vn Z2VzdGlvbiAqPiAqKXN1Z2dlc3Rpb25zCit7CisjaWYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5f UkVRVUlSRUQgPj0gMTAwMDAwCisgICAgaWQgPFVJVGV4dElucHV0U3VnZ2VzdGlvbkRlbGVnYXRl PiBzdWdnZXN0aW9uRGVsZWdhdGUgPSAoaWQgPFVJVGV4dElucHV0U3VnZ2VzdGlvbkRlbGVnYXRl PilfY29udGVudFZpZXcuaW5wdXREZWxlZ2F0ZTsKKyAgICBfc3VnZ2VzdGlvbnMgPSBhZG9wdE5T KFtzdWdnZXN0aW9ucyBjb3B5XSk7CisgICAgLy8gRklYTUUgMjUxMDIyMjQ6IFJlbW92ZSB0aGlz IGRpc3BhdGNoX2FmdGVyIG9uY2UgcmFjZSBjb25kaXRpb24gY2F1c2luZyBrZXlib2FyZCBzdWdn ZXN0aW9ucyB0byBvdmVyd3JpdGUKKyAgICAvLyB0aGUgc3VnZ2VzdGlvbnMgYmVpbmcgc2V0IGlz IHJlc29sdmVkCisgICAgZGlzcGF0Y2hfYWZ0ZXIoZGlzcGF0Y2hfdGltZShESVNQQVRDSF9USU1F X05PVywgKGludDY0X3QpKDIwICogTlNFQ19QRVJfTVNFQykpLCBkaXNwYXRjaF9nZXRfbWFpbl9x dWV1ZSgpLCBeeworICAgICAgICBbc3VnZ2VzdGlvbkRlbGVnYXRlIHNldFN1Z2dlc3Rpb25zOnN1 Z2dlc3Rpb25zXTsKKyAgICB9KTsKKyNlbmRpZgorfQorCiAtICh2b2lkKWludmFsaWRhdGUKIHsK ICAgICBfY29udGVudFZpZXcgPSBuaWw7CkBAIC0yNjAzLDYgKzI2MjIsMTUgQEAgLSAodm9pZCll bmRTZWxlY3Rpb25DaGFuZ2UKIHsKICAgICBbc2VsZi5pbnB1dERlbGVnYXRlIHNlbGVjdGlvbkRp ZENoYW5nZTpzZWxmXTsKIH0KKyAgICAKKyNpZiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFV SVJFRCA+PSAxMDAwMDAKKy0gKHZvaWQpaW5zZXJ0VGV4dFN1Z2dlc3Rpb246KFVJVGV4dFN1Z2dl c3Rpb24gKil0ZXh0U3VnZ2VzdGlvbgoreworICAgIGlkIDxfV0tJbnB1dERlbGVnYXRlPiBpbnB1 dERlbGVnYXRlID0gW193ZWJWaWV3IF9pbnB1dERlbGVnYXRlXTsKKyAgICBpZiAoW2lucHV0RGVs ZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rvcihfd2ViVmlldzppbnNlcnRUZXh0U3Vn Z2VzdGlvbjppbklucHV0U2Vzc2lvbjopXSkKKyAgICAgICAgW2lucHV0RGVsZWdhdGUgX3dlYlZp ZXc6X3dlYlZpZXcgaW5zZXJ0VGV4dFN1Z2dlc3Rpb246dGV4dFN1Z2dlc3Rpb24gaW5JbnB1dFNl c3Npb246X2Zvcm1JbnB1dFNlc3Npb24uZ2V0KCldOworfQorI2VuZGlmCiAKIC0gKE5TU3RyaW5n ICopdGV4dEluUmFuZ2U6KFVJVGV4dFJhbmdlICopcmFuZ2UKIHsK