155300 2016-03-10 09:35:09 -0800 Add shouldNotBe to standalone test harness 2016-03-10 16:42:09 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 153679 1 andy andy commit-queue ossy rniwa ryanhaddad oldest_to_newest 1173118 0 andy 2016-03-10 09:35:09 -0800 Add shouldNotBe to standalone test harness 1173119 1 273576 andy 2016-03-10 09:38:09 -0800 Created attachment 273576 Patch 1173192 2 273576 saam 2016-03-10 11:35:03 -0800 Comment on attachment 273576 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273576&action=review > LayoutTests/resources/standalone-pre.js:324 > function dfgCompiled(argument) > { > var numberOfCompiles = "compiles" in argument ? argument.compiles : 1; > - > + > if (!("f" in argument)) > throw new Error("dfgCompiled called with invalid argument."); > - > + > if (argument.f instanceof Array) { > for (var i = 0; i < argument.f.length; ++i) { Please revert all whitespace changes. 1173201 3 273589 andy 2016-03-10 11:40:12 -0800 Created attachment 273589 Patch 1173204 4 andy 2016-03-10 11:40:52 -0800 (In reply to comment #2) > Comment on attachment 273576 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=273576&action=review > > > LayoutTests/resources/standalone-pre.js:324 > > function dfgCompiled(argument) > > { > > var numberOfCompiles = "compiles" in argument ? argument.compiles : 1; > > - > > + > > if (!("f" in argument)) > > throw new Error("dfgCompiled called with invalid argument."); > > - > > + > > if (argument.f instanceof Array) { > > for (var i = 0; i < argument.f.length; ++i) { > > Please revert all whitespace changes. done 1173406 5 273589 ryanhaddad 2016-03-10 15:53:07 -0800 Comment on attachment 273589 Patch Marking cq+ to fix the tests. 1173451 6 273589 commit-queue 2016-03-10 16:42:06 -0800 Comment on attachment 273589 Patch Clearing flags on attachment: 273589 Committed r197969: <http://trac.webkit.org/changeset/197969> 1173452 7 commit-queue 2016-03-10 16:42:09 -0800 All reviewed patches have been landed. Closing bug. 273576 2016-03-10 09:38:09 -0800 2016-03-10 11:40:09 -0800 Patch bug-155300-20160310103756.patch text/plain 3640 andy U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3OTM4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGNmNjdjNjYzNGM0YWM3ZDdmNTAz ZTVkYmQwMDdlYWM4NDFlMzg5Ni4uNDYwMGMwMGUzM2ViZDI5MDM1YWRjN2U4YzI4MTBmNTMxODVl NDc3YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTAzLTEwICBBbmR5IFZhbldhZ29uZXIg IDxhbmR5QGluc3RydWN0dXJlLmNvbT4KKworICAgICAgICBBZGQgc2hvdWxkTm90QmUgdG8gc3Rh bmRhbG9uZSB0ZXN0IGhhcm5lc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1NTMwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIENvcHkgb3ZlciB0aGUgc2hvdWxkTm90QmUgZnVuY3Rpb24gZnJvbSBqcy10 ZXN0LXByZS4gVGhpcyBmaXhlcyBlcnJvcnMKKyAgICAgICAgaW50cm9kdWNlZCBiZSBuZXcgSW50 bCB0ZXN0cy4gQWxzbyByZW1vdmVzIHNvbWUgdHJhaWxpbmcgd2hpdGVzcGFjZS4KKworICAgICAg ICAqIHJlc291cmNlcy9zdGFuZGFsb25lLXByZS5qczoKKyAgICAgICAgKGRmZ1Nob3VsZEJlKToK KyAgICAgICAgKHNob3VsZE5vdEJlKToKKyAgICAgICAgKGRmZ0NvbXBpbGVkKToKKyAgICAgICAg KGRmZ0luY3JlbWVudCk6CisgICAgICAgIChub0lubGluZSk6CisKIDIwMTYtMDMtMTAgIEZyZWRl cmljIFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEFkZCBzdXBwb3J0 IGZvciBXT0ZGMgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcmVzb3VyY2VzL3N0YW5kYWxvbmUt cHJlLmpzIGIvTGF5b3V0VGVzdHMvcmVzb3VyY2VzL3N0YW5kYWxvbmUtcHJlLmpzCmluZGV4IDQ2 OGM2ZDQwMTQ4NWI4NWFiY2JhMjBkM2VkNmExNTRlNzQzNGEyZGQuLmZhMGMzZmU0NDNkNmI4YjRh NWMyNmQwZWY2NzA4MGM3NmQzN2I0ZmEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3Jlc291cmNl cy9zdGFuZGFsb25lLXByZS5qcworKysgYi9MYXlvdXRUZXN0cy9yZXNvdXJjZXMvc3RhbmRhbG9u ZS1wcmUuanMKQEAgLTE0NSw3ICsxNDUsNyBAQCBmdW5jdGlvbiBkZmdTaG91bGRCZSh0aGVGdW5j dGlvbiwgX2EsIF9iKQogICAvLyBEZWZlbmQgYWdhaW5zdCB0ZXN0cyB0aGF0IG11Y2sgd2l0aCBu dW1lcmljIHByb3BlcnRpZXMgb24gYXJyYXkucHJvdG90eXBlLgogICB2YWx1ZXMuX19wcm90b19f ID0gbnVsbDsKICAgdmFsdWVzLnB1c2ggPSBBcnJheS5wcm90b3R5cGUucHVzaDsKLSAgCisKICAg dHJ5IHsKICAgICB3aGlsZSAoIWRmZ0NvbXBpbGVkKHtmOnRoZUZ1bmN0aW9ufSkpCiAgICAgICB2 YWx1ZXMucHVzaChldmFsKF9hKSk7CkBAIC0xNzIsNyArMTcyLDcgQEAgZnVuY3Rpb24gZGZnU2hv dWxkQmUodGhlRnVuY3Rpb24sIF9hLCBfYikKICAgICBpZiAoYWxsUGFzc2VkKQogICAgICAgdGVz dFBhc3NlZChfYSArICIgaXMgIiArIF9iICsgIiBvbiBhbGwgaXRlcmF0aW9ucyBpbmNsdWRpbmcg YWZ0ZXIgREZHIHRpZXItdXAuIik7CiAgIH0KLSAgCisKICAgcmV0dXJuIHZhbHVlcy5sZW5ndGg7 CiB9CiAKQEAgLTE5Myw2ICsxOTMsMjkgQEAgZnVuY3Rpb24gc2hvdWxkQmVUeXBlKF9hLCBfdHlw ZSkgewogICB9CiB9CiAKK2Z1bmN0aW9uIHNob3VsZE5vdEJlKF9hLCBfYiwgcXVpZXQpCit7Cisg IGlmICh0eXBlb2YgX2EgIT0gInN0cmluZyIgfHwgdHlwZW9mIF9iICE9ICJzdHJpbmciKQorICAg IGRlYnVnKCJXQVJOOiBzaG91bGROb3RCZSgpIGV4cGVjdHMgc3RyaW5nIGFyZ3VtZW50cyIpOwor ICB2YXIgZXhjZXB0aW9uOworICB2YXIgX2F2OworICB0cnkgeworICAgICBfYXYgPSBldmFsKF9h KTsKKyAgfSBjYXRjaCAoZSkgeworICAgICBleGNlcHRpb24gPSBlOworICB9CisgIHZhciBfYnYg PSBldmFsKF9iKTsKKworICBpZiAoZXhjZXB0aW9uKQorICAgIHRlc3RGYWlsZWQoX2EgKyAiIHNo b3VsZCBub3QgYmUgIiArIF9idiArICIuIFRocmV3IGV4Y2VwdGlvbiAiICsgZXhjZXB0aW9uKTsK KyAgZWxzZSBpZiAoIWlzUmVzdWx0Q29ycmVjdChfYXYsIF9idikpIHsKKyAgICBpZiAoIXF1aWV0 KSB7CisgICAgICAgIHRlc3RQYXNzZWQoX2EgKyAiIGlzIG5vdCAiICsgX2IpOworICAgIH0KKyAg fSBlbHNlCisgICAgdGVzdEZhaWxlZChfYSArICIgc2hvdWxkIG5vdCBiZSAiICsgX2J2ICsgIi4i KTsKK30KKwogZnVuY3Rpb24gc2hvdWxkQmVUcnVlKF9hKSB7IHNob3VsZEJlKF9hLCAidHJ1ZSIp OyB9CiBmdW5jdGlvbiBzaG91bGRCZUZhbHNlKF9hKSB7IHNob3VsZEJlKF9hLCAiZmFsc2UiKTsg fQogZnVuY3Rpb24gc2hvdWxkQmVOYU4oX2EpIHsgc2hvdWxkQmUoX2EsICJOYU4iKTsgfQpAQCAt MjkzLDEwICszMTYsMTAgQEAgZnVuY3Rpb24gaXNTdWNjZXNzZnVsbHlQYXJzZWQoKQogZnVuY3Rp b24gZGZnQ29tcGlsZWQoYXJndW1lbnQpCiB7CiAgICAgdmFyIG51bWJlck9mQ29tcGlsZXMgPSAi Y29tcGlsZXMiIGluIGFyZ3VtZW50ID8gYXJndW1lbnQuY29tcGlsZXMgOiAxOwotICAgIAorCiAg ICAgaWYgKCEoImYiIGluIGFyZ3VtZW50KSkKICAgICAgICAgdGhyb3cgbmV3IEVycm9yKCJkZmdD b21waWxlZCBjYWxsZWQgd2l0aCBpbnZhbGlkIGFyZ3VtZW50LiIpOwotICAgIAorCiAgICAgaWYg KGFyZ3VtZW50LmYgaW5zdGFuY2VvZiBBcnJheSkgewogICAgICAgICBmb3IgKHZhciBpID0gMDsg aSA8IGFyZ3VtZW50LmYubGVuZ3RoOyArK2kpIHsKICAgICAgICAgICAgIGlmICh0ZXN0UnVubmVy Lm51bWJlck9mREZHQ29tcGlsZXMoYXJndW1lbnQuZltpXSkgPCBudW1iZXJPZkNvbXBpbGVzKQpA QCAtMzA2LDcgKzMyOSw3IEBAIGZ1bmN0aW9uIGRmZ0NvbXBpbGVkKGFyZ3VtZW50KQogICAgICAg ICBpZiAodGVzdFJ1bm5lci5udW1iZXJPZkRGR0NvbXBpbGVzKGFyZ3VtZW50LmYpIDwgbnVtYmVy T2ZDb21waWxlcykKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9Ci0gICAgCisKICAg ICByZXR1cm4gdHJ1ZTsKIH0KIApAQCAtMzE0LDE2ICszMzcsMTYgQEAgZnVuY3Rpb24gZGZnSW5j cmVtZW50KGFyZ3VtZW50KQogewogICAgIGlmICghc2VsZi50ZXN0UnVubmVyKQogICAgICAgICBy ZXR1cm4gYXJndW1lbnQuaTsKLSAgICAKKwogICAgIGlmIChhcmd1bWVudC5pIDwgYXJndW1lbnQu bikKICAgICAgICAgcmV0dXJuIGFyZ3VtZW50Lmk7Ci0gICAgCisKICAgICBpZiAoZGlkRmFpbFNv bWVUZXN0cykKICAgICAgICAgcmV0dXJuIGFyZ3VtZW50Lmk7Ci0gICAgCisKICAgICBpZiAoIWRm Z0NvbXBpbGVkKGFyZ3VtZW50KSkKICAgICAgICAgcmV0dXJuICJzdGFydCIgaW4gYXJndW1lbnQg PyBhcmd1bWVudC5zdGFydCA6IDA7Ci0gICAgCisKICAgICByZXR1cm4gYXJndW1lbnQuaTsKIH0K IApAQCAtMzMxLDcgKzM1NCw3IEBAIGZ1bmN0aW9uIG5vSW5saW5lKHRoZUZ1bmN0aW9uKQogewog ICAgIGlmICghc2VsZi50ZXN0UnVubmVyKQogICAgICAgICByZXR1cm47Ci0gICAgCisKICAgICB0 ZXN0UnVubmVyLm5ldmVySW5saW5lRnVuY3Rpb24odGhlRnVuY3Rpb24pOwogfQogCg== 273589 2016-03-10 11:40:12 -0800 2016-03-10 16:42:06 -0800 Patch bug-155300-20160310123959.patch text/plain 1804 andy U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3OTM4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGNmNjdjNjYzNGM0YWM3ZDdmNTAz ZTVkYmQwMDdlYWM4NDFlMzg5Ni4uN2U2ZTZmZGM3MDUzZGI2YzhkZWY1OWVmZWU1NzUxZDRjMWUy NjhlYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAzLTEwICBBbmR5IFZhbldhZ29uZXIg IDxhbmR5QGluc3RydWN0dXJlLmNvbT4KKworICAgICAgICBBZGQgc2hvdWxkTm90QmUgdG8gc3Rh bmRhbG9uZSB0ZXN0IGhhcm5lc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1NTMwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIENvcHkgb3ZlciB0aGUgc2hvdWxkTm90QmUgZnVuY3Rpb24gZnJvbSBqcy10 ZXN0LXByZS4gVGhpcyBmaXhlcyBlcnJvcnMKKyAgICAgICAgaW50cm9kdWNlZCBiZSBuZXcgSW50 bCB0ZXN0cy4KKworICAgICAgICAqIHJlc291cmNlcy9zdGFuZGFsb25lLXByZS5qczoKKyAgICAg ICAgKHNob3VsZE5vdEJlKToKKwogMjAxNi0wMy0xMCAgRnJlZGVyaWMgV2FuZyAgPGZ3YW5nQGln YWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gQWRkIHN1cHBvcnQgZm9yIFdPRkYyCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9yZXNvdXJjZXMvc3RhbmRhbG9uZS1wcmUuanMgYi9MYXlvdXRUZXN0 cy9yZXNvdXJjZXMvc3RhbmRhbG9uZS1wcmUuanMKaW5kZXggNDY4YzZkNDAxNDg1Yjg1YWJjYmEy MGQzZWQ2YTE1NGU3NDM0YTJkZC4uMmI1ODU5YzgxNjNlODBiNWNjY2MyNTZlNDY4YTk5MjFjMzY4 M2NlYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcmVzb3VyY2VzL3N0YW5kYWxvbmUtcHJlLmpz CisrKyBiL0xheW91dFRlc3RzL3Jlc291cmNlcy9zdGFuZGFsb25lLXByZS5qcwpAQCAtMTkzLDYg KzE5MywyOSBAQCBmdW5jdGlvbiBzaG91bGRCZVR5cGUoX2EsIF90eXBlKSB7CiAgIH0KIH0KIAor ZnVuY3Rpb24gc2hvdWxkTm90QmUoX2EsIF9iLCBxdWlldCkKK3sKKyAgaWYgKHR5cGVvZiBfYSAh PSAic3RyaW5nIiB8fCB0eXBlb2YgX2IgIT0gInN0cmluZyIpCisgICAgZGVidWcoIldBUk46IHNo b3VsZE5vdEJlKCkgZXhwZWN0cyBzdHJpbmcgYXJndW1lbnRzIik7CisgIHZhciBleGNlcHRpb247 CisgIHZhciBfYXY7CisgIHRyeSB7CisgICAgIF9hdiA9IGV2YWwoX2EpOworICB9IGNhdGNoIChl KSB7CisgICAgIGV4Y2VwdGlvbiA9IGU7CisgIH0KKyAgdmFyIF9idiA9IGV2YWwoX2IpOworCisg IGlmIChleGNlcHRpb24pCisgICAgdGVzdEZhaWxlZChfYSArICIgc2hvdWxkIG5vdCBiZSAiICsg X2J2ICsgIi4gVGhyZXcgZXhjZXB0aW9uICIgKyBleGNlcHRpb24pOworICBlbHNlIGlmICghaXNS ZXN1bHRDb3JyZWN0KF9hdiwgX2J2KSkgeworICAgIGlmICghcXVpZXQpIHsKKyAgICAgICAgdGVz dFBhc3NlZChfYSArICIgaXMgbm90ICIgKyBfYik7CisgICAgfQorICB9IGVsc2UKKyAgICB0ZXN0 RmFpbGVkKF9hICsgIiBzaG91bGQgbm90IGJlICIgKyBfYnYgKyAiLiIpOworfQorCiBmdW5jdGlv biBzaG91bGRCZVRydWUoX2EpIHsgc2hvdWxkQmUoX2EsICJ0cnVlIik7IH0KIGZ1bmN0aW9uIHNo b3VsZEJlRmFsc2UoX2EpIHsgc2hvdWxkQmUoX2EsICJmYWxzZSIpOyB9CiBmdW5jdGlvbiBzaG91 bGRCZU5hTihfYSkgeyBzaG91bGRCZShfYSwgIk5hTiIpOyB9Cg==