155250 2016-03-09 12:22:27 -0800 WebsiteDataStore::Configuration::legacyWebsiteDataStoreConfiguration() should respect the passed-in configuration 2016-03-09 13:30:35 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 conrad_shultz conrad_shultz andersca conrad_shultz oldest_to_newest 1172673 0 conrad_shultz 2016-03-09 12:22:27 -0800 Currently, WebsiteDataStore::Configuration::legacyWebsiteDataStoreConfiguration() respects the passed-in configuration's localStorageDirectory and webSQLDatabaseDirectory, but not the others. This makes it impossible for clients to override these other directories. legacyWebsiteDataStoreConfiguration() should use the passed-in configuration for all applicable directories. 1172674 1 conrad_shultz 2016-03-09 12:23:03 -0800 rdar://problem/24889640 1172681 2 273460 conrad_shultz 2016-03-09 12:30:23 -0800 Created attachment 273460 Patch 1172714 3 conrad_shultz 2016-03-09 13:21:06 -0800 The mac-wk2 EWS failures relating to localstorage occur prior to this patch. 1172726 4 conrad_shultz 2016-03-09 13:30:35 -0800 Committed r197881: <http://trac.webkit.org/changeset/197881> 273460 2016-03-09 12:30:23 -0800 2016-03-09 13:22:07 -0800 Patch bug-155250-20160309123009.patch text/plain 2554 conrad_shultz U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3ODI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjBjZWFiZjI3ZDMwNjJj ZmViOWVmNTk5MDkzOGY0MTFhZjZkZTk1Mi4uNWFjNTk3ZjRlNDFlOTk4NTY3MDgwMzkxZWIxMmQw M2JjNWM0MWNiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTAzLTA5ICBDb25y YWQgU2h1bHR6ICA8Y29ucmFkX3NodWx0ekBhcHBsZS5jb20+CisKKyAgICAgICAgV2Vic2l0ZURh dGFTdG9yZTo6Q29uZmlndXJhdGlvbjo6bGVnYWN5V2Vic2l0ZURhdGFTdG9yZUNvbmZpZ3VyYXRp b24oKSBzaG91bGQgcmVzcGVjdCB0aGUgcGFzc2VkLWluIGNvbmZpZ3VyYXRpb24KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTI1MAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vdGUgdGhhdCB0aGUgbGVn YWN5IGRpcmVjdG9yaWVzIGFyZSBhbHJlYWR5IHNldCBieSBkZWZhdWx0IGluIFByb2Nlc3NQb29s Q29uZmlndXJhdGlvbjo6Y3JlYXRlV2l0aExlZ2FjeU9wdGlvbnMoKSwKKyAgICAgICAgd2hpY2gg aXMgYWxzbyB3aGVyZSB0aGUgc2hvdWxkSGF2ZUxlZ2FjeURhdGFTdG9yZSBmbGFnLCB3aGljaCB3 aWxsIGNhdXNlIHRoaXMgY29kZSBwYXRoIHRvIGJlIHJlYWNoZWQsIGlzIHNldC4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OmxlZ2Fj eVdlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0aW9uKToKKyAgICAgICAgVXNlIHRoZSBwYXNzZWQt aW4gY29uZmlndXJhdGlvbiB0byBzZXQgdGhlIGFwcGxpY2F0aW9uIGNhY2hlLCBuZXR3b3JrIGNh Y2hlLCBhbmQgbWVkaWEga2V5cyBzdG9yYWdlIGRpcmVjdG9yaWVzLgorCiAyMDE2LTAzLTA4ICBT YW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUm9sbCByMTk3NjMyIGJhY2sg aW4gbm93IHRoYXQgdGhlIGJvdHMgaGF2ZSBjYXVnaHQgdXAuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL1dlYlByb2Nlc3NQb29sLmNwcAppbmRleCA5NTZlNzZjOWE2ZWM4MDI3ZGNiNTBkYzI5 ZTJlNDBkNDA5YTFjMzgzLi5mMTNmMWRiNTI0MWQ4Y2VlNGM5NDU4NDM5NzQyMDI1OWFiMjBkZTQ3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAKQEAgLTEy Nyw5ICsxMjcsOSBAQCBzdGF0aWMgV2Vic2l0ZURhdGFTdG9yZTo6Q29uZmlndXJhdGlvbiBsZWdh Y3lXZWJzaXRlRGF0YVN0b3JlQ29uZmlndXJhdGlvbihBUEk6OgogCiAgICAgY29uZmlndXJhdGlv bi5sb2NhbFN0b3JhZ2VEaXJlY3RvcnkgPSBwcm9jZXNzUG9vbENvbmZpZ3VyYXRpb24ubG9jYWxT dG9yYWdlRGlyZWN0b3J5KCk7CiAgICAgY29uZmlndXJhdGlvbi53ZWJTUUxEYXRhYmFzZURpcmVj dG9yeSA9IHByb2Nlc3NQb29sQ29uZmlndXJhdGlvbi53ZWJTUUxEYXRhYmFzZURpcmVjdG9yeSgp OwotICAgIGNvbmZpZ3VyYXRpb24uYXBwbGljYXRpb25DYWNoZURpcmVjdG9yeSA9IFdlYlByb2Nl c3NQb29sOjpsZWdhY3lQbGF0Zm9ybURlZmF1bHRBcHBsaWNhdGlvbkNhY2hlRGlyZWN0b3J5KCk7 Ci0gICAgY29uZmlndXJhdGlvbi5tZWRpYUtleXNTdG9yYWdlRGlyZWN0b3J5ID0gV2ViUHJvY2Vz c1Bvb2w6OmxlZ2FjeVBsYXRmb3JtRGVmYXVsdE1lZGlhS2V5c1N0b3JhZ2VEaXJlY3RvcnkoKTsK LSAgICBjb25maWd1cmF0aW9uLm5ldHdvcmtDYWNoZURpcmVjdG9yeSA9IFdlYlByb2Nlc3NQb29s OjpsZWdhY3lQbGF0Zm9ybURlZmF1bHROZXR3b3JrQ2FjaGVEaXJlY3RvcnkoKTsKKyAgICBjb25m aWd1cmF0aW9uLmFwcGxpY2F0aW9uQ2FjaGVEaXJlY3RvcnkgPSBwcm9jZXNzUG9vbENvbmZpZ3Vy YXRpb24uYXBwbGljYXRpb25DYWNoZURpcmVjdG9yeSgpOworICAgIGNvbmZpZ3VyYXRpb24ubWVk aWFLZXlzU3RvcmFnZURpcmVjdG9yeSA9IHByb2Nlc3NQb29sQ29uZmlndXJhdGlvbi5tZWRpYUtl eXNTdG9yYWdlRGlyZWN0b3J5KCk7CisgICAgY29uZmlndXJhdGlvbi5uZXR3b3JrQ2FjaGVEaXJl Y3RvcnkgPSBwcm9jZXNzUG9vbENvbmZpZ3VyYXRpb24uZGlza0NhY2hlRGlyZWN0b3J5KCk7CiAK ICAgICAvLyBUaGlzIGlzIG5lZWRlZCB0byBzdXBwb3J0IGxlZ2FjeSBXSzIgY2xpZW50cywgd2hp Y2ggZGlkIG5vdCBoYXZlIHJlc291cmNlIGxvYWQgc3RhdGlzdGljcy4KICAgICBjb25maWd1cmF0 aW9uLnJlc291cmNlTG9hZFN0YXRpc3RpY3NEaXJlY3RvcnkgPSBBUEk6OldlYnNpdGVEYXRhU3Rv cmU6OmRlZmF1bHRSZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGlyZWN0b3J5KCk7Cg==