155239 2016-03-09 10:17:54 -0800 Add a getter for WebVideoFullscreenInterfaceObjC and update its rate property 2016-03-09 15:36:50 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 adachan adachan oldest_to_newest 1172603 0 adachan 2016-03-09 10:17:54 -0800 Add a getter for WebVideoFullscreenInterfaceObjC and update its rate property. Also move the stub for WebVideoFullscreenInterfaceMac::setVideoDimensions() to the mm file. 1172605 1 adachan 2016-03-09 10:20:11 -0800 Needed for <rdar://problem/24396552>, <rdar://problem/24396678>, and <rdar://problem/24801763>. 1172635 2 273446 adachan 2016-03-09 11:28:11 -0800 Created attachment 273446 Patch 1172744 3 273446 eric.carlson 2016-03-09 14:01:51 -0800 Comment on attachment 273446 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273446&action=review > Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h:69 > + WEBCORE_EXPORT void setVideoDimensions(bool hasVideo, float width, float height) override; Nit: if this class isn't sub-classed, "override" should be "final" 1172767 4 adachan 2016-03-09 14:25:36 -0800 (In reply to comment #3) > Comment on attachment 273446 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=273446&action=review > > > Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h:69 > > + WEBCORE_EXPORT void setVideoDimensions(bool hasVideo, float width, float height) override; > > Nit: if this class isn't sub-classed, "override" should be "final" Fixed. Thanks for the review! 1172819 5 adachan 2016-03-09 15:36:50 -0800 Committed: http://trac.webkit.org/changeset/197893 273446 2016-03-09 11:28:11 -0800 2016-03-09 14:01:51 -0800 Patch bug-155239-20160309112758.patch text/plain 3715 adachan U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3ODMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGU0YWZmZWE1NmIwNjJk YTQ3YTJjM2VmMzkxZjZhZWYzYzk1OWIzNC4uMjQ2MDZjMzE0YmFhNjFkODQxZWRlYjgxYjYyNmRh ZmY0ZTUxMzc5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTAzLTA5ICBBZGEg Q2hhbiAgPGFkYWNoYW5AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBhIGdldHRlciBmb3IgV2Vi VmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlT2JqQyBhbmQgdXBkYXRlIGl0cyByYXRlIHByb3BlcnR5 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTUyMzkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRm b3JtL21hYy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VNYWMuaDoKKyAgICAgICAgTW92ZSB0 aGUgc3R1YiBpbXBsZW1lbnRhdGlvbiBvZiBzZXRWaWRlb0RpbWVuc2lvbnMoKSB0byB0aGUgbW0g ZmlsZS4KKyAgICAgICAgRGVjbGFyZSBhIGdldHRlciB0byBXZWJWaWRlb0Z1bGxzY3JlZW5JbnRl cmZhY2VNYWNPYmpDLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9XZWJWaWRlb0Z1bGxzY3JlZW5J bnRlcmZhY2VNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpXZWJWaWRlb0Z1bGxzY3JlZW5JbnRl cmZhY2VNYWM6OnNldFJhdGUpOgorICAgICAgICBBbHNvIHVwZGF0ZSB0aGUgcmF0ZSBwcm9wZXJ0 eSBvZiBXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VNYWNPYmpDLgorICAgICAgICAoV2ViQ29y ZTo6V2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlTWFjOjpzZXRWaWRlb0RpbWVuc2lvbnMpOgor ICAgICAgICBTdHViIGltcGxlbWVudGF0aW9uIG9mIHNldFZpZGVvRGltZW5zaW9ucygpIGhhcyBi ZWVuIG1vdmVkIHRvIGhlcmUuCisKIDIwMTYtMDMtMDggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29y YXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBNZW1vcnkgVGltZWxpbmUg c2hvdWxkIHNob3cgTWVtb3J5UHJlc3N1cmUgZXZlbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tYWMvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlTWFjLmggYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlTWFjLmgK aW5kZXggZGFkYTU5ZTA2YzNlOTBlYjY5MWZhMTY0ZDhjNWQxZmVkYTQ1OGNjYi4uODgzZjk3YzBj YmQ5MTQ0MGNmYmM1ZDM3MDdkMzFiM2Q1NTg0Y2U2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWFjL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZU1hYy5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VNYWMu aApAQCAtNjYsNyArNjYsNyBAQCBwdWJsaWM6CiAgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBzZXRD dXJyZW50VGltZShkb3VibGUgLypjdXJyZW50VGltZSovLCBkb3VibGUgLyphbmNob3JUaW1lKi8p IG92ZXJyaWRlOwogICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgc2V0QnVmZmVyZWRUaW1lKGRvdWJs ZSkgb3ZlcnJpZGUgeyB9CiAgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBzZXRSYXRlKGJvb2wgLypp c1BsYXlpbmcqLywgZmxvYXQgLypwbGF5YmFja1JhdGUqLykgb3ZlcnJpZGU7Ci0gICAgV0VCQ09S RV9FWFBPUlQgdm9pZCBzZXRWaWRlb0RpbWVuc2lvbnMoYm9vbCAvKmhhc1ZpZGVvKi8sIGZsb2F0 IC8qd2lkdGgqLywgZmxvYXQgLypoZWlnaHQqLykgb3ZlcnJpZGUgeyB9CisgICAgV0VCQ09SRV9F WFBPUlQgdm9pZCBzZXRWaWRlb0RpbWVuc2lvbnMoYm9vbCBoYXNWaWRlbywgZmxvYXQgd2lkdGgs IGZsb2F0IGhlaWdodCkgb3ZlcnJpZGU7CiAgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBzZXRTZWVr YWJsZVJhbmdlcyhjb25zdCBUaW1lUmFuZ2VzJikgb3ZlcnJpZGU7CiAgICAgV0VCQ09SRV9FWFBP UlQgdm9pZCBzZXRDYW5QbGF5RmFzdFJldmVyc2UoYm9vbCkgb3ZlcnJpZGUgeyB9CiAgICAgV0VC Q09SRV9FWFBPUlQgdm9pZCBzZXRBdWRpb01lZGlhU2VsZWN0aW9uT3B0aW9ucyhjb25zdCBWZWN0 b3I8V1RGOjpTdHJpbmc+JiAvKm9wdGlvbnMqLywgdWludDY0X3QgLypzZWxlY3RlZEluZGV4Ki8p IG92ZXJyaWRlIHsgfQpAQCAtOTQsNiArOTQsOSBAQCBwdWJsaWM6CiAgICAgdm9pZCBhcHBsaWNh dGlvbkRpZEJlY29tZUFjdGl2ZSgpIHsgfQogCiAgICAgV0VCQ09SRV9FWFBPUlQgV2ViUGxheWJh Y2tDb250cm9sc01hbmFnZXIgKnBsYXlCYWNrQ29udHJvbHNNYW5hZ2VyKCk7CisjaWYgVVNFKEFQ UExFX0lOVEVSTkFMX1NESykKKyAgICBXRUJDT1JFX0VYUE9SVCBXZWJWaWRlb0Z1bGxzY3JlZW5J bnRlcmZhY2VNYWNPYmpDICp2aWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VPYmpDKCk7CisjZW5kaWYK IAogcHJpdmF0ZToKICAgICBXZWJWaWRlb0Z1bGxzY3JlZW5Nb2RlbCogbV92aWRlb0Z1bGxzY3Jl ZW5Nb2RlbCB7IG51bGxwdHIgfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L21hYy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9tYWMvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlTWFjLm1tCmluZGV4IDc1NmY0 ZTZjZmQ1NGM2MjI4NmVhZDg5Njk3MDk5MTkyMjU1NTA2ZGYuLjNjYzMzNjM5YzcwNGI0MDUxNmM3 NjMxOGI2NjRlYmRlNjI0Y2JiYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L21hYy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VNYWMubW0KKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWFjL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZU1hYy5tbQpAQCAtMjE1 LDYgKzIxNSwxMCBAQCB2b2lkIFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZU1hYzo6c2V0UmF0 ZShib29sIGlzUGxheWluZywgZmxvYXQgcGxheWJhY2tSYXRlKQogICAgIFdlYlBsYXliYWNrQ29u dHJvbHNNYW5hZ2VyKiBjb250cm9sc01hbmFnZXIgPSBwbGF5QmFja0NvbnRyb2xzTWFuYWdlcigp OwogCiAgICAgW2NvbnRyb2xzTWFuYWdlciBzZXRSYXRlOmlzUGxheWluZyA/IHBsYXliYWNrUmF0 ZSA6IDAuXTsKKworI2lmIFVTRShBUFBMRV9JTlRFUk5BTF9TREspCisgICAgW3ZpZGVvRnVsbHNj cmVlbkludGVyZmFjZU9iakMoKSBzZXRSYXRlOmlzUGxheWluZyA/IHBsYXliYWNrUmF0ZSA6IDAu XTsKKyNlbmRpZgogfQogCiB2b2lkIFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZU1hYzo6c2V0 U2Vla2FibGVSYW5nZXMoY29uc3QgVGltZVJhbmdlcyYgdGltZVJhbmdlcykKQEAgLTI4MSw2ICsy ODUsMTAgQEAgdm9pZCBXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VNYWM6OnNldEV4dGVybmFs UGxheWJhY2soYm9vbCwgRXh0ZXJuYWxQbGF5YmFja1QKIHsKIH0KIAordm9pZCBXZWJWaWRlb0Z1 bGxzY3JlZW5JbnRlcmZhY2VNYWM6OnNldFZpZGVvRGltZW5zaW9ucyhib29sLCBmbG9hdCwgZmxv YXQpCit7Cit9CisKIGJvb2wgc3VwcG9ydHNQaWN0dXJlSW5QaWN0dXJlKCkKIHsKICAgICByZXR1 cm4gZmFsc2U7Cg==