155215 2016-03-08 20:41:38 -0800 Element with maximum tabIndex cannot be returned by nextElementWithGreaterTabIndex() 2016-03-09 09:57:35 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=155159 https://bugs.webkit.org/show_bug.cgi?id=155233 P2 Normal --- 1 cdumez cdumez ap commit-queue darin rniwa ryanhaddad oldest_to_newest 1172378 0 cdumez 2016-03-08 20:41:38 -0800 Element with maximum tabIndex cannot be returned by nextElementWithGreaterTabIndex() due to a bug in <http://trac.webkit.org/changeset/197726>. 1172380 1 273384 cdumez 2016-03-08 20:49:47 -0800 Created attachment 273384 Patch 1172414 2 273384 commit-queue 2016-03-08 22:27:43 -0800 Comment on attachment 273384 Patch Clearing flags on attachment: 273384 Committed r197835: <http://trac.webkit.org/changeset/197835> 1172415 3 commit-queue 2016-03-08 22:27:47 -0800 All reviewed patches have been landed. Closing bug. 1172425 4 ap 2016-03-08 23:09:22 -0800 The new test always times out on iOS. Can it be rewritten to work in a cross-platform way? 1172563 5 cdumez 2016-03-09 09:17:09 -0800 (In reply to comment #4) > The new test always times out on iOS. Can it be rewritten to work in a > cross-platform way? In EventSenderProxyIOS.mm: void EventSenderProxy::keyDown(WKStringRef key, WKEventModifiers modifiers, unsigned keyLocation) { // Write me. } iOS does not support EventSender.keydown() :/ 1172588 6 darin 2016-03-09 09:57:35 -0800 But you don’t move focus to the next element by pressing a "tab key" on iOS either. I’m not sure that WebKit on iOS has code that understands the tab character. We might have to write something different to test tabIndex on that platform. Not sure there is a platform independent way of walking through the tab loop. 273384 2016-03-08 20:49:47 -0800 2016-03-08 22:27:43 -0800 Patch bug-155215-20160308204936.patch text/plain 4769 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3ODMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGU0YWZmZWE1NmIwNjJk YTQ3YTJjM2VmMzkxZjZhZWYzYzk1OWIzNC4uYjMyOGY1YjM1YjQ4NTY0Y2NmZGM2YzU3ZGQxYjlh YTJlOWU0ZTlkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTAzLTA4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRWxlbWVudCB3aXRoIG1heGlt dW0gdGFiSW5kZXggY2Fubm90IGJlIHJldHVybmVkIGJ5IG5leHRFbGVtZW50V2l0aEdyZWF0ZXJU YWJJbmRleCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTUyMTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBFbGVtZW50IHdpdGggbWF4aW11bSB0YWJJbmRleCBjYW5ub3QgYmUgcmV0dXJuZWQgYnkgbmV4 dEVsZW1lbnRXaXRoR3JlYXRlclRhYkluZGV4KCkKKyAgICAgICAgZHVlIHRvIGEgYnVnIGluIHIx OTc3MjYuIFRoaXMgcGF0Y2ggZml4ZXMgdGhlIGlzc3VlIGJ5IG9ubHkgY29tcGFyaW5nCisgICAg ICAgIGNhbmRpZGF0ZS50YWJJbmRleCB0byB3aW5uaW5nVGFiSW5kZXggaWYgd2lubmVyIGlzIG5v bi1udWxsLgorCisgICAgICAgIFRlc3Q6IGZhc3QvZXZlbnRzL21heC10YWJpbmRleC1mb2N1cy5o dG1sCisKKyAgICAgICAgKiBwYWdlL0ZvY3VzQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpuZXh0RWxlbWVudFdpdGhHcmVhdGVyVGFiSW5kZXgpOgorCiAyMDE2LTAzLTA4ICBKb3Nl cGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogTWVtb3J5IFRpbWVsaW5lIHNob3VsZCBzaG93IE1lbW9yeVByZXNzdXJlIGV2ZW50cwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9Gb2N1c0NvbnRyb2xsZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvcGFnZS9Gb2N1c0NvbnRyb2xsZXIuY3BwCmluZGV4IDkyYzU2YTIyZDAzMjg2MjIx ZDEwODg2NTFkYWFlOGRkZDQ0ZWRkNDkuLmJjMTA0M2IyMjIyODNhYTI1ZWM4MTllNjg2ODhkNDIw MzdkMGFhNTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRm9jdXNDb250cm9sbGVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZvY3VzQ29udHJvbGxlci5jcHAKQEAgLTQ5 NSwxMCArNDk1LDEzIEBAIHN0YXRpYyBFbGVtZW50KiBuZXh0RWxlbWVudFdpdGhHcmVhdGVyVGFi SW5kZXgoY29uc3QgRm9jdXNOYXZpZ2F0aW9uU2NvcGUmIHNjb3BlCiAgICAgZm9yIChOb2RlKiBu b2RlID0gJnNjb3BlLnJvb3ROb2RlKCk7IG5vZGU7IG5vZGUgPSBzY29wZS5uZXh0SW5TY29wZShu b2RlKSkgewogICAgICAgICBpZiAoIWlzPEVsZW1lbnQ+KCpub2RlKSkKICAgICAgICAgICAgIGNv bnRpbnVlOwotICAgICAgICBFbGVtZW50JiBlbGVtZW50ID0gZG93bmNhc3Q8RWxlbWVudD4oKm5v ZGUpOwotICAgICAgICBpZiAoaXNGb2N1c2FibGVPckhhc1NoYWRvd1RyZWVXaXRob3V0Q3VzdG9t Rm9jdXNMb2dpYyhlbGVtZW50LCBldmVudCkgJiYgZWxlbWVudC50YWJJbmRleCgpID4gdGFiSW5k ZXggJiYgZWxlbWVudC50YWJJbmRleCgpIDwgd2lubmluZ1RhYkluZGV4KSB7Ci0gICAgICAgICAg ICB3aW5uZXIgPSAmZWxlbWVudDsKLSAgICAgICAgICAgIHdpbm5pbmdUYWJJbmRleCA9IGVsZW1l bnQudGFiSW5kZXgoKTsKKyAgICAgICAgRWxlbWVudCYgY2FuZGlkYXRlID0gZG93bmNhc3Q8RWxl bWVudD4oKm5vZGUpOworICAgICAgICBpbnQgY2FuZGlkYXRlVGFiSW5kZXggPSBjYW5kaWRhdGUu dGFiSW5kZXgoKTsKKyAgICAgICAgaWYgKGlzRm9jdXNhYmxlT3JIYXNTaGFkb3dUcmVlV2l0aG91 dEN1c3RvbUZvY3VzTG9naWMoY2FuZGlkYXRlLCBldmVudCkgJiYgY2FuZGlkYXRlVGFiSW5kZXgg PiB0YWJJbmRleCkgeworICAgICAgICAgICAgaWYgKCF3aW5uZXIgfHwgY2FuZGlkYXRlVGFiSW5k ZXggPCB3aW5uaW5nVGFiSW5kZXgpIHsKKyAgICAgICAgICAgICAgICB3aW5uZXIgPSAmY2FuZGlk YXRlOworICAgICAgICAgICAgICAgIHdpbm5pbmdUYWJJbmRleCA9IGNhbmRpZGF0ZVRhYkluZGV4 OworICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQogCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjk3Yzk4YWNiOTg5 YmVjZTNlNmFhZDFkOWZmMmUzODYxNmMwOTczZC4uNGY4ODhlZjBiNjk3ZjY1NGE3NzI2MGQ0MzY1 MjVmZTY1NjY3YjI2NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAzLTA4ICBDaHJpcyBE dW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRWxlbWVudCB3aXRoIG1heGltdW0g dGFiSW5kZXggY2Fubm90IGJlIHJldHVybmVkIGJ5IG5leHRFbGVtZW50V2l0aEdyZWF0ZXJUYWJJ bmRleCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTUyMTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGQgdGVzdCB0byBtYWtlIHN1cmUgdGhhdCBhbiBFbGVtZW50IHdpdGggYSB0YWJJbmRleCBlcXVh bCB0bworICAgICAgICAyMTQ3NDgzNjQ3IChtYXhpbXVtIHRhYkluZGV4KSBjYW4gYmUgZm9jdXNl ZC4KKworICAgICAgICAqIGZhc3QvZXZlbnRzL21heC10YWJpbmRleC1mb2N1cy1leHBlY3RlZC50 eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZXZlbnRzL21heC10YWJpbmRleC1mb2N1cy5odG1s OiBBZGRlZC4KKwogMjAxNi0wMy0wOCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFkZCBIZWFwIGRvbWFpbiBzdGFydC9zdG9w IHRyYWNraW5nIGNvbW1hbmRzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9t YXgtdGFiaW5kZXgtZm9jdXMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMv bWF4LXRhYmluZGV4LWZvY3VzLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zYWRmMDM3Y2U5ZmQ0 MmYzMTlmN2JjMTA2NGFlNTNlZWNlZWE4YTRkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9ldmVudHMvbWF4LXRhYmluZGV4LWZvY3VzLWV4cGVjdGVkLnR4dApAQCAtMCwwICsx LDEwIEBACitUZXN0cyB0aGF0IGFuIGVsZW1lbnQgd2l0aCB0aGUgbWF4aW11bSB0YWJJbmRleCB2 YWx1ZSBjYW4gYmUgZm9jdXNlZC4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVz IG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BB U1MgRWxlbWVudCB3aXRoIHRoZSBtYXhpbXVtIHRhYkluZGV4IHdhcyBmb2N1c2VkLgorUEFTUyBz dWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisgCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9tYXgtdGFiaW5kZXgtZm9jdXMuaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3QvZXZlbnRzL21heC10YWJpbmRleC1mb2N1cy5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjBh M2JhMWRhZGYyOTc5NzgwZjJjODg5NWZmMzExYWUyMzQ0NTUyNjEKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9tYXgtdGFiaW5kZXgtZm9jdXMuaHRtbApAQCAtMCww ICsxLDI5IEBACis8IURPQ1RZUEUgaHRtbD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMv anMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCJUZXN0cyB0 aGF0IGFuIGVsZW1lbnQgd2l0aCB0aGUgbWF4aW11bSB0YWJJbmRleCB2YWx1ZSBjYW4gYmUgZm9j dXNlZC4iKTsKK2pzVGVzdElzQXN5bmMgPSB0cnVlOworCitmdW5jdGlvbiBzdWNjZXNzKCkKK3sK KyAgICB0ZXN0UGFzc2VkKCJFbGVtZW50IHdpdGggdGhlIG1heGltdW0gdGFiSW5kZXggd2FzIGZv Y3VzZWQuIik7CisgICAgZmluaXNoSlNUZXN0KCk7Cit9CisKK2Z1bmN0aW9uIHJ1blRlc3QoKQor eworICAgIGlmICghd2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgIHJldHVybjsKKyAKKyAgICB2 YXIgZWxlbWVudCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdmb2N1c01lJykKKyAgICBlbGVt ZW50LmZvY3VzKCk7CisKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZWxlbWVudFdpdGhN YXhUYWJJbmRleCIpLm9uZm9jdXMgPSBzdWNjZXNzOworICAgIGV2ZW50U2VuZGVyLmtleURvd24o Ilx0Iik7IAorfQorPC9zY3JpcHQ+Cis8Ym9keSBvbmxvYWQ9InJ1blRlc3QoKSI+Cis8aW5wdXQg aWQ9ImZvY3VzTWUiIHRhYmluZGV4PSIxIj4KKzxpbnB1dCBpZD0iZWxlbWVudFdpdGhNYXhUYWJJ bmRleCIgdGFiaW5kZXg9IjIxNDc0ODM2NDciPgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNl cy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5Pgo=