155212 2016-03-08 20:05:40 -0800 Web Inspector: Timelines keeps switching to overview instead of keeping the selected timeline 2016-03-08 21:02:08 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1172356 0 joepeck 2016-03-08 20:05:40 -0800 * SUMMARY Timelines keeps switching to overview instead of keeping the selected timeline * STEPS TO REPRODUCE 1. Inspect this page 2. Show Timelines tab 3. Select Network Timeline 4. Reload => Should keep the Network Timeline selected 5. Reload again => Should keep the Network Timeline selected Timelines keeps unexpectedly switching back to the overview. 1172357 1 webkit-bug-importer 2016-03-08 20:06:00 -0800 <rdar://problem/25052504> 1172360 2 273377 joepeck 2016-03-08 20:08:52 -0800 Created attachment 273377 [PATCH] Proposed Fix 1172384 3 273377 commit-queue 2016-03-08 21:02:05 -0800 Comment on attachment 273377 [PATCH] Proposed Fix Clearing flags on attachment: 273377 Committed r197832: <http://trac.webkit.org/changeset/197832> 1172385 4 commit-queue 2016-03-08 21:02:08 -0800 All reviewed patches have been landed. Closing bug. 273377 2016-03-08 20:08:52 -0800 2016-03-08 21:02:05 -0800 [PATCH] Proposed Fix fix-restoration.patch text/plain 3773 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDY0NDQyZGIuLjdmMjEyODcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE2LTAzLTA4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxp bmVzIGtlZXBzIHN3aXRjaGluZyB0byBvdmVydmlldyBpbnN0ZWFkIG9mIGtlZXBpbmcgdGhlIHNl bGVjdGVkIHRpbWVsaW5lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTUyMTIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI1MDUyNTA0PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFj ZS9WaWV3cy9UaW1lbGluZVNpZGViYXJQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5U aW1lbGluZVNpZGViYXJQYW5lbC5wcm90b3R5cGUuc2F2ZVN0YXRlVG9Db29raWUpOgorICAgICAg ICBUaGUgc2lkZWJhciB3YXMgdXNpbmcgb3V0IG9mIGRhdGUgaW5mb3JtYXRpb24gaW4gaXRzIHRy ZWUgb3V0bGluZSBjYXVzaW5nIGl0IHRvCisgICAgICAgIHN3aXRjaCB0byB0aGUgd3Jvbmcgc2lk ZWJhci4gVXNlIHRoZSB1cCB0byBkYXRlIGluZm9ybWF0aW9uIGZyb20gdGhlIHJlY29yZGluZyB2 aWV3LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVRhYkNvbnRlbnRW aWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lVGFiQ29udGVudFZpZXcucHJv dG90eXBlLl9yZWNvcmRpbmdTZWxlY3RlZCk6CisgICAgICAgIEZpeCB0eXBvIG5vdCBnZXR0aW5n IHRoZSByaWdodCB0aW1lbGluZSB0eXBlLgorCisyMDE2LTAzLTA4ICBKb3NlcGggUGVjb3Jhcm8g IDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogTWVtb3J5IFRp bWVsaW5lIHNob3VsZCBzaG93IE1lbW9yeVByZXNzdXJlIGV2ZW50cwogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1MTU4CiAgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8yNTAyNjYxMD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuanMKaW5kZXgg MGRhMGM0My4uMzc3OTRlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuanMKQEAg LTQ3NCw5ICs0NzQsOSBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVTaWRlYmFyUGFuZWwgPSBjbGFz cyBUaW1lbGluZVNpZGViYXJQYW5lbCBleHRlbmRzIFdlYkluc3BlYwogICAgICAgICBpZiAodGhp cy5fdmlld01vZGUgPT09IFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3LlZpZXdNb2RlLlJl bmRlcmluZ0ZyYW1lcykKICAgICAgICAgICAgIGNvb2tpZVtXZWJJbnNwZWN0b3IuVGltZWxpbmVT aWRlYmFyUGFuZWwuU2VsZWN0ZWRUaW1lbGluZVZpZXdJZGVudGlmaWVyQ29va2llS2V5XSA9IFdl Ykluc3BlY3Rvci5UaW1lbGluZVJlY29yZC5UeXBlLlJlbmRlcmluZ0ZyYW1lOwogICAgICAgICBl bHNlIHsKLSAgICAgICAgICAgIHZhciBzZWxlY3RlZFRyZWVFbGVtZW50ID0gdGhpcy5fdGltZWxp bmVzVHJlZU91dGxpbmUuc2VsZWN0ZWRUcmVlRWxlbWVudDsKLSAgICAgICAgICAgIGlmIChzZWxl Y3RlZFRyZWVFbGVtZW50KQotICAgICAgICAgICAgICAgIGNvb2tpZVtXZWJJbnNwZWN0b3IuVGlt ZWxpbmVTaWRlYmFyUGFuZWwuU2VsZWN0ZWRUaW1lbGluZVZpZXdJZGVudGlmaWVyQ29va2llS2V5 XSA9IHNlbGVjdGVkVHJlZUVsZW1lbnQucmVwcmVzZW50ZWRPYmplY3QudHlwZTsKKyAgICAgICAg ICAgIHZhciBjdXJyZW50VGltZWxpbmVWaWV3ID0gdGhpcy5fZGlzcGxheWVkQ29udGVudFZpZXcg PyB0aGlzLl9kaXNwbGF5ZWRDb250ZW50Vmlldy5jdXJyZW50VGltZWxpbmVWaWV3IDogbnVsbDsK KyAgICAgICAgICAgIGlmIChjdXJyZW50VGltZWxpbmVWaWV3ICYmIGN1cnJlbnRUaW1lbGluZVZp ZXcucmVwcmVzZW50ZWRPYmplY3QgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuVGltZWxpbmUpCisg ICAgICAgICAgICAgICAgY29va2llW1dlYkluc3BlY3Rvci5UaW1lbGluZVNpZGViYXJQYW5lbC5T ZWxlY3RlZFRpbWVsaW5lVmlld0lkZW50aWZpZXJDb29raWVLZXldID0gY3VycmVudFRpbWVsaW5l Vmlldy5yZXByZXNlbnRlZE9iamVjdC50eXBlOwogICAgICAgICAgICAgZWxzZQogICAgICAgICAg ICAgICAgIGNvb2tpZVtXZWJJbnNwZWN0b3IuVGltZWxpbmVTaWRlYmFyUGFuZWwuU2VsZWN0ZWRU aW1lbGluZVZpZXdJZGVudGlmaWVyQ29va2llS2V5XSA9IFdlYkluc3BlY3Rvci5UaW1lbGluZVNp ZGViYXJQYW5lbC5PdmVydmlld1RpbWVsaW5lSWRlbnRpZmllckNvb2tpZVZhbHVlOyAgICAKICAg ICAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvVGltZWxpbmVUYWJDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lVGFiQ29udGVudFZpZXcuanMKaW5kZXggOGQzNDEw OS4uNzc0NjFhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvVGltZWxpbmVUYWJDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVRhYkNvbnRlbnRWaWV3LmpzCkBAIC00 NTAsNyArNDUwLDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lVGFiQ29udGVudFZpZXcgPSBjbGFz cyBUaW1lbGluZVRhYkNvbnRlbnRWaWV3IGV4dGVuZHMgV2ViSW4KIAogICAgICAgICAgICAgLy8g U2hvdyB0aGUgdGltZWxpbmUgdGhhdCB3YXMgYmVpbmcgc2hvd24gdG8gdXBkYXRlIHRoZSBzaWRl YmFyIHRyZWUgc3RhdGUuCiAgICAgICAgICAgICBsZXQgY3VycmVudFRpbWVsaW5lVmlldyA9IHRo aXMuX2Rpc3BsYXllZENvbnRlbnRWaWV3LmN1cnJlbnRUaW1lbGluZVZpZXc7Ci0gICAgICAgICAg ICBsZXQgdGltZWxpbmVUeXBlID0gY3VycmVudFRpbWVsaW5lVmlldyAmJiBjdXJyZW50VGltZWxp bmVWaWV3LnJlcHJlc2VudGVkT2JqZWN0IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLlRpbWVsaW5l ID8gY3VycmVudFRpbWVsaW5lVmlldy50eXBlIDogbnVsbDsKKyAgICAgICAgICAgIGxldCB0aW1l bGluZVR5cGUgPSBjdXJyZW50VGltZWxpbmVWaWV3ICYmIGN1cnJlbnRUaW1lbGluZVZpZXcucmVw cmVzZW50ZWRPYmplY3QgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuVGltZWxpbmUgPyBjdXJyZW50 VGltZWxpbmVWaWV3LnJlcHJlc2VudGVkT2JqZWN0LnR5cGUgOiBudWxsOwogICAgICAgICAgICAg dGhpcy5fc2hvd1RpbWVsaW5lVmlld0ZvclR5cGUodGltZWxpbmVUeXBlKTsKIAogICAgICAgICAg ICAgcmV0dXJuOwo=