155209 2016-03-08 16:59:21 -0800 CRASH at WebCore::RenderView::updateVisibleViewportRect 2016-03-10 20:26:12 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble ap simon.fraser webkit-bug-importer oldest_to_newest 1172311 0 jer.noble 2016-03-08 16:59:21 -0800 CRASH at WebCore::RenderView::updateVisibleViewportRect 1172312 1 jer.noble 2016-03-08 16:59:44 -0800 <rdar://problem/23997530> 1172372 2 273382 jer.noble 2016-03-08 20:31:28 -0800 Created attachment 273382 Patch 1172391 3 273382 simon.fraser 2016-03-08 21:21:58 -0800 Comment on attachment 273382 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273382&action=review > Source/WebCore/html/HTMLMediaElement.cpp:796 > + if (renderer() && renderer()->isRegisteredForVisibleInViewportCallback()) > renderer()->unregisterForVisibleInViewportCallback(); Would it be bad to just unconditionally call unregisterForVisibleInViewportCallback()? > LayoutTests/media/video-crash-invisible-autoplay-display-none.html:11 > + run('internals.setMediaElementRestrictions(video, "InvisibleAutoplayNotPermitted")'); This run() thing is weird. Does it just log and eval? 1172407 4 jer.noble 2016-03-08 22:08:56 -0800 (In reply to comment #3) > Comment on attachment 273382 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=273382&action=review > > > Source/WebCore/html/HTMLMediaElement.cpp:796 > > + if (renderer() && renderer()->isRegisteredForVisibleInViewportCallback()) > > renderer()->unregisterForVisibleInViewportCallback(); > > Would it be bad to just unconditionally call > unregisterForVisibleInViewportCallback()? Not really, as unregister...() checks whether it's actually registered itself as well. > > LayoutTests/media/video-crash-invisible-autoplay-display-none.html:11 > > + run('internals.setMediaElementRestrictions(video, "InvisibleAutoplayNotPermitted")'); > > This run() thing is weird. Does it just log and eval? Yep. I like that it shows what's going on in the results. 1173559 5 jer.noble 2016-03-10 20:25:42 -0800 Committed r197989: <http://trac.webkit.org/changeset/197989> 1173561 6 jer.noble 2016-03-10 20:26:12 -0800 *** Bug 155344 has been marked as a duplicate of this bug. *** 273382 2016-03-08 20:31:28 -0800 2016-03-08 21:21:58 -0800 Patch bug-155209-20160308203114.patch text/plain 4950 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3Mzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2Q0NDM1ZGViMjIzMjRk ZGI0N2JmMThiOWEzOGZjZDA1MGQwMzJiMC4uNTAxOWQwMDU2ODkxZmI0NDlmY2RkYjMwNjhmYmQ4 Yzc0M2E1ZWU5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTAzLTA4ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIENSQVNIIGF0IFdlYkNvcmU6 OlJlbmRlclZpZXc6OnVwZGF0ZVZpc2libGVWaWV3cG9ydFJlY3QKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTIwOQorICAgICAgICA8cmRhcjovL3By b2JsZW0vMjM5OTc1MzA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGVzdDogbWVkaWEvdmlkZW8tY3Jhc2gtaW52aXNpYmxlLWF1dG9wbGF5LWRpc3Bs YXktbm9uZS5odG1sCisKKyAgICAgICAgQmV0d2VlbiB0aGUgdGltZSB3aGVuIHRoZSB2aWRlbyBl bGVtZW50J3MgcmVuZGVyZXIgaXMgY3JlYXRlZCBhbmQgZGVzdHJveWVkLCB3ZSBtYXkgaGF2ZSB1 bnNldCB0aGUKKyAgICAgICAgSW52aXNpYmxlQXV0b3BsYXlOb3RQZXJtaXR0ZWQgcmVzdHJpY3Rp b24uIFNvIHJhdGhlciB0aGFuIGNoZWNrIGZvciB0aGF0IHJlc3RyaWN0aW9uIGJlZm9yZQorICAg ICAgICB1bnJlZ2lzdGVyaW5nIGZvciB0aGUgInZpc2libGUgaW4gdmlld3BvcnQiIG5vdGlmaWNh dGlvbiwgdW5yZWdpc3RlciBvbmx5IGlmIHRoZSByZW5kZXJlcgorICAgICAgICB3YXMgcHJldmlv dXNseSByZWdpc3RlcmVkLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OndpbGxEZXRhY2hSZW5kZXJlcnMp OgorCiAyMDE2LTAzLTA3ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAg ICAgIEFkZCBzZXBhcmF0ZSBXSyBhbmQgV0syIHByZWZlcmVuY2VzIGZvciByZXF1aXJpbmcgdXNl ciBnZXN0dXJlcyBmb3IgdmlkZW8gbWVkaWEsIGRpc3RpbmN0IGZyb20gdXNlciBnZXN0dXJlcyBm b3IgbWVkaWEgZ2VuZXJhbGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxN ZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNw cAppbmRleCBiZTVhY2M4MzVjM2Y1YzhlYzlhMDhiNWM3YWFkMGVkMGIyNzcxYjkxLi40ZjcxZjA5 YWFhYjVmMzZhOWJlZjI4MWY3MjEzYjE3NjdhOWY2Y2Q3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTc5Miw3ICs3OTIsNyBAQCB2b2lkIEhUTUxNZWRpYUVs ZW1lbnQ6OmRpZEF0dGFjaFJlbmRlcmVycygpCiAKIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6d2ls bERldGFjaFJlbmRlcmVycygpCiB7Ci0gICAgaWYgKHJlbmRlcmVyKCkgJiYgbV9tZWRpYVNlc3Np b24tPmhhc0JlaGF2aW9yUmVzdHJpY3Rpb24oTWVkaWFFbGVtZW50U2Vzc2lvbjo6SW52aXNpYmxl QXV0b3BsYXlOb3RQZXJtaXR0ZWQpKQorICAgIGlmIChyZW5kZXJlcigpICYmIHJlbmRlcmVyKCkt PmlzUmVnaXN0ZXJlZEZvclZpc2libGVJblZpZXdwb3J0Q2FsbGJhY2soKSkKICAgICAgICAgcmVu ZGVyZXIoKS0+dW5yZWdpc3RlckZvclZpc2libGVJblZpZXdwb3J0Q2FsbGJhY2soKTsKIH0KIApk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CmluZGV4IGM1ODdiMzc4NTQ5MDNiY2ZkNjEwZGI3ZDk0MmQwYjA4Y2RhOWU4MzIuLmNmODBiM2Rh MGRhYTcwMTczMjBiMDUwMGNkYTFiYzM5N2NlYzQzZDIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAxNi0wMy0wOCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KKworICAgICAgICBD UkFTSCBhdCBXZWJDb3JlOjpSZW5kZXJWaWV3Ojp1cGRhdGVWaXNpYmxlVmlld3BvcnRSZWN0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTUyMDkKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIzOTk3NTMwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogbWVkaWEvdmlkZW8tY3Jhc2gtaW52aXNpYmxlLWF1 dG9wbGF5LWRpc3BsYXktbm9uZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIG1lZGlh L3ZpZGVvLWNyYXNoLWludmlzaWJsZS1hdXRvcGxheS1kaXNwbGF5LW5vbmUuaHRtbDogQWRkZWQu CisKIDIwMTYtMDMtMDcgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAg ICAgQWRkIHNlcGFyYXRlIFdLIGFuZCBXSzIgcHJlZmVyZW5jZXMgZm9yIHJlcXVpcmluZyB1c2Vy IGdlc3R1cmVzIGZvciB2aWRlbyBtZWRpYSwgZGlzdGluY3QgZnJvbSB1c2VyIGdlc3R1cmVzIGZv ciBtZWRpYSBnZW5lcmFsbHkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWNy YXNoLWludmlzaWJsZS1hdXRvcGxheS1kaXNwbGF5LW5vbmUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvbWVkaWEvdmlkZW8tY3Jhc2gtaW52aXNpYmxlLWF1dG9wbGF5LWRpc3BsYXktbm9uZS1l eHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNzQ0NzMzZjM1ZWJiOGQ5ZDg2ZWMyMDc5ZGIzMTBiZmNi NzQxNWI1YgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWNyYXNo LWludmlzaWJsZS1hdXRvcGxheS1kaXNwbGF5LW5vbmUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEs OCBAQAorVGVzdHMgdGhhdCBjbGVhcmluZyB0aGUgSW52aXNpYmxlQXV0b3BsYXlOb3RQZXJtaXR0 ZWQgcmVzdHJpY3Rpb24gdGhlbiBkZXN0cm95aW5nIHRoZSBSZW5kZXJWaWRlbyBhZnRlciBhIHN0 eWxlIHJlY2FsYyBkb2VzIG5vdCBjYXVzZSBhIGNyYXNoLgorUlVOKGludGVybmFscy5zZXRNZWRp YUVsZW1lbnRSZXN0cmljdGlvbnModmlkZW8sICJJbnZpc2libGVBdXRvcGxheU5vdFBlcm1pdHRl ZCIpKQorRVZFTlQoY2FucGxheXRocm91Z2gpCitSVU4ocnVuV2l0aEtleURvd24oZnVuY3Rpb24o KSB7IHZpZGVvLnBsYXkoKSB9KSkKK1JVTih2aWRlby5zdHlsZS5kaXNwbGF5ID0gIm5vbmUiKQor UlVOKHZpZGVvLmNsaWVudEhlaWdodCkKK0VORCBPRiBURVNUCisKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL21lZGlhL3ZpZGVvLWNyYXNoLWludmlzaWJsZS1hdXRvcGxheS1kaXNwbGF5LW5vbmUu aHRtbCBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWNyYXNoLWludmlzaWJsZS1hdXRvcGxheS1k aXNwbGF5LW5vbmUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45ZGE0ZDc0Zjk1YzY2OTdkZWU1OTU4ZWYxNDlh YzBmMzdhNDdkMDdkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8t Y3Jhc2gtaW52aXNpYmxlLWF1dG9wbGF5LWRpc3BsYXktbm9uZS5odG1sCkBAIC0wLDAgKzEsMjkg QEAKKzxodG1sPgorICAgIDxoZWFkPgorICAgICAgICA8c2NyaXB0IHNyYz0ibWVkaWEtZmlsZS5q cyI+PC9zY3JpcHQ+CisgICAgICAgIDxzY3JpcHQgc3JjPSJ2aWRlby10ZXN0LmpzIj48L3Njcmlw dD4KKyAgICAgICAgPHNjcmlwdD4KKyAgICAgICAgZnVuY3Rpb24gZ28oKSB7CisgICAgICAgICAg ICBpZiAoIXdpbmRvdy5pbnRlcm5hbHMpCisgICAgICAgICAgICAgICAgY29uc29sZVdyaXRlKCd3 aW5kb3cuaW50ZXJuYWxzIG5vdCBmb3VuZDsgdGVzdCBtYXkgbm90IGNvbXBsZXRlIHN1Y2Vzc2Z1 bGx5IGluIGJyb3dzZXIuJyk7CisKKyAgICAgICAgICAgIHZpZGVvID0gZG9jdW1lbnQuY3JlYXRl RWxlbWVudCgndmlkZW8nKTsKKyAgICAgICAgICAgIHJ1bignaW50ZXJuYWxzLnNldE1lZGlhRWxl bWVudFJlc3RyaWN0aW9ucyh2aWRlbywgIkludmlzaWJsZUF1dG9wbGF5Tm90UGVybWl0dGVkIikn KTsKKyAgICAgICAgICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQodmlkZW8pOworCisgICAg ICAgICAgICB3YWl0Rm9yRXZlbnQoJ2NhbnBsYXl0aHJvdWdoJywgY2FucGxheXRocm91Z2gpOwor ICAgICAgICAgICAgc2V0U3JjQnlUYWdOYW1lKCd2aWRlbycsIGZpbmRNZWRpYUZpbGUoJ3ZpZGVv JywgJ2NvbnRlbnQvdGVzdCcpKTsKKyAgICAgICAgfQorCisgICAgICAgIGZ1bmN0aW9uIGNhbnBs YXl0aHJvdWdoKCkgeworICAgICAgICAgICAgcnVuKCdydW5XaXRoS2V5RG93bihmdW5jdGlvbigp IHsgdmlkZW8ucGxheSgpIH0pJyk7CisgICAgICAgICAgICBydW4oJ3ZpZGVvLnN0eWxlLmRpc3Bs YXkgPSAibm9uZSInKTsKKyAgICAgICAgICAgIHJ1bigndmlkZW8uY2xpZW50SGVpZ2h0Jyk7Cisg ICAgICAgICAgICBlbmRUZXN0KCk7CisgICAgICAgIH0KKyAgICAgICAgPC9zY3JpcHQ+CisgICAg PC9oZWFkPgorICAgIDxib2R5IG9ubG9hZD0iZ28oKSI+CisgICAgICAgIDxkaXY+VGVzdHMgdGhh dCBjbGVhcmluZyB0aGUgSW52aXNpYmxlQXV0b3BsYXlOb3RQZXJtaXR0ZWQgcmVzdHJpY3Rpb24g dGhlbiBkZXN0cm95aW5nIHRoZSBSZW5kZXJWaWRlbyBhZnRlciBhIHN0eWxlIHJlY2FsYyBkb2Vz IG5vdCBjYXVzZSBhIGNyYXNoLjwvZGl2PgorICAgIDwvYm9keT4KKzwvaHRtbD4K