155162 2016-03-07 21:58:42 -0800 Web Inspector: Make WebAutomationSession::closeBrowsingContext work as expected 2016-03-08 00:55:49 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1171935 0 timothy 2016-03-07 21:58:42 -0800 The code for WebAutomationSession::closeBrowsingContext is not working. We need to call a different method to trigger a close via the UIClient of the page. 1171936 1 webkit-bug-importer 2016-03-07 21:58:58 -0800 <rdar://problem/25027191> 1171938 2 273271 timothy 2016-03-07 22:06:36 -0800 Created attachment 273271 Patch 1171942 3 273271 bburg 2016-03-07 22:29:15 -0800 Comment on attachment 273271 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273271&action=review r=me > Source/WebKit2/ChangeLog:4 > + Nit: extra newline not needed 1171977 4 273271 commit-queue 2016-03-08 00:55:45 -0800 Comment on attachment 273271 Patch Clearing flags on attachment: 273271 Committed r197742: <http://trac.webkit.org/changeset/197742> 1171978 5 commit-queue 2016-03-08 00:55:49 -0800 All reviewed patches have been landed. Closing bug. 273271 2016-03-07 22:06:36 -0800 2016-03-08 00:55:45 -0800 Patch bug-155162-20160307220622.patch text/plain 3625 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3NzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjE5OGJkYzEwYWI3MTI3 OTcyNGIwNTEwZGY5Y2ZiN2JiMjAyMGMzNy4uZDVmMzk3MGQ2MDc0ZTU3NzBkOWI0MzY2NjMyZmQ0 MDU1OWY2M2UyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTAzLTA3ICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBNYWtlIFdlYkF1dG9tYXRpb25TZXNzaW9uOjpjbG9zZUJyb3dzaW5nQ29udGV4dCB3b3JrIGFz IGV4cGVjdGVkCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1NTE2MgorICAgICAgICByZGFyOi8vcHJvYmxlbS8yNTAyNzE5MQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0F1dG9tYXRp b24vV2ViQXV0b21hdGlvblNlc3Npb24uY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJBdXRvbWF0 aW9uU2Vzc2lvbjo6Y2xvc2VCcm93c2luZ0NvbnRleHQpOgorICAgICAgICBDYWxsIGNsb3NlUGFn ZSwgdGhlIHNhbWUgbWV0aG9kIHVsdGltYXRlbHkgdXNlZCBieSB3aW5kb3cuY2xvc2UoKS4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaDogTWFrZSBjbG9zZVBhZ2UgcHVibGlj LgorCiAyMDE2LTAzLTA3ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAg ICAgICAgIFJlZHVjZSBzdGFydHVwIGFuZCBzaHV0ZG93biBjb3N0IG9mIHJlc291cmNlIGxvYWQg c3RhdGlzdGljcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0F1dG9tYXRp b24vV2ViQXV0b21hdGlvblNlc3Npb24uY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0F1 dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Npb24uY3BwCmluZGV4IDQzOWY4OGFlNWM5MzEzYTg0 OWMwOTg1Y2Q0OGI1OTFiN2RmNmE4MTEuLjFmYmNlYzc4MTY2ZDg0MzkzMDZjZDZhNGRjNGZlMzk2 ZTFjYWExYmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BdXRvbWF0aW9u L1dlYkF1dG9tYXRpb25TZXNzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5jcHAKQEAgLTE3MCw5ICsxNzAsNyBAQCB2 b2lkIFdlYkF1dG9tYXRpb25TZXNzaW9uOjpjbG9zZUJyb3dzaW5nQ29udGV4dChJbnNwZWN0b3I6 OkVycm9yU3RyaW5nJiBlcnJvclN0cgogICAgIGlmIChoYW5kbGUgPT0gbV9hY3RpdmVCcm93c2lu Z0NvbnRleHRIYW5kbGUpCiAgICAgICAgIG1fYWN0aXZlQnJvd3NpbmdDb250ZXh0SGFuZGxlID0g ZW1wdHlTdHJpbmcoKTsKIAotICAgIC8vIEZJWE1FOiBWZXJpZnkgdGhpcyBpcyBlbm91Z2guIFdl IHN0aWxsIG1pZ2h0IHdhbnQgdG8gZ28gdGhyb3VnaCB0aGUgQXV0b21hdGlvblNlc3Npb25DbGll bnQKLSAgICAvLyB0byBnZXQgY2xvc2VyIHRvIGEgdXNlciBwcmVzc2luZyB0aGUgY2xvc2UgYnV0 dG9uLgotICAgIHBhZ2UtPnRyeUNsb3NlKCk7CisgICAgcGFnZS0+Y2xvc2VQYWdlKGZhbHNlKTsK IH0KIAogdm9pZCBXZWJBdXRvbWF0aW9uU2Vzc2lvbjo6c3dpdGNoVG9Ccm93c2luZ0NvbnRleHQo SW5zcGVjdG9yOjpFcnJvclN0cmluZyYgZXJyb3JTdHJpbmcsIGNvbnN0IFN0cmluZyYgaGFuZGxl KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCmluZGV4IGUzNzQzNTJhZTNk NGViMjI0NTBlMTAzMzI1MTg4OTRmMTBjNmQ4MjIuLmQ1MjVlMGQ3MDc3MzljZmVlN2ZhN2QwNTNh YTI1OTFlNWQ4YzU1M2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgK QEAgLTM2Myw2ICszNjMsOCBAQCBwdWJsaWM6CiAgICAgYm9vbCB0cnlDbG9zZSgpOwogICAgIGJv b2wgaXNDbG9zZWQoKSBjb25zdCB7IHJldHVybiBtX2lzQ2xvc2VkOyB9CiAKKyAgICB2b2lkIGNs b3NlUGFnZShib29sIHN0b3BSZXNwb25zaXZlbmVzc1RpbWVyKTsKKwogICAgIFJlZlB0cjxBUEk6 Ok5hdmlnYXRpb24+IGxvYWRSZXF1ZXN0KGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYs IFdlYkNvcmU6OlNob3VsZE9wZW5FeHRlcm5hbFVSTHNQb2xpY3kgPSBXZWJDb3JlOjpTaG91bGRP cGVuRXh0ZXJuYWxVUkxzUG9saWN5OjpTaG91bGRBbGxvd0V4dGVybmFsU2NoZW1lcywgQVBJOjpP YmplY3QqIHVzZXJEYXRhID0gbnVsbHB0cik7CiAgICAgUmVmUHRyPEFQSTo6TmF2aWdhdGlvbj4g bG9hZEZpbGUoY29uc3QgU3RyaW5nJiBmaWxlVVJMLCBjb25zdCBTdHJpbmcmIHJlc291cmNlRGly ZWN0b3J5VVJMLCBBUEk6Ok9iamVjdCogdXNlckRhdGEgPSBudWxscHRyKTsKICAgICBSZWZQdHI8 QVBJOjpOYXZpZ2F0aW9uPiBsb2FkRGF0YShBUEk6OkRhdGEqLCBjb25zdCBTdHJpbmcmIE1JTUVU eXBlLCBjb25zdCBTdHJpbmcmIGVuY29kaW5nLCBjb25zdCBTdHJpbmcmIGJhc2VVUkwsIEFQSTo6 T2JqZWN0KiB1c2VyRGF0YSA9IG51bGxwdHIpOwpAQCAtMTE3MCw3ICsxMTcyLDYgQEAgcHJpdmF0 ZToKICAgICAvLyBVSSBjbGllbnQKICAgICB2b2lkIGNyZWF0ZU5ld1BhZ2UodWludDY0X3QgZnJh bWVJRCwgY29uc3QgV2ViQ29yZTo6U2VjdXJpdHlPcmlnaW5EYXRhJiwgY29uc3QgV2ViQ29yZTo6 UmVzb3VyY2VSZXF1ZXN0JiwgY29uc3QgV2ViQ29yZTo6V2luZG93RmVhdHVyZXMmLCBjb25zdCBO YXZpZ2F0aW9uQWN0aW9uRGF0YSYsIHVpbnQ2NF90JiBuZXdQYWdlSUQsIFdlYlBhZ2VDcmVhdGlv blBhcmFtZXRlcnMmKTsKICAgICB2b2lkIHNob3dQYWdlKCk7Ci0gICAgdm9pZCBjbG9zZVBhZ2Uo Ym9vbCBzdG9wUmVzcG9uc2l2ZW5lc3NUaW1lcik7CiAgICAgdm9pZCBydW5KYXZhU2NyaXB0QWxl cnQodWludDY0X3QgZnJhbWVJRCwgY29uc3QgV2ViQ29yZTo6U2VjdXJpdHlPcmlnaW5EYXRhJiwg Y29uc3QgU3RyaW5nJiwgUmVmUHRyPE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OlJ1bkphdmFTY3Jp cHRBbGVydDo6RGVsYXllZFJlcGx5Pik7CiAgICAgdm9pZCBydW5KYXZhU2NyaXB0Q29uZmlybSh1 aW50NjRfdCBmcmFtZUlELCBjb25zdCBXZWJDb3JlOjpTZWN1cml0eU9yaWdpbkRhdGEmLCBjb25z dCBTdHJpbmcmLCBSZWZQdHI8TWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6UnVuSmF2YVNjcmlwdENv bmZpcm06OkRlbGF5ZWRSZXBseT4pOwogICAgIHZvaWQgcnVuSmF2YVNjcmlwdFByb21wdCh1aW50 NjRfdCBmcmFtZUlELCBjb25zdCBXZWJDb3JlOjpTZWN1cml0eU9yaWdpbkRhdGEmLCBjb25zdCBT dHJpbmcmLCBjb25zdCBTdHJpbmcmLCBSZWZQdHI8TWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6UnVu SmF2YVNjcmlwdFByb21wdDo6RGVsYXllZFJlcGx5Pik7Cg==