155160 2016-03-07 21:52:27 -0800 createRegExpMatchesArray should allocate substrings more quickly 2016-03-07 22:53:46 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1171930 0 fpizlo 2016-03-07 21:52:27 -0800 Patch forthcoming. 1171931 1 273269 fpizlo 2016-03-07 21:55:31 -0800 Created attachment 273269 the patch 1171950 2 fpizlo 2016-03-07 22:53:46 -0800 Landed in http://trac.webkit.org/changeset/197729 273269 2016-03-07 21:55:31 -0800 2016-03-07 22:41:40 -0800 the patch blah.patch text/plain 6346 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk3NzI0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBA CisyMDE2LTAzLTA3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Y3JlYXRlUmVnRXhwTWF0Y2hlc0FycmF5IHNob3VsZCBhbGxvY2F0ZSBzdWJzdHJpbmdzIG1vcmUg cXVpY2tseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU1MTYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhpcyB3YXMgY2FsbGluZyBhIHZlcnNpb24gb2YganNTdWJzdHJpbmcoKSB0aGF0IGlzbid0IGlu bGluZWFibGUgYmVjYXVzZSBpdCB3YXMgZG9pbmcgYSBsb3QKKyAgICAgICAgb2YgY2hlY2tzIGlu IGZpbmlzaENyZWF0aW9uKCkuIEluIHBhcnRpY3VsYXIsIGl0IHdhcyBjaGVja2luZyB0aGF0IHRo ZSBiYXNlIHN0cmluZyBpcyBub3QKKyAgICAgICAgaXRzZWxmIGEgc3Vic3RyaW5nIGFuZCB0aGF0 IGl0J3MgYmVlbiByZXNvbHZlZC4gV2UgZG9uJ3QgbmVlZCB0aG9zZSBjaGVja3MgaGVyZSwgc2lu Y2UgdGhlCisgICAgICAgIHN0cmluZyBtdXN0IGhhdmUgYmVlbiByZXNvbHZlZCBwcmlvciB0byBy ZWdleHAgcHJvY2Vzc2luZy4KKworICAgICAgICBUaGlzIHBhdGNoIGlzIGFsc28gc21hcnQgYWJv dXQgd2hldGhlciB0byBkbyBjaGVja3MgZm9yIHRoZSBlbXB0eSBhbmQgZnVsbCBzdWJzdHJpbmdz LiBJbgorICAgICAgICB0aGUgbWF0Y2hlcyBhcnJheSBsb29wLCB0aGVzZSBjaGVja3MgYXJlIHN1 cGVyIHVubGlrZWx5IHRvIGJlIHByb2ZpdGFibGUsIHNvIHdlIGp1c3QKKyAgICAgICAgdW5jb25k aXRpb25hbGx5IGFsbG9jYXRlIHRoZSBzdWJzdHJpbmcuCisKKyAgICAgICAgVGhpcyByZW1vdmVz IHRob3NlIGNoZWNrcyBhbmQgbWFrZXMgdGhlIGFsbG9jYXRpb24gaW5saW5lYWJsZS4gSXQgbG9v a3MgbGlrZSBhIDElIHNwZWVkLXVwCisgICAgICAgIG9uIE9jdGFuZS9yZWdleHAuCisKKyAgICAg ICAgKiBydW50aW1lL0pTU3RyaW5nLmg6CisgICAgICAgIChKU0M6OmpzU3Vic3RyaW5nKToKKyAg ICAgICAgKEpTQzo6anNTdWJzdHJpbmdPZlJlc29sdmVkKToKKyAgICAgICAgKiBydW50aW1lL1Jl Z0V4cE1hdGNoZXNBcnJheS5jcHA6CisgICAgICAgIChKU0M6OmNyZWF0ZVJlZ0V4cE1hdGNoZXNB cnJheSk6CisKIDIwMTYtMDMtMDcgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKICAg ICAgICAgV2ViIEluc3BlY3RvcjogdGhlIHByb3RvY29sIGdlbmVyYXRvciBzaG91bGQgZ2VuZXJh dGUgZmFjdG9yeSBtZXRob2Qgc3R1YnMgZm9yIHByb3RvY29sIHR5cGVzCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1N0cmluZy5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU3RyaW5nLmgJKHJldmlzaW9uIDE5NzcyMykKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU3RyaW5nLmgJKHdvcmtpbmcgY29weSkKQEAg LTI2Niw3ICsyNjYsNyBAQCBwdWJsaWM6CiAgICAgfTsKIAogcHJpdmF0ZToKLSAgICBKU1JvcGVT dHJpbmcoVk0mIHZtKQorICAgIEFMV0FZU19JTkxJTkUgSlNSb3BlU3RyaW5nKFZNJiB2bSkKICAg ICAgICAgOiBKU1N0cmluZyh2bSkKICAgICB7CiAgICAgfQpAQCAtMzE3LDYgKzMxNywxOCBAQCBw cml2YXRlOgogICAgICAgICB9CiAgICAgfQogCisgICAgQUxXQVlTX0lOTElORSB2b2lkIGZpbmlz aENyZWF0aW9uU3Vic3RyaW5nT2ZSZXNvbHZlZChWTSYgdm0sIEpTU3RyaW5nKiBiYXNlLCB1bnNp Z25lZCBvZmZzZXQsIHVuc2lnbmVkIGxlbmd0aCkKKyAgICB7CisgICAgICAgIEJhc2U6OmZpbmlz aENyZWF0aW9uKHZtKTsKKyAgICAgICAgQVNTRVJUKCFzdW1PdmVyZmxvd3M8aW50MzJfdD4ob2Zm c2V0LCBsZW5ndGgpKTsKKyAgICAgICAgQVNTRVJUKG9mZnNldCArIGxlbmd0aCA8PSBiYXNlLT5s ZW5ndGgoKSk7CisgICAgICAgIG1fbGVuZ3RoID0gbGVuZ3RoOworICAgICAgICBzZXRJczhCaXQo YmFzZS0+aXM4Qml0KCkpOworICAgICAgICBzZXRJc1N1YnN0cmluZyh0cnVlKTsKKyAgICAgICAg c3Vic3RyaW5nQmFzZSgpLnNldCh2bSwgdGhpcywgYmFzZSk7CisgICAgICAgIHN1YnN0cmluZ09m ZnNldCgpID0gb2Zmc2V0OworICAgIH0KKwogICAgIHZvaWQgZmluaXNoQ3JlYXRpb24oVk0mIHZt KQogICAgIHsKICAgICAgICAgSlNTdHJpbmc6OmZpbmlzaENyZWF0aW9uKHZtKTsKQEAgLTM2Miw2 ICszNzQsMTMgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gbmV3U3RyaW5nOwogICAgIH0KIAor ICAgIEFMV0FZU19JTkxJTkUgc3RhdGljIEpTU3RyaW5nKiBjcmVhdGVTdWJzdHJpbmdPZlJlc29s dmVkKFZNJiB2bSwgSlNTdHJpbmcqIGJhc2UsIHVuc2lnbmVkIG9mZnNldCwgdW5zaWduZWQgbGVu Z3RoKQorICAgIHsKKyAgICAgICAgSlNSb3BlU3RyaW5nKiBuZXdTdHJpbmcgPSBuZXcgKE5vdE51 bGwsIGFsbG9jYXRlQ2VsbDxKU1JvcGVTdHJpbmc+KHZtLmhlYXApKSBKU1JvcGVTdHJpbmcodm0p OworICAgICAgICBuZXdTdHJpbmctPmZpbmlzaENyZWF0aW9uU3Vic3RyaW5nT2ZSZXNvbHZlZCh2 bSwgYmFzZSwgb2Zmc2V0LCBsZW5ndGgpOworICAgICAgICByZXR1cm4gbmV3U3RyaW5nOworICAg IH0KKwogICAgIHZvaWQgdmlzaXRGaWJlcnMoU2xvdFZpc2l0b3ImKTsKIAogICAgIHN0YXRpYyBw dHJkaWZmX3Qgb2Zmc2V0T2ZGaWJlcnMoKSB7IHJldHVybiBPQkpFQ1RfT0ZGU0VUT0YoSlNSb3Bl U3RyaW5nLCB1KTsgfQpAQCAtNTUzLDYgKzU3MiwxOCBAQCBpbmxpbmUgSlNTdHJpbmcqIGpzU3Vi c3RyaW5nKFZNJiB2bSwgRXhlCiAgICAgcmV0dXJuIEpTUm9wZVN0cmluZzo6Y3JlYXRlKHZtLCBl eGVjLCBzLCBvZmZzZXQsIGxlbmd0aCk7CiB9CiAKK2lubGluZSBKU1N0cmluZyoganNTdWJzdHJp bmdPZlJlc29sdmVkKFZNJiB2bSwgSlNTdHJpbmcqIHMsIHVuc2lnbmVkIG9mZnNldCwgdW5zaWdu ZWQgbGVuZ3RoKQoreworICAgIEFTU0VSVChvZmZzZXQgPD0gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+ KHMtPmxlbmd0aCgpKSk7CisgICAgQVNTRVJUKGxlbmd0aCA8PSBzdGF0aWNfY2FzdDx1bnNpZ25l ZD4ocy0+bGVuZ3RoKCkpKTsKKyAgICBBU1NFUlQob2Zmc2V0ICsgbGVuZ3RoIDw9IHN0YXRpY19j YXN0PHVuc2lnbmVkPihzLT5sZW5ndGgoKSkpOworICAgIGlmICghbGVuZ3RoKQorICAgICAgICBy ZXR1cm4gdm0uc21hbGxTdHJpbmdzLmVtcHR5U3RyaW5nKCk7CisgICAgaWYgKCFvZmZzZXQgJiYg bGVuZ3RoID09IHMtPmxlbmd0aCgpKQorICAgICAgICByZXR1cm4gczsKKyAgICByZXR1cm4gSlNS b3BlU3RyaW5nOjpjcmVhdGVTdWJzdHJpbmdPZlJlc29sdmVkKHZtLCBzLCBvZmZzZXQsIGxlbmd0 aCk7Cit9CisKIGlubGluZSBKU1N0cmluZyoganNTdWJzdHJpbmcoRXhlY1N0YXRlKiBleGVjLCBK U1N0cmluZyogcywgdW5zaWduZWQgb2Zmc2V0LCB1bnNpZ25lZCBsZW5ndGgpCiB7CiAgICAgcmV0 dXJuIGpzU3Vic3RyaW5nKGV4ZWMtPnZtKCksIGV4ZWMsIHMsIG9mZnNldCwgbGVuZ3RoKTsKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4cE1hdGNoZXNBcnJheS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwTWF0Y2hl c0FycmF5LmNwcAkocmV2aXNpb24gMTk3NzIzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvUmVnRXhwTWF0Y2hlc0FycmF5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzYsMTMgKzc2 LDEzIEBAIEpTQXJyYXkqIGNyZWF0ZVJlZ0V4cE1hdGNoZXNBcnJheSgKICAgICBpZiAoVU5MSUtF TFkoZ2xvYmFsT2JqZWN0LT5pc0hhdmluZ0FCYWRUaW1lKCkpKSB7CiAgICAgICAgIGFycmF5ID0g SlNBcnJheTo6dHJ5Q3JlYXRlVW5pbml0aWFsaXplZCh2bSwgZ2xvYmFsT2JqZWN0LT5yZWdFeHBN YXRjaGVzQXJyYXlTdHJ1Y3R1cmUoKSwgcmVnRXhwLT5udW1TdWJwYXR0ZXJucygpICsgMSk7CiAg ICAgICAgIAotICAgICAgICBhcnJheS0+aW5pdGlhbGl6ZUluZGV4KHZtLCAwLCBqc1N1YnN0cmlu Zyh2bSwgZXhlYywgaW5wdXQsIHJlc3VsdC5zdGFydCwgcmVzdWx0LmVuZCAtIHJlc3VsdC5zdGFy dCkpOworICAgICAgICBhcnJheS0+aW5pdGlhbGl6ZUluZGV4KHZtLCAwLCBqc1N1YnN0cmluZ09m UmVzb2x2ZWQodm0sIGlucHV0LCByZXN1bHQuc3RhcnQsIHJlc3VsdC5lbmQgLSByZXN1bHQuc3Rh cnQpKTsKICAgICAgICAgCiAgICAgICAgIGlmICh1bnNpZ25lZCBudW1TdWJwYXR0ZXJucyA9IHJl Z0V4cC0+bnVtU3VicGF0dGVybnMoKSkgewogICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0g MTsgaSA8PSBudW1TdWJwYXR0ZXJuczsgKytpKSB7CiAgICAgICAgICAgICAgICAgaW50IHN0YXJ0 ID0gc3VicGF0dGVyblJlc3VsdHNbMiAqIGldOwogICAgICAgICAgICAgICAgIGlmIChzdGFydCA+ PSAwKQotICAgICAgICAgICAgICAgICAgICBhcnJheS0+aW5pdGlhbGl6ZUluZGV4KHZtLCBpLCBq c1N1YnN0cmluZyh2bSwgZXhlYywgaW5wdXQsIHN0YXJ0LCBzdWJwYXR0ZXJuUmVzdWx0c1syICog aSArIDFdIC0gc3RhcnQpKTsKKyAgICAgICAgICAgICAgICAgICAgYXJyYXktPmluaXRpYWxpemVJ bmRleCh2bSwgaSwgSlNSb3BlU3RyaW5nOjpjcmVhdGVTdWJzdHJpbmdPZlJlc29sdmVkKHZtLCBp bnB1dCwgc3RhcnQsIHN1YnBhdHRlcm5SZXN1bHRzWzIgKiBpICsgMV0gLSBzdGFydCkpOwogICAg ICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICAgICAgYXJyYXktPmluaXRpYWxpemVJ bmRleCh2bSwgaSwganNVbmRlZmluZWQoKSk7CiAgICAgICAgICAgICB9CkBAIC05MSwxMyArOTEs MTMgQEAgSlNBcnJheSogY3JlYXRlUmVnRXhwTWF0Y2hlc0FycmF5KAogICAgICAgICBhcnJheSA9 IHRyeUNyZWF0ZVVuaW5pdGlhbGl6ZWRSZWdFeHBNYXRjaGVzQXJyYXkodm0sIGdsb2JhbE9iamVj dC0+cmVnRXhwTWF0Y2hlc0FycmF5U3RydWN0dXJlKCksIHJlZ0V4cC0+bnVtU3VicGF0dGVybnMo KSArIDEpOwogICAgICAgICBSRUxFQVNFX0FTU0VSVChhcnJheSk7CiAgICAgICAgIAotICAgICAg ICBhcnJheS0+aW5pdGlhbGl6ZUluZGV4KHZtLCAwLCBqc1N1YnN0cmluZyh2bSwgZXhlYywgaW5w dXQsIHJlc3VsdC5zdGFydCwgcmVzdWx0LmVuZCAtIHJlc3VsdC5zdGFydCksIEFycmF5V2l0aENv bnRpZ3VvdXMpOworICAgICAgICBhcnJheS0+aW5pdGlhbGl6ZUluZGV4KHZtLCAwLCBqc1N1YnN0 cmluZ09mUmVzb2x2ZWQodm0sIGlucHV0LCByZXN1bHQuc3RhcnQsIHJlc3VsdC5lbmQgLSByZXN1 bHQuc3RhcnQpLCBBcnJheVdpdGhDb250aWd1b3VzKTsKICAgICAgICAgCiAgICAgICAgIGlmICh1 bnNpZ25lZCBudW1TdWJwYXR0ZXJucyA9IHJlZ0V4cC0+bnVtU3VicGF0dGVybnMoKSkgewogICAg ICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMTsgaSA8PSBudW1TdWJwYXR0ZXJuczsgKytpKSB7 CiAgICAgICAgICAgICAgICAgaW50IHN0YXJ0ID0gc3VicGF0dGVyblJlc3VsdHNbMiAqIGldOwog ICAgICAgICAgICAgICAgIGlmIChzdGFydCA+PSAwKQotICAgICAgICAgICAgICAgICAgICBhcnJh eS0+aW5pdGlhbGl6ZUluZGV4KHZtLCBpLCBqc1N1YnN0cmluZyh2bSwgZXhlYywgaW5wdXQsIHN0 YXJ0LCBzdWJwYXR0ZXJuUmVzdWx0c1syICogaSArIDFdIC0gc3RhcnQpLCBBcnJheVdpdGhDb250 aWd1b3VzKTsKKyAgICAgICAgICAgICAgICAgICAgYXJyYXktPmluaXRpYWxpemVJbmRleCh2bSwg aSwgSlNSb3BlU3RyaW5nOjpjcmVhdGVTdWJzdHJpbmdPZlJlc29sdmVkKHZtLCBpbnB1dCwgc3Rh cnQsIHN1YnBhdHRlcm5SZXN1bHRzWzIgKiBpICsgMV0gLSBzdGFydCksIEFycmF5V2l0aENvbnRp Z3VvdXMpOwogICAgICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICAgICAgYXJyYXkt PmluaXRpYWxpemVJbmRleCh2bSwgaSwganNVbmRlZmluZWQoKSwgQXJyYXlXaXRoQ29udGlndW91 cyk7CiAgICAgICAgICAgICB9Cg==