155154 2016-03-07 19:13:08 -0800 WeakBlock::visit() should check for a WeakHandleOwner before consulting mark bits. 2016-03-08 09:57:00 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Performance P2 Normal --- 1 kling kling commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1171898 0 kling 2016-03-07 19:13:08 -0800 Many WeakImpl's do not have a WeakHandleOwner, so WeakBlock::visit() is just wasting its time looking up the mark bits for its pointee. 1171899 1 273260 kling 2016-03-07 19:13:37 -0800 Created attachment 273260 Patch 1172048 2 273260 darin 2016-03-08 09:09:40 -0800 Comment on attachment 273260 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273260&action=review > Source/JavaScriptCore/heap/WeakBlock.cpp:121 > + const JSValue& jsValue = weakImpl->jsValue(); The use of const JSValue& here seems peculiar. Why not just JSValue? 1172065 3 273260 commit-queue 2016-03-08 09:56:57 -0800 Comment on attachment 273260 Patch Clearing flags on attachment: 273260 Committed r197774: <http://trac.webkit.org/changeset/197774> 1172066 4 commit-queue 2016-03-08 09:57:00 -0800 All reviewed patches have been landed. Closing bug. 273260 2016-03-07 19:13:37 -0800 2016-03-08 09:56:57 -0800 Patch bug-155154.diff text/plain 2024 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGVlM2JmMmQuLjM1YTEyOTUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTAzLTA3ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBXZWFrQmxvY2s6OnZpc2l0KCkgc2hvdWxk IGNoZWNrIGZvciBhIFdlYWtIYW5kbGVPd25lciBiZWZvcmUgY29uc3VsdGluZyBtYXJrIGJpdHMu CisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xNTUxNTQ+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVvcmRlciB0aGUgY2hlY2tzIGluIFdl YWtCbG9jazo6dmlzaXQoKSBzbyB3ZSBkb24ndCBsb29rIGF0IHRoZSBtYXJrIGJpdHMgaW4gTWFy a2VkQmxvY2sKKyAgICAgICAgdW5sZXNzIHRoZSBjdXJyZW50IFdlYWtJbXBsIGhhcyBhIFdlYWtI YW5kbGVPd25lciB3ZSBuZWVkIHRvIGNvbnN1bHQuCisKKyAgICAgICAgSSB3YXMgb3JpZ2luYWxs eSBob3BpbmcgdG8gbWFrZSBhbiBvcHRpbWl6YXRpb24gdGhhdCBjb3VsZCBza2lwIG92ZXIgZW50 aXJlIFdlYWtCbG9ja3MKKyAgICAgICAgaWYgdGhleSBkaWRuJ3QgaGF2ZSBhIHNpbmdsZSBXZWFr SGFuZGxlT3duZXIsIGJ1dCBpdCB0dXJucyBvdXQgdGhhdCBzY2VuYXJpbyBpcyBub3QgYXMKKyAg ICAgICAgY29tbW9uIGFzIEkgc3VzcGVjdGVkLgorCisgICAgICAgICogaGVhcC9XZWFrQmxvY2su Y3BwOgorICAgICAgICAoSlNDOjpXZWFrQmxvY2s6OnZpc2l0KToKKwogMjAxNi0wMy0wNyAgQnJp YW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiB0aGUg cHJvdG9jb2wgZ2VuZXJhdG9yIHNob3VsZCBnZW5lcmF0ZSBmYWN0b3J5IG1ldGhvZCBzdHVicyBm b3IgcHJvdG9jb2wgdHlwZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFw L1dlYWtCbG9jay5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9XZWFrQmxvY2suY3Bw CmluZGV4IDRiMmFlNjYuLmRkYmJjOGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9oZWFwL1dlYWtCbG9jay5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvV2Vh a0Jsb2NrLmNwcApAQCAtMTE0LDE0ICsxMTQsMTQgQEAgdm9pZCBXZWFrQmxvY2s6OnZpc2l0KEhl YXBSb290VmlzaXRvciYgaGVhcFJvb3RWaXNpdG9yKQogICAgICAgICBpZiAod2Vha0ltcGwtPnN0 YXRlKCkgIT0gV2Vha0ltcGw6OkxpdmUpCiAgICAgICAgICAgICBjb250aW51ZTsKIAotICAgICAg ICBjb25zdCBKU1ZhbHVlJiBqc1ZhbHVlID0gd2Vha0ltcGwtPmpzVmFsdWUoKTsKLSAgICAgICAg aWYgKG1fbWFya2VkQmxvY2stPmlzTWFya2VkT3JOZXdseUFsbG9jYXRlZChqc1ZhbHVlLmFzQ2Vs bCgpKSkKLSAgICAgICAgICAgIGNvbnRpbnVlOwotCiAgICAgICAgIFdlYWtIYW5kbGVPd25lciog d2Vha0hhbmRsZU93bmVyID0gd2Vha0ltcGwtPndlYWtIYW5kbGVPd25lcigpOwogICAgICAgICBp ZiAoIXdlYWtIYW5kbGVPd25lcikKICAgICAgICAgICAgIGNvbnRpbnVlOwogCisgICAgICAgIGNv bnN0IEpTVmFsdWUmIGpzVmFsdWUgPSB3ZWFrSW1wbC0+anNWYWx1ZSgpOworICAgICAgICBpZiAo bV9tYXJrZWRCbG9jay0+aXNNYXJrZWRPck5ld2x5QWxsb2NhdGVkKGpzVmFsdWUuYXNDZWxsKCkp KQorICAgICAgICAgICAgY29udGludWU7CisKICAgICAgICAgaWYgKCF3ZWFrSGFuZGxlT3duZXIt PmlzUmVhY2hhYmxlRnJvbU9wYXF1ZVJvb3RzKEhhbmRsZTxVbmtub3duPjo6d3JhcFNsb3QoJmNv bnN0X2Nhc3Q8SlNWYWx1ZSY+KGpzVmFsdWUpKSwgd2Vha0ltcGwtPmNvbnRleHQoKSwgdmlzaXRv cikpCiAgICAgICAgICAgICBjb250aW51ZTsKIAo=