155152 2016-03-07 18:55:10 -0800 [JSC] Small clean up of how we use SSA's valuesAtHead 2016-03-07 21:56:46 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue fpizlo keith_miller mark.lam msaboff saam oldest_to_newest 1171891 0 benjamin 2016-03-07 18:55:10 -0800 [JSC] Small clean up of how we use SSA's valuesAtHead 1171893 1 273259 benjamin 2016-03-07 18:57:16 -0800 Created attachment 273259 Patch 1171908 2 273259 fpizlo 2016-03-07 20:24:14 -0800 Comment on attachment 273259 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273259&action=review > Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.cpp:65 > + for (auto& iter : basicBlock->ssa->valuesAtHead) I would call it "entry" instead of "iter". > Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.cpp:302 > + for (auto& valueAtHeadIterator : to->ssa->valuesAtHead) { Ditto. Maybe you could just call it "entry" here as well. 1171917 3 273265 benjamin 2016-03-07 20:57:24 -0800 Created attachment 273265 Patch for landing 1171933 4 273265 commit-queue 2016-03-07 21:56:42 -0800 Comment on attachment 273265 Patch for landing Clearing flags on attachment: 273265 Committed r197725: <http://trac.webkit.org/changeset/197725> 1171934 5 commit-queue 2016-03-07 21:56:46 -0800 All reviewed patches have been landed. Closing bug. 273259 2016-03-07 18:57:16 -0800 2016-03-07 20:57:21 -0800 Patch bug-155152-20160307185703.patch text/plain 3390 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3NjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz MTc3MjgxYTNiMGIyYzBmMjgyYjRjNDVmZDRkZTk2ZjEwOWFiNjIwLi5mMzZhOGJhZDFjYWJiZGM5 ODcxZWRiMTMyYzc4NjRjNzg5MzNkMTNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNi0wMy0wNyAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBbSlNDXSBTbWFsbCBjbGVhbiB1cCBvZiBob3cgd2UgdXNlIFNTQSdz IHZhbHVlc0F0SGVhZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTU1MTUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgbGl2ZUF0SGVhZCBhbmQgdmFsdWVzQXRIZWFkIGNvbnRhaW4gdGhlIHNhbWUgbm9kZXMs CisgICAgICAgIHdlIGRvIG5vdCBuZWVkIHRoZSBleHRyYSBsb29rIHVwLgorCisgICAgICAgIFRo aXMgYWxzbyBvcGVucyB0aGUgd2F5IHRvIHVzZSB0aGUgc2FtZSBraW5kIG9mIGxpdmVuZXNzCisg ICAgICAgIGFuYWx5c2lzIGFzIEFpciAod2hlcmUgbGl2ZSB2YWx1ZXMgYXQgaGVhZCBkbyBub3Qg dXNlIGEgc2V0KS4KKworICAgICAgICAqIGRmZy9ERkdJblBsYWNlQWJzdHJhY3RTdGF0ZS5jcHA6 CisgICAgICAgIChKU0M6OkRGRzo6SW5QbGFjZUFic3RyYWN0U3RhdGU6OmJlZ2luQmFzaWNCbG9j ayk6CisgICAgICAgIChKU0M6OkRGRzo6SW5QbGFjZUFic3RyYWN0U3RhdGU6Om1lcmdlKToKKwog MjAxNi0wMy0wNiAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiB0aGUgcHJvdG9jb2wgZ2VuZXJhdG9yIHNob3VsZCBoYXZlIHNlcGFyYXRlIHBy ZWZpeCBvcHRpb25zIGZvciBPYmplY3RpdmUtQyBjbGFzc2VzIGFuZCBmaWxlbmFtZXMKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSW5QbGFjZUFic3RyYWN0U3RhdGUu Y3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdJblBsYWNlQWJzdHJhY3RTdGF0ZS5j cHAKaW5kZXggZmVmZjRlYmYxYTI0NDgxOTMxNGFjMzY4MjU0ZGM0NDEzY2VjMmY4OC4uN2IwYmI3 NmZkMDczOTJiODljNzAyYmU3MWY5ODUzMjY2Y2ZlYzQ0ZiAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdJblBsYWNlQWJzdHJhY3RTdGF0ZS5jcHAKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdJblBsYWNlQWJzdHJhY3RTdGF0ZS5jcHAKQEAgLTYyLDEw ICs2Miw4IEBAIHZvaWQgSW5QbGFjZUFic3RyYWN0U3RhdGU6OmJlZ2luQmFzaWNCbG9jayhCYXNp Y0Jsb2NrKiBiYXNpY0Jsb2NrKQogICAgIG1fdmFyaWFibGVzID0gYmFzaWNCbG9jay0+dmFsdWVz QXRIZWFkOwogICAgIAogICAgIGlmIChtX2dyYXBoLm1fZm9ybSA9PSBTU0EpIHsKLSAgICAgICAg SGFzaE1hcDxOb2RlKiwgQWJzdHJhY3RWYWx1ZT46Oml0ZXJhdG9yIGl0ZXIgPSBiYXNpY0Jsb2Nr LT5zc2EtPnZhbHVlc0F0SGVhZC5iZWdpbigpOwotICAgICAgICBIYXNoTWFwPE5vZGUqLCBBYnN0 cmFjdFZhbHVlPjo6aXRlcmF0b3IgZW5kID0gYmFzaWNCbG9jay0+c3NhLT52YWx1ZXNBdEhlYWQu ZW5kKCk7Ci0gICAgICAgIGZvciAoOyBpdGVyICE9IGVuZDsgKytpdGVyKQotICAgICAgICAgICAg Zm9yTm9kZShpdGVyLT5rZXkpID0gaXRlci0+dmFsdWU7CisgICAgICAgIGZvciAoYXV0byYgaXRl ciA6IGJhc2ljQmxvY2stPnNzYS0+dmFsdWVzQXRIZWFkKQorICAgICAgICAgICAgZm9yTm9kZShp dGVyLmtleSkgPSBpdGVyLnZhbHVlOwogICAgIH0KICAgICBiYXNpY0Jsb2NrLT5jZmFTaG91bGRS ZXZpc2l0ID0gZmFsc2U7CiAgICAgYmFzaWNCbG9jay0+Y2ZhSGFzVmlzaXRlZCA9IHRydWU7CkBA IC0zMDAsMTcgKzI5OCwxNiBAQCBib29sIEluUGxhY2VBYnN0cmFjdFN0YXRlOjptZXJnZShCYXNp Y0Jsb2NrKiBmcm9tLCBCYXNpY0Jsb2NrKiB0bykKICAgICBjYXNlIFNTQTogewogICAgICAgICBm b3IgKHNpemVfdCBpID0gZnJvbS0+dmFsdWVzQXRUYWlsLnNpemUoKTsgaS0tOykKICAgICAgICAg ICAgIGNoYW5nZWQgfD0gdG8tPnZhbHVlc0F0SGVhZFtpXS5tZXJnZShmcm9tLT52YWx1ZXNBdFRh aWxbaV0pOwotICAgICAgICAKLSAgICAgICAgSGFzaFNldDxOb2RlKj46Oml0ZXJhdG9yIGl0ZXIg PSB0by0+c3NhLT5saXZlQXRIZWFkLmJlZ2luKCk7Ci0gICAgICAgIEhhc2hTZXQ8Tm9kZSo+Ojpp dGVyYXRvciBlbmQgPSB0by0+c3NhLT5saXZlQXRIZWFkLmVuZCgpOwotICAgICAgICBmb3IgKDsg aXRlciAhPSBlbmQ7ICsraXRlcikgewotICAgICAgICAgICAgTm9kZSogbm9kZSA9ICppdGVyOwor CisgICAgICAgIGZvciAoYXV0byYgdmFsdWVBdEhlYWRJdGVyYXRvciA6IHRvLT5zc2EtPnZhbHVl c0F0SGVhZCkgeworICAgICAgICAgICAgTm9kZSogbm9kZSA9IHZhbHVlQXRIZWFkSXRlcmF0b3Iu a2V5OwogICAgICAgICAgICAgaWYgKHZlcmJvc2UpCi0gICAgICAgICAgICAgICAgZGF0YUxvZygi ICAgICAgTWVyZ2luZyBmb3IgIiwgbm9kZSwgIjogZnJvbSAiLCBmcm9tLT5zc2EtPnZhbHVlc0F0 VGFpbC5maW5kKG5vZGUpLT52YWx1ZSwgIiB0byAiLCB0by0+c3NhLT52YWx1ZXNBdEhlYWQuZmlu ZChub2RlKS0+dmFsdWUsICJcbiIpOwotICAgICAgICAgICAgY2hhbmdlZCB8PSB0by0+c3NhLT52 YWx1ZXNBdEhlYWQuZmluZChub2RlKS0+dmFsdWUubWVyZ2UoCisgICAgICAgICAgICAgICAgZGF0 YUxvZygiICAgICAgTWVyZ2luZyBmb3IgIiwgbm9kZSwgIjogZnJvbSAiLCBmcm9tLT5zc2EtPnZh bHVlc0F0VGFpbC5maW5kKG5vZGUpLT52YWx1ZSwgIiB0byAiLCB2YWx1ZUF0SGVhZEl0ZXJhdG9y LnZhbHVlLCAiXG4iKTsKKyAgICAgICAgICAgIGNoYW5nZWQgfD0gdmFsdWVBdEhlYWRJdGVyYXRv ci52YWx1ZS5tZXJnZSgKICAgICAgICAgICAgICAgICBmcm9tLT5zc2EtPnZhbHVlc0F0VGFpbC5m aW5kKG5vZGUpLT52YWx1ZSk7CisKICAgICAgICAgICAgIGlmICh2ZXJib3NlKQotICAgICAgICAg ICAgICAgIGRhdGFMb2coIiAgICAgICAgIFJlc3VsdDogIiwgdG8tPnNzYS0+dmFsdWVzQXRIZWFk LmZpbmQobm9kZSktPnZhbHVlLCAiXG4iKTsKKyAgICAgICAgICAgICAgICBkYXRhTG9nKCIgICAg ICAgICBSZXN1bHQ6ICIsIHZhbHVlQXRIZWFkSXRlcmF0b3IudmFsdWUsICJcbiIpOwogICAgICAg ICB9CiAgICAgICAgIGJyZWFrOwogICAgIH0K 273265 2016-03-07 20:57:24 -0800 2016-03-07 21:56:42 -0800 Patch for landing bug-155152-20160307205710.patch text/plain 3302 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3NzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl ZTNiZjJkYjkyMjM4ZDM1MDdkNDIzZWIzZDVhMDZiZTEzOTM1MzAyLi5lOGYzY2MyYmRlZDMxYjQ0 NDhkYWI3ODk2NzU1MzY2YzA3NmQ5OTA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNi0wMy0wNyAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBbSlNDXSBTbWFsbCBjbGVhbiB1cCBvZiBob3cgd2UgdXNlIFNTQSdz IHZhbHVlc0F0SGVhZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTU1MTUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRmlsaXAgUGl6bG8uCisKKyAgICAg ICAgbGl2ZUF0SGVhZCBhbmQgdmFsdWVzQXRIZWFkIGNvbnRhaW4gdGhlIHNhbWUgbm9kZXMsCisg ICAgICAgIHdlIGRvIG5vdCBuZWVkIHRoZSBleHRyYSBsb29rIHVwLgorCisgICAgICAgIFRoaXMg YWxzbyBvcGVucyB0aGUgd2F5IHRvIHVzZSB0aGUgc2FtZSBraW5kIG9mIGxpdmVuZXNzCisgICAg ICAgIGFuYWx5c2lzIGFzIEFpciAod2hlcmUgbGl2ZSB2YWx1ZXMgYXQgaGVhZCBkbyBub3QgdXNl IGEgc2V0KS4KKworICAgICAgICAqIGRmZy9ERkdJblBsYWNlQWJzdHJhY3RTdGF0ZS5jcHA6Cisg ICAgICAgIChKU0M6OkRGRzo6SW5QbGFjZUFic3RyYWN0U3RhdGU6OmJlZ2luQmFzaWNCbG9jayk6 CisgICAgICAgIChKU0M6OkRGRzo6SW5QbGFjZUFic3RyYWN0U3RhdGU6Om1lcmdlKToKKwogMjAx Ni0wMy0wNyAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5z cGVjdG9yOiB0aGUgcHJvdG9jb2wgZ2VuZXJhdG9yIHNob3VsZCBnZW5lcmF0ZSBmYWN0b3J5IG1l dGhvZCBzdHVicyBmb3IgcHJvdG9jb2wgdHlwZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHSW5QbGFjZUFic3RyYWN0U3RhdGUuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdJblBsYWNlQWJzdHJhY3RTdGF0ZS5jcHAKaW5kZXggZmVmZjRlYmYxYTI0 NDgxOTMxNGFjMzY4MjU0ZGM0NDEzY2VjMmY4OC4uZTVkODhkMmQ1OWZjZWQ0OGZkNzQwZTdiMjdj ODZiZTI0M2Q2MTg4NSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdJ blBsYWNlQWJzdHJhY3RTdGF0ZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdJblBsYWNlQWJzdHJhY3RTdGF0ZS5jcHAKQEAgLTYyLDEwICs2Miw4IEBAIHZvaWQgSW5QbGFj ZUFic3RyYWN0U3RhdGU6OmJlZ2luQmFzaWNCbG9jayhCYXNpY0Jsb2NrKiBiYXNpY0Jsb2NrKQog ICAgIG1fdmFyaWFibGVzID0gYmFzaWNCbG9jay0+dmFsdWVzQXRIZWFkOwogICAgIAogICAgIGlm IChtX2dyYXBoLm1fZm9ybSA9PSBTU0EpIHsKLSAgICAgICAgSGFzaE1hcDxOb2RlKiwgQWJzdHJh Y3RWYWx1ZT46Oml0ZXJhdG9yIGl0ZXIgPSBiYXNpY0Jsb2NrLT5zc2EtPnZhbHVlc0F0SGVhZC5i ZWdpbigpOwotICAgICAgICBIYXNoTWFwPE5vZGUqLCBBYnN0cmFjdFZhbHVlPjo6aXRlcmF0b3Ig ZW5kID0gYmFzaWNCbG9jay0+c3NhLT52YWx1ZXNBdEhlYWQuZW5kKCk7Ci0gICAgICAgIGZvciAo OyBpdGVyICE9IGVuZDsgKytpdGVyKQotICAgICAgICAgICAgZm9yTm9kZShpdGVyLT5rZXkpID0g aXRlci0+dmFsdWU7CisgICAgICAgIGZvciAoYXV0byYgZW50cnkgOiBiYXNpY0Jsb2NrLT5zc2Et PnZhbHVlc0F0SGVhZCkKKyAgICAgICAgICAgIGZvck5vZGUoZW50cnkua2V5KSA9IGVudHJ5LnZh bHVlOwogICAgIH0KICAgICBiYXNpY0Jsb2NrLT5jZmFTaG91bGRSZXZpc2l0ID0gZmFsc2U7CiAg ICAgYmFzaWNCbG9jay0+Y2ZhSGFzVmlzaXRlZCA9IHRydWU7CkBAIC0zMDAsMTcgKzI5OCwxNiBA QCBib29sIEluUGxhY2VBYnN0cmFjdFN0YXRlOjptZXJnZShCYXNpY0Jsb2NrKiBmcm9tLCBCYXNp Y0Jsb2NrKiB0bykKICAgICBjYXNlIFNTQTogewogICAgICAgICBmb3IgKHNpemVfdCBpID0gZnJv bS0+dmFsdWVzQXRUYWlsLnNpemUoKTsgaS0tOykKICAgICAgICAgICAgIGNoYW5nZWQgfD0gdG8t PnZhbHVlc0F0SGVhZFtpXS5tZXJnZShmcm9tLT52YWx1ZXNBdFRhaWxbaV0pOwotICAgICAgICAK LSAgICAgICAgSGFzaFNldDxOb2RlKj46Oml0ZXJhdG9yIGl0ZXIgPSB0by0+c3NhLT5saXZlQXRI ZWFkLmJlZ2luKCk7Ci0gICAgICAgIEhhc2hTZXQ8Tm9kZSo+OjppdGVyYXRvciBlbmQgPSB0by0+ c3NhLT5saXZlQXRIZWFkLmVuZCgpOwotICAgICAgICBmb3IgKDsgaXRlciAhPSBlbmQ7ICsraXRl cikgewotICAgICAgICAgICAgTm9kZSogbm9kZSA9ICppdGVyOworCisgICAgICAgIGZvciAoYXV0 byYgZW50cnkgOiB0by0+c3NhLT52YWx1ZXNBdEhlYWQpIHsKKyAgICAgICAgICAgIE5vZGUqIG5v ZGUgPSBlbnRyeS5rZXk7CiAgICAgICAgICAgICBpZiAodmVyYm9zZSkKLSAgICAgICAgICAgICAg ICBkYXRhTG9nKCIgICAgICBNZXJnaW5nIGZvciAiLCBub2RlLCAiOiBmcm9tICIsIGZyb20tPnNz YS0+dmFsdWVzQXRUYWlsLmZpbmQobm9kZSktPnZhbHVlLCAiIHRvICIsIHRvLT5zc2EtPnZhbHVl c0F0SGVhZC5maW5kKG5vZGUpLT52YWx1ZSwgIlxuIik7Ci0gICAgICAgICAgICBjaGFuZ2VkIHw9 IHRvLT5zc2EtPnZhbHVlc0F0SGVhZC5maW5kKG5vZGUpLT52YWx1ZS5tZXJnZSgKKyAgICAgICAg ICAgICAgICBkYXRhTG9nKCIgICAgICBNZXJnaW5nIGZvciAiLCBub2RlLCAiOiBmcm9tICIsIGZy b20tPnNzYS0+dmFsdWVzQXRUYWlsLmZpbmQobm9kZSktPnZhbHVlLCAiIHRvICIsIGVudHJ5LnZh bHVlLCAiXG4iKTsKKyAgICAgICAgICAgIGNoYW5nZWQgfD0gZW50cnkudmFsdWUubWVyZ2UoCiAg ICAgICAgICAgICAgICAgZnJvbS0+c3NhLT52YWx1ZXNBdFRhaWwuZmluZChub2RlKS0+dmFsdWUp OworCiAgICAgICAgICAgICBpZiAodmVyYm9zZSkKLSAgICAgICAgICAgICAgICBkYXRhTG9nKCIg ICAgICAgICBSZXN1bHQ6ICIsIHRvLT5zc2EtPnZhbHVlc0F0SGVhZC5maW5kKG5vZGUpLT52YWx1 ZSwgIlxuIik7CisgICAgICAgICAgICAgICAgZGF0YUxvZygiICAgICAgICAgUmVzdWx0OiAiLCBl bnRyeS52YWx1ZSwgIlxuIik7CiAgICAgICAgIH0KICAgICAgICAgYnJlYWs7CiAgICAgfQo=