155137 2016-03-07 14:41:11 -0800 Always call NSURLSession completion handlers 2016-03-10 17:15:21 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen bfulgham commit-queue oldest_to_newest 1171763 0 achristensen 2016-03-07 14:41:11 -0800 Always call NSURLSession completion handlers 1171781 1 273219 achristensen 2016-03-07 15:01:34 -0800 Created attachment 273219 Patch 1172039 2 273219 bfulgham 2016-03-08 08:51:26 -0800 Comment on attachment 273219 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273219&action=review This seems fine. r=me. > Source/WebKit2/ChangeLog:10 > + There are also a few release asserts that do not need to crash release builds. So is this patch just about protecting against a possible problem we could encounter? 1172041 3 bfulgham 2016-03-08 08:52:06 -0800 (In reply to comment #2) > Comment on attachment 273219 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=273219&action=review > > This seems fine. r=me. I mean, NOT r=me. You need a WK2 owner. Sorry! (But it seems fine). 1172079 4 273219 achristensen 2016-03-08 10:18:07 -0800 Comment on attachment 273219 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273219&action=review >> Source/WebKit2/ChangeLog:10 >> + There are also a few release asserts that do not need to crash release builds. > > So is this patch just about protecting against a possible problem we could encounter? yep 1172333 5 273219 darin 2016-03-08 18:08:59 -0800 Comment on attachment 273219 Patch I do not understand the status of these ASSERT_NOT_REACHED. Will we ever reach these? If so, why? 1172602 6 achristensen 2016-03-09 10:17:26 -0800 (In reply to comment #5) > Comment on attachment 273219 [details] > Patch > > I do not understand the status of these ASSERT_NOT_REACHED. Will we ever > reach these? If so, why? We should not reach any of these assertions because once we are doing loading, a session with the given SessionID has already been made in the SessionTracker. If something goes horribly wrong and we are, for example, finishing loading after we have destroyed a session, then these do not need to crash release builds because the only effect might be that we do some loads without credentials. 1172623 7 273219 commit-queue 2016-03-09 11:03:56 -0800 Comment on attachment 273219 Patch Clearing flags on attachment: 273219 Committed r197865: <http://trac.webkit.org/changeset/197865> 1172624 8 commit-queue 2016-03-09 11:03:59 -0800 All reviewed patches have been landed. Closing bug. 1173409 9 achristensen 2016-03-10 15:54:56 -0800 removed an assertion in r197965 1173480 10 achristensen 2016-03-10 17:15:21 -0800 When a load is redirected to a url that we do not like, we call the willPerformHTTPRedirection completion handler with nil in NetworkLoad::continueWillSendRequest just after the NetworkLoad and NetworkDataTask are destroyed by the call to didFail. When this happens, we get a didReceiveResponse delegate callback for the url that was redirected from, which no longer corresponds to a NetworkDataTask that exists any more in case the 301 response had content that we wanted, but in WebKit we never use that content, so we are correctly calling the completion handler with NSURLSessionResponseCancel. This happens in several tests, including http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html 273219 2016-03-07 15:01:34 -0800 2016-03-09 11:03:56 -0800 Patch bug-155137-20160307150121.patch text/plain 5692 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NzcwNykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDE2LTAzLTA3ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWx3YXlzIGNh bGwgTlNVUkxTZXNzaW9uIGNvbXBsZXRpb24gaGFuZGxlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTEzNworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGFyZSBzb21lIGVkZ2UgY2FzZXMgd2hp Y2ggc2hvdWxkIG5vdCBiZSBoaXQsIGJ1dCBpZiB0aGV5IGFyZSB0aGV5IHdvdWxkIGNhdXNlIHRo ZQorICAgICAgICBuZXR3b3JrIHByb2Nlc3MgdG8gaGFuZyBhbmQgbmV0d29yayByZXNvdXJjZXMg dG8gYmUgbGVha2VkLiAgVGhpcyBjYW4gYmUgYXZvaWRlZC4KKyAgICAgICAgVGhlcmUgYXJlIGFs c28gYSBmZXcgcmVsZWFzZSBhc3NlcnRzIHRoYXQgZG8gbm90IG5lZWQgdG8gY3Jhc2ggcmVsZWFz ZSBidWlsZHMuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrRGF0YVRh c2tDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0RhdGFUYXNrOjpOZXR3b3JrRGF0 YVRhc2spOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrRGF0YVRhc2s6OmRpZFJlY2VpdmVDaGFs bGVuZ2UpOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrRGF0YVRhc2s6OmRpZENvbXBsZXRlV2l0 aEVycm9yKToKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0RhdGFUYXNrOjpkaWRSZWNlaXZlUmVz cG9uc2UpOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrRGF0YVRhc2s6OmRpZFJlY2VpdmVEYXRh KToKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0RhdGFUYXNrOjp3aWxsUGVyZm9ybUhUVFBSZWRp cmVjdGlvbik6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtEYXRhVGFzazo6c2NoZWR1bGVGYWls dXJlKToKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0RhdGFUYXNrOjp0cnlQYXNzd29yZEJhc2Vk QXV0aGVudGljYXRpb24pOgorICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtT ZXNzaW9uQ29jb2EubW06CisgICAgICAgICgtW1dLTmV0d29ya1Nlc3Npb25EZWxlZ2F0ZSBVUkxT ZXNzaW9uOnRhc2s6d2lsbFBlcmZvcm1IVFRQUmVkaXJlY3Rpb246bmV3UmVxdWVzdDpjb21wbGV0 aW9uSGFuZGxlcjpdKToKKyAgICAgICAgKC1bV0tOZXR3b3JrU2Vzc2lvbkRlbGVnYXRlIFVSTFNl c3Npb246dGFzazpkaWRSZWNlaXZlQ2hhbGxlbmdlOmNvbXBsZXRpb25IYW5kbGVyOl0pOgorICAg ICAgICAoLVtXS05ldHdvcmtTZXNzaW9uRGVsZWdhdGUgVVJMU2Vzc2lvbjpkYXRhVGFzazpkaWRS ZWNlaXZlUmVzcG9uc2U6Y29tcGxldGlvbkhhbmRsZXI6XSk6CisKIDIwMTYtMDMtMDcgIERhbmll bCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIENsZWFudXA6IEFkZCBjb252 ZW5pZW5jZSBmdW5jdGlvbiBVUkw6OnByb2NvdG9sSXNCbG9iKCkKSW5kZXg6IFNvdXJjZS9XZWJL aXQyL05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0NvY29hLm1tCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFz a0NvY29hLm1tCShyZXZpc2lvbiAxOTc3MDUpCisrKyBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJv Y2Vzcy9jb2NvYS9OZXR3b3JrRGF0YVRhc2tDb2NvYS5tbQkod29ya2luZyBjb3B5KQpAQCAtODUs NyArODUsNyBAQCBOZXR3b3JrRGF0YVRhc2s6Ok5ldHdvcmtEYXRhVGFzayhOZXR3b3JrCiAgICAg ICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICAgc3RvcmFnZVNlc3Npb24tPmNyZWRlbnRpYWxT dG9yYWdlKCkuc2V0KFdlYkNvcmU6OkNyZWRlbnRpYWwobV91c2VyLCBtX3Bhc3N3b3JkLCBXZWJD b3JlOjpDcmVkZW50aWFsUGVyc2lzdGVuY2VOb25lKSwgdXJsKTsKICAgICAgICAgfSBlbHNlCi0g ICAgICAgICAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICAgICAgQVNT RVJUX05PVF9SRUFDSEVEKCk7CiAjZW5kaWYKICAgICB9CiAKQEAgLTE1NCw2ICsxNTQsMTAgQEAg dm9pZCBOZXR3b3JrRGF0YVRhc2s6OmRpZFJlY2VpdmVDaGFsbGVuZwogCiAgICAgaWYgKG1fY2xp ZW50KQogICAgICAgICBtX2NsaWVudC0+ZGlkUmVjZWl2ZUNoYWxsZW5nZShjaGFsbGVuZ2UsIGNv bXBsZXRpb25IYW5kbGVyKTsKKyAgICBlbHNlIHsKKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVE KCk7CisgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlRGlz cG9zaXRpb246OlBlcmZvcm1EZWZhdWx0SGFuZGxpbmcsIHsgfSk7CisgICAgfQogfQogCiB2b2lk IE5ldHdvcmtEYXRhVGFzazo6ZGlkQ29tcGxldGVXaXRoRXJyb3IoY29uc3QgV2ViQ29yZTo6UmVz b3VyY2VFcnJvciYgZXJyb3IpCkBAIC0xNjYsNiArMTcwLDEwIEBAIHZvaWQgTmV0d29ya0RhdGFU YXNrOjpkaWRSZWNlaXZlUmVzcG9uc2UKIHsKICAgICBpZiAobV9jbGllbnQpCiAgICAgICAgIG1f Y2xpZW50LT5kaWRSZWNlaXZlUmVzcG9uc2VOZXR3b3JrU2Vzc2lvbihyZXNwb25zZSwgY29tcGxl dGlvbkhhbmRsZXIpOworICAgIGVsc2UgeworICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsK KyAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoV2ViQ29yZTo6UG9saWN5QWN0aW9uOjpQb2xpY3lJ Z25vcmUpOworICAgIH0KIH0KIAogdm9pZCBOZXR3b3JrRGF0YVRhc2s6OmRpZFJlY2VpdmVEYXRh KFJlZlB0cjxXZWJDb3JlOjpTaGFyZWRCdWZmZXI+JiYgZGF0YSkKQEAgLTIyMiwxMyArMjMwLDE3 IEBAIHZvaWQgTmV0d29ya0RhdGFUYXNrOjp3aWxsUGVyZm9ybUhUVFBSZWQKICAgICAgICAgICAg ICAgICAgICAgYXBwbHlCYXNpY0F1dGhvcml6YXRpb25IZWFkZXIocmVxdWVzdCwgbV9pbml0aWFs Q3JlZGVudGlhbCk7CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfSBlbHNlCi0gICAg ICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgICAgICAg ICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICAgICAgfQogI2VuZGlmCiAgICAgfQogICAgIAog ICAgIGlmIChtX2NsaWVudCkKICAgICAgICAgbV9jbGllbnQtPndpbGxQZXJmb3JtSFRUUFJlZGly ZWN0aW9uKHJlZGlyZWN0UmVzcG9uc2UsIHJlcXVlc3QsIGNvbXBsZXRpb25IYW5kbGVyKTsKKyAg ICBlbHNlIHsKKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgIGNvbXBsZXRp b25IYW5kbGVyKHsgfSk7CisgICAgfQogfQogICAgIAogdm9pZCBOZXR3b3JrRGF0YVRhc2s6OnNj aGVkdWxlRmFpbHVyZShGYWlsdXJlVHlwZSB0eXBlKQpAQCAtMzA3LDcgKzMxOSw3IEBAIGJvb2wg TmV0d29ya0RhdGFUYXNrOjp0cnlQYXNzd29yZEJhc2VkQXUKICAgICAgICAgICAgICAgICB9CiAg ICAgICAgICAgICB9CiAgICAgICAgIH0gZWxzZQotICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlRf Tk9UX1JFQUNIRUQoKTsKKyAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIH0K ICNlbmRpZgogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3 b3JrU2Vzc2lvbkNvY29hLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQ cm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0JKHJldmlzaW9uIDE5NzcwNSkKKysr IFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2Eu bW0JKHdvcmtpbmcgY29weSkKQEAgLTExMyw2ICsxMTMsOSBAQCAtICh2b2lkKVVSTFNlc3Npb246 KE5TVVJMU2Vzc2lvbiAqKXNlc3NpCiAgICAgICAgICAgICBjb21wbGV0aW9uSGFuZGxlckNvcHko cmVxdWVzdC5uc1VSTFJlcXVlc3QoV2ViQ29yZTo6VXBkYXRlSFRUUEJvZHkpKTsKICAgICAgICAg ICAgIEJsb2NrX3JlbGVhc2UoY29tcGxldGlvbkhhbmRsZXJDb3B5KTsKICAgICAgICAgfSk7Cisg ICAgfSBlbHNlIHsKKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgIGNvbXBs ZXRpb25IYW5kbGVyKG5pbCk7CiAgICAgfQogfQogCkBAIC0xMzcsNiArMTQwLDggQEAgLSAodm9p ZClVUkxTZXNzaW9uOihOU1VSTFNlc3Npb24gKilzZXNzaQogICAgICAgICAgICAgICAgICAgICB1 cmxUb1N0b3JlID0gYXV0aGVudGljYXRpb25DaGFsbGVuZ2UuZmFpbHVyZVJlc3BvbnNlKCkudXJs KCk7CiAgICAgICAgICAgICAgICAgaWYgKGF1dG8gc3RvcmFnZVNlc3Npb24gPSBXZWJLaXQ6OlNl c3Npb25UcmFja2VyOjpzdG9yYWdlU2Vzc2lvbihzZXNzaW9uSUQpKQogICAgICAgICAgICAgICAg ICAgICBzdG9yYWdlU2Vzc2lvbi0+Y3JlZGVudGlhbFN0b3JhZ2UoKS5zZXQobm9uUGVyc2lzdGVu dENyZWRlbnRpYWwsIGF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlLnByb3RlY3Rpb25TcGFjZSgpLCB1 cmxUb1N0b3JlKTsKKyAgICAgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgICAgIEFT U0VSVF9OT1RfUkVBQ0hFRCgpOwogCiAgICAgICAgICAgICAgICAgY29tcGxldGlvbkhhbmRsZXJD b3B5KHRvTlNVUkxTZXNzaW9uQXV0aENoYWxsZW5nZURpc3Bvc2l0aW9uKGRpc3Bvc2l0aW9uKSwg bm9uUGVyc2lzdGVudENyZWRlbnRpYWwubnNDcmVkZW50aWFsKCkpOwogICAgICAgICAgICAgfSBl bHNlCkBAIC0xNDUsNiArMTUwLDkgQEAgLSAodm9pZClVUkxTZXNzaW9uOihOU1VSTFNlc3Npb24g KilzZXNzaQogICAgICAgICAgICAgQmxvY2tfcmVsZWFzZShjb21wbGV0aW9uSGFuZGxlckNvcHkp OwogICAgICAgICB9OwogICAgICAgICBuZXR3b3JrRGF0YVRhc2stPmRpZFJlY2VpdmVDaGFsbGVu Z2UoY2hhbGxlbmdlLCBjaGFsbGVuZ2VDb21wbGV0aW9uSGFuZGxlcik7CisgICAgfSBlbHNlIHsK KyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgIGNvbXBsZXRpb25IYW5kbGVy KE5TVVJMU2Vzc2lvbkF1dGhDaGFsbGVuZ2VQZXJmb3JtRGVmYXVsdEhhbmRsaW5nLCBuaWwpOwog ICAgIH0KIH0KIApAQCAtMTgwLDYgKzE4OCw5IEBAIC0gKHZvaWQpVVJMU2Vzc2lvbjooTlNVUkxT ZXNzaW9uICopc2Vzc2kKICAgICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyQ29weSh0b05TVVJM U2Vzc2lvblJlc3BvbnNlRGlzcG9zaXRpb24ocG9saWN5QWN0aW9uKSk7CiAgICAgICAgICAgICBC bG9ja19yZWxlYXNlKGNvbXBsZXRpb25IYW5kbGVyQ29weSk7CiAgICAgICAgIH0pOworICAgIH0g ZWxzZSB7CisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICBjb21wbGV0aW9u SGFuZGxlcihOU1VSTFNlc3Npb25SZXNwb25zZUNhbmNlbCk7CiAgICAgfQogfQogCg==