155104 2016-03-07 00:28:40 -0800 [JSC] Improve and64() and or64() with immediate on x86 2016-03-11 14:03:17 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1171534 0 benjamin 2016-03-07 00:28:40 -0800 [JSC] Improve and64() and or64() with immediate on x86 1171535 1 273165 benjamin 2016-03-07 00:31:41 -0800 Created attachment 273165 Patch 1171619 2 273165 ggaren 2016-03-07 09:33:46 -0800 Comment on attachment 273165 Patch r=me 1171674 3 273165 commit-queue 2016-03-07 10:57:06 -0800 Comment on attachment 273165 Patch Clearing flags on attachment: 273165 Committed r197695: <http://trac.webkit.org/changeset/197695> 1171675 4 commit-queue 2016-03-07 10:57:09 -0800 All reviewed patches have been landed. Closing bug. 1173748 5 273165 darin 2016-03-11 09:37:05 -0800 Comment on attachment 273165 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273165&action=review > Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h:350 > + if (intValue <= std::numeric_limits<int32_t>::max() > + && intValue >= std::numeric_limits<int32_t>::min()) { Isn’t it more obvious to write it like this? if (intValue == static_cast<int32_t>(intValue)) 1173860 6 benjamin 2016-03-11 14:03:17 -0800 (In reply to comment #5) > Comment on attachment 273165 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=273165&action=review > > > Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h:350 > > + if (intValue <= std::numeric_limits<int32_t>::max() > > + && intValue >= std::numeric_limits<int32_t>::min()) { > > Isn’t it more obvious to write it like this? > > if (intValue == static_cast<int32_t>(intValue)) That's how I originally wrote it but I thought the more verbose version was making the intent more obvious. 273165 2016-03-07 00:31:41 -0800 2016-03-07 10:57:06 -0800 Patch bug-155104-20160307003127.patch text/plain 2597 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3NjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz MTc3MjgxYTNiMGIyYzBmMjgyYjRjNDVmZDRkZTk2ZjEwOWFiNjIwLi4wMTNkNTU5YzI3NmNjM2Ez ZDg5ZjViMjUzOGFmM2U2NjdhMmI2ZTExIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxNi0wMy0wNyAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW0pTQ10gSW1wcm92ZSBhbmQ2NCgpIGFuZCBvcjY0KCkgd2l0aCBp bW1lZGlhdGUgb24geDg2CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTUxMDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBHZXRCdXR0ZXJmbHlSZWFkT25seSB3YXMgZG9pbmc6CisgICAgICAgICAgICBtb3Zx IDB4OCglcmJ4KSwgJXI5CisgICAgICAgICAgICBtb3ZxICQweGZmZmZmZmZmZmZmZmZmZmMsICVy MTEKKyAgICAgICAgICAgIGFuZHEgJXIxMSwgJXI5CisgICAgICAgIFRoZXJlIGlzIG5vIG5lZWQg Zm9yIHRoZSBtb3ZlIHRvIGxvYWQgdGhlIGltbWVkaWF0ZSwKKyAgICAgICAgYW5kcSBzaWduIGV4 dGVuZCBpdHMgaW1tZWRpYXRlLgorCisgICAgICAgIFdpdGggdGhpcyBwYXRjaCwgd2UgaGF2ZToK KyAgICAgICAgICAgIG1vdnEgMHg4KCVyYngpLCAlcjkKKyAgICAgICAgICAgIGFuZHEgJDB4ZmZm ZmZmZmZmZmZmZmZmYywgJXI5CisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJY ODZfNjQuaDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJYODZfNjQ6OmFuZDY0KToKKyAg ICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJYODZfNjQ6Om9yNjQpOgorCiAyMDE2LTAzLTA2ICBC cmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHRo ZSBwcm90b2NvbCBnZW5lcmF0b3Igc2hvdWxkIGhhdmUgc2VwYXJhdGUgcHJlZml4IG9wdGlvbnMg Zm9yIE9iamVjdGl2ZS1DIGNsYXNzZXMgYW5kIGZpbGVuYW1lcwpkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclg4Nl82NC5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclg4Nl82NC5oCmluZGV4IDJk YTRiOWExYTU1MWI5Mzk0ODQ3NmQ2ZjQ0YTlkMDk0NjUzMzJlOWQuLjc3ODNkOTQwYWI2Mjk1Yzg2 M2NiMDBkYWRhYTBhNGE2MzNlYzgyMjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZfNjQuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyWDg2XzY0LmgKQEAgLTM0NSw2ICszNDUsMTIg QEAgcHVibGljOgogCiAgICAgdm9pZCBhbmQ2NChUcnVzdGVkSW1tUHRyIGltbSwgUmVnaXN0ZXJJ RCBzcmNEZXN0KQogICAgIHsKKyAgICAgICAgaW50cHRyX3QgaW50VmFsdWUgPSBpbW0uYXNJbnRw dHIoKTsKKyAgICAgICAgaWYgKGludFZhbHVlIDw9IHN0ZDo6bnVtZXJpY19saW1pdHM8aW50MzJf dD46Om1heCgpCisgICAgICAgICAgICAmJiBpbnRWYWx1ZSA+PSBzdGQ6Om51bWVyaWNfbGltaXRz PGludDMyX3Q+OjptaW4oKSkgeworICAgICAgICAgICAgYW5kNjQoVHJ1c3RlZEltbTMyKHN0YXRp Y19jYXN0PGludDMyX3Q+KGludFZhbHVlKSksIHNyY0Rlc3QpOworICAgICAgICAgICAgcmV0dXJu OworICAgICAgICB9CiAgICAgICAgIG1vdmUoaW1tLCBzY3JhdGNoUmVnaXN0ZXIoKSk7CiAgICAg ICAgIGFuZDY0KHNjcmF0Y2hSZWdpc3RlcigpLCBzcmNEZXN0KTsKICAgICB9CkBAIC00ODcsMTAg KzQ5MywxNSBAQCBwdWJsaWM6CiAgICAgICAgIG1fYXNzZW1ibGVyLm9ycV9ycihzcmMsIGRlc3Qp OwogICAgIH0KIAotICAgIHZvaWQgb3I2NChUcnVzdGVkSW1tNjQgaW1tLCBSZWdpc3RlcklEIGRl c3QpCisgICAgdm9pZCBvcjY0KFRydXN0ZWRJbW02NCBpbW0sIFJlZ2lzdGVySUQgc3JjRGVzdCkK ICAgICB7CisgICAgICAgIGlmIChpbW0ubV92YWx1ZSA8PSBzdGQ6Om51bWVyaWNfbGltaXRzPGlu dDMyX3Q+OjptYXgoKQorICAgICAgICAgICAgJiYgaW1tLm1fdmFsdWUgPj0gc3RkOjpudW1lcmlj X2xpbWl0czxpbnQzMl90Pjo6bWluKCkpIHsKKyAgICAgICAgICAgIG9yNjQoVHJ1c3RlZEltbTMy KHN0YXRpY19jYXN0PGludDMyX3Q+KGltbS5tX3ZhbHVlKSksIHNyY0Rlc3QpOworICAgICAgICAg ICAgcmV0dXJuOworICAgICAgICB9CiAgICAgICAgIG1vdmUoaW1tLCBzY3JhdGNoUmVnaXN0ZXIo KSk7Ci0gICAgICAgIG9yNjQoc2NyYXRjaFJlZ2lzdGVyKCksIGRlc3QpOworICAgICAgICBvcjY0 KHNjcmF0Y2hSZWdpc3RlcigpLCBzcmNEZXN0KTsKICAgICB9CiAKICAgICB2b2lkIG9yNjQoVHJ1 c3RlZEltbTMyIGltbSwgUmVnaXN0ZXJJRCBkZXN0KQo=