155084 2016-03-05 20:50:54 -0800 Create a DOMHTMLVideoElement when wrapping <video> elements 2016-03-18 08:42:30 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton achristensen andersca mitz ossy sam simon.fraser webkit-bug-importer oldest_to_newest 1171377 0 thorton 2016-03-05 20:50:54 -0800 Create a DOMHTMLVideoElement when wrapping <video> elements 1171378 1 273124 thorton 2016-03-05 20:51:26 -0800 Created attachment 273124 Patch 1171379 2 webkit-bug-importer 2016-03-05 20:53:01 -0800 <rdar://problem/24997193> 1171380 3 273124 mitz 2016-03-05 20:53:19 -0800 Comment on attachment 273124 Patch This seems API-testable 1171381 4 thorton 2016-03-05 20:55:17 -0800 Sure, I suppose it is. 1171382 5 thorton 2016-03-05 21:02:55 -0800 http://trac.webkit.org/changeset/197633 1171723 6 ossy 2016-03-07 13:33:56 -0800 (In reply to comment #5) > http://trac.webkit.org/changeset/197633 It broke the Apple Mac cmake build: /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/bindings/objc/DOM.mm:36:9: fatal error: 'DOMHTMLVideoElement.h' file not found #import "DOMHTMLVideoElement.h" ^ 1172817 7 achristensen 2016-03-09 15:33:49 -0800 r197892 should fix that. 1173109 8 ossy 2016-03-10 09:03:56 -0800 (In reply to comment #7) > r197892 should fix that. No, it didn't fix. /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/bindings/objc/DOM.mm:59:9: fatal error: 'DOMHTMLVideoElement.h' file not found #import "DOMHTMLVideoElement.h" ^ 1 error generated. 1176104 9 ossy 2016-03-18 00:55:01 -0700 (In reply to comment #8) > (In reply to comment #7) > > r197892 should fix that. > > No, it didn't fix. > > /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/bindings/objc/ > DOM.mm:59:9: fatal error: 'DOMHTMLVideoElement.h' file not found > #import "DOMHTMLVideoElement.h" > ^ > 1 error generated. Still broken due to this error. 1176154 10 ossy 2016-03-18 06:47:57 -0700 one more fix landed in http://trac.webkit.org/changeset/198397, but the build is still broken: In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/bindings/objc/DOM.mm:59: /Volumes/Data/slave/elcapitan-cmake-debug/build/WebKitBuild/Debug/DerivedSources/WebCore/DOMHTMLVideoElement.h:27:9: fatal error: 'WebCore/DOMHTMLMediaElement.h' file not found #import <WebCore/DOMHTMLMediaElement.h> ^ 1 error generated. 1176167 11 ossy 2016-03-18 08:06:01 -0700 (In reply to comment #10) > one more fix landed in http://trac.webkit.org/changeset/198397, > but the build is still broken: > > In file included from > /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/bindings/objc/ > DOM.mm:59: > /Volumes/Data/slave/elcapitan-cmake-debug/build/WebKitBuild/Debug/ > DerivedSources/WebCore/DOMHTMLVideoElement.h:27:9: fatal error: > 'WebCore/DOMHTMLMediaElement.h' file not found > #import <WebCore/DOMHTMLMediaElement.h> > ^ > 1 error generated. More fixes landed in - http://trac.webkit.org/changeset/198398 - http://trac.webkit.org/changeset/198400 but the build is still broken ... 1176172 12 ossy 2016-03-18 08:42:30 -0700 more fixes landed: - http://trac.webkit.org/changeset/198401 - http://trac.webkit.org/changeset/198402 - http://trac.webkit.org/changeset/198405 273124 2016-03-05 20:51:26 -0800 2016-03-05 20:53:19 -0800 Patch bug-155084-20160305205112.patch text/plain 1684 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3NjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmQxZjZlYjkxMmI0NDVi YjZkYzIzOTYxMzFjYjlkMzdiYzQ2ODM2MC4uZjk1MDViNDJjNWY3OTY2NGRjMDUzZGRlMGZlMDY3 ZmYzMGNmMDkyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTAzLTA1ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIENyZWF0ZSBhIERP TUhUTUxWaWRlb0VsZW1lbnQgd2hlbiB3cmFwcGluZyA8dmlkZW8+IGVsZW1lbnRzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTUwODQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL29iamMv RE9NLm1tOgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlRWxlbWVudENsYXNzTWFwKToKKyAgICAg ICAgQWRkIDx2aWRlbz4gdG8gdGhlIG1hcHBpbmcuCisKIDIwMTYtMDMtMDUgIEpvYW5tYXJpZSBE aWdncyAgPGpkaWdnc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIEFYOiBJbXBsZW1lbnQgbWlzc2lu Zy9kaWZmZXJlbnQgYWNjZXNzaWJpbGl0eSBBUEkgbWFwcGluZ3MgZm9yIFNWRwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvb2JqYy9ET00ubW0gYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9vYmpjL0RPTS5tbQppbmRleCA2ODZkZTc1YTU1ZjZlNGUyMmNkYjIxN2JjNTYwM2Jm M2FjOWZiMjJmLi40N2ZhZDZkOWM3YWEyNjFmNjk5YTI1ZjI2Y2M4MDFiNGVhZWU3ZjBlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9vYmpjL0RPTS5tbQorKysgYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9vYmpjL0RPTS5tbQpAQCAtMzMsNiArMzMsNyBAQAogI2ltcG9ydCAi RE9NRWxlbWVudEludGVybmFsLmgiCiAjaW1wb3J0ICJET01IVE1MQ2FudmFzRWxlbWVudC5oIgog I2ltcG9ydCAiRE9NSFRNTFRhYmxlQ2VsbEVsZW1lbnRJbnRlcm5hbC5oIgorI2ltcG9ydCAiRE9N SFRNTFZpZGVvRWxlbWVudC5oIgogI2ltcG9ydCAiRE9NTm9kZUludGVybmFsLmgiCiAjaW1wb3J0 ICJET01Qcml2YXRlLmgiCiAjaW1wb3J0ICJET01SYW5nZUludGVybmFsLmgiCkBAIC0xNjMsNiAr MTY0LDkgQEAgc3RhdGljIHZvaWQgY3JlYXRlRWxlbWVudENsYXNzTWFwKCkKICAgICBhZGRFbGVt ZW50Q2xhc3MoSFRNTE5hbWVzOjp0aXRsZVRhZywgW0RPTUhUTUxUaXRsZUVsZW1lbnQgY2xhc3Nd KTsKICAgICBhZGRFbGVtZW50Q2xhc3MoSFRNTE5hbWVzOjp0clRhZywgW0RPTUhUTUxUYWJsZVJv d0VsZW1lbnQgY2xhc3NdKTsKICAgICBhZGRFbGVtZW50Q2xhc3MoSFRNTE5hbWVzOjp1bFRhZywg W0RPTUhUTUxVTGlzdEVsZW1lbnQgY2xhc3NdKTsKKyNpZiBFTkFCTEUoVklERU8pCisgICAgYWRk RWxlbWVudENsYXNzKEhUTUxOYW1lczo6dmlkZW9UYWcsIFtET01IVE1MVmlkZW9FbGVtZW50IGNs YXNzXSk7CisjZW5kaWYKICAgICBhZGRFbGVtZW50Q2xhc3MoSFRNTE5hbWVzOjp4bXBUYWcsIFtE T01IVE1MUHJlRWxlbWVudCBjbGFzc10pOwogfQogCg==