155073 2016-03-05 16:13:32 -0800 [GTK][EFL] Disable subtle-crypto in FeatureList.pm 2016-06-28 07:10:55 -0700 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=155008 P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply cgarcia clopez dbates elima gyuyoung.kim mcatanzaro mrobinson oldest_to_newest 1171299 0 mcatanzaro 2016-03-05 16:13:32 -0800 Nobody is working on it and nobody has further plans to work on it. This would have caught a build failure when we perhaps inadvertently added a required dependency on GnuTLS in r197575. 1171300 1 273106 mcatanzaro 2016-03-05 16:14:38 -0800 Created attachment 273106 Patch 1171312 2 mcatanzaro 2016-03-05 16:55:50 -0800 By the way, it's failing EWS due to bug #155008; just ignore that, I will push an unreviewed build fix. 1171364 3 273106 dbates 2016-03-05 19:50:10 -0800 Comment on attachment 273106 Patch OK 1205846 4 mcatanzaro 2016-06-27 19:47:43 -0700 Committed r202535: <http://trac.webkit.org/changeset/202535> 1205848 5 clopez 2016-06-27 19:53:09 -0700 Please skip crypto/subtle layout tests (they were passing until now) 1205881 6 cgarcia 2016-06-27 22:41:35 -0700 (In reply to comment #5) > Please skip crypto/subtle layout tests (they were passing until now) Wait, why are we disabling a feature that is, at least partially, working? How do you know *nobody* is interested in this? If we disable this, and whatever is currently working breaks we will not notice it. Of course we can disable on production builds. 1205996 7 clopez 2016-06-28 03:47:32 -0700 (In reply to comment #6) > (In reply to comment #5) > > Please skip crypto/subtle layout tests (they were passing until now) > > Wait, why are we disabling a feature that is, at least partially, working? > How do you know *nobody* is interested in this? If we disable this, and > whatever is currently working breaks we will not notice it. Of course we can > disable on production builds. It was already disabled on production builds. It only was enabled on developer ones. FWIW: I agree with turning on this feature back on developer builds. Otherwise development of this feature is going to be more complicated than necessary. 1206020 8 mcatanzaro 2016-06-28 06:59:28 -0700 I disabled this feature because the difference in having it enabled on the bots and having it disabled in production builds led to a change that broke production builds without tripping the bots. It's better that we keep the build flags we use in development builds similar to those we use in production builds, except for a few features that are under active development, so that we have the same set of bugs. I'll skip the layout tests, thanks for noticing. (In reply to comment #6) > Wait, why are we disabling a feature that is, at least partially, working? Because the primary developer has moved on to another project, and nobody else has shown any interest in working on it since then. > How do you know *nobody* is interested in this? I have not seen any progress in it since I started working on WebKit. It's not on my to-do list, and probably not on yours either, and I'm not expecting a new contributor to materialize from nowhere with patches, and I'm not expecting Igalia to invest in it. So.... A lot of people are interested in the feature working, just nobody seems to be currently interested in working on implementing it. If anybody starts to actually work on it, we can turn it back on. > If we disable this, and > whatever is currently working breaks we will not notice it. I honestly don't care if some feature we don't have enabled breaks. I'd actually rather we did not notice, because this feature is never going to be enabled at the current rate, so it's a waste of time trying to fix it. If it breaks, it can be fixed whenever someone wants to try enabling it again. (In reply to comment #7) > FWIW: I agree with turning on this feature back on developer builds. > Otherwise development of this feature is going to be more complicated than > necessary. But I don't agree that it's complicated to enable a build flag. It's not like we're getting rid of the flag, you can still use it, we're just changing it to a default that's more suitable. 1206021 9 mcatanzaro 2016-06-28 07:10:55 -0700 Updated expectations in r202561. 273106 2016-03-05 16:14:38 -0800 2016-03-05 19:50:10 -0800 Patch bug-155073-20160305181423.patch text/plain 1560 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3NjE1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWQxYmE1OGIxNjkzOWQ3NjU4MWE0ZGI0OWE1ODk1MzFj NWEwNWNiMS4uZjBkN2M5N2IyZTZjY2Q0Y2U0M2M1MDE2NzM4OGQyZjg5NTI0NTNkMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE2LTAzLTA1ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBbR1RLXVtFRkxdIERpc2FibGUgc3VidGxlLWNyeXB0byBpbiBGZWF0dXJl TGlzdC5wbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU1MDczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxpc3QucG06CisKIDIwMTYtMDMtMDUgIENhcmxv cyBBbGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dU S10gRml4IGxvZ2dpbmcgZGV0YWlscyBhZnRlciByMTk3NTA1IChSdW4gdGhlIHJ1bi1iZW5jaG1h cmsgc2NyaXB0IG9uIHRoZSBwZXJmb3JtYW5jZSBib3QuKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJs L0ZlYXR1cmVMaXN0LnBtCmluZGV4IGQ5M2Y5MTViNDY5M2VkN2MwZjZmZmM3NWVlMzBlZDkzMzlk Yjc5MWMuLjcxZDZlY2JiN2UxMjIyNzdkNzI5Njg3ZmM3M2E3YjVjMDYwMjA0MzEgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxpc3QucG0KQEAgLTQwMSw3ICs0MDEsNyBAQCBteSBA ZmVhdHVyZXMgPSAoCiAgICAgICBkZWZpbmUgPT4gIkVOQUJMRV9TVFJFQU1TX0FQSSIsIGRlZmF1 bHQgPT4gMSwgdmFsdWUgPT4gXCRzdHJlYW1zQVBJU3VwcG9ydCB9LAogCiAgICAgeyBvcHRpb24g PT4gInN1YnRsZS1jcnlwdG8iLCBkZXNjID0+ICJUb2dnbGUgV2ViQ3J5cHRvIFN1YnRsZS1Dcnlw dG8gc3VwcG9ydCIsCi0gICAgICBkZWZpbmUgPT4gIkVOQUJMRV9TVUJUTEVfQ1JZUFRPIiwgZGVm YXVsdCA9PiAoaXNHdGsoKSB8fCBpc0VmbCgpIHx8IGlzQXBwbGVNYWNXZWJLaXQoKSB8fCBpc0lP U1dlYktpdCgpKSwgdmFsdWUgPT4gXCRzdWJ0bGVDcnlwdG8gfSwKKyAgICAgIGRlZmluZSA9PiAi RU5BQkxFX1NVQlRMRV9DUllQVE8iLCBkZWZhdWx0ID0+IChpc0FwcGxlTWFjV2ViS2l0KCkgfHwg aXNJT1NXZWJLaXQoKSksIHZhbHVlID0+IFwkc3VidGxlQ3J5cHRvIH0sCiAKICAgICB7IG9wdGlv biA9PiAic3ZnLWZvbnRzIiwgZGVzYyA9PiAiVG9nZ2xlIFNWRyBGb250cyBzdXBwb3J0IiwKICAg ICAgIGRlZmluZSA9PiAiRU5BQkxFX1NWR19GT05UUyIsIGRlZmF1bHQgPT4gMSwgdmFsdWUgPT4g XCRzdmdGb250c1N1cHBvcnQgfSwK