155071 2016-03-05 15:16:46 -0800 [JSC] Remove a useless "Move" from baseline-JIT op_mul's fast path 2016-03-07 10:23:40 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue fpizlo keith_miller mark.lam msaboff saam oldest_to_newest 1171279 0 benjamin 2016-03-05 15:16:46 -0800 [JSC] Remove a useless "Move" from baseline-JIT op_mul's fast path 1171280 1 273101 benjamin 2016-03-05 15:17:56 -0800 Created attachment 273101 Patch 1171282 2 benjamin 2016-03-05 15:19:30 -0800 Useful for Sunspider. I doubt that will help any other benchmark: Conf#1 Conf#2 3d-cube 4.8120+-0.0615 ? 4.8620+-0.1448 ? might be 1.0104x slower 3d-morph 5.4550+-0.1999 5.3248+-0.0256 might be 1.0245x faster 3d-raytrace 5.6889+-0.0605 ? 5.7573+-0.0993 ? might be 1.0120x slower access-binary-trees 2.2023+-0.0702 ? 2.2791+-0.1373 ? might be 1.0348x slower access-fannkuch 6.0842+-0.1919 ? 6.2618+-0.3064 ? might be 1.0292x slower access-nbody 2.7319+-0.0712 2.7156+-0.0459 access-nsieve 3.0611+-0.0894 3.0315+-0.0712 bitops-3bit-bits-in-byte 1.1824+-0.0228 ? 1.1891+-0.0258 ? bitops-bits-in-byte 3.3129+-0.0350 ? 3.3498+-0.0505 ? might be 1.0111x slower bitops-bitwise-and 2.1524+-0.0938 2.1421+-0.0922 bitops-nsieve-bits 3.1258+-0.1240 3.0624+-0.0383 might be 1.0207x faster controlflow-recursive 2.3898+-0.0535 ? 2.3947+-0.0497 ? crypto-aes 4.0141+-0.0312 ? 4.0504+-0.0387 ? crypto-md5 2.5760+-0.0188 ? 2.6217+-0.0555 ? might be 1.0178x slower crypto-sha1 2.3456+-0.0369 2.3417+-0.0114 date-format-tofte 6.8730+-0.0833 ? 6.9368+-0.1232 ? date-format-xparb 4.8472+-0.0824 ? 4.9277+-0.1234 ? might be 1.0166x slower math-cordic 3.0174+-0.0999 ? 3.0407+-0.1887 ? math-partial-sums 5.0294+-0.1186 4.9583+-0.1085 might be 1.0143x faster math-spectral-norm 2.0405+-0.0270 ? 2.0534+-0.0375 ? regexp-dna 6.5270+-0.4192 6.1059+-0.1505 might be 1.0690x faster string-base64 4.6023+-0.1701 4.5483+-0.0740 might be 1.0119x faster string-fasta 5.9656+-0.0696 ? 6.0196+-0.2774 ? string-tagcloud 8.4972+-0.2720 8.3649+-0.2489 might be 1.0158x faster string-unpack-code 18.8633+-0.6859 18.5759+-0.2329 might be 1.0155x faster string-validate-input 4.2562+-0.1027 ? 4.2848+-0.0806 ? <arithmetic> 4.6790+-0.0256 4.6616+-0.0305 might be 1.0037x faster 1171614 3 273101 ggaren 2016-03-07 09:29:40 -0800 Comment on attachment 273101 Patch r=me 1171642 4 273101 commit-queue 2016-03-07 10:23:36 -0800 Comment on attachment 273101 Patch Clearing flags on attachment: 273101 Committed r197685: <http://trac.webkit.org/changeset/197685> 1171643 5 commit-queue 2016-03-07 10:23:40 -0800 All reviewed patches have been landed. Closing bug. 273101 2016-03-05 15:17:56 -0800 2016-03-07 10:23:36 -0800 Patch bug-155071-20160305151742.patch text/plain 2863 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3NjA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 OTdiN2NhODRhZmE4NjI0NGE0YzA5NDM2MTdlNGIzNDM3N2Q2MmFkLi5kOGQyZjViMTdkNGE2OGYw MWEzYWZmNjcxODAzOTY3MGMwMmI1NGZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNi0wMy0wNSAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW0pTQ10gUmVtb3ZlIGEgdXNlbGVzcyAiTW92ZSIgZnJvbSBiYXNl bGluZS1KSVQgb3BfbXVsJ3MgZmFzdCBwYXRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTUwNzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZSBkbyBub3QgbmVlZCB0byBtdWx0aXBseSB0byBhIHNjcmF0 Y2ggYW5kIHRoZW4gbW92ZSB0aGUgcmVzdWx0CisgICAgICAgIHRvIHRoZSBkZXN0aW5hdGlvbi4g V2UgY2FuIGp1c3QgbXVsdGlwbHkgdG8gdGhlIGRlc3RpbmF0aW9uLgorCisgICAgICAgICogaml0 L0pJVEFyaXRobWV0aWMuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRfb3BfbXVsKToKKyAg ICAgICAgKiBqaXQvSklUTXVsR2VuZXJhdG9yLmNwcDoKKyAgICAgICAgKEpTQzo6SklUTXVsR2Vu ZXJhdG9yOjpnZW5lcmF0ZUZhc3RQYXRoKToKKwogMjAxNi0wMy0wNCAgQW5kcmVhcyBLbGluZyAg PGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gVGhyb3cgYXdheSBjb21waWxlZCBS ZWdFeHAgY29kZSB3aGVuIG5hdmlnYXRpbmcgdG8gYSBuZXcgcGFnZS4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUQXJpdGhtZXRpYy5jcHAgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaml0L0pJVEFyaXRobWV0aWMuY3BwCmluZGV4IDY5MzYzOWNlYjk5NDJmNDZjYTEy MGViMWI5MmIzOTI0MDFlYmE2ZDEuLjI3NTE3MjBiNzdmNzMxNDRhMzUyZTExZDYwMzhmNjlhYjJl Y2RhY2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUQXJpdGhtZXRp Yy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRBcml0aG1ldGljLmNwcApA QCAtODIyLDggKzgyMiw4IEBAIHZvaWQgSklUOjplbWl0X29wX211bChJbnN0cnVjdGlvbiogY3Vy cmVudEluc3RydWN0aW9uKQogI2lmIFVTRShKU1ZBTFVFNjQpCiAgICAgSlNWYWx1ZVJlZ3MgbGVm dFJlZ3MgPSBKU1ZhbHVlUmVncyhyZWdUMCk7CiAgICAgSlNWYWx1ZVJlZ3MgcmlnaHRSZWdzID0g SlNWYWx1ZVJlZ3MocmVnVDEpOwotICAgIEpTVmFsdWVSZWdzIHJlc3VsdFJlZ3MgPSBsZWZ0UmVn czsKLSAgICBHUFJSZWcgc2NyYXRjaEdQUiA9IHJlZ1QyOworICAgIEpTVmFsdWVSZWdzIHJlc3Vs dFJlZ3MgPSBKU1ZhbHVlUmVncyhyZWdUMik7CisgICAgR1BSUmVnIHNjcmF0Y2hHUFIgPSByZWdU MzsKICAgICBGUFJSZWcgc2NyYXRjaEZQUiA9IEludmFsaWRGUFJSZWc7CiAjZWxzZQogICAgIEpT VmFsdWVSZWdzIGxlZnRSZWdzID0gSlNWYWx1ZVJlZ3MocmVnVDEsIHJlZ1QwKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUTXVsR2VuZXJhdG9yLmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUTXVsR2VuZXJhdG9yLmNwcAppbmRleCBmZjBhMDVlN2Jj ZDg4YjdhNzhiYWNjYWY2YTI4ZWRhODMyMjk5YjM4Li5iMWZiMGIwZDBkZTI3YjI5MGQ4OWY5OTc0 NDdkYTJkZDJjMDAwOWFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJ VE11bEdlbmVyYXRvci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRNdWxH ZW5lcmF0b3IuY3BwCkBAIC02MCw5ICs2MCwxMyBAQCB2b2lkIEpJVE11bEdlbmVyYXRvcjo6Z2Vu ZXJhdGVGYXN0UGF0aChDQ2FsbEhlbHBlcnMmIGppdCkKICAgICAgICAgLy8gVHJ5IHRvIGRvIGlu dFZhciAqIGludENvbnN0YW50LgogICAgICAgICBDQ2FsbEhlbHBlcnM6Okp1bXAgbm90SW50MzIg PSBqaXQuYnJhbmNoSWZOb3RJbnQzMih2YXIpOwogCi0gICAgICAgIG1fc2xvd1BhdGhKdW1wTGlz dC5hcHBlbmQoaml0LmJyYW5jaE11bDMyKENDYWxsSGVscGVyczo6T3ZlcmZsb3csIHZhci5wYXls b2FkR1BSKCksIENDYWxsSGVscGVyczo6SW1tMzIoY29uc3RPcHIuYXNDb25zdEludDMyKCkpLCBt X3NjcmF0Y2hHUFIpKTsKKyAgICAgICAgR1BSUmVnIG11bHRpcGx5UmVzdWx0R1BSID0gbV9yZXN1 bHQucGF5bG9hZEdQUigpOworICAgICAgICBpZiAobXVsdGlwbHlSZXN1bHRHUFIgPT0gdmFyLnBh eWxvYWRHUFIoKSkKKyAgICAgICAgICAgIG11bHRpcGx5UmVzdWx0R1BSID0gbV9zY3JhdGNoR1BS OwogCi0gICAgICAgIGppdC5ib3hJbnQzMihtX3NjcmF0Y2hHUFIsIG1fcmVzdWx0KTsKKyAgICAg ICAgbV9zbG93UGF0aEp1bXBMaXN0LmFwcGVuZChqaXQuYnJhbmNoTXVsMzIoQ0NhbGxIZWxwZXJz OjpPdmVyZmxvdywgdmFyLnBheWxvYWRHUFIoKSwgQ0NhbGxIZWxwZXJzOjpJbW0zMihjb25zdE9w ci5hc0NvbnN0SW50MzIoKSksIG11bHRpcGx5UmVzdWx0R1BSKSk7CisKKyAgICAgICAgaml0LmJv eEludDMyKG11bHRpcGx5UmVzdWx0R1BSLCBtX3Jlc3VsdCk7CiAgICAgICAgIG1fZW5kSnVtcExp c3QuYXBwZW5kKGppdC5qdW1wKCkpOwogCiAgICAgICAgIGlmICghaml0LnN1cHBvcnRzRmxvYXRp bmdQb2ludCgpKSB7Cg==