155049 2016-03-04 14:53:51 -0800 [CMake] Enable -Wsuggest-override 2016-03-06 02:43:58 -0800 1 1 1 Unclassified WebKit WebCore Misc. Other PC Linux NEW P2 Normal --- 1 mcatanzaro webkit-unassigned achristensen annulen darin mcatanzaro mrobinson oldest_to_newest 1171067 0 mcatanzaro 2016-03-04 14:53:51 -0800 To help enforce our new coding style, we should enable -Wsuggest-override in WEBKIT_SET_EXTRA_COMPILER_FLAGS: -Wsuggest-override Warn about overriding virtual functions that are not marked with the override keyword. 1171070 1 mcatanzaro 2016-03-04 14:57:23 -0800 However we should investigate if this warning is triggered when using 'final' instead of 'override', as Darin is suggesting that we use 'final' whenever possible [1]. He has some convincing reasons in his follow-up post. If that would trip up -Wsuggest-override then we should probably WONTFIX this. [1] https://lists.webkit.org/pipermail/webkit-dev/2016-March/028018.html 1171236 2 darin 2016-03-05 12:06:15 -0800 We probably want this on for iOS and Mac too. 1171252 3 mcatanzaro 2016-03-05 13:26:50 -0800 Apparently Clang doesn't have this warning, it's GCC-only. :( 1171402 4 annulen 2016-03-06 02:31:39 -0800 Clang provides similar -Winconsistent-missing-override, which is included in -Wall. However, it is issued only when class already has at least one method with 'override' specifier. 1171403 5 annulen 2016-03-06 02:43:58 -0800 BTW, it looks like -Wsuggest-override is not just GCC-only, but requires GCC 5.1