155038 2016-03-04 13:31:47 -0800 Max out timer throttling immediately for pre-render pages 2016-03-04 13:56:49 -0800 1 1 1 Unclassified WebKit WebKit Misc. Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough barraclough cdumez oldest_to_newest 1171010 0 barraclough 2016-03-04 13:31:47 -0800 If a hidden page has never been visible, no need to gently ramp into throttling - treat it the same as a page that has been viewed, but has been in the background for a long time. Why? The throttling mechanism scales with the amount of background work by shifting the limit - once all background pages have maxed out the limit, they should no longer be burden of the system. However the mechanism doesn't currently do anything to accelerate towards the limit based on the number of pages in the ramp up phase, and ramp up duration is proportional to limit (so ramping up to a high limit takes a long time). So if you quickly create a large number of hidden pages the system may be under excessive load for a while, as we slowly ramp up to a limit that will adequately constrain resource consumption. In cases where a large number of hidden pages are rapidly generated, many likely remain in the pre-render state, so this mitigation should typically help. 1171014 1 273034 barraclough 2016-03-04 13:41:10 -0800 Created attachment 273034 Fix 1171027 2 273034 cdumez 2016-03-04 13:51:52 -0800 Comment on attachment 273034 Fix r=me 1171031 3 barraclough 2016-03-04 13:56:49 -0800 Transmitting file data .. Committed revision 197588. 273034 2016-03-04 13:41:10 -0800 2016-03-04 13:51:52 -0800 Fix 155038.1.patch text/plain 3931 barraclough SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NzU4NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDE2LTAzLTA0ICBHYXZpbiBC YXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KKworICAgICAgICBNYXggb3V0IHRp bWVyIHRocm90dGxpbmcgaW1tZWRpYXRlbHkgZm9yIHByZS1yZW5kZXIgcGFnZXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NTAzOAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIGEgaGlkZGVuIHBhZ2Ug aGFzIG5ldmVyIGJlZW4gdmlzaWJsZSwgbm8gbmVlZCB0byBnZW50bHkgcmFtcCBpbnRvIHRocm90 dGxpbmcgLSB0cmVhdCBpdAorICAgICAgICB0aGUgc2FtZSBhcyBhIHBhZ2UgdGhhdCBoYXMgYmVl biB2aWV3ZWQsIGJ1dCBoYXMgYmVlbiBpbiB0aGUgYmFja2dyb3VuZCBmb3IgYSBsb25nIHRpbWUu CisKKyAgICAgICAgV2h5PyBUaGUgdGhyb3R0bGluZyBtZWNoYW5pc20gc2NhbGVzIHdpdGggdGhl IGFtb3VudCBvZiBiYWNrZ3JvdW5kIHdvcmsgYnkgc2hpZnRpbmcgdGhlCisgICAgICAgIGxpbWl0 IC0gb25jZSBhbGwgYmFja2dyb3VuZCBwYWdlcyBoYXZlIG1heGVkIG91dCB0aGUgbGltaXQsIHRo ZXkgc2hvdWxkIG5vIGxvbmdlciBiZSBidXJkZW4KKyAgICAgICAgb2YgdGhlIHN5c3RlbS4gSG93 ZXZlciB0aGUgbWVjaGFuaXNtIGRvZXNuJ3QgY3VycmVudGx5IGRvIGFueXRoaW5nIHRvIGFjY2Vs ZXJhdGUgdG93YXJkcworICAgICAgICB0aGUgbGltaXQgYmFzZWQgb24gdGhlIG51bWJlciBvZiBw YWdlcyBpbiB0aGUgcmFtcCB1cCBwaGFzZSwgYW5kIHJhbXAgdXAgZHVyYXRpb24gaXMKKyAgICAg ICAgcHJvcG9ydGlvbmFsIHRvIGxpbWl0IChzbyByYW1waW5nIHVwIHRvIGEgaGlnaCBsaW1pdCB0 YWtlcyBhIGxvbmcgdGltZSkuIFNvIGlmIHlvdSBxdWlja2x5CisgICAgICAgIGNyZWF0ZSBhIGxh cmdlIG51bWJlciBvZiBoaWRkZW4gcGFnZXMgdGhlIHN5c3RlbSBtYXkgYmUgdW5kZXIgZXhjZXNz aXZlIGxvYWQgZm9yIGEgd2hpbGUsCisgICAgICAgIGFzIHdlIHNsb3dseSByYW1wIHVwIHRvIGEg bGltaXQgdGhhdCB3aWxsIGFkZXF1YXRlbHkgY29uc3RyYWluIHJlc291cmNlIGNvbnN1bXB0aW9u LgorICAgICAgICBJbiBjYXNlcyB3aGVyZSBhIGxhcmdlIG51bWJlciBvZiBoaWRkZW4gcGFnZXMg YXJlIHJhcGlkbHkgZ2VuZXJhdGVkLCBtYW55IGxpa2VseSByZW1haW4gaW4KKyAgICAgICAgdGhl IHByZS1yZW5kZXIgc3RhdGUsIHNvIHRoaXMgbWl0aWdhdGlvbiBzaG91bGQgdHlwaWNhbGx5IGhl bHAuCisKKyAgICAgICAgKiBwYWdlL1BhZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFnZTo6 dXBkYXRlRE9NVGltZXJBbGlnbm1lbnRJbnRlcnZhbCk6CisgICAgICAgICAgICAtIGlmIG1faXNQ cmVyZW5kZXIgdGhlbiBtX3RpbWVyQWxpZ25tZW50SW50ZXJ2YWwgaXMgc2V0IHRvIHRoZSBsaW1p dC4KKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6OnNldElzUHJlcmVuZGVyKToKKyAgICAgICAgICAg IC0gV2hlbiB0aGlzIGNoYW5nZXMgdXBkYXRlRE9NVGltZXJBbGlnbm1lbnRJbnRlcnZhbCgpLgor CiAyMDE2LTAzLTA0ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4K IAogICAgICAgICBVbmlmeSBkZXRlcm1pbmF0aW9uIG9mIHBhZ2UgdGltZXIgYWxpZ25tZW50Cklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3BhZ2UvUGFnZS5jcHAJKHJldmlzaW9uIDE5NzU4MSkKKysrIFNvdXJjZS9XZWJDb3Jl L3BhZ2UvUGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyNDQsMTEgKzEyNDQsMjAgQEAgdm9p ZCBQYWdlOjp1cGRhdGVET01UaW1lckFsaWdubWVudEludGVydgogICAgICAgICBicmVhazsKIAog ICAgIGNhc2UgVGltZXJUaHJvdHRsaW5nU3RhdGU6OkVuYWJsZWRJbmNyZWFzaW5nOgotICAgICAg ICBBU1NFUlQobV90aW1lclRocm90dGxpbmdTdGF0ZUxhc3RDaGFuZ2VkVGltZSk7Ci0gICAgICAg IGRvdWJsZSB0aHJvdHRsZWREdXJhdGlvbiA9IG1vbm90b25pY2FsbHlJbmNyZWFzaW5nVGltZSgp IC0gbV90aW1lclRocm90dGxpbmdTdGF0ZUxhc3RDaGFuZ2VkVGltZTsKLSAgICAgICAgZG91Ymxl IG1pbmltdW1BbGlnbm1lbnRJbnRlcnZhbCA9IHN0ZDo6bWF4KERPTVRpbWVyOjpoaWRkZW5QYWdl QWxpZ25tZW50SW50ZXJ2YWwoKSwgdGhyb3R0bGVkRHVyYXRpb24pOwotICAgICAgICBtX3RpbWVy QWxpZ25tZW50SW50ZXJ2YWwgPSBzdGQ6Om1pbihtaW5pbXVtQWxpZ25tZW50SW50ZXJ2YWwsIG1f dGltZXJBbGlnbm1lbnRJbnRlcnZhbEluY3JlYXNlTGltaXQpOwotICAgICAgICBuZWVkc0luY3Jl YXNlVGltZXIgPSBtX3RpbWVyQWxpZ25tZW50SW50ZXJ2YWwgPCBtX3RpbWVyQWxpZ25tZW50SW50 ZXJ2YWxJbmNyZWFzZUxpbWl0OworICAgICAgICAvLyBGb3IgcGFnZXMgaW4gcHJlcmVuZGVyIHN0 YXRlIG1heGltdW0gdGhyb3R0bGluZyBraWNrcyBpbiBpbW1lZGlhdGVseS4KKyAgICAgICAgaWYg KG1faXNQcmVyZW5kZXIpCisgICAgICAgICAgICBtX3RpbWVyQWxpZ25tZW50SW50ZXJ2YWwgPSBt X3RpbWVyQWxpZ25tZW50SW50ZXJ2YWxJbmNyZWFzZUxpbWl0OworICAgICAgICBlbHNlIHsKKyAg ICAgICAgICAgIEFTU0VSVChtX3RpbWVyVGhyb3R0bGluZ1N0YXRlTGFzdENoYW5nZWRUaW1lKTsK KyAgICAgICAgICAgIG1fdGltZXJBbGlnbm1lbnRJbnRlcnZhbCA9IG1vbm90b25pY2FsbHlJbmNy ZWFzaW5nVGltZSgpIC0gbV90aW1lclRocm90dGxpbmdTdGF0ZUxhc3RDaGFuZ2VkVGltZTsKKyAg ICAgICAgICAgIC8vIElmIHdlJ3JlIGJlbG93IHRoZSBsaW1pdCwgc2V0IHRoZSB0aW1lci4gSWYg YWJvdmUsIGNsYW1wIHRvIGxpbWl0LgorICAgICAgICAgICAgaWYgKG1fdGltZXJBbGlnbm1lbnRJ bnRlcnZhbCA8IG1fdGltZXJBbGlnbm1lbnRJbnRlcnZhbEluY3JlYXNlTGltaXQpCisgICAgICAg ICAgICAgICAgbmVlZHNJbmNyZWFzZVRpbWVyID0gdHJ1ZTsKKyAgICAgICAgICAgIGVsc2UKKyAg ICAgICAgICAgICAgICBtX3RpbWVyQWxpZ25tZW50SW50ZXJ2YWwgPSBtX3RpbWVyQWxpZ25tZW50 SW50ZXJ2YWxJbmNyZWFzZUxpbWl0OworICAgICAgICB9CisgICAgICAgIC8vIEFsaWdubWVudCBp bnRlcnZhbCBzaG91bGQgbm90IGJlIGxlc3MgdGhhbiBET01UaW1lcjo6aGlkZGVuUGFnZUFsaWdu bWVudEludGVydmFsKCkuCisgICAgICAgIG1fdGltZXJBbGlnbm1lbnRJbnRlcnZhbCA9IHN0ZDo6 bWF4KG1fdGltZXJBbGlnbm1lbnRJbnRlcnZhbCwgRE9NVGltZXI6OmhpZGRlblBhZ2VBbGlnbm1l bnRJbnRlcnZhbCgpKTsKICAgICB9CiAKICAgICAvLyBJZiB0aHJvdHRsaW5nIGlzIGVuYWJsZWQs IGF1dG8taW5jcmVhc2luZyBvZiB0aHJvdHRsaW5nIGlzIGVuYWJsZWQsIGFuZCB0aGUgYXV0by1p bmNyZWFzZQpAQCAtMTQ3OSw2ICsxNDg4LDcgQEAgdm9pZCBQYWdlOjpzZXRJc1Zpc2libGVJbnRl cm5hbChib29sIGlzVgogdm9pZCBQYWdlOjpzZXRJc1ByZXJlbmRlcigpCiB7CiAgICAgbV9pc1By ZXJlbmRlciA9IHRydWU7CisgICAgdXBkYXRlRE9NVGltZXJBbGlnbm1lbnRJbnRlcnZhbCgpOwog fQogCiBQYWdlVmlzaWJpbGl0eVN0YXRlIFBhZ2U6OnZpc2liaWxpdHlTdGF0ZSgpIGNvbnN0Cg==