155033 2016-03-04 12:42:45 -0800 REGRESSION (r197531): JavaScriptCore ASan build fails due to weak external symbol 2016-03-04 14:18:05 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 154877 1 ddkilzer ddkilzer ap benjamin commit-queue ggaren keith_miller mark.lam msaboff rniwa ryanhaddad saam webkit-bug-importer oldest_to_newest 1170979 0 ddkilzer 2016-03-04 12:42:45 -0800 JavaScriptCore ASan build fails due to weak external symbol: PhaseScriptExecution Check For Weak VTables and Externals ERROR: JavaScriptCore has a weak external symbol in it (/Volumes/Data/BuildSlave/Monarch-WebKitASan/build/OpenSource/WebKitBuild/Debug-iphonesimulator/JavaScriptCore.framework/JavaScriptCore) ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library. ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file. ERROR: symbol __ZNK3JSC8JSObject19ordinaryToPrimitiveEPNS_9ExecStateENS_22PreferredPrimitiveTypeE This regressed with: Bug 154877: [ES6] Add support for Symbol.toPrimitive <https://bugs.webkit.org/show_bug.cgi?id=154877> <http://trac.webkit.org/changeset/197531> 1170980 1 ddkilzer 2016-03-04 12:43:53 -0800 <rdar://problem/24979661> 1170982 2 273026 ddkilzer 2016-03-04 12:45:20 -0800 Created attachment 273026 Patch v1 1170985 3 273026 ap 2016-03-04 12:50:41 -0800 Comment on attachment 273026 Patch v1 No cq+, since EWS is not done yet. 1170986 4 ddkilzer 2016-03-04 12:53:32 -0800 (In reply to comment #3) > Comment on attachment 273026 [details] > Patch v1 > > No cq+, since EWS is not done yet. Huh? EWS doesn't wait for in-flight builds to finish? 1170989 5 ap 2016-03-04 12:59:52 -0800 No, it never did. It would try to build itself, but only one configuration. 1171039 6 273026 commit-queue 2016-03-04 14:18:00 -0800 Comment on attachment 273026 Patch v1 Clearing flags on attachment: 273026 Committed r197590: <http://trac.webkit.org/changeset/197590> 1171040 7 commit-queue 2016-03-04 14:18:05 -0800 All reviewed patches have been landed. Closing bug. 273026 2016-03-04 12:45:20 -0800 2016-03-04 14:18:00 -0800 Patch v1 bug-155033-20160304124506.patch text/plain 2585 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3NTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi ZTBiMWI1ZjQwYmM1YTllZDVlZmExZDYzOTBhYzk5YjY1YWI4ZjRkLi5hNjJkMmY0YWNlMzdkZjUz MGYwMTk0ZWJkMjNlZjM0N2VlMzlhNTlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNi0wMy0wNCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxOTc1MzEpOiBKYXZhU2NyaXB0Q29yZSBBU2FuIGJ1 aWxkIGZhaWxzIGR1ZSB0byB3ZWFrIGV4dGVybmFsIHN5bWJvbAorICAgICAgICA8aHR0cDovL3dl YmtpdC5vcmcvYi8xNTUwMzM+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNDk3OTY2MT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUv SlNPYmplY3QuY3BwOgorICAgICAgICAoSlNDOjpKU09iamVjdDo6b3JkaW5hcnlUb1ByaW1pdGl2 ZSk6IERvbid0IG1hcmsgdGhpcyBtZXRob2QKKyAgICAgICAgaW5saW5lIHNpbmNlIGl0J3MgYWxz byB1c2VkIGluIERhdGVQcm90b3R5cGUuY3BwLCBhbmQgaXMKKyAgICAgICAgZGVjbGFyZWQgYXMg YSBwdWJsaWMgY2xhc3MgbWV0aG9kLgorICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3QuaDoKKyAg ICAgICAgKEpTQzo6SlNPYmplY3Q6Om9yZGluYXJ5VG9QcmltaXRpdmUpOiBEb24ndCBleHBvcnQg dGhpcyBtZXRob2QKKyAgICAgICAgc2luY2UgaXQgaXMgbm90IHVzZWQgb3V0c2lkZSBvZiBKYXZh U2NyaXB0Q29yZS4KKwogMjAxNi0wMy0wNCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNl bkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSB2Y3hwcm9qIGJ1aWxkIHN5c3RlbQpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwCmluZGV4IGZjYjM1MGE0OWQ1 MGE2OTRhYjQ2ZTFhZDQ1Njg1ZjE2MDcyOGQ4MWYuLjEwNzk5OWQyZDZhMTYxYWFjNzg3NDkwM2Q1 ODJmOGM4YzI3OTFiYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVj dC5jcHAKQEAgLTE0NjgsNyArMTQ2OCw3IEBAIHN0YXRpYyBBTFdBWVNfSU5MSU5FIEpTVmFsdWUg Y2FsbFRvUHJpbWl0aXZlRnVuY3Rpb24oRXhlY1N0YXRlKiBleGVjLCBjb25zdCBKU09iCiB9CiAK IC8vIEVDTUEgNy4xLjEKLWlubGluZSBKU1ZhbHVlIEpTT2JqZWN0OjpvcmRpbmFyeVRvUHJpbWl0 aXZlKEV4ZWNTdGF0ZSogZXhlYywgUHJlZmVycmVkUHJpbWl0aXZlVHlwZSBoaW50KSBjb25zdAor SlNWYWx1ZSBKU09iamVjdDo6b3JkaW5hcnlUb1ByaW1pdGl2ZShFeGVjU3RhdGUqIGV4ZWMsIFBy ZWZlcnJlZFByaW1pdGl2ZVR5cGUgaGludCkgY29uc3QKIHsKICAgICAvLyBNYWtlIHN1cmUgdGhh dCB3aGF0ZXZlciBkZWZhdWx0IHZhbHVlIG1ldGhvZHMgdGhlcmUgYXJlIG9uIG9iamVjdCdzIHBy b3RvdHlwZSBjaGFpbiBhcmUKICAgICAvLyBiZWluZyB3YXRjaGVkLgpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0pTT2JqZWN0LmgKaW5kZXggMjI2MjhlMDkzNTFlMmU4MDFhYjZlYTg3ZDg3 MGQ2NGFjYWRjNjNiMy4uMzMzODcyM2FiOTE0YjQwN2IzNzViOGIyMmJmZDYzZWE1YTliNjUxNCAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaAorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oCkBAIC01MDUsNyArNTA1 LDcgQEAgcHVibGljOgogICAgIEpTX0VYUE9SVF9QUklWQVRFIHN0YXRpYyBib29sIGRlbGV0ZVBy b3BlcnR5QnlJbmRleChKU0NlbGwqLCBFeGVjU3RhdGUqLCB1bnNpZ25lZCBwcm9wZXJ0eU5hbWUp OwogCiAgICAgSlNfRVhQT1JUX1BSSVZBVEUgc3RhdGljIEpTVmFsdWUgZGVmYXVsdFZhbHVlKGNv bnN0IEpTT2JqZWN0KiwgRXhlY1N0YXRlKiwgUHJlZmVycmVkUHJpbWl0aXZlVHlwZSk7Ci0gICAg SlNfRVhQT1JUX1BSSVZBVEUgSlNWYWx1ZSBvcmRpbmFyeVRvUHJpbWl0aXZlKEV4ZWNTdGF0ZSos IFByZWZlcnJlZFByaW1pdGl2ZVR5cGUpIGNvbnN0OworICAgIEpTVmFsdWUgb3JkaW5hcnlUb1By aW1pdGl2ZShFeGVjU3RhdGUqLCBQcmVmZXJyZWRQcmltaXRpdmVUeXBlKSBjb25zdDsKIAogICAg IEpTX0VYUE9SVF9QUklWQVRFIGJvb2wgaGFzSW5zdGFuY2UoRXhlY1N0YXRlKiwgSlNWYWx1ZSB2 YWx1ZSwgSlNWYWx1ZSBoYXNJbnN0YW5jZVZhbHVlKTsKICAgICBib29sIGhhc0luc3RhbmNlKEV4 ZWNTdGF0ZSosIEpTVmFsdWUpOwo=