155012 2016-03-04 00:46:24 -0800 [[Set]] isn't correct with respect to the spec and Proxy 2019-11-04 15:30:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam ashvayka commit-queue ews-watchlist keith_miller mark.lam msaboff ross.kirsling tzagallo webkit-bug-importer oldest_to_newest 1170552 0 saam 2016-03-04 00:46:24 -0800 When we traverse the prototype chain during [[Set]], we need to perform the following if O is a proxy because this is observable behavior. ``` if (O is a proxy) { let result = O.[[GetOwnPropertyDescriptor]](...) if (result) return; let proto = O.[[GetPrototypeOf]]() ... } ``` Right now, we just perform the [[Set]] unconditionally. We can special case Proxy here because this behavior is only observable with a Proxy. If the thing isn't a Proxy, we can do the fast prototype() lookup, etc. 1587118 1 382766 ashvayka 2019-11-04 13:22:17 -0800 Created attachment 382766 Patch 1587158 2 382766 saam 2019-11-04 14:28:44 -0800 Comment on attachment 382766 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382766&action=review > Source/JavaScriptCore/runtime/JSObject.cpp:-843 > - // https://bugs.webkit.org/show_bug.cgi?id=155012 can you close this bug? 1587161 3 ashvayka 2019-11-04 14:33:54 -0800 (In reply to Saam Barati from comment #2) > Comment on attachment 382766 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=382766&action=review > > > Source/JavaScriptCore/runtime/JSObject.cpp:-843 > > - // https://bugs.webkit.org/show_bug.cgi?id=155012 > > can you close this bug? It is this very bug, so the commit bot will close it (I don't have such rights yet). 1587165 4 saam 2019-11-04 14:37:37 -0800 (In reply to Alexey Shvayka from comment #3) > (In reply to Saam Barati from comment #2) > > Comment on attachment 382766 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=382766&action=review > > > > > Source/JavaScriptCore/runtime/JSObject.cpp:-843 > > > - // https://bugs.webkit.org/show_bug.cgi?id=155012 > > > > can you close this bug? > > It is this very bug, so the commit bot will close it (I don't have such > rights yet). haha. Oops. I didn't realize it was the same one :-) 1587194 5 382766 commit-queue 2019-11-04 15:29:17 -0800 Comment on attachment 382766 Patch Clearing flags on attachment: 382766 Committed r252019: <https://trac.webkit.org/changeset/252019> 1587195 6 commit-queue 2019-11-04 15:29:19 -0800 All reviewed patches have been landed. Closing bug. 1587196 7 webkit-bug-importer 2019-11-04 15:30:16 -0800 <rdar://problem/56883293> 382766 2019-11-04 13:22:17 -0800 2019-11-04 15:29:17 -0800 Patch bug-155012-20191104232216.patch text/plain 2033 ashvayka SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjUyMDA5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE5LTExLTA0ICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNoQGdtYWlsLmNvbT4KKwor ICAgICAgICBbW1NldF1dIGlzbid0IGNvcnJlY3Qgd2l0aCByZXNwZWN0IHRvIHRoZSBzcGVjIGFu ZCBQcm94eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU1MDEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhpcyBwYXRjaCBtZXJlbHkgcmVtb3ZlcyBhIEZJWE1FIGNvbW1lbnQsIGFzIEphdmFTY3JpcHRD b3JlIGhhcyBhbHJlYWR5IGNvcnJlY3QKKyAgICAgICAgaW1wbGVtZW50YXRpb24gb2Ygb3JkaW5h cnkgW1tTZXRdXS4gSW4gc3RlcCAyLmIgb2YgaHR0cHM6Ly90YzM5LmVzL2VjbWEyNjIvI3NlYy1v cmRpbmFyeXNldHdpdGhvd25kZXNjcmlwdG9yLAorICAgICAgICBpZiBgcGFyZW50YCBpcyBhIFBy b3h5LCB0aGUgYWxnb3JpdGhtIHJldHVybnMgcmVzdWx0IG9mIFByb3h5J3MgW1tTZXRdXSBtZXRo b2QgY2FsbC4KKyAgICAgICAgSXQgaXMgdXAgdG8gdGhlIGF1dGhvciBvZiAic2V0IiB0cmFwIChp ZiBhbnkpIHRvIGNvbnN1bHQgdGhlIHByb3RvdHlwZSBjaGFpbi4KKworICAgICAgICBBbGwgYnJv d3NlcnMgcGFzcyBodHRwczovL3Rlc3QyNjIucmVwb3J0L2Jyb3dzZS9idWlsdC1pbnMvUHJveHkv c2V0L2NhbGwtcGFyYW1ldGVycy1wcm90b3R5cGUuanMsCisgICAgICAgIHdoaWNoIGFzc2VydHMg dGhhdCBubyB0cmFwcyBiZXNpZGVzICJzZXQiIGFyZSBpbnZva2VkIG9uIFByb3hpZXMgaW4gcHJv dG90eXBlIGNoYWluIGR1cmluZyBbW1NldF1dLgorCisgICAgICAgICogcnVudGltZS9KU09iamVj dC5jcHA6CisgICAgICAgIChKU0M6OkpTT2JqZWN0OjpwdXRJbmxpbmVTbG93KToKKwogMjAxOS0x MS0wNCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgU3VycHJlc3Mg QVNBTiBpbiBTYW1wbGluZ1Byb2ZpbGVyJ3MgRnJhbWVXYWxrZXI6OnJlc2V0QXRNYWNoaW5lRnJh bWUoKS4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAJ KHJldmlzaW9uIDI1MjAwMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2Jq ZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtODM4LDkgKzgzOCw2IEBAIGJvb2wgSlNPYmplY3Q6 OnB1dElubGluZVNsb3coSlNHbG9iYWxPYmoKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAg ICAgICBpZiAob2JqLT50eXBlKCkgPT0gUHJveHlPYmplY3RUeXBlKSB7Ci0gICAgICAgICAgICAv LyBGSVhNRTogV2Ugc2hvdWxkbid0IHVuY29uZGl0aW9uYWxseSBwZXJmb3JtIFtbU2V0XV0gaGVy ZS4KLSAgICAgICAgICAgIC8vIFdlIG5lZWQgdG8gZG8gbW9yZSBiZWNhdXNlIHRoaXMgaXMgb2Jz ZXJ2YWJsZSBiZWhhdmlvci4KLSAgICAgICAgICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTUwMTIKICAgICAgICAgICAgIFByb3h5T2JqZWN0KiBwcm94eSA9 IGpzQ2FzdDxQcm94eU9iamVjdCo+KG9iaik7CiAgICAgICAgICAgICBSRUxFQVNFX0FORF9SRVRV Uk4oc2NvcGUsIHByb3h5LT5Qcm94eU9iamVjdDo6cHV0KHByb3h5LCBnbG9iYWxPYmplY3QsIHBy b3BlcnR5TmFtZSwgdmFsdWUsIHNsb3QpKTsKICAgICAgICAgfQo=