<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>155000</bug_id>
          
          <creation_ts>2016-03-03 18:49:53 -0800</creation_ts>
          <short_desc>webkitpy should verify timestamp from CrashLogs while collecting all crash logs</short_desc>
          <delta_ts>2016-03-07 13:40:30 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Aakash Jain">aakash_jain</reporter>
          <assigned_to name="Aakash Jain">aakash_jain</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>ap</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dbates</cc>
    
    <cc>glenn</cc>
    
    <cc>lforschler</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1170452</commentid>
    <comment_count>0</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2016-03-03 18:49:53 -0800</bug_when>
    <thetext>Sometimes &quot;Other crashes&quot; section in the layout-tests results contains crashes that actually happened hours before. It might be OS regression. We should verify timestamps in crash logs for robustness.
see &lt;rdar://problem/24860219&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1170454</commentid>
    <comment_count>1</comment_count>
      <attachid>272815</attachid>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2016-03-03 18:57:32 -0800</bug_when>
    <thetext>Created attachment 272815
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1171281</commentid>
    <comment_count>2</comment_count>
      <attachid>272815</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2016-03-05 15:18:49 -0800</bug_when>
    <thetext>Comment on attachment 272815
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272815&amp;action=review

&gt; Tools/ChangeLog:10
&gt; +        (CrashLogs._is_new_crash_log): Check if crash logs are newer than required.

I would say: &quot;Make sure that crash log timestamp is within expected time range, because file modification time is not always accurate&quot;.

&gt; Tools/Scripts/webkitpy/common/system/crashlogs.py:165
&gt; +    def _is_new_crash_log(self, log_contents, newer_than=None):

Do we ever want to call this without a newer_than argument? It&apos;s confusing to have it optional when the function makes no sense without it.

Just seeing the function name, someone could imagine that this is about crash log format (new vs. old). Maybe something like &quot;_is_timestamp_newer_than&quot; would be better?

Another idea: instead of _is_new_crash_log, add a function that returns internal timestamp (possibly as datetime), and then the caller can compare it to &quot;newer_than&quot;. There is no need to combine extracting the timestamp with a policy decision of what it should be.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1171376</commentid>
    <comment_count>3</comment_count>
      <attachid>273123</attachid>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2016-03-05 20:44:36 -0800</bug_when>
    <thetext>Created attachment 273123
Updated Patch

Updated patch with review comments incorporated.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1171697</commentid>
    <comment_count>4</comment_count>
      <attachid>273123</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2016-03-07 12:03:52 -0800</bug_when>
    <thetext>Comment on attachment 273123
Updated Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273123&amp;action=review

&gt; Tools/Scripts/webkitpy/common/system/crashlogs.py:170
&gt; +    def get_timestamp_from_logs(self, log_contents):

Should this be &quot;get_timestamp_from_logs&quot; (singular)?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1171701</commentid>
    <comment_count>5</comment_count>
      <attachid>273201</attachid>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2016-03-07 12:13:31 -0800</bug_when>
    <thetext>Created attachment 273201
Updated patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1171706</commentid>
    <comment_count>6</comment_count>
      <attachid>273201</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-03-07 12:45:50 -0800</bug_when>
    <thetext>Comment on attachment 273201
Updated patch

Rejecting attachment 273201 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.webkit.org&apos;, &apos;--bot-id=webkit-cq-02&apos;, &apos;validate-changelog&apos;, &apos;--check-oops&apos;, &apos;--non-interactive&apos;, 273201, &apos;--port=mac&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Tools/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/937825</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1171725</commentid>
    <comment_count>7</comment_count>
      <attachid>273201</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-03-07 13:40:27 -0800</bug_when>
    <thetext>Comment on attachment 273201
Updated patch

Clearing flags on attachment: 273201

Committed r197704: &lt;http://trac.webkit.org/changeset/197704&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1171726</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-03-07 13:40:30 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>272815</attachid>
            <date>2016-03-03 18:57:32 -0800</date>
            <delta_ts>2016-03-05 20:44:36 -0800</delta_ts>
            <desc>Proposed patch</desc>
            <filename>patch_crashlog_timestamp</filename>
            <type>text/plain</type>
            <size>2345</size>
            <attacher name="Aakash Jain">aakash_jain</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDE5NzU0MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE0IEBACisyMDE2LTAzLTAzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv
bT4KKworICAgICAgICB3ZWJraXRweSBzaG91bGQgdmVyaWZ5IHRpbWVzdGFtcCBmcm9tIENyYXNo
TG9ncyB3aGlsZSBjb2xsZWN0aW5nIGFsbCBjcmFzaCBsb2dzCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTUwMDAKKyAgICAgICAgPHJkYXI6Ly9wcm9i
bGVtLzI0ODYwMjE5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2NyYXNobG9ncy5weToKKyAg
ICAgICAgKENyYXNoTG9ncy5faXNfbmV3X2NyYXNoX2xvZyk6IENoZWNrIGlmIGNyYXNoIGxvZ3Mg
YXJlIG5ld2VyIHRoYW4gcmVxdWlyZWQuCisKIDIwMTYtMDMtMDMgIENhcmxvcyBBbGJlcnRvIExv
cGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gVW5yZXZpZXdl
ZCBmaXggYWZ0ZXIgcjE5NzUwNSAoUnVuIHRoZSBydW4tYmVuY2htYXJrIHNjcmlwdCBvbiB0aGUg
cGVyZm9ybWFuY2UgYm90LikKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5
c3RlbS9jcmFzaGxvZ3MucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9j
b21tb24vc3lzdGVtL2NyYXNobG9ncy5weQkocmV2aXNpb24gMTk3NTQyKQorKysgVG9vbHMvU2Ny
aXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2NyYXNobG9ncy5weQkod29ya2luZyBjb3B5KQpA
QCAtMjksNiArMjksNyBAQAogCiBpbXBvcnQgY29kZWNzCiBpbXBvcnQgcmUKK2ltcG9ydCBkYXRl
dGltZQogCiAKIGNsYXNzIENyYXNoTG9ncyhvYmplY3QpOgpAQCAtMTM5LDYgKzE0MCw4IEBAIGNs
YXNzIENyYXNoTG9ncyhvYmplY3QpOgogICAgICAgICAgICAgICAgICAgICByZXN1bHRfbmFtZSA9
ICJVbmtub3duIgogICAgICAgICAgICAgICAgICAgICBwaWQgPSAwCiAgICAgICAgICAgICAgICAg
ICAgIGxvZ19jb250ZW50cyA9IHNlbGYuX2hvc3QuZmlsZXN5c3RlbS5yZWFkX3RleHRfZmlsZShw
YXRoKQorICAgICAgICAgICAgICAgICAgICBpZiBub3Qgc2VsZi5faXNfbmV3X2NyYXNoX2xvZyhs
b2dfY29udGVudHMsIG5ld2VyX3RoYW4pOgorICAgICAgICAgICAgICAgICAgICAgICAgY29udGlu
dWUKICAgICAgICAgICAgICAgICAgICAgbWF0Y2ggPSBmaXJzdF9saW5lX3JlZ2V4Lm1hdGNoKGxv
Z19jb250ZW50c1swOmxvZ19jb250ZW50cy5maW5kKCdcbicpXSkKICAgICAgICAgICAgICAgICAg
ICAgaWYgbWF0Y2g6CiAgICAgICAgICAgICAgICAgICAgICAgICBwcm9jZXNzX25hbWUgPSBtYXRj
aC5ncm91cCgncHJvY2Vzc19uYW1lJykKQEAgLTE1OCwzICsxNjEsMTUgQEAgY2xhc3MgQ3Jhc2hM
b2dzKG9iamVjdCk6CiAgICAgICAgIGlmIGluY2x1ZGVfZXJyb3JzIGFuZCBlcnJvcnMgYW5kIGxl
bihjcmFzaF9sb2dzKSA9PSAwOgogICAgICAgICAgICAgcmV0dXJuIGVycm9ycwogICAgICAgICBy
ZXR1cm4gY3Jhc2hfbG9ncworCisgICAgZGVmIF9pc19uZXdfY3Jhc2hfbG9nKHNlbGYsIGxvZ19j
b250ZW50cywgbmV3ZXJfdGhhbj1Ob25lKToKKyAgICAgICAgZGF0ZV9tYXRjaCA9IHJlLnNlYXJj
aCgnRGF0ZS9UaW1lOlxzKyguKz8pXG4nLCBsb2dfY29udGVudHMpCisgICAgICAgIGlmIG5vdCBu
ZXdlcl90aGFuIG9yIG5vdCBkYXRlX21hdGNoOgorICAgICAgICAgICAgcmV0dXJuIFRydWUKKyAg
ICAgICAgdHJ5OgorICAgICAgICAgICAgY3Jhc2hfdGltZV9zdHIgPSAnICcuam9pbihkYXRlX21h
dGNoLmdyb3VwKDEpLnNwbGl0KCIgIilbMDoyXSkKKyAgICAgICAgICAgIGNyYXNoX3RpbWUgPSBk
YXRldGltZS5kYXRldGltZS5zdHJwdGltZShjcmFzaF90aW1lX3N0ciwgJyVZLSVtLSVkICVIOiVN
OiVTLiVmJykKKyAgICAgICAgICAgIHN0YXJ0X3RpbWUgPSBkYXRldGltZS5kYXRldGltZS5mcm9t
dGltZXN0YW1wKGZsb2F0KG5ld2VyX3RoYW4pKQorICAgICAgICBleGNlcHQgVmFsdWVFcnJvcjoK
KyAgICAgICAgICAgIHJldHVybiBUcnVlCisgICAgICAgIHJldHVybiBjcmFzaF90aW1lID4gc3Rh
cnRfdGltZQo=
</data>
<flag name="review"
          id="297584"
          type_id="1"
          status="-"
          setter="ap"
    />
    <flag name="commit-queue"
          id="297585"
          type_id="3"
          status="-"
          setter="ap"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>273123</attachid>
            <date>2016-03-05 20:44:36 -0800</date>
            <delta_ts>2016-03-07 12:13:31 -0800</delta_ts>
            <desc>Updated Patch</desc>
            <filename>patch_crashlog_timestamp_v2</filename>
            <type>text/plain</type>
            <size>3976</size>
            <attacher name="Aakash Jain">aakash_jain</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDE5NzYzMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE4IEBACisyMDE2LTAzLTA1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv
bT4KKworICAgICAgICB3ZWJraXRweSBzaG91bGQgdmVyaWZ5IHRpbWVzdGFtcCBmcm9tIENyYXNo
TG9ncyB3aGlsZSBjb2xsZWN0aW5nIGFsbCBjcmFzaCBsb2dzCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTUwMDAKKyAgICAgICAgPHJkYXI6Ly9wcm9i
bGVtLzI0ODYwMjE5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2NyYXNobG9ncy5weToKKyAg
ICAgICAgKENyYXNoTG9ncy5fZmluZF9hbGxfbG9nc19kYXJ3aW4pOiBNYWtlIHN1cmUgdGhhdCBj
cmFzaCBsb2cgdGltZXN0YW1wIGlzIHdpdGhpbiBleHBlY3RlZCAKKyAgICAgICAgdGltZSByYW5n
ZSwgYmVjYXVzZSBmaWxlIG1vZGlmaWNhdGlvbiB0aW1lIGlzIG5vdCBhbHdheXMgYWNjdXJhdGUu
CisgICAgICAgIChDcmFzaExvZ3MuZ2V0X3RpbWVzdGFtcF9mcm9tX2xvZ3MpOiBQYXJzZSB0aGUg
dGltZXN0YW1wIGZyb20gbG9ncy4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9z
eXN0ZW0vY3Jhc2hsb2dzX3VuaXR0ZXN0LnB5OgorICAgICAgICAoQ3Jhc2hMb2dzVGVzdC50ZXN0
X2dldF90aW1lc3RhbXBfZnJvbV9sb2dzX2Rhcndpbik6IFRlc3RjYXNlIGZvciBhYm92ZSBmdW5j
dGlvbi4KKwogMjAxNi0wMy0wNSAgQ2FybG9zIEFsYmVydG8gTG9wZXogUGVyZXogIDxjbG9wZXpA
aWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBGaXggbG9nZ2luZyBkZXRhaWxzIGFmdGVyIHIx
OTc1MDUgKFJ1biB0aGUgcnVuLWJlbmNobWFyayBzY3JpcHQgb24gdGhlIHBlcmZvcm1hbmNlIGJv
dC4pCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vY3Jhc2hsb2dz
LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9j
cmFzaGxvZ3MucHkJKHJldmlzaW9uIDE5NzYzMSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv
Y29tbW9uL3N5c3RlbS9jcmFzaGxvZ3MucHkJKHdvcmtpbmcgY29weSkKQEAgLTI5LDYgKzI5LDcg
QEAKIAogaW1wb3J0IGNvZGVjcwogaW1wb3J0IHJlCitpbXBvcnQgZGF0ZXRpbWUKIAogCiBjbGFz
cyBDcmFzaExvZ3Mob2JqZWN0KToKQEAgLTEzOSw2ICsxNDAsMTMgQEAgY2xhc3MgQ3Jhc2hMb2dz
KG9iamVjdCk6CiAgICAgICAgICAgICAgICAgICAgIHJlc3VsdF9uYW1lID0gIlVua25vd24iCiAg
ICAgICAgICAgICAgICAgICAgIHBpZCA9IDAKICAgICAgICAgICAgICAgICAgICAgbG9nX2NvbnRl
bnRzID0gc2VsZi5faG9zdC5maWxlc3lzdGVtLnJlYWRfdGV4dF9maWxlKHBhdGgpCisgICAgICAg
ICAgICAgICAgICAgICMgVmVyaWZ5IHRpbWVzdGFtcCBmcm9tIGxvZyBjb250ZW50cworICAgICAg
ICAgICAgICAgICAgICBjcmFzaF90aW1lID0gc2VsZi5nZXRfdGltZXN0YW1wX2Zyb21fbG9ncyhs
b2dfY29udGVudHMpCisgICAgICAgICAgICAgICAgICAgIGlmIGNyYXNoX3RpbWUgaXMgbm90IE5v
bmUgYW5kIG5ld2VyX3RoYW4gaXMgbm90IE5vbmU6CisgICAgICAgICAgICAgICAgICAgICAgICBz
dGFydF90aW1lID0gZGF0ZXRpbWUuZGF0ZXRpbWUuZnJvbXRpbWVzdGFtcChmbG9hdChuZXdlcl90
aGFuKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIGlmIGNyYXNoX3RpbWUgPCBzdGFydF90aW1l
OgorICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlCisKICAgICAgICAgICAgICAg
ICAgICAgbWF0Y2ggPSBmaXJzdF9saW5lX3JlZ2V4Lm1hdGNoKGxvZ19jb250ZW50c1swOmxvZ19j
b250ZW50cy5maW5kKCdcbicpXSkKICAgICAgICAgICAgICAgICAgICAgaWYgbWF0Y2g6CiAgICAg
ICAgICAgICAgICAgICAgICAgICBwcm9jZXNzX25hbWUgPSBtYXRjaC5ncm91cCgncHJvY2Vzc19u
YW1lJykKQEAgLTE1OCwzICsxNjYsMTQgQEAgY2xhc3MgQ3Jhc2hMb2dzKG9iamVjdCk6CiAgICAg
ICAgIGlmIGluY2x1ZGVfZXJyb3JzIGFuZCBlcnJvcnMgYW5kIGxlbihjcmFzaF9sb2dzKSA9PSAw
OgogICAgICAgICAgICAgcmV0dXJuIGVycm9ycwogICAgICAgICByZXR1cm4gY3Jhc2hfbG9ncwor
CisgICAgZGVmIGdldF90aW1lc3RhbXBfZnJvbV9sb2dzKHNlbGYsIGxvZ19jb250ZW50cyk6Cisg
ICAgICAgIGRhdGVfbWF0Y2ggPSByZS5zZWFyY2goJ0RhdGUvVGltZTpccysoLis/KVxuJywgbG9n
X2NvbnRlbnRzKQorICAgICAgICBpZiBub3QgZGF0ZV9tYXRjaDoKKyAgICAgICAgICAgIHJldHVy
biBOb25lCisgICAgICAgIHRyeToKKyAgICAgICAgICAgIGNyYXNoX3RpbWVfc3RyID0gJyAnLmpv
aW4oZGF0ZV9tYXRjaC5ncm91cCgxKS5zcGxpdCgiICIpWzA6Ml0pCisgICAgICAgICAgICBjcmFz
aF90aW1lID0gZGF0ZXRpbWUuZGF0ZXRpbWUuc3RycHRpbWUoY3Jhc2hfdGltZV9zdHIsICclWS0l
bS0lZCAlSDolTTolUy4lZicpCisgICAgICAgIGV4Y2VwdCBWYWx1ZUVycm9yOgorICAgICAgICAg
ICAgcmV0dXJuIE5vbmUKKyAgICAgICAgcmV0dXJuIGNyYXNoX3RpbWUKSW5kZXg6IFRvb2xzL1Nj
cmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9jcmFzaGxvZ3NfdW5pdHRlc3QucHkKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2NyYXNobG9nc191
bml0dGVzdC5weQkocmV2aXNpb24gMTk3NjMxKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9j
b21tb24vc3lzdGVtL2NyYXNobG9nc191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMzM2
LDMgKzMzNiwxNiBAQCBjbGFzcyBDcmFzaExvZ3NUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAg
ICAgICAgZmlsZXN5c3RlbS5yZWFkX2JpbmFyeV9maWxlID0gYmFkX3JlYWQKICAgICAgICAgbG9n
ID0gY3Jhc2hfbG9ncy5maW5kX25ld2VzdF9sb2coIkR1bXBSZW5kZXJUcmVlIiwgMjg1MzEsIGlu
Y2x1ZGVfZXJyb3JzPVRydWUpCiAgICAgICAgIHNlbGYuYXNzZXJ0SW4oJ0lPRXJyb3I6IE5vIHN1
Y2ggZmlsZSBvciBkaXJlY3RvcnknLCBsb2cpCisKKyAgICBkZWYgdGVzdF9nZXRfdGltZXN0YW1w
X2Zyb21fbG9nc19kYXJ3aW4oc2VsZik6CisgICAgICAgIGlmIG5vdCBTeXN0ZW1Ib3N0KCkucGxh
dGZvcm0uaXNfbWFjKCk6CisgICAgICAgICAgICByZXR1cm4KKworICAgICAgICBjcmFzaF9yZXBv
cnQgPSBtYWtlX21vY2tfY3Jhc2hfcmVwb3J0X2RhcndpbignRHVtcFJlbmRlclRyZWUnLCAyODUy
OCkKKyAgICAgICAgY3Jhc2hfbG9ncyA9IENyYXNoTG9ncyhNb2NrU3lzdGVtSG9zdCgpKQorICAg
ICAgICBjcmFzaF90aW1lc3RhbXAgPSBjcmFzaF9sb2dzLmdldF90aW1lc3RhbXBfZnJvbV9sb2dz
KGNyYXNoX3JlcG9ydCkKKyAgICAgICAgc2VsZi5hc3NlcnRJbignMjAxMS0xMi0wNyAxMzoyNzoz
NC44MTYnLCBzdHIoY3Jhc2hfdGltZXN0YW1wKSkKKworICAgICAgICBjcmFzaF9yZXBvcnQgPSBj
cmFzaF9yZXBvcnQucmVwbGFjZSgiRGF0ZS9UaW1lIiwgIiIpCisgICAgICAgIGNyYXNoX3RpbWVz
dGFtcCA9IGNyYXNoX2xvZ3MuZ2V0X3RpbWVzdGFtcF9mcm9tX2xvZ3MoY3Jhc2hfcmVwb3J0KQor
ICAgICAgICBzZWxmLmFzc2VydElzTm9uZShjcmFzaF90aW1lc3RhbXApCg==
</data>
<flag name="review"
          id="297728"
          type_id="1"
          status="+"
          setter="ap"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>273201</attachid>
            <date>2016-03-07 12:13:31 -0800</date>
            <delta_ts>2016-03-07 13:40:27 -0800</delta_ts>
            <desc>Updated patch</desc>
            <filename>patch_crashlog_timestamp_v3</filename>
            <type>text/plain</type>
            <size>3916</size>
            <attacher name="Aakash Jain">aakash_jain</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDE5NzY5NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE4IEBACisyMDE2LTAzLTA3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv
bT4KKworICAgICAgICB3ZWJraXRweSBzaG91bGQgdmVyaWZ5IHRpbWVzdGFtcCBmcm9tIENyYXNo
TG9ncyB3aGlsZSBjb2xsZWN0aW5nIGFsbCBjcmFzaCBsb2dzCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTUwMDAKKyAgICAgICAgPHJkYXI6Ly9wcm9i
bGVtLzI0ODYwMjE5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2NyYXNobG9ncy5weToKKyAg
ICAgICAgKENyYXNoTG9ncy5fZmluZF9hbGxfbG9nc19kYXJ3aW4pOiBNYWtlIHN1cmUgdGhhdCBj
cmFzaCBsb2cgdGltZXN0YW1wIGlzIHdpdGhpbiBleHBlY3RlZCAKKyAgICAgICAgdGltZSByYW5n
ZSwgYmVjYXVzZSBmaWxlIG1vZGlmaWNhdGlvbiB0aW1lIGlzIG5vdCBhbHdheXMgYWNjdXJhdGUu
CisgICAgICAgIChDcmFzaExvZ3MuZ2V0X3RpbWVzdGFtcF9mcm9tX2xvZ3MpOiBQYXJzZSB0aGUg
dGltZXN0YW1wIGZyb20gbG9ncy4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9z
eXN0ZW0vY3Jhc2hsb2dzX3VuaXR0ZXN0LnB5OgorICAgICAgICAoQ3Jhc2hMb2dzVGVzdC50ZXN0
X2dldF90aW1lc3RhbXBfZnJvbV9sb2dzX2Rhcndpbik6IFRlc3RjYXNlIGZvciBhYm92ZSBmdW5j
dGlvbi4KKwogMjAxNi0wMy0wNiAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4K
IAogICAgICAgICBidWlsZC13ZWJraXQgcHJpbnRzIGFuIGVycm9yIG9uIGlPUyBzaW11bGF0b3Ig
Ym90cwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2NyYXNobG9n
cy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0v
Y3Jhc2hsb2dzLnB5CShyZXZpc2lvbiAxOTc2OTYpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5
L2NvbW1vbi9zeXN0ZW0vY3Jhc2hsb2dzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yOSw2ICsyOSw3
IEBACiAKIGltcG9ydCBjb2RlY3MKIGltcG9ydCByZQoraW1wb3J0IGRhdGV0aW1lCiAKIAogY2xh
c3MgQ3Jhc2hMb2dzKG9iamVjdCk6CkBAIC0xMzksNiArMTQwLDEzIEBAIGNsYXNzIENyYXNoTG9n
cyhvYmplY3QpOgogICAgICAgICAgICAgICAgICAgICByZXN1bHRfbmFtZSA9ICJVbmtub3duIgog
ICAgICAgICAgICAgICAgICAgICBwaWQgPSAwCiAgICAgICAgICAgICAgICAgICAgIGxvZ19jb250
ZW50cyA9IHNlbGYuX2hvc3QuZmlsZXN5c3RlbS5yZWFkX3RleHRfZmlsZShwYXRoKQorICAgICAg
ICAgICAgICAgICAgICAjIFZlcmlmeSB0aW1lc3RhbXAgZnJvbSBsb2cgY29udGVudHMKKyAgICAg
ICAgICAgICAgICAgICAgY3Jhc2hfdGltZSA9IHNlbGYuZ2V0X3RpbWVzdGFtcF9mcm9tX2xvZyhs
b2dfY29udGVudHMpCisgICAgICAgICAgICAgICAgICAgIGlmIGNyYXNoX3RpbWUgaXMgbm90IE5v
bmUgYW5kIG5ld2VyX3RoYW4gaXMgbm90IE5vbmU6CisgICAgICAgICAgICAgICAgICAgICAgICBz
dGFydF90aW1lID0gZGF0ZXRpbWUuZGF0ZXRpbWUuZnJvbXRpbWVzdGFtcChmbG9hdChuZXdlcl90
aGFuKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIGlmIGNyYXNoX3RpbWUgPCBzdGFydF90aW1l
OgorICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlCisKICAgICAgICAgICAgICAg
ICAgICAgbWF0Y2ggPSBmaXJzdF9saW5lX3JlZ2V4Lm1hdGNoKGxvZ19jb250ZW50c1swOmxvZ19j
b250ZW50cy5maW5kKCdcbicpXSkKICAgICAgICAgICAgICAgICAgICAgaWYgbWF0Y2g6CiAgICAg
ICAgICAgICAgICAgICAgICAgICBwcm9jZXNzX25hbWUgPSBtYXRjaC5ncm91cCgncHJvY2Vzc19u
YW1lJykKQEAgLTE1OCwzICsxNjYsMTQgQEAgY2xhc3MgQ3Jhc2hMb2dzKG9iamVjdCk6CiAgICAg
ICAgIGlmIGluY2x1ZGVfZXJyb3JzIGFuZCBlcnJvcnMgYW5kIGxlbihjcmFzaF9sb2dzKSA9PSAw
OgogICAgICAgICAgICAgcmV0dXJuIGVycm9ycwogICAgICAgICByZXR1cm4gY3Jhc2hfbG9ncwor
CisgICAgZGVmIGdldF90aW1lc3RhbXBfZnJvbV9sb2coc2VsZiwgbG9nX2NvbnRlbnRzKToKKyAg
ICAgICAgZGF0ZV9tYXRjaCA9IHJlLnNlYXJjaCgnRGF0ZS9UaW1lOlxzKyguKz8pXG4nLCBsb2df
Y29udGVudHMpCisgICAgICAgIGlmIG5vdCBkYXRlX21hdGNoOgorICAgICAgICAgICAgcmV0dXJu
IE5vbmUKKyAgICAgICAgdHJ5OgorICAgICAgICAgICAgY3Jhc2hfdGltZV9zdHIgPSAnICcuam9p
bihkYXRlX21hdGNoLmdyb3VwKDEpLnNwbGl0KCIgIilbMDoyXSkKKyAgICAgICAgICAgIGNyYXNo
X3RpbWUgPSBkYXRldGltZS5kYXRldGltZS5zdHJwdGltZShjcmFzaF90aW1lX3N0ciwgJyVZLSVt
LSVkICVIOiVNOiVTLiVmJykKKyAgICAgICAgZXhjZXB0IFZhbHVlRXJyb3I6CisgICAgICAgICAg
ICByZXR1cm4gTm9uZQorICAgICAgICByZXR1cm4gY3Jhc2hfdGltZQpJbmRleDogVG9vbHMvU2Ny
aXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2NyYXNobG9nc191bml0dGVzdC5weQo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vY3Jhc2hsb2dzX3Vu
aXR0ZXN0LnB5CShyZXZpc2lvbiAxOTc2OTYpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2Nv
bW1vbi9zeXN0ZW0vY3Jhc2hsb2dzX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zMzYs
MyArMzM2LDE2IEBAIGNsYXNzIENyYXNoTG9nc1Rlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAg
ICAgICBmaWxlc3lzdGVtLnJlYWRfYmluYXJ5X2ZpbGUgPSBiYWRfcmVhZAogICAgICAgICBsb2cg
PSBjcmFzaF9sb2dzLmZpbmRfbmV3ZXN0X2xvZygiRHVtcFJlbmRlclRyZWUiLCAyODUzMSwgaW5j
bHVkZV9lcnJvcnM9VHJ1ZSkKICAgICAgICAgc2VsZi5hc3NlcnRJbignSU9FcnJvcjogTm8gc3Vj
aCBmaWxlIG9yIGRpcmVjdG9yeScsIGxvZykKKworICAgIGRlZiB0ZXN0X2dldF90aW1lc3RhbXBf
ZnJvbV9sb2dzX2RhcndpbihzZWxmKToKKyAgICAgICAgaWYgbm90IFN5c3RlbUhvc3QoKS5wbGF0
Zm9ybS5pc19tYWMoKToKKyAgICAgICAgICAgIHJldHVybgorCisgICAgICAgIGNyYXNoX3JlcG9y
dCA9IG1ha2VfbW9ja19jcmFzaF9yZXBvcnRfZGFyd2luKCdEdW1wUmVuZGVyVHJlZScsIDI4NTI4
KQorICAgICAgICBjcmFzaF9sb2dzID0gQ3Jhc2hMb2dzKE1vY2tTeXN0ZW1Ib3N0KCkpCisgICAg
ICAgIGNyYXNoX3RpbWVzdGFtcCA9IGNyYXNoX2xvZ3MuZ2V0X3RpbWVzdGFtcF9mcm9tX2xvZyhj
cmFzaF9yZXBvcnQpCisgICAgICAgIHNlbGYuYXNzZXJ0SW4oJzIwMTEtMTItMDcgMTM6Mjc6MzQu
ODE2Jywgc3RyKGNyYXNoX3RpbWVzdGFtcCkpCisKKyAgICAgICAgY3Jhc2hfcmVwb3J0ID0gY3Jh
c2hfcmVwb3J0LnJlcGxhY2UoIkRhdGUvVGltZSIsICIiKQorICAgICAgICBjcmFzaF90aW1lc3Rh
bXAgPSBjcmFzaF9sb2dzLmdldF90aW1lc3RhbXBfZnJvbV9sb2coY3Jhc2hfcmVwb3J0KQorICAg
ICAgICBzZWxmLmFzc2VydElzTm9uZShjcmFzaF90aW1lc3RhbXApCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>