154994 2016-03-03 16:33:10 -0800 Octane/regexp's Exec function should benefit from array length accessor inlining 2016-03-03 18:44:13 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1170389 0 fpizlo 2016-03-03 16:33:10 -0800 Patch forthcoming. 1170392 1 272796 fpizlo 2016-03-03 16:35:16 -0800 Created attachment 272796 the patch 1170395 2 fpizlo 2016-03-03 16:39:31 -0800 WHOA EWS is not happy. Looks like EWS's fault and not this patch. 1170451 3 fpizlo 2016-03-03 18:44:13 -0800 Landed in http://trac.webkit.org/changeset/197542 272796 2016-03-03 16:35:16 -0800 2016-03-03 16:38:06 -0800 the patch blah.patch text/plain 4315 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk3NTI4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM0IEBA CisyMDE2LTAzLTAzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg T2N0YW5lL3JlZ2V4cCdzIEV4ZWMgZnVuY3Rpb24gc2hvdWxkIGJlbmVmaXQgZnJvbSBhcnJheSBs ZW5ndGggYWNjZXNzb3IgaW5saW5pbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE1NDk5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEl0IGRvZXM6CisKKyAgICAgICAgICAgIHZhciB0aGluZ3kgPSBibGFo Yml0dHkuYmxhaDsKKyAgICAgICAgICAgIGlmICh0aGluZ3kpCisgICAgICAgICAgICAgICAgZm9v ID0gdGhpbmd5Lmxlbmd0aDsKKworICAgICAgICBTbywgJ3RoaW5neScgaXMgU3BlY0FycmF5IHwg U3BlY090aGVyLCB3aGljaCBwcmV2ZW50cyB0aGUgYXJyYXkgbGVuZ3RoIGFjY2Vzc29yIGlubGlu aW5nIGZyb20KKyAgICAgICAga2lja2luZyBpbi4gT3VyIHN0cmF0ZWd5IGZvciB0aGlzIGVsc2V3 aGVyZSBpbiB0aGUgREZHIGlzIHRvIGFsbG93IGEgb25lLXRpbWUgc3BlY3VsYXRpb24gdGhhdAor ICAgICAgICB3ZSB3b24ndCBzZWUgU3BlY090aGVyLCBzaW5jZSAqdXN1YWxseSogd2Ugc2VlIFNw ZWNPdGhlciBtaXhlZCB3aXRoIG90aGVyIHN0dWZmIGluIGNhc2VzIGxpa2UKKyAgICAgICAgdGhp cyB3aGVyZSB0aGVyZSBpcyBzb21lIG51bGwgY2hlY2sgZ3VhcmRpbmcgdGhlIGNvZGUuCisKKyAg ICAgICAgVGhpcyBnaXZlcyBhbm90aGVyIHNsaWdodCBzcGVlZC11cCBvbiBPY3RhbmUvcmVnZXhw LgorCisgICAgICAgICogYnl0ZWNvZGUvU3BlY3VsYXRlZFR5cGUuaDoKKyAgICAgICAgKEpTQzo6 aXNDZWxsU3BlY3VsYXRpb24pOgorICAgICAgICAoSlNDOjppc0NlbGxPck90aGVyU3BlY3VsYXRp b24pOgorICAgICAgICAoSlNDOjppc05vdENlbGxTcGVjdWxhdGlvbik6CisgICAgICAgICogZGZn L0RGR0ZpeHVwUGhhc2UuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkZpeHVwUGhhc2U6OmZpeHVw Tm9kZSk6CisgICAgICAgICogZGZnL0RGR05vZGUuaDoKKyAgICAgICAgKEpTQzo6REZHOjpOb2Rl OjpzaG91bGRTcGVjdWxhdGVDZWxsKToKKyAgICAgICAgKEpTQzo6REZHOjpOb2RlOjpzaG91bGRT cGVjdWxhdGVDZWxsT3JPdGhlcik6CisgICAgICAgIChKU0M6OkRGRzo6Tm9kZTo6c2hvdWxkU3Bl Y3VsYXRlTm90Q2VsbCk6CisKIDIwMTYtMDMtMDMgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxl LmNvbT4KIAogICAgICAgICBERkcgc2hvdWxkIGJlIGFibGUgdG8gY29tcGlsZSBTdHJpbmdSZXBs YWNlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvU3BlY3VsYXRlZFR5cGUu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvU3BlY3VsYXRl ZFR5cGUuaAkocmV2aXNpb24gMTk3NTIzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVj b2RlL1NwZWN1bGF0ZWRUeXBlLmgJKHdvcmtpbmcgY29weSkKQEAgLTEwNCw2ICsxMDQsMTEgQEAg aW5saW5lIGJvb2wgaXNDZWxsU3BlY3VsYXRpb24oU3BlY3VsYXRlZAogICAgIHJldHVybiAhISh2 YWx1ZSAmIFNwZWNDZWxsKSAmJiAhKHZhbHVlICYgflNwZWNDZWxsKTsKIH0KIAoraW5saW5lIGJv b2wgaXNDZWxsT3JPdGhlclNwZWN1bGF0aW9uKFNwZWN1bGF0ZWRUeXBlIHZhbHVlKQoreworICAg IHJldHVybiAhIXZhbHVlICYmICEodmFsdWUgJiB+KFNwZWNDZWxsIHwgU3BlY090aGVyKSk7Cit9 CisKIGlubGluZSBib29sIGlzTm90Q2VsbFNwZWN1bGF0aW9uKFNwZWN1bGF0ZWRUeXBlIHZhbHVl KQogewogICAgIHJldHVybiAhKHZhbHVlICYgU3BlY0NlbGwpICYmIHZhbHVlOwpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdGaXh1cFBoYXNlLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ZpeHVwUGhhc2UuY3BwCShyZXZpc2lvbiAxOTc1 MjMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ZpeHVwUGhhc2UuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMDY0LDEyICsxMDY0LDEyIEBAIHByaXZhdGU6CiAKICAgICAgICAgY2Fz ZSBHZXRCeUlkOgogICAgICAgICBjYXNlIEdldEJ5SWRGbHVzaDogewotICAgICAgICAgICAgaWYg KCFub2RlLT5jaGlsZDEoKS0+c2hvdWxkU3BlY3VsYXRlQ2VsbCgpKQotICAgICAgICAgICAgICAg IGJyZWFrOwotCi0gICAgICAgICAgICAvLyBJZiB3ZSBoYWRuJ3QgZXhpdGVkIGJlY2F1c2Ugb2Yg QmFkQ2FjaGUsIEJhZEluZGV4aW5nVHlwZSwgb3IgRXhvdGljT2JqZWN0TW9kZSwgdGhlbgotICAg ICAgICAgICAgLy8gbGVhdmUgdGhpcyBhcyBhIEdldEJ5SWQuCi0gICAgICAgICAgICBpZiAoIW1f Z3JhcGguaGFzRXhpdFNpdGUobm9kZS0+b3JpZ2luLnNlbWFudGljLCBCYWRDYWNoZSkKKyAgICAg ICAgICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCBiZSBkb25lIGluIHRoZSBCeXRlQ29kZVBhcnNl ciBiYXNlZCBvbiByZWFkaW5nIHRoZQorICAgICAgICAgICAgLy8gUG9seW1vcnBoaWNBY2Nlc3Ms IHdoaWNoIHdpbGwgc3VyZWx5IHRlbGwgdXMgdGhhdCB0aGlzIGlzIGEgQWNjZXNzQ2FzZTo6QXJy YXlMZW5ndGguCisgICAgICAgICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTU0OTkwCisgICAgICAgICAgICBpZiAobm9kZS0+Y2hpbGQxKCktPnNob3VsZFNw ZWN1bGF0ZUNlbGxPck90aGVyKCkKKyAgICAgICAgICAgICAgICAmJiAhbV9ncmFwaC5oYXNFeGl0 U2l0ZShub2RlLT5vcmlnaW4uc2VtYW50aWMsIEJhZFR5cGUpCisgICAgICAgICAgICAgICAgJiYg IW1fZ3JhcGguaGFzRXhpdFNpdGUobm9kZS0+b3JpZ2luLnNlbWFudGljLCBCYWRDYWNoZSkKICAg ICAgICAgICAgICAgICAmJiAhbV9ncmFwaC5oYXNFeGl0U2l0ZShub2RlLT5vcmlnaW4uc2VtYW50 aWMsIEJhZEluZGV4aW5nVHlwZSkKICAgICAgICAgICAgICAgICAmJiAhbV9ncmFwaC5oYXNFeGl0 U2l0ZShub2RlLT5vcmlnaW4uc2VtYW50aWMsIEV4b3RpY09iamVjdE1vZGUpKSB7CiAgICAgICAg ICAgICAgICAgYXV0byB1aWQgPSBtX2dyYXBoLmlkZW50aWZpZXJzKClbbm9kZS0+aWRlbnRpZmll ck51bWJlcigpXTsKQEAgLTEwNzgsNyArMTA3OCw5IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAg ICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KLSAgICAgICAg ICAgIGZpeEVkZ2U8Q2VsbFVzZT4obm9kZS0+Y2hpbGQxKCkpOworCisgICAgICAgICAgICBpZiAo bm9kZS0+Y2hpbGQxKCktPnNob3VsZFNwZWN1bGF0ZUNlbGwoKSkKKyAgICAgICAgICAgICAgICBm aXhFZGdlPENlbGxVc2U+KG5vZGUtPmNoaWxkMSgpKTsKICAgICAgICAgICAgIGJyZWFrOwogICAg ICAgICB9CiAgICAgICAgICAgICAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH Tm9kZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZS5o CShyZXZpc2lvbiAxOTc1MjMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR05vZGUu aAkod29ya2luZyBjb3B5KQpAQCAtMjA2Nyw2ICsyMDY3LDExIEBAIHN0cnVjdCBOb2RlIHsKICAg ICAgICAgcmV0dXJuIGlzQ2VsbFNwZWN1bGF0aW9uKHByZWRpY3Rpb24oKSk7CiAgICAgfQogICAg IAorICAgIGJvb2wgc2hvdWxkU3BlY3VsYXRlQ2VsbE9yT3RoZXIoKQorICAgIHsKKyAgICAgICAg cmV0dXJuIGlzQ2VsbE9yT3RoZXJTcGVjdWxhdGlvbihwcmVkaWN0aW9uKCkpOworICAgIH0KKyAg ICAKICAgICBib29sIHNob3VsZFNwZWN1bGF0ZU5vdENlbGwoKQogICAgIHsKICAgICAgICAgcmV0 dXJuIGlzTm90Q2VsbFNwZWN1bGF0aW9uKHByZWRpY3Rpb24oKSk7Cg==