154986 2016-03-03 15:32:20 -0800 Drop DocumentSharedObjectPool immediately when going into PageCache. 2016-03-24 19:25:59 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Performance P2 Normal --- 1 kling kling cdumez commit-queue esprehn+autocc kangil.han oldest_to_newest 1170340 0 kling 2016-03-03 15:32:20 -0800 We can reclaim ElementData memory sooner if we drop the DocumentSharedObjectPool the instant we go into PageCache. 1170341 1 272780 kling 2016-03-03 15:32:57 -0800 Created attachment 272780 Patch 1170344 2 272780 koivisto 2016-03-03 15:39:21 -0800 Comment on attachment 272780 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272780&action=review > Source/WebCore/dom/Document.cpp:5049 > -void Document::sharedObjectPoolClearTimerFired() > +void Document::clearSharedObjectPool() I often keep *TimerFired function that just calls a payload function. Makes it easier to see what is what. 1170554 3 272780 commit-queue 2016-03-04 01:02:51 -0800 Comment on attachment 272780 Patch Clearing flags on attachment: 272780 Committed r197552: <http://trac.webkit.org/changeset/197552> 1170555 4 commit-queue 2016-03-04 01:02:55 -0800 All reviewed patches have been landed. Closing bug. 1176855 5 cdumez 2016-03-21 15:07:36 -0700 Reverted r197552 for reason: May have caused a ~2% PLT regression on iOS Committed r198500: <http://trac.webkit.org/changeset/198500> 1177853 6 cdumez 2016-03-24 19:24:53 -0700 Reverted r198500 for reason: Roll back in r197552 as it did not seem to cause a PLT regression after all Committed r198658: <http://trac.webkit.org/changeset/198658> 1177854 7 cdumez 2016-03-24 19:25:59 -0700 Re-landed in r198658 as it does not seem it caused a PLT regression after all. Sorry about the noise. 272780 2016-03-03 15:32:57 -0800 2016-03-04 01:02:51 -0800 Patch bug-154986.diff text/plain 2974 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzNDYxN2U2Li5kMDkyODJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTYtMDMtMDMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIERyb3AgRG9jdW1lbnRTaGFyZWRPYmplY3RQb29sIGltbWVkaWF0ZWx5IHdoZW4gZ29pbmcg aW50byBQYWdlQ2FjaGUuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xNTQ5ODY+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIERvY3Vt ZW50U2hhcmVkT2JqZWN0UG9vbCBpcyBhIHdlaXJkbHkgZWZmaWNpZW50IGxpdHRsZSBvcHRpbWl6 YXRpb24KKyAgICAgICAgdGhhdCBkZWR1cGxpY2F0ZXMgRWxlbWVudERhdGEgZHVyaW5nIHRoZSBm aXJzdCAxMHMgb2YgYSBEb2N1bWVudCdzIGxpZmV0aW1lLgorICAgICAgICBXaGlsZSBpdCdzIHVw LCBldmVyeSBFbGVtZW50RGF0YSBjcmVhdGVkIHdpbGwgcGVyc2lzdCBzbyBpdCBjYW4gYmUgdXNl ZCBmb3IKKyAgICAgICAgZGVkdXBsaWNhdGlvbi4KKworICAgICAgICBJZiBhIERvY3VtZW50IGdv ZXMgaW50byB0aGUgUGFnZUNhY2hlIHdoaWxlIGl0cyBzaGFyZWQgb2JqZWN0IHBvb2wgaXMgc3Rp bGwKKyAgICAgICAgYWxpdmUsIHdlIGNhbiBqdXN0IGtpbGwgaXQgcmlnaHQgYXdheS4gVGhpcyB3 aWxsIHNvbWV0aW1lcyBhbGxvdyB1cyB0byBmcmVlCisgICAgICAgIGEgYnVuY2ggb2YgRWxlbWVu dERhdGEgc29vbmVyLgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkRvY3VtZW50OjpEb2N1bWVudCk6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6 c2V0SW5QYWdlQ2FjaGUpOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmNsZWFyU2hhcmVk T2JqZWN0UG9vbCk6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6c2hhcmVkT2JqZWN0UG9v bENsZWFyVGltZXJGaXJlZCk6IERlbGV0ZWQuCisgICAgICAgICogZG9tL0RvY3VtZW50Lmg6CisK IDIwMTYtMDMtMDMgIERhdmUgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgQWRk IHN1cHBvcnQgZm9yIHRoZSAibGFzdCIgdmFsdWUgb2YgaGFuZ2luZy1wdW5jdHVhdGlvbgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggMTQ5ZjhmNS4uMDczMWZjNSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9j dW1lbnQuY3BwCkBAIC01MzIsNyArNTMyLDcgQEAgRG9jdW1lbnQ6OkRvY3VtZW50KEZyYW1lKiBm cmFtZSwgY29uc3QgVVJMJiB1cmwsIHVuc2lnbmVkIGRvY3VtZW50Q2xhc3NlcywgdW5zaWcKICAg ICAsIG1fc2NoZWR1bGVkVGFza3NBcmVTdXNwZW5kZWQoZmFsc2UpCiAgICAgLCBtX3Zpc3VhbFVw ZGF0ZXNBbGxvd2VkKHRydWUpCiAgICAgLCBtX3Zpc3VhbFVwZGF0ZXNTdXBwcmVzc2lvblRpbWVy KCp0aGlzLCAmRG9jdW1lbnQ6OnZpc3VhbFVwZGF0ZXNTdXBwcmVzc2lvblRpbWVyRmlyZWQpCi0g ICAgLCBtX3NoYXJlZE9iamVjdFBvb2xDbGVhclRpbWVyKCp0aGlzLCAmRG9jdW1lbnQ6OnNoYXJl ZE9iamVjdFBvb2xDbGVhclRpbWVyRmlyZWQpCisgICAgLCBtX3NoYXJlZE9iamVjdFBvb2xDbGVh clRpbWVyKCp0aGlzLCAmRG9jdW1lbnQ6OmNsZWFyU2hhcmVkT2JqZWN0UG9vbCkKICNpZm5kZWYg TkRFQlVHCiAgICAgLCBtX2RpZERpc3BhdGNoVmlld3BvcnRQcm9wZXJ0aWVzQ2hhbmdlZChmYWxz ZSkKICNlbmRpZgpAQCAtNDU5OSw2ICs0NTk5LDcgQEAgdm9pZCBEb2N1bWVudDo6c2V0SW5QYWdl Q2FjaGUoYm9vbCBmbGFnKQogCiAgICAgICAgIGNsZWFyU3R5bGVSZXNvbHZlcigpOwogICAgICAg ICBjbGVhclNlbGVjdG9yUXVlcnlDYWNoZSgpOworICAgICAgICBjbGVhclNoYXJlZE9iamVjdFBv b2woKTsKICAgICB9IGVsc2UgewogICAgICAgICBpZiAoY2hpbGROZWVkc1N0eWxlUmVjYWxjKCkp CiAgICAgICAgICAgICBzY2hlZHVsZVN0eWxlUmVjYWxjKCk7CkBAIC01MDQ1LDkgKzUwNDYsMTAg QEAgdm9pZCBEb2N1bWVudDo6ZmluaXNoZWRQYXJzaW5nKCkKICAgICBtX2NhY2hlZFJlc291cmNl TG9hZGVyLT5jbGVhclByZWxvYWRzKCk7CiB9CiAKLXZvaWQgRG9jdW1lbnQ6OnNoYXJlZE9iamVj dFBvb2xDbGVhclRpbWVyRmlyZWQoKQordm9pZCBEb2N1bWVudDo6Y2xlYXJTaGFyZWRPYmplY3RQ b29sKCkKIHsKICAgICBtX3NoYXJlZE9iamVjdFBvb2wgPSBudWxscHRyOworICAgIG1fc2hhcmVk T2JqZWN0UG9vbENsZWFyVGltZXIuc3RvcCgpOwogfQogCiAjaWYgRU5BQkxFKFRFTEVQSE9ORV9O VU1CRVJfREVURUNUSU9OKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50 LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAppbmRleCAxZDcyZmRlLi42YzA1MGJh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnQuaApAQCAtMTcyMSw3ICsxNzIxLDcgQEAgcHJpdmF0ZToKIAog ICAgIFJlZlB0cjxOYW1lZEZsb3dDb2xsZWN0aW9uPiBtX25hbWVkRmxvd3M7CiAKLSAgICB2b2lk IHNoYXJlZE9iamVjdFBvb2xDbGVhclRpbWVyRmlyZWQoKTsKKyAgICB2b2lkIGNsZWFyU2hhcmVk T2JqZWN0UG9vbCgpOwogICAgIFRpbWVyIG1fc2hhcmVkT2JqZWN0UG9vbENsZWFyVGltZXI7CiAK ICAgICBzdGQ6OnVuaXF1ZV9wdHI8RG9jdW1lbnRTaGFyZWRPYmplY3RQb29sPiBtX3NoYXJlZE9i amVjdFBvb2w7Cg==