154978 2016-03-03 11:42:50 -0800 Update style guide to reflect our style of only using "override" or "final" when overriding virtual methods 2016-03-06 14:30:29 -0800 1 1 1 Unclassified WebKit WebKit Website WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam bfulgham darin ggaren jond timothy oldest_to_newest 1170294 0 saam 2016-03-03 11:42:50 -0800 Opposed to only using "virtual" or both "virtual" and "override" 1170539 1 272837 saam 2016-03-03 23:48:06 -0800 Created attachment 272837 patch 1171033 2 272837 darin 2016-03-04 14:06:05 -0800 Comment on attachment 272837 patch This is good, but you should probably revise to include the rule about final. We want to use exactly one of final, override, and virtual. 1171456 3 273144 saam 2016-03-06 14:28:15 -0800 Created attachment 273144 patch for landing 1171457 4 273145 saam 2016-03-06 14:29:24 -0800 Created attachment 273145 patch for landing v2 changed bug title to reflect "final" keyword 1171458 5 saam 2016-03-06 14:30:29 -0800 landed in: http://trac.webkit.org/changeset/197643 272837 2016-03-03 23:48:06 -0800 2016-03-06 14:28:15 -0800 patch b-backup.diff text/plain 2188 saam SW5kZXg6IFdlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNp dGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCShyZXZpc2lvbiAxOTc1NTApCisrKyBXZWJzaXRlcy93 ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE2 LTAzLTAzICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0 ZSBzdHlsZSBndWlkZSB0byByZWZsZWN0IG91ciBzdHlsZSBvZiBvbmx5IHVzaW5nICJvdmVycmlk ZSIgd2hlbiBvdmVycmlkaW5nIHZpcnR1YWwgbWV0aG9kcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0OTc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjb2RlLXN0eWxlLm1kOgorCiAyMDE2LTAyLTI5 ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFtERkdd W0ZUTF1bQjNdIFN1cHBvcnQgZmxvb3IgYW5kIGNlaWwKSW5kZXg6IFdlYnNpdGVzL3dlYmtpdC5v cmcvY29kZS1zdHlsZS5tZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJzaXRlcy93ZWJraXQub3JnL2NvZGUt c3R5bGUubWQJKHJldmlzaW9uIDE5NzIxMikKKysrIFdlYnNpdGVzL3dlYmtpdC5vcmcvY29kZS1z dHlsZS5tZAkod29ya2luZyBjb3B5KQpAQCAtMTE4Nyw0ICsxMTg3LDQ5IEBAIGRyYXdKcGcoKTsg Ly8gRklYTUUoam9lKTogTWFrZSB0aGlzIGNvZGUKIAogYGBgY3BwCiBkcmF3SnBnKCk7IC8vIFRP RE86IE1ha2UgdGhpcyBjb2RlIGhhbmRsZSBqcGcgaW4gYWRkaXRpb24gdG8gdGhlIHBuZyBzdXBw b3J0LgotYGBgClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQorYGBgCisKKyMjIyBPdmVycmlk aW5nIFZpcnR1YWwgTWV0aG9kcworCitbXSgjb3ZlcnJpZGUtbWV0aG9kcykgVGhlIGJhc2UgbGV2 ZWwgZGVjbGFyYXRpb24gb2YgYSB2aXJ0dWFsIG1ldGhvZCBpbnNpZGUgYSBjbGFzcyBtdXN0IGJl IGRlY2xhcmVkIHdpdGggdGhlIGB2aXJ0dWFsYCBrZXl3b3JkLiBBbGwgc3ViY2xhc3NlcyBvZiB0 aGF0IGNsYXNzIG11c3Qgc3BlY2lmeSB0aGUgYG92ZXJyaWRlYCBrZXl3b3JkIHdoZW4gb3ZlcnJp ZGluZyB0aGUgdmlydHVhbCBtZXRob2QuCisKKyMjIyMjIyBSaWdodDoKKworYGBgY3BwCitjbGFz cyBQZXJzb24geworcHVibGljOgorICAgIHZpcnR1YWwgU3RyaW5nIGRlc2NyaXB0aW9uKCkgeyAu Li4gfTsKK30KKworY2xhc3MgU3R1ZGVudCA6IHB1YmxpYyBQZXJzb24geworcHVibGljOgorICAg IFN0cmluZyBkZXNjcmlwdGlvbigpIG92ZXJyaWRlIHsgLi4uIH07IC8vIFRoaXMgaXMgY29ycmVj dCBiZWNhdXNlIGl0IG9ubHkgY29udGFpbnMgdGhlICJvdmVycmlkZSIga2V5d29yZCB0byBpbmRp Y2F0ZSB0aGF0IHRoZSBtZXRob2QgaXMgb3ZlcnJpZGRlbi4KK30KKworYGBgCisKKyMjIyMjIyBX cm9uZzoKKworYGBgY3BwCitjbGFzcyBQZXJzb24geworcHVibGljOgorICAgIHZpcnR1YWwgU3Ry aW5nIGRlc2NyaXB0aW9uKCkgeyAuLi4gfTsKK30KKworY2xhc3MgU3R1ZGVudCA6IHB1YmxpYyBQ ZXJzb24geworcHVibGljOgorICAgIHZpcnR1YWwgU3RyaW5nIGRlc2NyaXB0aW9uKCkgb3ZlcnJp ZGUgeyAuLi4gfTsgLy8gVGhpcyBpcyBpbmNvcnJlY3QgYmVjYXVzZSBpdCB1c2VzIGJvdGggdGhl ICJ2aXJ0dWFsIiBhbmQgIm92ZXJyaWRlIiBrZXl3b3JkcyB0byBpbmRpY2F0ZSB0aGF0IHRoZSBt ZXRob2QgaXMgb3ZlcnJpZGRlbi4KK30KK2BgYAorCitgYGBjcHAKK2NsYXNzIFBlcnNvbiB7Citw dWJsaWM6CisgICAgdmlydHVhbCBTdHJpbmcgZGVzY3JpcHRpb24oKSB7IC4uLiB9OworfQorCitj bGFzcyBTdHVkZW50IDogcHVibGljIFBlcnNvbiB7CitwdWJsaWM6CisgICAgdmlydHVhbCBTdHJp bmcgZGVzY3JpcHRpb24oKSB7IC4uLiB9OyAvLyBUaGlzIGlzIGluY29ycmVjdCBiZWNhdXNlIGl0 IHVzZXMgdGhlICJ2aXJ0dWFsIiBrZXl3b3JkIHRvIGluZGljYXRlIHRoYXQgdGhlIG1ldGhvZCBp cyBvdmVycmlkZGVuLgorfQorYGBgCg== 273144 2016-03-06 14:28:15 -0800 2016-03-06 14:29:24 -0800 patch for landing b-backup.diff text/plain 3172 saam SW5kZXg6IFdlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNp dGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCShyZXZpc2lvbiAxOTc2NDIpCisrKyBXZWJzaXRlcy93 ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE2 LTAzLTAzICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0 ZSBzdHlsZSBndWlkZSB0byByZWZsZWN0IG91ciBzdHlsZSBvZiBvbmx5IHVzaW5nICJvdmVycmlk ZSIgd2hlbiBvdmVycmlkaW5nIHZpcnR1YWwgbWV0aG9kcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0OTc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg RGFyaW4gQWRsZXIuCisKKyAgICAgICAgKiBjb2RlLXN0eWxlLm1kOgorCiAyMDE2LTAyLTI5ICBZ dXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFtERkddW0ZU TF1bQjNdIFN1cHBvcnQgZmxvb3IgYW5kIGNlaWwKSW5kZXg6IFdlYnNpdGVzL3dlYmtpdC5vcmcv Y29kZS1zdHlsZS5tZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJzaXRlcy93ZWJraXQub3JnL2NvZGUtc3R5 bGUubWQJKHJldmlzaW9uIDE5NzY0MikKKysrIFdlYnNpdGVzL3dlYmtpdC5vcmcvY29kZS1zdHls ZS5tZAkod29ya2luZyBjb3B5KQpAQCAtMTE4Nyw0ICsxMTg3LDc0IEBAIGRyYXdKcGcoKTsgLy8g RklYTUUoam9lKTogTWFrZSB0aGlzIGNvZGUKIAogYGBgY3BwCiBkcmF3SnBnKCk7IC8vIFRPRE86 IE1ha2UgdGhpcyBjb2RlIGhhbmRsZSBqcGcgaW4gYWRkaXRpb24gdG8gdGhlIHBuZyBzdXBwb3J0 LgotYGBgClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQorYGBgCisKKyMjIyBPdmVycmlkaW5n IFZpcnR1YWwgTWV0aG9kcworCitbXSgjb3ZlcnJpZGUtbWV0aG9kcykgVGhlIGJhc2UgbGV2ZWwg ZGVjbGFyYXRpb24gb2YgYSB2aXJ0dWFsIG1ldGhvZCBpbnNpZGUgYSBjbGFzcyBtdXN0IGJlIGRl Y2xhcmVkIHdpdGggdGhlIGB2aXJ0dWFsYCBrZXl3b3JkLiBBbGwgc3ViY2xhc3NlcyBvZiB0aGF0 IGNsYXNzIG11c3QgZWl0aGVyIHNwZWNpZnkgdGhlIGBvdmVycmlkZWAga2V5d29yZCB3aGVuIG92 ZXJyaWRpbmcgdGhlIHZpcnR1YWwgbWV0aG9kIG9yIHRoZSBgZmluYWxgIGtleXdvcmQgd2hlbiBv dmVycmlkaW5nIHRoZSB2aXJ0dWFsIG1ldGhvZCBhbmQgcmVxdWlyaW5nIHRoYXQgbm8gZnVydGhl ciBzdWJjbGFzc2VzIGNhbiBvdmVycmlkZSBpdC4gWW91IG5ldmVyIHdhbnQgdG8gYW5ub3RhdGUg YSBtZXRob2Qgd2l0aCBtb3JlIHRoYW4gb25lIG9mIHRoZSBgdmlydHVhbGAsIGBvdmVycmlkZWAs IG9yIGBmaW5hbGAga2V5d29yZHMuCisKKyMjIyMjIyBSaWdodDoKKworYGBgY3BwCitjbGFzcyBQ ZXJzb24geworcHVibGljOgorICAgIHZpcnR1YWwgU3RyaW5nIGRlc2NyaXB0aW9uKCkgeyAuLi4g fTsKK30KKworY2xhc3MgU3R1ZGVudCA6IHB1YmxpYyBQZXJzb24geworcHVibGljOgorICAgIFN0 cmluZyBkZXNjcmlwdGlvbigpIG92ZXJyaWRlIHsgLi4uIH07IC8vIFRoaXMgaXMgY29ycmVjdCBi ZWNhdXNlIGl0IG9ubHkgY29udGFpbnMgdGhlICJvdmVycmlkZSIga2V5d29yZCB0byBpbmRpY2F0 ZSB0aGF0IHRoZSBtZXRob2QgaXMgb3ZlcnJpZGRlbi4KK30KKworYGBgCisKK2BgYGNwcAorY2xh c3MgUGVyc29uIHsKK3B1YmxpYzoKKyAgICB2aXJ0dWFsIFN0cmluZyBkZXNjcmlwdGlvbigpIHsg Li4uIH07Cit9CisKK2NsYXNzIFN0dWRlbnQgOiBwdWJsaWMgUGVyc29uIHsKK3B1YmxpYzoKKyAg ICBTdHJpbmcgZGVzY3JpcHRpb24oKSBmaW5hbCB7IC4uLiB9OyAvLyBUaGlzIGlzIGNvcnJlY3Qg YmVjYXVzZSBpdCBvbmx5IGNvbnRhaW5zIHRoZSAiZmluYWwiIGtleXdvcmQgdG8gaW5kaWNhdGUg dGhhdCB0aGUgbWV0aG9kIGlzIG92ZXJyaWRkZW4gYW5kIHRoYXQgbm8gc3ViY2xhc3NlcyBvZiAi U3R1ZGVudCIgY2FuIG92ZXJyaWRlICJkZXNjcmlwdGlvbiIuCit9CisKK2BgYAorCisjIyMjIyMg V3Jvbmc6CisKK2BgYGNwcAorY2xhc3MgUGVyc29uIHsKK3B1YmxpYzoKKyAgICB2aXJ0dWFsIFN0 cmluZyBkZXNjcmlwdGlvbigpIHsgLi4uIH07Cit9CisKK2NsYXNzIFN0dWRlbnQgOiBwdWJsaWMg UGVyc29uIHsKK3B1YmxpYzoKKyAgICB2aXJ0dWFsIFN0cmluZyBkZXNjcmlwdGlvbigpIG92ZXJy aWRlIHsgLi4uIH07IC8vIFRoaXMgaXMgaW5jb3JyZWN0IGJlY2F1c2UgaXQgdXNlcyBib3RoIHRo ZSAidmlydHVhbCIgYW5kICJvdmVycmlkZSIga2V5d29yZHMgdG8gaW5kaWNhdGUgdGhhdCB0aGUg bWV0aG9kIGlzIG92ZXJyaWRkZW4uIEluc3RlYWQsIGl0IHNob3VsZCBvbmx5IHVzZSB0aGUgIm92 ZXJyaWRlIiBrZXl3b3JkLgorfQorYGBgCisKK2BgYGNwcAorY2xhc3MgUGVyc29uIHsKK3B1Ymxp YzoKKyAgICB2aXJ0dWFsIFN0cmluZyBkZXNjcmlwdGlvbigpIHsgLi4uIH07Cit9CisKK2NsYXNz IFN0dWRlbnQgOiBwdWJsaWMgUGVyc29uIHsKK3B1YmxpYzoKKyAgICB2aXJ0dWFsIFN0cmluZyBk ZXNjcmlwdGlvbigpIGZpbmFsIHsgLi4uIH07IC8vIFRoaXMgaXMgaW5jb3JyZWN0IGJlY2F1c2Ug aXQgdXNlcyBib3RoIHRoZSAidmlydHVhbCIgYW5kICJmaW5hbCIga2V5d29yZHMgdG8gaW5kaWNh dGUgdGhhdCB0aGUgbWV0aG9kIGlzIG92ZXJyaWRkZW4gYW5kIGZpbmFsLiBJbnN0ZWFkLCBpdCBz aG91bGQgb25seSB1c2UgdGhlICJmaW5hbCIga2V5d29yZC4KK30KK2BgYAorCitgYGBjcHAKK2Ns YXNzIFBlcnNvbiB7CitwdWJsaWM6CisgICAgdmlydHVhbCBTdHJpbmcgZGVzY3JpcHRpb24oKSB7 IC4uLiB9OworfQorCitjbGFzcyBTdHVkZW50IDogcHVibGljIFBlcnNvbiB7CitwdWJsaWM6Cisg ICAgdmlydHVhbCBTdHJpbmcgZGVzY3JpcHRpb24oKSB7IC4uLiB9OyAvLyBUaGlzIGlzIGluY29y cmVjdCBiZWNhdXNlIGl0IHVzZXMgdGhlICJ2aXJ0dWFsIiBrZXl3b3JkIHRvIGluZGljYXRlIHRo YXQgdGhlIG1ldGhvZCBpcyBvdmVycmlkZGVuLgorfQorYGBgCg== 273145 2016-03-06 14:29:24 -0800 2016-03-06 14:29:24 -0800 patch for landing v2 b-backup.diff text/plain 3183 saam SW5kZXg6IFdlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNp dGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCShyZXZpc2lvbiAxOTc2NDIpCisrKyBXZWJzaXRlcy93 ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE2 LTAzLTAzICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0 ZSBzdHlsZSBndWlkZSB0byByZWZsZWN0IG91ciBzdHlsZSBvZiBvbmx5IHVzaW5nICJvdmVycmlk ZSIgb3IgImZpbmFsIiB3aGVuIG92ZXJyaWRpbmcgdmlydHVhbCBtZXRob2RzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTQ5NzgKKworICAgICAgICBS ZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICAqIGNvZGUtc3R5bGUubWQ6CisKIDIw MTYtMDItMjkgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAg ICAgW0RGR11bRlRMXVtCM10gU3VwcG9ydCBmbG9vciBhbmQgY2VpbApJbmRleDogV2Vic2l0ZXMv d2Via2l0Lm9yZy9jb2RlLXN0eWxlLm1kCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNpdGVzL3dlYmtpdC5v cmcvY29kZS1zdHlsZS5tZAkocmV2aXNpb24gMTk3NjQyKQorKysgV2Vic2l0ZXMvd2Via2l0Lm9y Zy9jb2RlLXN0eWxlLm1kCSh3b3JraW5nIGNvcHkpCkBAIC0xMTg3LDQgKzExODcsNzQgQEAgZHJh d0pwZygpOyAvLyBGSVhNRShqb2UpOiBNYWtlIHRoaXMgY29kZQogCiBgYGBjcHAKIGRyYXdKcGco KTsgLy8gVE9ETzogTWFrZSB0aGlzIGNvZGUgaGFuZGxlIGpwZyBpbiBhZGRpdGlvbiB0byB0aGUg cG5nIHN1cHBvcnQuCi1gYGAKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCitgYGAKKworIyMj IE92ZXJyaWRpbmcgVmlydHVhbCBNZXRob2RzCisKK1tdKCNvdmVycmlkZS1tZXRob2RzKSBUaGUg YmFzZSBsZXZlbCBkZWNsYXJhdGlvbiBvZiBhIHZpcnR1YWwgbWV0aG9kIGluc2lkZSBhIGNsYXNz IG11c3QgYmUgZGVjbGFyZWQgd2l0aCB0aGUgYHZpcnR1YWxgIGtleXdvcmQuIEFsbCBzdWJjbGFz c2VzIG9mIHRoYXQgY2xhc3MgbXVzdCBlaXRoZXIgc3BlY2lmeSB0aGUgYG92ZXJyaWRlYCBrZXl3 b3JkIHdoZW4gb3ZlcnJpZGluZyB0aGUgdmlydHVhbCBtZXRob2Qgb3IgdGhlIGBmaW5hbGAga2V5 d29yZCB3aGVuIG92ZXJyaWRpbmcgdGhlIHZpcnR1YWwgbWV0aG9kIGFuZCByZXF1aXJpbmcgdGhh dCBubyBmdXJ0aGVyIHN1YmNsYXNzZXMgY2FuIG92ZXJyaWRlIGl0LiBZb3UgbmV2ZXIgd2FudCB0 byBhbm5vdGF0ZSBhIG1ldGhvZCB3aXRoIG1vcmUgdGhhbiBvbmUgb2YgdGhlIGB2aXJ0dWFsYCwg YG92ZXJyaWRlYCwgb3IgYGZpbmFsYCBrZXl3b3Jkcy4KKworIyMjIyMjIFJpZ2h0OgorCitgYGBj cHAKK2NsYXNzIFBlcnNvbiB7CitwdWJsaWM6CisgICAgdmlydHVhbCBTdHJpbmcgZGVzY3JpcHRp b24oKSB7IC4uLiB9OworfQorCitjbGFzcyBTdHVkZW50IDogcHVibGljIFBlcnNvbiB7CitwdWJs aWM6CisgICAgU3RyaW5nIGRlc2NyaXB0aW9uKCkgb3ZlcnJpZGUgeyAuLi4gfTsgLy8gVGhpcyBp cyBjb3JyZWN0IGJlY2F1c2UgaXQgb25seSBjb250YWlucyB0aGUgIm92ZXJyaWRlIiBrZXl3b3Jk IHRvIGluZGljYXRlIHRoYXQgdGhlIG1ldGhvZCBpcyBvdmVycmlkZGVuLgorfQorCitgYGAKKwor YGBgY3BwCitjbGFzcyBQZXJzb24geworcHVibGljOgorICAgIHZpcnR1YWwgU3RyaW5nIGRlc2Ny aXB0aW9uKCkgeyAuLi4gfTsKK30KKworY2xhc3MgU3R1ZGVudCA6IHB1YmxpYyBQZXJzb24gewor cHVibGljOgorICAgIFN0cmluZyBkZXNjcmlwdGlvbigpIGZpbmFsIHsgLi4uIH07IC8vIFRoaXMg aXMgY29ycmVjdCBiZWNhdXNlIGl0IG9ubHkgY29udGFpbnMgdGhlICJmaW5hbCIga2V5d29yZCB0 byBpbmRpY2F0ZSB0aGF0IHRoZSBtZXRob2QgaXMgb3ZlcnJpZGRlbiBhbmQgdGhhdCBubyBzdWJj bGFzc2VzIG9mICJTdHVkZW50IiBjYW4gb3ZlcnJpZGUgImRlc2NyaXB0aW9uIi4KK30KKworYGBg CisKKyMjIyMjIyBXcm9uZzoKKworYGBgY3BwCitjbGFzcyBQZXJzb24geworcHVibGljOgorICAg IHZpcnR1YWwgU3RyaW5nIGRlc2NyaXB0aW9uKCkgeyAuLi4gfTsKK30KKworY2xhc3MgU3R1ZGVu dCA6IHB1YmxpYyBQZXJzb24geworcHVibGljOgorICAgIHZpcnR1YWwgU3RyaW5nIGRlc2NyaXB0 aW9uKCkgb3ZlcnJpZGUgeyAuLi4gfTsgLy8gVGhpcyBpcyBpbmNvcnJlY3QgYmVjYXVzZSBpdCB1 c2VzIGJvdGggdGhlICJ2aXJ0dWFsIiBhbmQgIm92ZXJyaWRlIiBrZXl3b3JkcyB0byBpbmRpY2F0 ZSB0aGF0IHRoZSBtZXRob2QgaXMgb3ZlcnJpZGRlbi4gSW5zdGVhZCwgaXQgc2hvdWxkIG9ubHkg dXNlIHRoZSAib3ZlcnJpZGUiIGtleXdvcmQuCit9CitgYGAKKworYGBgY3BwCitjbGFzcyBQZXJz b24geworcHVibGljOgorICAgIHZpcnR1YWwgU3RyaW5nIGRlc2NyaXB0aW9uKCkgeyAuLi4gfTsK K30KKworY2xhc3MgU3R1ZGVudCA6IHB1YmxpYyBQZXJzb24geworcHVibGljOgorICAgIHZpcnR1 YWwgU3RyaW5nIGRlc2NyaXB0aW9uKCkgZmluYWwgeyAuLi4gfTsgLy8gVGhpcyBpcyBpbmNvcnJl Y3QgYmVjYXVzZSBpdCB1c2VzIGJvdGggdGhlICJ2aXJ0dWFsIiBhbmQgImZpbmFsIiBrZXl3b3Jk cyB0byBpbmRpY2F0ZSB0aGF0IHRoZSBtZXRob2QgaXMgb3ZlcnJpZGRlbiBhbmQgZmluYWwuIElu c3RlYWQsIGl0IHNob3VsZCBvbmx5IHVzZSB0aGUgImZpbmFsIiBrZXl3b3JkLgorfQorYGBgCisK K2BgYGNwcAorY2xhc3MgUGVyc29uIHsKK3B1YmxpYzoKKyAgICB2aXJ0dWFsIFN0cmluZyBkZXNj cmlwdGlvbigpIHsgLi4uIH07Cit9CisKK2NsYXNzIFN0dWRlbnQgOiBwdWJsaWMgUGVyc29uIHsK K3B1YmxpYzoKKyAgICB2aXJ0dWFsIFN0cmluZyBkZXNjcmlwdGlvbigpIHsgLi4uIH07IC8vIFRo aXMgaXMgaW5jb3JyZWN0IGJlY2F1c2UgaXQgdXNlcyB0aGUgInZpcnR1YWwiIGtleXdvcmQgdG8g aW5kaWNhdGUgdGhhdCB0aGUgbWV0aG9kIGlzIG92ZXJyaWRkZW4uCit9CitgYGAK