154952 2016-03-02 20:42:15 -0800 Drop [TreatNullAs=LegacyNullString] from HTMLBaseElement.href 2022-02-27 23:20:23 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://html.spec.whatwg.org/multipage/semantics.html#the-base-element WebExposed P2 Normal --- 1 cdumez cdumez commit-queue darin esprehn+autocc gyuyoung.kim kondapallykalyan rniwa sam oldest_to_newest 1170084 0 cdumez 2016-03-02 20:42:15 -0800 Drop [TreatNullAs=LegacyNullString] from HTMLBaseElement.href as this does not match the specification: https://html.spec.whatwg.org/multipage/semantics.html#the-base-element Firefox and Chrome both convert null to the string "null". 1170092 1 272726 cdumez 2016-03-02 21:07:46 -0800 Created attachment 272726 Patch 1170112 2 272726 rniwa 2016-03-02 22:09:43 -0800 Comment on attachment 272726 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272726&action=review > Source/WebCore/ChangeLog:14 > + No new tests, already covered by existing test. You're adding a test case to fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html so you should list that instead of saying there's an existing coverage. 1170117 3 cdumez 2016-03-02 22:31:29 -0800 Committed r197494: <http://trac.webkit.org/changeset/197494> 272726 2016-03-02 21:07:46 -0800 2022-02-27 23:20:23 -0800 Patch bug-154952-20160302210731.patch text/plain 4691 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3NDg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjA3OTAyNTUxMzBmZmQx ZmFlY2ExMjNlN2E1ZWM4ZDQ0YjliMmM0My4uYjUyNWQ1OTAyNDA4YmQ3MzY2NTFkNzgxMThjYTc0 NDgxZjQ5MTBhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTAzLTAyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCBbVHJlYXROdWxsQXM9 TGVnYWN5TnVsbFN0cmluZ10gZnJvbSBIVE1MQmFzZUVsZW1lbnQuaHJlZgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0OTUyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRHJvcCBbVHJlYXROdWxsQXM9TGVn YWN5TnVsbFN0cmluZ10gZnJvbSBIVE1MQmFzZUVsZW1lbnQuaHJlZiBhcyB0aGlzCisgICAgICAg IGRvZXMgbm90IG1hdGNoIHRoZSBzcGVjaWZpY2F0aW9uOgorICAgICAgICAtIGh0dHBzOi8vaHRt bC5zcGVjLndoYXR3Zy5vcmcvbXVsdGlwYWdlL3NlbWFudGljcy5odG1sI3RoZS1iYXNlLWVsZW1l bnQKKworICAgICAgICBGaXJlZm94IGFuZCBDaHJvbWUgYm90aCBjb252ZXJ0IG51bGwgdG8gdGhl IHN0cmluZyAibnVsbCIuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBhbHJlYWR5IGNvdmVyZWQg YnkgZXhpc3RpbmcgdGVzdC4KKworICAgICAgICAqIGh0bWwvSFRNTEJhc2VFbGVtZW50LmlkbDoK KwogMjAxNi0wMy0wMiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAg ICBIVE1MIHBhcnNlciBpbnN0YW50aWF0ZXMgYSBjdXN0b20gZWxlbWVudCBpbnNpZGUgYSB0ZW1w bGF0ZSBlbGVtZW50IHdpdGggYSB3cm9uZyBvd25lciBkb2N1bWVudApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MQmFzZUVsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MQmFzZUVsZW1lbnQuaWRsCmluZGV4IDkxOTEwMTQ5NDBiYzA1YzFiNTg1Y2RhYWVkOGIz OWFlYmUyZDg4MGIuLjU0NjJiZWM0NmEzYWU1M2ZhYTQ5MzBmNTczMzJmNjQxYmFjOTMwZmEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEJhc2VFbGVtZW50LmlkbAorKysgYi9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxCYXNlRWxlbWVudC5pZGwKQEAgLTE4LDggKzE4LDcgQEAK ICAqLwogCiBpbnRlcmZhY2UgSFRNTEJhc2VFbGVtZW50IDogSFRNTEVsZW1lbnQgewotICAgIC8v IEZJWE1FOiBUaGlzIHNob3VsZCBub3QgaGF2ZSBbVHJlYXROdWxsQXM9TGVnYWN5TnVsbFN0cmlu Z10uCi0gICAgW1RyZWF0TnVsbEFzPUxlZ2FjeU51bGxTdHJpbmddIGF0dHJpYnV0ZSBET01TdHJp bmcgaHJlZjsKKyAgICBhdHRyaWJ1dGUgRE9NU3RyaW5nIGhyZWY7CiAKICAgICBbUmVmbGVjdF0g YXR0cmlidXRlIERPTVN0cmluZyB0YXJnZXQ7CiB9OwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDc3MzliNGVjZWM5MzJmNGJl OTZlYzlkMTBlOTMxMzQ1OGJkYTk5ZjIuLjkwMThmOGQxOGQzZjgwNjU4NmMwYzc4NmZmYWMzMWFh ZTAxNWU1NTYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNi0wMy0wMiAgQ2hyaXMgRHVtZXog IDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIERyb3AgW1RyZWF0TnVsbEFzPUxlZ2FjeU51 bGxTdHJpbmddIGZyb20gSFRNTEJhc2VFbGVtZW50LmhyZWYKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDk1MgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSBleGlzdGluZyBsYXlvdXQgdGVzdCBu b3cgdGhhdCBIVE1MQmFzZUVsZW1lbnQuaHJlZiBzZXR0ZXIgbm8KKyAgICAgICAgbG9uZ2VyIHRy ZWF0cyBudWxsIGFzIHRoZSBlbXB0eSBzdHJpbmcuCisKKyAgICAgICAgKiBmYXN0L2RvbS9IVE1M QmFzZUVsZW1lbnQvaHJlZi1hdHRyaWJ1dGUtcmVzb2x2ZXMtd2l0aC1yZXNwZWN0LXRvLWRvY3Vt ZW50LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2RvbS9IVE1MQmFzZUVsZW1lbnQvaHJl Zi1hdHRyaWJ1dGUtcmVzb2x2ZXMtd2l0aC1yZXNwZWN0LXRvLWRvY3VtZW50Lmh0bWw6CisKIDIw MTYtMDMtMDIgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAgICAgICAg TWFya2luZyBzdG9yYWdlL2luZGV4ZWRkYi9vZGQtc3RyaW5ncy5odG1sIGFzIGZsYWt5IG9uIG1h Yy13azEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxCYXNlRWxlbWVudC9o cmVmLWF0dHJpYnV0ZS1yZXNvbHZlcy13aXRoLXJlc3BlY3QtdG8tZG9jdW1lbnQtZXhwZWN0ZWQu dHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEJhc2VFbGVtZW50L2hyZWYtYXR0cmlidXRl LXJlc29sdmVzLXdpdGgtcmVzcGVjdC10by1kb2N1bWVudC1leHBlY3RlZC50eHQKaW5kZXggYTdh YmQzZjY3NzFiYTNhMTMxNDY5YzhiOTc2Yzc4YzgxN2UwOWQ5OS4uYTQwNjA5OGQzNTM4NDc1NzU2 YTBlNTkyNjhjMmY1M2ZmZjJkNWVmMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9kb20v SFRNTEJhc2VFbGVtZW50L2hyZWYtYXR0cmlidXRlLXJlc29sdmVzLXdpdGgtcmVzcGVjdC10by1k b2N1bWVudC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEJhc2VF bGVtZW50L2hyZWYtYXR0cmlidXRlLXJlc29sdmVzLXdpdGgtcmVzcGVjdC10by1kb2N1bWVudC1l eHBlY3RlZC50eHQKQEAgLTEsNSArMSw3IEBACiBQQVNTIGVuZHNXaXRoKGRvY3VtZW50LnF1ZXJ5 U2VsZWN0b3IoJ2Jhc2UnKS5ocmVmLCAnZm9vL2Jhci8nKSBpcyB0cnVlCiBQQVNTIGVuZHNXaXRo KGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2Jhc2UnKS5ocmVmLCAnZm9vL2Jhci9mb28vYmFyLycp IGlzIGZhbHNlCitQQVNTIGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2Jhc2UnKS5oYXNBdHRyaWJ1 dGUoJ2hyZWYnKSBpcyB0cnVlCitQQVNTIGVuZHNXaXRoKGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3Io J2Jhc2UnKS5ocmVmLCAnL251bGwnKSBpcyB0cnVlCiBQQVNTIGRvY3VtZW50LnF1ZXJ5U2VsZWN0 b3IoJ2Jhc2UnKS5oYXNBdHRyaWJ1dGUoJ2hyZWYnKSBpcyBmYWxzZQogUEFTUyBlbmRzV2l0aChk b2N1bWVudC5xdWVyeVNlbGVjdG9yKCdiYXNlJykuaHJlZiwgJy9ocmVmLWF0dHJpYnV0ZS1yZXNv bHZlcy13aXRoLXJlc3BlY3QtdG8tZG9jdW1lbnQuaHRtbCcpIGlzIHRydWUKIFBBU1MgZG9jdW1l bnRXaXRob3V0QVZpZXcucXVlcnlTZWxlY3RvcignYmFzZScpLmhyZWYgaXMgIiIKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxCYXNlRWxlbWVudC9ocmVmLWF0dHJpYnV0ZS1y ZXNvbHZlcy13aXRoLXJlc3BlY3QtdG8tZG9jdW1lbnQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv ZG9tL0hUTUxCYXNlRWxlbWVudC9ocmVmLWF0dHJpYnV0ZS1yZXNvbHZlcy13aXRoLXJlc3BlY3Qt dG8tZG9jdW1lbnQuaHRtbAppbmRleCA1ZDdjOTMyYTBiMDg4OTZlNzY4NDI2MTZkOWFiNThlMGI3 NzU4NzM2Li5kNDZkY2ZlOTNiYjM3ZWFlYmQxYzc3YTllOWNiZGE1NTJlOWYzYjgzIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MQmFzZUVsZW1lbnQvaHJlZi1hdHRyaWJ1dGUt cmVzb2x2ZXMtd2l0aC1yZXNwZWN0LXRvLWRvY3VtZW50Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC9kb20vSFRNTEJhc2VFbGVtZW50L2hyZWYtYXR0cmlidXRlLXJlc29sdmVzLXdpdGgtcmVz cGVjdC10by1kb2N1bWVudC5odG1sCkBAIC0yMyw2ICsyMywxMCBAQCBzaG91bGRCZVRydWUoImVu ZHNXaXRoKGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2Jhc2UnKS5ocmVmLCAnZm9vL2Jhci8nKSIp Owogc2hvdWxkQmVGYWxzZSgiZW5kc1dpdGgoZG9jdW1lbnQucXVlcnlTZWxlY3RvcignYmFzZScp LmhyZWYsICdmb28vYmFyL2Zvby9iYXIvJykiKTsKIAogYmFzZS5ocmVmID0gbnVsbDsKK3Nob3Vs ZEJlVHJ1ZSgiZG9jdW1lbnQucXVlcnlTZWxlY3RvcignYmFzZScpLmhhc0F0dHJpYnV0ZSgnaHJl ZicpIik7CitzaG91bGRCZVRydWUoImVuZHNXaXRoKGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2Jh c2UnKS5ocmVmLCAnL251bGwnKSIpOworCitiYXNlLnJlbW92ZUF0dHJpYnV0ZSgnaHJlZicpOwog c2hvdWxkQmVGYWxzZSgiZG9jdW1lbnQucXVlcnlTZWxlY3RvcignYmFzZScpLmhhc0F0dHJpYnV0 ZSgnaHJlZicpIik7CiBzaG91bGRCZVRydWUoImVuZHNXaXRoKGRvY3VtZW50LnF1ZXJ5U2VsZWN0 b3IoJ2Jhc2UnKS5ocmVmLCAnL2hyZWYtYXR0cmlidXRlLXJlc29sdmVzLXdpdGgtcmVzcGVjdC10 by1kb2N1bWVudC5odG1sJykiKTsKIApAQCAtNTUsNCArNTksNCBAQCBuZXdXaW5kb3cuY2xvc2Uo KTsKIAogZmluaXNoSlNUZXN0KCk7CiAKLTwvc2NyaXB0PgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9m IGZpbGUKKzwvc2NyaXB0Pgo=