154949 2016-03-02 19:30:56 -0800 HTMLFormElement's named property getter does not return a RadioNodelist 2016-03-02 23:43:58 -0800 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://html.spec.whatwg.org/multipage/forms.html#the-form-element P2 Normal --- 1 frankolivier cdumez cdumez commit-queue darin koivisto rniwa sam oldest_to_newest 1170067 0 frankolivier 2016-03-02 19:30:56 -0800 See https://jsfiddle.net/mjba21mk/5/ <form name="f"> <input type="radio" name="r" value="value1" /> <input type="radio" name="r" value="value2" checked /> </form> document.f.r.value is undefined - as document.f.r is a NodeList document.f.r.value should be “value2” - as document.f.r should be a RadioNodeList Relevant spec https://w3c.github.io/html/single-page.html#the-htmlformcontrolscollection-interface Works in latest Chrome, Firefox; will be fixed soon in Edge This bug might be covered by https://bugs.webkit.org/show_bug.cgi?id=150957 Seen on https://www.washingtonpost.com/news/the-fix/wp/2015/10/06/hey-lets-all-make-our-own-donald-trump-hats/ User can’t create a white-and-gold hat in the MAKE A HAT GREAT AGAIN section 1170104 1 cdumez 2016-03-02 21:29:32 -0800 Did not mean to close this yet. 1170110 2 cdumez 2016-03-02 21:54:21 -0800 Actually, based on the test case, the issue is with HTMLFormElement's named property getter. 1170116 3 272732 cdumez 2016-03-02 22:28:50 -0800 Created attachment 272732 Patch 1170130 4 272732 commit-queue 2016-03-02 23:43:52 -0800 Comment on attachment 272732 Patch Clearing flags on attachment: 272732 Committed r197497: <http://trac.webkit.org/changeset/197497> 1170131 5 commit-queue 2016-03-02 23:43:58 -0800 All reviewed patches have been landed. Closing bug. 272732 2016-03-02 22:28:50 -0800 2016-03-02 23:43:52 -0800 Patch bug-154949-20160302222834.patch text/plain 5625 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3NDg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjA3OTAyNTUxMzBmZmQx ZmFlY2ExMjNlN2E1ZWM4ZDQ0YjliMmM0My4uZDM3MmQ0YTgzMzUzMzhjZTg3MWVkMjg4NWRhMjNi YjRmOGJhYzdhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE2LTAzLTAyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgSFRNTEZvcm1FbGVtZW50J3Mg bmFtZWQgcHJvcGVydHkgZ2V0dGVyIGRvZXMgbm90IHJldHVybiBhIFJhZGlvTm9kZWxpc3QKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDk0OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhUTUxGb3JtRWxl bWVudCdzIG5hbWVkIHByb3BlcnR5IGdldHRlciBzaG91bGQgcmV0dXJuIGEgUmFkaW9Ob2RlTGlz dAorICAgICAgICB3aGVuIHRoZXJlIGFyZSBzZXZlcmFsIG1hdGNoZXM6CisgICAgICAgIGh0dHBz Oi8vaHRtbC5zcGVjLndoYXR3Zy5vcmcvbXVsdGlwYWdlL2Zvcm1zLmh0bWwjdGhlLWZvcm0tZWxl bWVudAorCisgICAgICAgIFByZXZpb3VzbHksIFdlYktpdCByZXR1cm5lZCBhIGdlbmVyaWMgTm9k ZUxpc3QuIEFzIGEgcmVzdWx0LCB1c2VycworICAgICAgICBjYW5ub3QgY3JlYXRlIGEgd2hpdGUt YW5kLWdvbGQgaGF0IGluIHRoZSBNQUtFIEEgSEFUIEdSRUFUIEFHQUlOCisgICAgICAgIHNlY3Rp b24gYXQ6CisgICAgICAgIGh0dHBzOi8vd3d3Lndhc2hpbmd0b25wb3N0LmNvbS9uZXdzL3RoZS1m aXgvd3AvMjAxNS8xMC8wNi9oZXktbGV0cy1hbGwtbWFrZS1vdXItb3duLWRvbmFsZC10cnVtcC1o YXRzLworCisgICAgICAgIENocm9tZSBhbmQgRmlyZWZveCBhbHJlYWR5IG1hdGNoIHRoZSBzcGVj aWZpY2F0aW9uLiBFZGdlIHdpbGwgc29vbi4KKworICAgICAgICBUZXN0OiBmYXN0L2RvbS9IVE1M Rm9ybUVsZW1lbnQvbmFtZWQtcHJvcGVydHktZ2V0dGVyLXJhZGlvbm9kZWxpc3QuaHRtbAorCisg ICAgICAgICogYmluZGluZ3MvanMvSlNIVE1MRm9ybUVsZW1lbnRDdXN0b20uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6SlNIVE1MRm9ybUVsZW1lbnQ6Om5hbWVHZXR0ZXIpOgorCiAyMDE2LTAzLTAy ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEhUTUwgcGFyc2Vy IGluc3RhbnRpYXRlcyBhIGN1c3RvbSBlbGVtZW50IGluc2lkZSBhIHRlbXBsYXRlIGVsZW1lbnQg d2l0aCBhIHdyb25nIG93bmVyIGRvY3VtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9qcy9KU0hUTUxGb3JtRWxlbWVudEN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9qcy9KU0hUTUxGb3JtRWxlbWVudEN1c3RvbS5jcHAKaW5kZXggM2FlZDcwNTJmNDYx NWVmMGFjOTM1OWU3MWE5MTU4NzgwYjNiZDU3YS4uY2IyMTE5YjEwM2Y1YmY1ODcwMDAwZGRmYTY3 N2FmYzY1MDU1ZDFlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNI VE1MRm9ybUVsZW1lbnRDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L0pTSFRNTEZvcm1FbGVtZW50Q3VzdG9tLmNwcApAQCAtMzAsOCArMzAsNyBAQAogI2luY2x1ZGUg IkhUTUxDb2xsZWN0aW9uLmgiCiAjaW5jbHVkZSAiSFRNTEZvcm1FbGVtZW50LmgiCiAjaW5jbHVk ZSAiSlNET01XaW5kb3dDdXN0b20uaCIKLSNpbmNsdWRlICJKU05vZGVMaXN0LmgiCi0jaW5jbHVk ZSAiU3RhdGljTm9kZUxpc3QuaCIKKyNpbmNsdWRlICJKU1JhZGlvTm9kZUxpc3QuaCIKIAogdXNp bmcgbmFtZXNwYWNlIEpTQzsKIApAQCAtNDgsOCArNDcsNyBAQCBib29sIEpTSFRNTEZvcm1FbGVt ZW50OjpuYW1lR2V0dGVyKEV4ZWNTdGF0ZSogZXhlYywgUHJvcGVydHlOYW1lIHByb3BlcnR5TmFt ZSwgSgogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKLSAgICAvLyBGSVhNRTogSFRNTDUg c3BlY2lmaWVzIHRoYXQgdGhpcyBzaG91bGQgYmUgYSBSYWRpb05vZGVMaXN0LgotICAgIHZhbHVl ID0gdG9KUyhleGVjLCBnbG9iYWxPYmplY3QoKSwgU3RhdGljRWxlbWVudExpc3Q6OmFkb3B0KG5h bWVkSXRlbXMpLmdldCgpKTsKKyAgICB2YWx1ZSA9IHRvSlMoZXhlYywgZ2xvYmFsT2JqZWN0KCks IHdyYXBwZWQoKS5yYWRpb05vZGVMaXN0KHByb3BlcnR5TmFtZVRvQXRvbWljU3RyaW5nKHByb3Bl cnR5TmFtZSkpLmdldCgpKTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KIApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDc3MzliNGVj ZWM5MzJmNGJlOTZlYzlkMTBlOTMxMzQ1OGJkYTk5ZjIuLjJlNDZiM2IzNzY1N2ZhMjU4ZWE1NzIz OGJiOTViNTMzZmY5YTI4NjQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNi0wMy0wMiAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIEhUTUxGb3JtRWxlbWVudCdz IG5hbWVkIHByb3BlcnR5IGdldHRlciBkb2VzIG5vdCByZXR1cm4gYSBSYWRpb05vZGVsaXN0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTQ5NDkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbGF5b3V0 IHRlc3QgdG8gY29uZmlybSB0aGF0IEhUTUxGb3JtRWxlbWVudCdzIG5hbWVkIHByb3BlcnR5IGdl dHRlcgorICAgICAgICBkb2VzIGluZGVlZCByZXR1cm4gYSBSYWRpb05vZGVMaXN0IHdoZW4gdGhl cmUgYXJlIHNldmVyYWwgbWF0Y2hlcy4KKworICAgICAgICAqIGZhc3QvZG9tL0hUTUxGb3JtRWxl bWVudC9uYW1lZC1wcm9wZXJ0eS1nZXR0ZXItcmFkaW9ub2RlbGlzdC1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIGZhc3QvZG9tL0hUTUxGb3JtRWxlbWVudC9uYW1lZC1wcm9wZXJ0eS1n ZXR0ZXItcmFkaW9ub2RlbGlzdC5odG1sOiBBZGRlZC4KKwogMjAxNi0wMy0wMiAgUnlhbiBIYWRk YWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4KIAogICAgICAgICBNYXJraW5nIHN0b3JhZ2UvaW5k ZXhlZGRiL29kZC1zdHJpbmdzLmh0bWwgYXMgZmxha3kgb24gbWFjLXdrMQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEZvcm1FbGVtZW50L25hbWVkLXByb3BlcnR5LWdldHRl ci1yYWRpb25vZGVsaXN0LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxG b3JtRWxlbWVudC9uYW1lZC1wcm9wZXJ0eS1nZXR0ZXItcmFkaW9ub2RlbGlzdC1leHBlY3RlZC50 eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uNGIzYTIwMGY3NDE0NWIwMjcxZWEwMzljMTkxNTEwODkyOTllYWI0MAot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxGb3JtRWxlbWVudC9u YW1lZC1wcm9wZXJ0eS1nZXR0ZXItcmFkaW9ub2RlbGlzdC1leHBlY3RlZC50eHQKQEAgLTAsMCAr MSwxNSBAQAorVGVzdHMgdGhhdCBIVE1MRm9ybUVsZW1lbnQncyBuYW1lZCBwcm9wZXJ0eSBnZXR0 ZXIgcmV0dXJucyBhIFJhZGlvTm9kZUxpc3QgaWYgdGhlcmUgYXJlIHNldmVyYWwgbWF0Y2hpbmcg ZWxlbWVudHMuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIg bWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIHJhZGlvTm9k ZUxpc3QuX19wcm90b19fIGlzIFJhZGlvTm9kZUxpc3QucHJvdG90eXBlCitQQVNTIHJhZGlvTm9k ZUxpc3QubGVuZ3RoIGlzIDMKK1BBU1MgcmFkaW9Ob2RlTGlzdFswXSBpcyByYWRpbzEKK1BBU1Mg cmFkaW9Ob2RlTGlzdFsxXSBpcyByYWRpbzIKK1BBU1MgcmFkaW9Ob2RlTGlzdFsyXSBpcyByYWRp bzMKK1BBU1MgcmFkaW9Ob2RlTGlzdC52YWx1ZSBpcyAidmFsdWUyIgorUEFTUyBzdWNjZXNzZnVs bHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisgICAgCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L2RvbS9IVE1MRm9ybUVsZW1lbnQvbmFtZWQtcHJvcGVydHktZ2V0dGVyLXJh ZGlvbm9kZWxpc3QuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxGb3JtRWxlbWVudC9u YW1lZC1wcm9wZXJ0eS1nZXR0ZXItcmFkaW9ub2RlbGlzdC5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmZmN2M4 ZGViY2IzMTc2ZGVhYjFkMzc4NjI1YjJjOWEyMzliM2MwZTMKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MRm9ybUVsZW1lbnQvbmFtZWQtcHJvcGVydHktZ2V0dGVy LXJhZGlvbm9kZWxpc3QuaHRtbApAQCAtMCwwICsxLDI5IEBACis8IURPQ1RZUEUgaHRtbD4KKzxo dG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJl LmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPGZvcm0gbmFtZT0iZiI+CisgPGlucHV0 IHR5cGU9InJhZGlvIiBpZD0icmFkaW8xIiBuYW1lPSJyIiB2YWx1ZT0idmFsdWUxIiAvPgorIDxp bnB1dCB0eXBlPSJyYWRpbyIgaWQ9InJhZGlvMiIgbmFtZT0iciIgdmFsdWU9InZhbHVlMiIgY2hl Y2tlZCAvPgorIDxpbnB1dCB0eXBlPSJyYWRpbyIgaWQ9InJhZGlvMyIgbmFtZT0iciIgdmFsdWU9 InZhbHVlMyIgLz4KKzwvZm9ybT4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbigiVGVzdHMgdGhhdCBI VE1MRm9ybUVsZW1lbnQncyBuYW1lZCBwcm9wZXJ0eSBnZXR0ZXIgcmV0dXJucyBhIFJhZGlvTm9k ZUxpc3QgaWYgdGhlcmUgYXJlIHNldmVyYWwgbWF0Y2hpbmcgZWxlbWVudHMuIik7CisKK3ZhciBy YWRpbzEgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmFkaW8xIik7Cit2YXIgcmFkaW8yID0g ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJhZGlvMiIpOwordmFyIHJhZGlvMyA9IGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJyYWRpbzMiKTsKKwordmFyIHJhZGlvTm9kZUxpc3QgPSBkb2N1bWVu dC5mLnI7CitzaG91bGRCZSgicmFkaW9Ob2RlTGlzdC5fX3Byb3RvX18iLCAiUmFkaW9Ob2RlTGlz dC5wcm90b3R5cGUiKTsKK3Nob3VsZEJlKCJyYWRpb05vZGVMaXN0Lmxlbmd0aCIsICIzIik7Citz aG91bGRCZSgicmFkaW9Ob2RlTGlzdFswXSIsICJyYWRpbzEiKTsKK3Nob3VsZEJlKCJyYWRpb05v ZGVMaXN0WzFdIiwgInJhZGlvMiIpOworc2hvdWxkQmUoInJhZGlvTm9kZUxpc3RbMl0iLCAicmFk aW8zIik7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoInJhZGlvTm9kZUxpc3QudmFsdWUiLCAidmFs dWUyIik7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9yZXNvdXJjZXMvanMtdGVz dC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K