154947 2016-03-02 18:34:13 -0800 [JSC] JSCell_freeListNext and JSCell_structureID are considered not overlapping 2016-03-02 21:29:11 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue fpizlo oldest_to_newest 1170055 0 benjamin 2016-03-02 18:34:13 -0800 [JSC] JSCell_freeListNext and JSCell_structureID are considered not overlapping 1170056 1 272717 benjamin 2016-03-02 18:37:58 -0800 Created attachment 272717 Patch 1170065 2 272717 fpizlo 2016-03-02 19:19:32 -0800 Comment on attachment 272717 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272717&action=review > Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.h:57 > + macro(JSCell_header, OBJECT_OFFSETOF(MarkedBlock::FreeList, head)) \ I would change the offset to just 0. The reason why MarkedBlock::FreeList::head overlaps with JSCell::structure is that they are both the first thing in the cell. "0" really is the best way of saying that. 1170074 3 272723 benjamin 2016-03-02 20:03:52 -0800 Created attachment 272723 Patch for landing 1170102 4 272723 commit-queue 2016-03-02 21:29:08 -0800 Comment on attachment 272723 Patch for landing Clearing flags on attachment: 272723 Committed r197491: <http://trac.webkit.org/changeset/197491> 1170103 5 commit-queue 2016-03-02 21:29:11 -0800 All reviewed patches have been landed. Closing bug. 272717 2016-03-02 18:37:58 -0800 2016-03-02 20:03:49 -0800 Patch bug-154947-20160302183742.patch text/plain 3594 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3NDYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 OGMxZjg1NDdhODMxYjVlNjE0YzBhNzA4NDI5NTlhMDM5ODNlN2JlLi5kMjczNWIwMWNjY2M4MTk1 MGI2YWEwMzdlOWFlODU5OTZjNDZiOWUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNyBAQAorMjAxNi0wMy0wMiAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBbSlNDXSBKU0NlbGxfZnJlZUxpc3ROZXh0IGFuZCBKU0NlbGxfc3Ry dWN0dXJlSUQgYXJlIGNvbnNpZGVyZWQgbm90IG92ZXJsYXBwaW5nCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTQ5NDcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGJ1ZyB3YXMgZGlzY292ZXJlZCB3 aGlsZSB0ZXN0aW5nIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTQ4 OTQuCisKKyAgICAgICAgVGhlIHByb2JsZW0gd2FzIHRoYXQgSlNDZWxsX2ZyZWVMaXN0TmV4dCBh bmQgSlNDZWxsX3N0cnVjdHVyZUlEIHdlcmUKKyAgICAgICAgY29uc2lkZXJlZCBhcyBkaXNqb2lu dC4gV2hlbiByZW9yZGVyaW5nIGluc3RydWN0aW9ucywgdGhlIHNjaGVkdWxlcgorICAgICAgICBj b3VsZCBtb3ZlIHRoZSB3cml0ZSBvZiB0aGUgU3RydWN0dXJlSUQgZmlyc3QgdG8gcmVkdWNlIGRl cGVuZGVuY2llcy4KKyAgICAgICAgVGhpcyB3b3VsZCBlcmFzZSBoYWxmIG9mIEpTQ2VsbF9mcmVl TGlzdE5leHQgYmVmb3JlIHdlIGdldCBhIGNoYW5jZQorICAgICAgICB0byBsb2FkIHRoZSB2YWx1 ZS4KKworICAgICAgICBUaGlzIHBhdGNoIGNoYW5nZXMgdGhlIGhpZXJhcmNoeSB0byBtYWtlIHN1 cmUgbm90aGluZyBpcyB3cml0dGVuCisgICAgICAgIHVudGlsIEpTQ2VsbF9mcmVlTGlzdE5leHQg aXMgcHJvY2Vzc2VkLgorCisgICAgICAgIEFsbCBjcmVkaXRzIGZvciB0aGlzIHBhdGNoIGdvIHRv IEZpbGlwLgorCisgICAgICAgICogZnRsL0ZUTEFic3RyYWN0SGVhcFJlcG9zaXRvcnkuY3BwOgor ICAgICAgICAoSlNDOjpGVEw6OkFic3RyYWN0SGVhcFJlcG9zaXRvcnk6OkFic3RyYWN0SGVhcFJl cG9zaXRvcnkpOgorICAgICAgICAqIGZ0bC9GVExBYnN0cmFjdEhlYXBSZXBvc2l0b3J5Lmg6CisK IDIwMTYtMDMtMDIgIFNhYW0gYmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAg U0lHU0VHViBpbiBQcm94eSBbW0dldF1dIGFuZCBbW1NldF1dIHJlY3Vyc2lvbgpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExBYnN0cmFjdEhlYXBSZXBvc2l0b3J5LmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQWJzdHJhY3RIZWFwUmVwb3NpdG9yeS5j cHAKaW5kZXggYThkMjE1ZGM4MmU4MzU0ZjM2ZmM4NmE4OWZlYzc3ZWFkZjk2NzlkMi4uMDRkN2E2 ODlkZGIwYmJjNWJhOGViNDk2NGNjYmJjMzhiNjBmNDIyNyAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2Z0bC9GVExBYnN0cmFjdEhlYXBSZXBvc2l0b3J5LmNwcAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEFic3RyYWN0SGVhcFJlcG9zaXRvcnkuY3BwCkBAIC01 Nyw3ICs1Nyw3IEBAIEFic3RyYWN0SGVhcFJlcG9zaXRvcnk6OkFic3RyYWN0SGVhcFJlcG9zaXRv cnkoKQogICAgIEZPUl9FQUNIX0FCU1RSQUNUX0ZJRUxEKEFCU1RSQUNUX0ZJRUxEX0lOSVRJQUxJ WkFUSU9OKQogI3VuZGVmIEFCU1RSQUNUX0ZJRUxEX0lOSVRJQUxJWkFUSU9OCiAgICAgCi0gICAg LCBKU0NlbGxfZnJlZUxpc3ROZXh0KEpTQ2VsbF9zdHJ1Y3R1cmVJRCkKKyAgICAsIEpTQ2VsbF9m cmVlTGlzdE5leHQoSlNDZWxsX2hlYWRlcikKICAgICAKICNkZWZpbmUgSU5ERVhFRF9BQlNUUkFD VF9IRUFQX0lOSVRJQUxJWkFUSU9OKG5hbWUsIG9mZnNldCwgc2l6ZSkgLCBuYW1lKCZyb290LCAj bmFtZSwgb2Zmc2V0LCBzaXplKQogICAgIEZPUl9FQUNIX0lOREVYRURfQUJTVFJBQ1RfSEVBUChJ TkRFWEVEX0FCU1RSQUNUX0hFQVBfSU5JVElBTElaQVRJT04pCkBAIC03NSw2ICs3NSw4IEBAIEFi c3RyYWN0SGVhcFJlcG9zaXRvcnk6OkFic3RyYWN0SGVhcFJlcG9zaXRvcnkoKQogICAgIFJFTEVB U0VfQVNTRVJUKEpTQ2VsbF9pbmRleGluZ1R5cGUub2Zmc2V0KCkgKyAyID09IEpTQ2VsbF90eXBl SW5mb0ZsYWdzLm9mZnNldCgpKTsKICAgICBSRUxFQVNFX0FTU0VSVChKU0NlbGxfaW5kZXhpbmdU eXBlLm9mZnNldCgpICsgMyA9PSBKU0NlbGxfY2VsbFN0YXRlLm9mZnNldCgpKTsKIAorICAgIEpT Q2VsbF9zdHJ1Y3R1cmVJRC5jaGFuZ2VQYXJlbnQoJkpTQ2VsbF9oZWFkZXIpOworICAgIEpTQ2Vs bF91c2VmdWxCeXRlcy5jaGFuZ2VQYXJlbnQoJkpTQ2VsbF9oZWFkZXIpOwogICAgIEpTQ2VsbF9p bmRleGluZ1R5cGUuY2hhbmdlUGFyZW50KCZKU0NlbGxfdXNlZnVsQnl0ZXMpOwogICAgIEpTQ2Vs bF90eXBlSW5mb1R5cGUuY2hhbmdlUGFyZW50KCZKU0NlbGxfdXNlZnVsQnl0ZXMpOwogICAgIEpT Q2VsbF90eXBlSW5mb0ZsYWdzLmNoYW5nZVBhcmVudCgmSlNDZWxsX3VzZWZ1bEJ5dGVzKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQWJzdHJhY3RIZWFwUmVwb3Np dG9yeS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExBYnN0cmFjdEhlYXBSZXBvc2l0 b3J5LmgKaW5kZXggOTllNTE0OGNiZDhmNGI0MWM5Mjk5ZDE0YjZiYmY4MzdhYmU5MTdhMy4uMWQx MzlmOTAxMTkxNTA4M2U2ZDFkODExNDYzNThlYTE5Zjg2ODA3ZSAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2Z0bC9GVExBYnN0cmFjdEhlYXBSZXBvc2l0b3J5LmgKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExBYnN0cmFjdEhlYXBSZXBvc2l0b3J5LmgKQEAgLTU0 LDYgKzU0LDcgQEAgbmFtZXNwYWNlIEpTQyB7IG5hbWVzcGFjZSBGVEwgewogICAgIG1hY3JvKEpT QXJyYXlCdWZmZXJWaWV3X21vZGUsIEpTQXJyYXlCdWZmZXJWaWV3OjpvZmZzZXRPZk1vZGUoKSkg XAogICAgIG1hY3JvKEpTQXJyYXlCdWZmZXJWaWV3X3ZlY3RvciwgSlNBcnJheUJ1ZmZlclZpZXc6 Om9mZnNldE9mVmVjdG9yKCkpIFwKICAgICBtYWNybyhKU0NlbGxfY2VsbFN0YXRlLCBKU0NlbGw6 OmNlbGxTdGF0ZU9mZnNldCgpKSBcCisgICAgbWFjcm8oSlNDZWxsX2hlYWRlciwgT0JKRUNUX09G RlNFVE9GKE1hcmtlZEJsb2NrOjpGcmVlTGlzdCwgaGVhZCkpIFwKICAgICBtYWNybyhKU0NlbGxf aW5kZXhpbmdUeXBlLCBKU0NlbGw6OmluZGV4aW5nVHlwZU9mZnNldCgpKSBcCiAgICAgbWFjcm8o SlNDZWxsX3N0cnVjdHVyZUlELCBKU0NlbGw6OnN0cnVjdHVyZUlET2Zmc2V0KCkpIFwKICAgICBt YWNybyhKU0NlbGxfdHlwZUluZm9GbGFncywgSlNDZWxsOjp0eXBlSW5mb0ZsYWdzT2Zmc2V0KCkp IFwK 272723 2016-03-02 20:03:52 -0800 2016-03-02 21:29:08 -0800 Patch for landing bug-154947-20160302200337.patch text/plain 3604 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3NDg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk M2U3MDVkZDBmMWU2MTU5YjMxMmQ1NDA2NzgxNTM4MDI3Njk5ODdjLi4wZTYxOTdlOGMxZDRjYzVl NzVjMzk0NGZjNmEwYzc2YmQzZGU3NjhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNyBAQAorMjAxNi0wMy0wMiAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBbSlNDXSBKU0NlbGxfZnJlZUxpc3ROZXh0IGFuZCBKU0NlbGxfc3Ry dWN0dXJlSUQgYXJlIGNvbnNpZGVyZWQgbm90IG92ZXJsYXBwaW5nCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTQ5NDcKKworICAgICAgICBSZXZpZXdl ZCBieSBGaWxpcCBQaXpsby4KKworICAgICAgICBUaGlzIGJ1ZyB3YXMgZGlzY292ZXJlZCB3aGls ZSB0ZXN0aW5nIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTQ4OTQu CisKKyAgICAgICAgVGhlIHByb2JsZW0gd2FzIHRoYXQgSlNDZWxsX2ZyZWVMaXN0TmV4dCBhbmQg SlNDZWxsX3N0cnVjdHVyZUlEIHdlcmUKKyAgICAgICAgY29uc2lkZXJlZCBhcyBkaXNqb2ludC4g V2hlbiByZW9yZGVyaW5nIGluc3RydWN0aW9ucywgdGhlIHNjaGVkdWxlcgorICAgICAgICBjb3Vs ZCBtb3ZlIHRoZSB3cml0ZSBvZiB0aGUgU3RydWN0dXJlSUQgZmlyc3QgdG8gcmVkdWNlIGRlcGVu ZGVuY2llcy4KKyAgICAgICAgVGhpcyB3b3VsZCBlcmFzZSBoYWxmIG9mIEpTQ2VsbF9mcmVlTGlz dE5leHQgYmVmb3JlIHdlIGdldCBhIGNoYW5jZQorICAgICAgICB0byBsb2FkIHRoZSB2YWx1ZS4K KworICAgICAgICBUaGlzIHBhdGNoIGNoYW5nZXMgdGhlIGhpZXJhcmNoeSB0byBtYWtlIHN1cmUg bm90aGluZyBpcyB3cml0dGVuCisgICAgICAgIHVudGlsIEpTQ2VsbF9mcmVlTGlzdE5leHQgaXMg cHJvY2Vzc2VkLgorCisgICAgICAgIEFsbCBjcmVkaXRzIGZvciB0aGlzIHBhdGNoIGdvIHRvIEZp bGlwLgorCisgICAgICAgICogZnRsL0ZUTEFic3RyYWN0SGVhcFJlcG9zaXRvcnkuY3BwOgorICAg ICAgICAoSlNDOjpGVEw6OkFic3RyYWN0SGVhcFJlcG9zaXRvcnk6OkFic3RyYWN0SGVhcFJlcG9z aXRvcnkpOgorICAgICAgICAqIGZ0bC9GVExBYnN0cmFjdEhlYXBSZXBvc2l0b3J5Lmg6CisKIDIw MTYtMDMtMDIgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBSZWdF eHBQcm90b3R5cGUgc2hvdWxkIGNoZWNrIGZvciBleGNlcHRpb25zIGFmdGVyIGNhbGxpbmcgdG9T dHJpbmcgYW5kIGRvaW5nIHNvIHNob3VsZCBub3QgYmUgZXhwZW5zaXZlCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEFic3RyYWN0SGVhcFJlcG9zaXRvcnkuY3BwIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExBYnN0cmFjdEhlYXBSZXBvc2l0b3J5LmNwcApp bmRleCBhOGQyMTVkYzgyZTgzNTRmMzZmYzg2YTg5ZmVjNzdlYWRmOTY3OWQyLi4wNGQ3YTY4OWRk YjBiYmM1YmE4ZWI0OTY0Y2NiYmMzOGI2MGY0MjI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZnRsL0ZUTEFic3RyYWN0SGVhcFJlcG9zaXRvcnkuY3BwCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9mdGwvRlRMQWJzdHJhY3RIZWFwUmVwb3NpdG9yeS5jcHAKQEAgLTU3LDcg KzU3LDcgQEAgQWJzdHJhY3RIZWFwUmVwb3NpdG9yeTo6QWJzdHJhY3RIZWFwUmVwb3NpdG9yeSgp CiAgICAgRk9SX0VBQ0hfQUJTVFJBQ1RfRklFTEQoQUJTVFJBQ1RfRklFTERfSU5JVElBTElaQVRJ T04pCiAjdW5kZWYgQUJTVFJBQ1RfRklFTERfSU5JVElBTElaQVRJT04KICAgICAKLSAgICAsIEpT Q2VsbF9mcmVlTGlzdE5leHQoSlNDZWxsX3N0cnVjdHVyZUlEKQorICAgICwgSlNDZWxsX2ZyZWVM aXN0TmV4dChKU0NlbGxfaGVhZGVyKQogICAgIAogI2RlZmluZSBJTkRFWEVEX0FCU1RSQUNUX0hF QVBfSU5JVElBTElaQVRJT04obmFtZSwgb2Zmc2V0LCBzaXplKSAsIG5hbWUoJnJvb3QsICNuYW1l LCBvZmZzZXQsIHNpemUpCiAgICAgRk9SX0VBQ0hfSU5ERVhFRF9BQlNUUkFDVF9IRUFQKElOREVY RURfQUJTVFJBQ1RfSEVBUF9JTklUSUFMSVpBVElPTikKQEAgLTc1LDYgKzc1LDggQEAgQWJzdHJh Y3RIZWFwUmVwb3NpdG9yeTo6QWJzdHJhY3RIZWFwUmVwb3NpdG9yeSgpCiAgICAgUkVMRUFTRV9B U1NFUlQoSlNDZWxsX2luZGV4aW5nVHlwZS5vZmZzZXQoKSArIDIgPT0gSlNDZWxsX3R5cGVJbmZv RmxhZ3Mub2Zmc2V0KCkpOwogICAgIFJFTEVBU0VfQVNTRVJUKEpTQ2VsbF9pbmRleGluZ1R5cGUu b2Zmc2V0KCkgKyAzID09IEpTQ2VsbF9jZWxsU3RhdGUub2Zmc2V0KCkpOwogCisgICAgSlNDZWxs X3N0cnVjdHVyZUlELmNoYW5nZVBhcmVudCgmSlNDZWxsX2hlYWRlcik7CisgICAgSlNDZWxsX3Vz ZWZ1bEJ5dGVzLmNoYW5nZVBhcmVudCgmSlNDZWxsX2hlYWRlcik7CiAgICAgSlNDZWxsX2luZGV4 aW5nVHlwZS5jaGFuZ2VQYXJlbnQoJkpTQ2VsbF91c2VmdWxCeXRlcyk7CiAgICAgSlNDZWxsX3R5 cGVJbmZvVHlwZS5jaGFuZ2VQYXJlbnQoJkpTQ2VsbF91c2VmdWxCeXRlcyk7CiAgICAgSlNDZWxs X3R5cGVJbmZvRmxhZ3MuY2hhbmdlUGFyZW50KCZKU0NlbGxfdXNlZnVsQnl0ZXMpOwpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExBYnN0cmFjdEhlYXBSZXBvc2l0b3J5 LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEFic3RyYWN0SGVhcFJlcG9zaXRvcnku aAppbmRleCA5OWU1MTQ4Y2JkOGY0YjQxYzkyOTlkMTRiNmJiZjgzN2FiZTkxN2EzLi45MDg4NDU1 YmUwYTM3N2Q3NDEyNmZhN2M0ZjA4Mzc0OGU1NTdjOGY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZnRsL0ZUTEFic3RyYWN0SGVhcFJlcG9zaXRvcnkuaAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvZnRsL0ZUTEFic3RyYWN0SGVhcFJlcG9zaXRvcnkuaApAQCAtNTQsNiAr NTQsNyBAQCBuYW1lc3BhY2UgSlNDIHsgbmFtZXNwYWNlIEZUTCB7CiAgICAgbWFjcm8oSlNBcnJh eUJ1ZmZlclZpZXdfbW9kZSwgSlNBcnJheUJ1ZmZlclZpZXc6Om9mZnNldE9mTW9kZSgpKSBcCiAg ICAgbWFjcm8oSlNBcnJheUJ1ZmZlclZpZXdfdmVjdG9yLCBKU0FycmF5QnVmZmVyVmlldzo6b2Zm c2V0T2ZWZWN0b3IoKSkgXAogICAgIG1hY3JvKEpTQ2VsbF9jZWxsU3RhdGUsIEpTQ2VsbDo6Y2Vs bFN0YXRlT2Zmc2V0KCkpIFwKKyAgICBtYWNybyhKU0NlbGxfaGVhZGVyLCAwKSBcCiAgICAgbWFj cm8oSlNDZWxsX2luZGV4aW5nVHlwZSwgSlNDZWxsOjppbmRleGluZ1R5cGVPZmZzZXQoKSkgXAog ICAgIG1hY3JvKEpTQ2VsbF9zdHJ1Y3R1cmVJRCwgSlNDZWxsOjpzdHJ1Y3R1cmVJRE9mZnNldCgp KSBcCiAgICAgbWFjcm8oSlNDZWxsX3R5cGVJbmZvRmxhZ3MsIEpTQ2VsbDo6dHlwZUluZm9GbGFn c09mZnNldCgpKSBcCg==