154933 2016-03-02 15:39:25 -0800 Crashes in media tests after http://trac.webkit.org/changeset/197461 2016-03-02 15:50:39 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned oldest_to_newest 1169981 0 bdakin 2016-03-02 15:39:25 -0800 Crashes in media tests after http://trac.webkit.org/changeset/197461 1169984 1 272697 bdakin 2016-03-02 15:42:19 -0800 Created attachment 272697 Patch 1169987 2 272697 eric.carlson 2016-03-02 15:46:33 -0800 Comment on attachment 272697 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272697&action=review > Source/WebKit2/ChangeLog:8 > + Since the controlsManagerInterface is not guaranteed to exist, it doesn’t "smart" quote? 1169989 3 bdakin 2016-03-02 15:50:39 -0800 Thanks Eric! http://trac.webkit.org/changeset/197469 272697 2016-03-02 15:42:19 -0800 2016-03-02 15:46:33 -0800 Patch for-review.txt text/plain 2573 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NzQ2OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE2LTAzLTAyICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaGVzIGluIG1lZGlhIHRlc3Rz IGFmdGVyIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE5NzQ2MQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0OTMzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgdGhlIGNvbnRyb2xz TWFuYWdlckludGVyZmFjZSBpcyBub3QgZ3VhcmFudGVlZCB0byBleGlzdCwgaXQgZG9lc27igJl0 IAorICAgICAgICBtYWtlIHNlbnNlIHRvIHJldHVybiBhIHJlZmVyZW5jZS4gUmV0dXJuIGEgcG9p bnRlciBpbnN0ZWFkLgorICAgICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9XZWJWaWRlb0Z1bGxzY3Jl ZW5NYW5hZ2VyUHJveHkuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvV2ViVmlkZW9GdWxs c2NyZWVuTWFuYWdlclByb3h5Lm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWRlb0Z1bGxzY3Jl ZW5NYW5hZ2VyUHJveHk6OmlzVmlzaWJsZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZGVvRnVs bHNjcmVlbk1hbmFnZXJQcm94eTo6Y29udHJvbHNNYW5hZ2VySW50ZXJmYWNlKToKKyAgICAgICAg KFdlYktpdDo6V2ViVmlkZW9GdWxsc2NyZWVuTWFuYWdlclByb3h5OjpmdWxsc2NyZWVuTWF5UmV0 dXJuVG9JbmxpbmUpOgorCiAyMDE2LTAzLTAyICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNv bT4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3IgcGxheWJhY2tDb250cm9sc01hbmFnZXIKSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWRlb0Z1bGxzY3JlZW5NYW5h Z2VyUHJveHkuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2Ev V2ViVmlkZW9GdWxsc2NyZWVuTWFuYWdlclByb3h5LmgJKHJldmlzaW9uIDE5NzQ2MSkKKysrIFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWRlb0Z1bGxzY3JlZW5NYW5hZ2VyUHJv eHkuaAkod29ya2luZyBjb3B5KQpAQCAtMTE5LDcgKzExOSw3IEBAIHB1YmxpYzoKICAgICB2b2lk IGFwcGxpY2F0aW9uRGlkQmVjb21lQWN0aXZlKCk7CiAgICAgYm9vbCBpc1Zpc2libGUoKSBjb25z dDsKIAotICAgIFBsYXRmb3JtV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlJiBjb250cm9sc01h bmFnZXJJbnRlcmZhY2UoKTsKKyAgICBQbGF0Zm9ybVdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFj ZSogY29udHJvbHNNYW5hZ2VySW50ZXJmYWNlKCk7CiAKIHByaXZhdGU6CiAgICAgZnJpZW5kIGNs YXNzIFdlYlZpZGVvRnVsbHNjcmVlbk1vZGVsQ29udGV4dDsKSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWRlb0Z1bGxzY3JlZW5NYW5hZ2VyUHJveHkubW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL1dlYlZpZGVvRnVsbHNjcmVl bk1hbmFnZXJQcm94eS5tbQkocmV2aXNpb24gMTk3NDYxKQorKysgU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0NvY29hL1dlYlZpZGVvRnVsbHNjcmVlbk1hbmFnZXJQcm94eS5tbQkod29ya2luZyBj b3B5KQpAQCAtNjMzLDkgKzYzMywxMyBAQCBib29sIFdlYlZpZGVvRnVsbHNjcmVlbk1hbmFnZXJQ cm94eTo6aXNWCiAgICAgcmV0dXJuIG1fcGFnZS0+aXNWaWV3VmlzaWJsZSgpICYmIG1fcGFnZS0+ aXNJbldpbmRvdygpOwogfQogCi1QbGF0Zm9ybVdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZSYg V2ViVmlkZW9GdWxsc2NyZWVuTWFuYWdlclByb3h5Ojpjb250cm9sc01hbmFnZXJJbnRlcmZhY2Uo KQorUGxhdGZvcm1XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2UqIFdlYlZpZGVvRnVsbHNjcmVl bk1hbmFnZXJQcm94eTo6Y29udHJvbHNNYW5hZ2VySW50ZXJmYWNlKCkKIHsKLSAgICByZXR1cm4g ZW5zdXJlSW50ZXJmYWNlKG1fY29udHJvbHNNYW5hZ2VyQ29udGV4dElkKTsKKyAgICBpZiAoIW1f Y29udHJvbHNNYW5hZ2VyQ29udGV4dElkKQorICAgICAgICByZXR1cm4gbnVsbHB0cjsKKworICAg IGF1dG8mIGludGVyZmFjZSA9IGVuc3VyZUludGVyZmFjZShtX2NvbnRyb2xzTWFuYWdlckNvbnRl eHRJZCk7CisgICAgcmV0dXJuICZpbnRlcmZhY2U7CiB9CiAKIHZvaWQgV2ViVmlkZW9GdWxsc2Ny ZWVuTWFuYWdlclByb3h5OjpmdWxsc2NyZWVuTWF5UmV0dXJuVG9JbmxpbmUodWludDY0X3QgY29u dGV4dElkKQo=