154902 2016-03-01 19:38:58 -0800 Simplify some StringBuilder appends 2016-03-01 20:30:45 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1169693 0 joepeck 2016-03-01 19:38:58 -0800 Simplify some StringBuilder appends 1169694 1 272625 joepeck 2016-03-01 19:39:57 -0800 Created attachment 272625 [PATCH] Proposed Fix 1169696 2 272625 mark.lam 2016-03-01 19:43:51 -0800 Comment on attachment 272625 [PATCH] Proposed Fix r=me 1169704 3 272625 commit-queue 2016-03-01 20:30:39 -0800 Comment on attachment 272625 [PATCH] Proposed Fix Clearing flags on attachment: 272625 Committed r197438: <http://trac.webkit.org/changeset/197438> 1169705 4 commit-queue 2016-03-01 20:30:45 -0800 All reviewed patches have been landed. Closing bug. 272625 2016-03-01 19:39:57 -0800 2016-03-01 20:30:39 -0800 [PATCH] Proposed Fix cleanup.patch text/plain 2639 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGIxMzYxZWFhLi43ZTVkYjNhIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAxNi0wMy0wMSAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCisgICAgICAgIFNpbXBsaWZ5IHNvbWUgU3RyaW5n QnVpbGRlciBhcHBlbmRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTQ5MDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHJ1bnRpbWUvRXhjZXB0aW9uSGVscGVycy5jcHA6CisgICAgICAgIChKU0M6Om5v dEFGdW5jdGlvblNvdXJjZUFwcGVuZGVyKToKKyAgICAgICAgKiBydW50aW1lL1NhbXBsaW5nUHJv ZmlsZXIuY3BwOgorICAgICAgICAoSlNDOjpTYW1wbGluZ1Byb2ZpbGVyOjpzdGFja1RyYWNlc0Fz SlNPTik6CisgICAgICAgIFVzZSBTdHJpbmdCdWlsZGVyOjphcHBlbmQoY2hhcikgaW5zdGVhZCBv ZiBhcHBlbmQoY2hhciopIHdoZXJlIHBvc3NpYmxlLgorCisyMDE2LTAzLTAxICBKb3NlcGggUGVj b3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgQWRkIGFiaWxpdHkgdG8gZ2Vu ZXJhdGUgYSBIZWFwIFNuYXBzaG90CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTQ4NDcKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvRXhjZXB0aW9uSGVscGVycy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9FeGNlcHRpb25IZWxwZXJzLmNwcAppbmRleCAxOTZiZTJlLi5mOWE1YmI0IDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FeGNlcHRpb25IZWxwZXJzLmNwcAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FeGNlcHRpb25IZWxwZXJzLmNwcApA QCAtMTg2LDcgKzE4Niw3IEBAIHN0YXRpYyBTdHJpbmcgbm90QUZ1bmN0aW9uU291cmNlQXBwZW5k ZXIoY29uc3QgU3RyaW5nJiBvcmlnaW5hbE1lc3NhZ2UsIGNvbnN0IFN0CiAgICAgaWYgKHR5cGUg PT0gVHlwZU9iamVjdCkKICAgICAgICAgYnVpbGRlci5hcHBlbmRMaXRlcmFsKCJhbiBpbnN0YW5j ZSBvZiAiKTsKICAgICBidWlsZGVyLmFwcGVuZChkaXNwbGF5VmFsdWUpOwotICAgIGJ1aWxkZXIu YXBwZW5kTGl0ZXJhbCgiKSIpOworICAgIGJ1aWxkZXIuYXBwZW5kKCcpJyk7CiAKICAgICByZXR1 cm4gYnVpbGRlci50b1N0cmluZygpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvU2FtcGxpbmdQcm9maWxlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9TYW1wbGluZ1Byb2ZpbGVyLmNwcAppbmRleCAyZmVjN2U1Li45YzdhZDc0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TYW1wbGluZ1Byb2ZpbGVyLmNw cAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TYW1wbGluZ1Byb2ZpbGVyLmNw cApAQCAtNzMxLDI5ICs3MzEsMjkgQEAgU3RyaW5nIFNhbXBsaW5nUHJvZmlsZXI6OnN0YWNrVHJh Y2VzQXNKU09OKCkKICAgICB9CiAKICAgICBTdHJpbmdCdWlsZGVyIGpzb247Ci0gICAganNvbi5h cHBlbmRMaXRlcmFsKCJbIik7CisgICAganNvbi5hcHBlbmQoJ1snKTsKIAogICAgIGJvb2wgbG9v cGVkT25jZSA9IGZhbHNlOwogICAgIGF1dG8gY29tbWEgPSBbJl0gewogICAgICAgICBpZiAobG9v cGVkT25jZSkKLSAgICAgICAgICAgIGpzb24uYXBwZW5kTGl0ZXJhbCgiLCIpOworICAgICAgICAg ICAganNvbi5hcHBlbmQoJywnKTsKICAgICB9OwogICAgIGZvciAoU3RhY2tUcmFjZSYgc3RhY2tU cmFjZSA6IG1fc3RhY2tUcmFjZXMpIHsKICAgICAgICAgY29tbWEoKTsKLSAgICAgICAganNvbi5h cHBlbmRMaXRlcmFsKCJbIik7CisgICAgICAgIGpzb24uYXBwZW5kKCdbJyk7CiAgICAgICAgIGxv b3BlZE9uY2UgPSBmYWxzZTsKICAgICAgICAgZm9yIChTdGFja0ZyYW1lJiBzdGFja0ZyYW1lIDog c3RhY2tUcmFjZS5mcmFtZXMpIHsKICAgICAgICAgICAgIGNvbW1hKCk7Ci0gICAgICAgICAgICBq c29uLmFwcGVuZExpdGVyYWwoIlwiIik7CisgICAgICAgICAgICBqc29uLmFwcGVuZCgnIicpOwog ICAgICAgICAgICAganNvbi5hcHBlbmQoc3RhY2tGcmFtZS5kaXNwbGF5TmFtZUZvckpTT05UZXN0 cyhtX3ZtKSk7Ci0gICAgICAgICAgICBqc29uLmFwcGVuZExpdGVyYWwoIlwiIik7CisgICAgICAg ICAgICBqc29uLmFwcGVuZCgnIicpOwogICAgICAgICAgICAgbG9vcGVkT25jZSA9IHRydWU7CiAg ICAgICAgIH0KLSAgICAgICAganNvbi5hcHBlbmRMaXRlcmFsKCJdIik7CisgICAgICAgIGpzb24u YXBwZW5kKCddJyk7CiAgICAgICAgIGxvb3BlZE9uY2UgPSB0cnVlOwogICAgIH0KIAotICAgIGpz b24uYXBwZW5kTGl0ZXJhbCgiXSIpOworICAgIGpzb24uYXBwZW5kKCddJyk7CiAKICAgICBjbGVh ckRhdGEobG9ja2VyKTsKIAo=