154880 2016-03-01 15:14:05 -0800 iOS EWS is broken 2016-03-24 17:52:10 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=154821 P2 Critical --- 1 dean_johnson dean_johnson ap commit-queue lforschler ossy oldest_to_newest 1169583 0 dean_johnson 2016-03-01 15:14:05 -0800 It looks like https://bugs.webkit.org/show_bug.cgi?id=154821 broke iOS EWS. The fix is adding back `willUseIOSDeviceSDK()` since that pops --sdk off of the argument list. 1169586 1 272596 dean_johnson 2016-03-01 15:23:39 -0800 Created attachment 272596 Patch 1169588 2 272596 ddkilzer 2016-03-01 15:24:47 -0800 Comment on attachment 272596 Patch r=me 1169590 3 272596 ddkilzer 2016-03-01 15:26:44 -0800 Comment on attachment 272596 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272596&action=review r- > Tools/Scripts/copy-webkitlibraries-to-product-directory:41 > +willUseIOSDeviceSDK() Need semi-colon. Perl doesn't roll like python. :) 1169594 4 272598 dean_johnson 2016-03-01 15:32:43 -0800 Created attachment 272598 Patch 1169667 5 272598 commit-queue 2016-03-01 17:42:55 -0800 Comment on attachment 272598 Patch Clearing flags on attachment: 272598 Committed r197430: <http://trac.webkit.org/changeset/197430> 1169668 6 commit-queue 2016-03-01 17:42:59 -0800 All reviewed patches have been landed. Closing bug. 272596 2016-03-01 15:23:39 -0800 2016-03-01 15:32:41 -0800 Patch bug-154880-20160301152324.patch text/plain 1226 dean_johnson U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3NDEzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWExZDcyMjY2YjI5ZGNhNjVlM2NjOTg2NzA3ZjA3ZGFi YzYyZThkMC4uMDA0YjJjODMyNmYxMTAyYjFhNTM0MTIxNmM2ZWFmM2JiNWUwNWIwMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE2LTAzLTAxICBEZWFuIEpvaG5zb24gIDxkZWFuX2pvaG5zb25AYXBwbGUuY29tPgor CisgICAgICAgIEZpeCBpT1MgRVdTLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTU0ODgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2NvcHktd2Via2l0bGlicmFyaWVzLXRvLXByb2R1Y3Qt ZGlyZWN0b3J5OgorCiAyMDE2LTAyLTI5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CiAKICAgICAgICAgSGF2ZSBwYXJzZUhUTUxJbnRlZ2VyKCkgLyBwYXJzZUhUTUxOb25OZWdhdGl2 ZUludGVnZXIoKSB1c2UgV1RGOjpPcHRpb25hbApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9j b3B5LXdlYmtpdGxpYnJhcmllcy10by1wcm9kdWN0LWRpcmVjdG9yeSBiL1Rvb2xzL1NjcmlwdHMv Y29weS13ZWJraXRsaWJyYXJpZXMtdG8tcHJvZHVjdC1kaXJlY3RvcnkKaW5kZXggOTA4Zjg2MjA3 NmVlM2U1ZGRiOTM1MDk5NWFkZTU1MDExMzNjNmUyMy4uMjNlMDA5NTVjNTYzNmNhMDg4MWQzMTVm NDVjYzBhMzYzNzk0Mjg0OSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9jb3B5LXdlYmtpdGxp YnJhcmllcy10by1wcm9kdWN0LWRpcmVjdG9yeQorKysgYi9Ub29scy9TY3JpcHRzL2NvcHktd2Vi a2l0bGlicmFyaWVzLXRvLXByb2R1Y3QtZGlyZWN0b3J5CkBAIC0zNyw2ICszNyw5IEBAIG15ICR1 c2VGdWxsTGliUGF0aHMgPSAwOwogbXkgJG9zeFZlcnNpb247CiBteSAkZm9yY2UgPSAwOwogCisj IFBvcHMgb2ZmIC0tc2RrPTxTREsgTmFtZT4gZnJvbSB0aGUgYXJndW1lbnQgbGlzdCBzbyAtLXNk ayBpcyBub3QgdGFrZW4gYXMgdGhlIHByb2R1Y3REaXIuCit3aWxsVXNlSU9TRGV2aWNlU0RLKCkK KwogbXkgJHByb2dyYW1OYW1lID0gYmFzZW5hbWUoJDApOwogbXkgJHVzYWdlID0gPDxFT0Y7CiBV c2FnZTogJHByb2dyYW1OYW1lIFtvcHRpb25zXQo= 272598 2016-03-01 15:32:43 -0800 2016-03-01 17:42:55 -0800 Patch bug-154880-20160301153228.patch text/plain 1227 dean_johnson U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3NDEzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWExZDcyMjY2YjI5ZGNhNjVlM2NjOTg2NzA3ZjA3ZGFi YzYyZThkMC4uMDA0YjJjODMyNmYxMTAyYjFhNTM0MTIxNmM2ZWFmM2JiNWUwNWIwMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE2LTAzLTAxICBEZWFuIEpvaG5zb24gIDxkZWFuX2pvaG5zb25AYXBwbGUuY29tPgor CisgICAgICAgIEZpeCBpT1MgRVdTLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTU0ODgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2NvcHktd2Via2l0bGlicmFyaWVzLXRvLXByb2R1Y3Qt ZGlyZWN0b3J5OgorCiAyMDE2LTAyLTI5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CiAKICAgICAgICAgSGF2ZSBwYXJzZUhUTUxJbnRlZ2VyKCkgLyBwYXJzZUhUTUxOb25OZWdhdGl2 ZUludGVnZXIoKSB1c2UgV1RGOjpPcHRpb25hbApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9j b3B5LXdlYmtpdGxpYnJhcmllcy10by1wcm9kdWN0LWRpcmVjdG9yeSBiL1Rvb2xzL1NjcmlwdHMv Y29weS13ZWJraXRsaWJyYXJpZXMtdG8tcHJvZHVjdC1kaXJlY3RvcnkKaW5kZXggOTA4Zjg2MjA3 NmVlM2U1ZGRiOTM1MDk5NWFkZTU1MDExMzNjNmUyMy4uZTg0MGZjZWFkMTllYmYwNDYxNGZmZjUz ZTQ0NWM1MmNmNjU4YjBlOCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9jb3B5LXdlYmtpdGxp YnJhcmllcy10by1wcm9kdWN0LWRpcmVjdG9yeQorKysgYi9Ub29scy9TY3JpcHRzL2NvcHktd2Vi a2l0bGlicmFyaWVzLXRvLXByb2R1Y3QtZGlyZWN0b3J5CkBAIC0zNyw2ICszNyw5IEBAIG15ICR1 c2VGdWxsTGliUGF0aHMgPSAwOwogbXkgJG9zeFZlcnNpb247CiBteSAkZm9yY2UgPSAwOwogCisj IFBvcHMgb2ZmIC0tc2RrPTxTREsgTmFtZT4gZnJvbSB0aGUgYXJndW1lbnQgbGlzdCBzbyAtLXNk ayBpcyBub3QgdGFrZW4gYXMgdGhlIHByb2R1Y3REaXIuCit3aWxsVXNlSU9TRGV2aWNlU0RLKCk7 CisKIG15ICRwcm9ncmFtTmFtZSA9IGJhc2VuYW1lKCQwKTsKIG15ICR1c2FnZSA9IDw8RU9GOwog VXNhZ2U6ICRwcm9ncmFtTmFtZSBbb3B0aW9uc10K