154878 2016-03-01 14:17:44 -0800 Timer alignment in separate web processes should not all sync up to the same point. 2016-03-01 15:33:32 -0800 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough barraclough cdumez oldest_to_newest 1169571 0 barraclough 2016-03-01 14:17:44 -0800 This leads to a thundering herd of timers firing concurrently. 1169575 1 272592 barraclough 2016-03-01 14:33:08 -0800 Created attachment 272592 Fix 1169582 2 272592 cdumez 2016-03-01 15:05:07 -0800 Comment on attachment 272592 Fix View in context: https://bugs.webkit.org/attachment.cgi?id=272592&action=review r=me > Source/WebCore/page/DOMTimer.cpp:430 > + static double randomizedAlignment = randomNumber(); should probably be const. > Source/WebCore/page/DOMTimer.cpp:431 > + // Force alignment to randomizedAlignment fraction of the way between alignemntIntervals, e.g. typo: alignemntIntervals 1169595 3 barraclough 2016-03-01 15:33:32 -0800 Transmitting file data .. Committed revision 197415. 272592 2016-03-01 14:33:08 -0800 2016-03-01 15:05:07 -0800 Fix 154878.1.patch text/plain 2338 barraclough SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NzQxMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE2LTAzLTAxICBHYXZpbiBC YXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KKworICAgICAgICBUaW1lciBhbGln bm1lbnQgaW4gc2VwYXJhdGUgd2ViIHByb2Nlc3NlcyBzaG91bGQgbm90IGFsbCBzeW5jIHVwIHRv IHRoZSBzYW1lIHBvaW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTU0ODc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRm9yIGFueSBnaXZlbiBXZWJDb250ZW50IHByb2Nlc3MgaXQgaXMgZGVzaXJhYmxl IHRoYXQgdGltZXJzIGFyZSBzeW5jaHJvbml6ZWQgdG8gYSBzaW5nbGUKKyAgICAgICAgYWxpZ25t ZW50IHBvaW50LCBidXQgaWYgYWxsIFdlYkNvbnRlbnQgcHJvY2Vzc2VzIGFsaWduIHRvIHRoZSBz YW1lIHBvaW50IHRoZW4gdGhlcmUgbWF5CisgICAgICAgIGJlIGEgdGh1bmRlcmluZyBoZXJkIG9m IHByb2Nlc3NlcyB3YWtpbmcgdXAuCisKKyAgICAgICAgKiBwYWdlL0RPTVRpbWVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkRPTVRpbWVyOjphbGlnbmVkRmlyZVRpbWUpOgorICAgICAgICAgICAg LSBhbGlnbiB0byBhIHJhbmRvbWl6ZWQgcG9pbnQuCisKIDIwMTYtMDMtMDEgIEFuZHJlYXMgS2xp bmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxNTQ2MTYpOiBB Y2NlbGVyYXRlZCBkcmF3aW5nIGlzIG9mZiBkdXJpbmcgdGhlIGluaXRpYWwgbG9hZApJbmRleDog U291cmNlL1dlYkNvcmUvcGFnZS9ET01UaW1lci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcGFnZS9ET01UaW1lci5jcHAJKHJldmlzaW9uIDE5NzM2MSkKKysrIFNvdXJjZS9XZWJD b3JlL3BhZ2UvRE9NVGltZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MCw2ICs0MCw3IEBACiAj aW5jbHVkZSA8d3RmL0hhc2hNYXAuaD4KICNpbmNsdWRlIDx3dGYvTWF0aEV4dHJhcy5oPgogI2lu Y2x1ZGUgPHd0Zi9OZXZlckRlc3Ryb3llZC5oPgorI2luY2x1ZGUgPHd0Zi9SYW5kb21OdW1iZXIu aD4KICNpbmNsdWRlIDx3dGYvU3RkTGliRXh0cmFzLmg+CiAKICNpZiBQTEFURk9STShJT1MpCkBA IC00MjIsOCArNDIzLDE1IEBAIGRvdWJsZSBET01UaW1lcjo6aW50ZXJ2YWxDbGFtcGVkVG9NaW5p bXUKIAogZG91YmxlIERPTVRpbWVyOjphbGlnbmVkRmlyZVRpbWUoZG91YmxlIGZpcmVUaW1lKSBj b25zdAogewotICAgIGlmIChkb3VibGUgYWxpZ25tZW50SW50ZXJ2YWwgPSBzY3JpcHRFeGVjdXRp b25Db250ZXh0KCktPnRpbWVyQWxpZ25tZW50SW50ZXJ2YWwobV9uZXN0aW5nTGV2ZWwgPj0gbWF4 VGltZXJOZXN0aW5nTGV2ZWwpKQotICAgICAgICByZXR1cm4gY2VpbChmaXJlVGltZSAvIGFsaWdu bWVudEludGVydmFsKSAqIGFsaWdubWVudEludGVydmFsOworICAgIGlmIChkb3VibGUgYWxpZ25t ZW50SW50ZXJ2YWwgPSBzY3JpcHRFeGVjdXRpb25Db250ZXh0KCktPnRpbWVyQWxpZ25tZW50SW50 ZXJ2YWwobV9uZXN0aW5nTGV2ZWwgPj0gbWF4VGltZXJOZXN0aW5nTGV2ZWwpKSB7CisgICAgICAg IC8vIERvbid0IG1lc3Mgd2l0aCB6ZXJvLWRlbGF5IHRpbWVycy4KKyAgICAgICAgaWYgKCFmaXJl VGltZSkKKyAgICAgICAgICAgIHJldHVybiBmaXJlVGltZTsKKyAgICAgICAgc3RhdGljIGRvdWJs ZSByYW5kb21pemVkQWxpZ25tZW50ID0gcmFuZG9tTnVtYmVyKCk7CisgICAgICAgIC8vIEZvcmNl IGFsaWdubWVudCB0byByYW5kb21pemVkQWxpZ25tZW50IGZyYWN0aW9uIG9mIHRoZSB3YXkgYmV0 d2VlbiBhbGlnbmVtbnRJbnRlcnZhbHMsIGUuZy4KKyAgICAgICAgLy8gaWYgYWxpZ25tZW50SW50 ZXJ2YWwgaXMgMTAgYW5kIHJhbmRvbWl6ZWRBbGlnbm1lbnQgaXMgMC4zIHRoaXMgd2lsbCBhbGln biB0byAzLCAxMywgMjMsIC4uLgorICAgICAgICByZXR1cm4gKGNlaWwoZmlyZVRpbWUgLyBhbGln bm1lbnRJbnRlcnZhbCAtIHJhbmRvbWl6ZWRBbGlnbm1lbnQpICsgcmFuZG9taXplZEFsaWdubWVu dCkgKiBhbGlnbm1lbnRJbnRlcnZhbDsKKyAgICB9CiAKICAgICByZXR1cm4gZmlyZVRpbWU7CiB9 Cg==