154871 2016-03-01 13:34:24 -0800 FTL should simplify StringReplace with an empty replacement string 2016-03-01 15:44:11 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1169551 0 fpizlo 2016-03-01 13:34:24 -0800 Patch forthcoming. 1169578 1 272594 fpizlo 2016-03-01 14:42:07 -0800 Created attachment 272594 the patch 1169581 2 272594 msaboff 2016-03-01 15:00:33 -0800 Comment on attachment 272594 the patch r=me 1169602 3 fpizlo 2016-03-01 15:44:11 -0800 Landed in http://trac.webkit.org/changeset/197416 and http://trac.webkit.org/changeset/197417 272594 2016-03-01 14:42:07 -0800 2016-03-01 15:00:33 -0800 the patch blah.patch text/plain 6099 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk3NDE0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBA CisyMDE2LTAzLTAxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RlRMIHNob3VsZCBzaW1wbGlmeSBTdHJpbmdSZXBsYWNlIHdpdGggYW4gZW1wdHkgcmVwbGFjZW1l bnQgc3RyaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTQ4NzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIGlzIGEgc2ltcGxlIGFuZCBodWdlbHkgcHJvZml0YWJsZSBjaGFuZ2UuIElmIHdlIGRv IGEgc3RyaW5nLnJlcGxhY2UoL3RoaW5ncy8sICIiKSwgdGhlbgorICAgICAgICB0aGlzIGNhbGxz IGRpcmVjdGx5IGludG8gU3RyaW5nUHJvdG90eXBlJ3MgcmVwbGFjZS13aXRoLWVtcHR5LXN0cmlu ZyBsb2dpYyBpbnN0ZWFkIG9mIGdvaW5nCisgICAgICAgIHRocm91Z2ggc3R1ZmYgdGhhdCBkb2Vz IGNoZWNrcyBiZWZvcmUgcmVhY2hpbmcgdGhhdCBzYW1lIGNvbmNsdXNpb24uCisKKyAgICAgICAg VGhpcyBzcGVlZHMgdXAgT2N0YW5lL3JlZ2V4cCBieSBhYm91dCAxMCUuIEl0IGFsc28gc3BlZWRz IHVwIHRoZSBhdHRhY2hlZCBtaWNyb2JlbmNobWFyayBieQorICAgICAgICBhYm91dCA3JS4gVGhl IGZhY3QgdGhhdCB0aGUgc3BlZWQtdXAgaXMgYmlnZ2VyIGluIE9jdGFuZSBpcyBwcm9iYWJseSBi ZWNhdXNlIHRoZXNlIGtpbmRzIG9mCisgICAgICAgIHRoaW5ncyBnZW5lcmF0ZSB0aGUgZ3JlYXRl c3QgYmVuZWZpdCBpbiB2ZXJ5IGxhcmdlIHByb2dyYW1zIHRoYXQgcHV0IHByZXNzdXJlIG9uIHRo ZSBpY2FjaGUuCisgICAgICAgIFRoYXQncyBteSBndWVzcyB0aG91Z2ggSSBoYXZlIGxpdHRsZSB0 byBiYWNrIGl0IHVwLgorCisgICAgICAgICogZnRsL0ZUTExvd2VyREZHVG9CMy5jcHA6CisgICAg ICAgIChKU0M6OkZUTDo6REZHOjpMb3dlckRGR1RvQjM6OmNvbXBpbGVTdHJpbmdSZXBsYWNlKToK KyAgICAgICAgKiBydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHA6CisgICAgICAgIChKU0M6Ompz U3BsaWNlU3Vic3RyaW5nc1dpdGhTZXBhcmF0b3JzKToKKyAgICAgICAgKEpTQzo6cmVtb3ZlVXNp bmdSZWdFeHBTZWFyY2gpOgorICAgICAgICAoSlNDOjpyZXBsYWNlVXNpbmdSZWdFeHBTZWFyY2gp OgorICAgICAgICAoSlNDOjpvcGVyYXRpb25TdHJpbmdQcm90b0Z1bmNSZXBsYWNlUmVnRXhwRW1w dHlTdHIpOgorICAgICAgICAoSlNDOjpvcGVyYXRpb25TdHJpbmdQcm90b0Z1bmNSZXBsYWNlUmVn RXhwU3RyaW5nKToKKyAgICAgICAgKiBydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5oOgorCiAyMDE2 LTAzLTAxICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmVkdWNlIHNpemUgb2YgaW50ZXJuYWwgd2luZG93cyBidWlsZCBvdXRwdXQKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9CMy5jcHAJKHJldmlz aW9uIDE5NzQwOCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0Iz LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjQ2Nyw2ICs2NDY3LDIxIEBAIHByaXZhdGU6CiAgICAg ICAgIGlmIChtX25vZGUtPmNoaWxkMSgpLnVzZUtpbmQoKSA9PSBTdHJpbmdVc2UKICAgICAgICAg ICAgICYmIG1fbm9kZS0+Y2hpbGQyKCkudXNlS2luZCgpID09IFJlZ0V4cE9iamVjdFVzZQogICAg ICAgICAgICAgJiYgbV9ub2RlLT5jaGlsZDMoKS51c2VLaW5kKCkgPT0gU3RyaW5nVXNlKSB7CisK KyAgICAgICAgICAgIGlmIChKU1N0cmluZyogcmVwbGFjZSA9IG1fbm9kZS0+Y2hpbGQzKCktPmR5 bmFtaWNDYXN0Q29uc3RhbnQ8SlNTdHJpbmcqPigpKSB7CisgICAgICAgICAgICAgICAgaWYgKCFy ZXBsYWNlLT5sZW5ndGgoKSkgeworICAgICAgICAgICAgICAgICAgICBMVmFsdWUgc3RyaW5nID0g bG93U3RyaW5nKG1fbm9kZS0+Y2hpbGQxKCkpOworICAgICAgICAgICAgICAgICAgICBMVmFsdWUg cmVnRXhwID0gbG93Q2VsbChtX25vZGUtPmNoaWxkMigpKTsKKyAgICAgICAgICAgICAgICAgICAg c3BlY3VsYXRlUmVnRXhwT2JqZWN0KG1fbm9kZS0+Y2hpbGQyKCksIHJlZ0V4cCk7CisKKyAgICAg ICAgICAgICAgICAgICAgTFZhbHVlIHJlc3VsdCA9IHZtQ2FsbCgKKyAgICAgICAgICAgICAgICAg ICAgICAgIEludDY0LCBtX291dC5vcGVyYXRpb24ob3BlcmF0aW9uU3RyaW5nUHJvdG9GdW5jUmVw bGFjZVJlZ0V4cEVtcHR5U3RyKSwKKyAgICAgICAgICAgICAgICAgICAgICAgIG1fY2FsbEZyYW1l LCBzdHJpbmcsIHJlZ0V4cCk7CisKKyAgICAgICAgICAgICAgICAgICAgc2V0SlNWYWx1ZShyZXN1 bHQpOworICAgICAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICAgICAgfQorICAg ICAgICAgICAgfQogICAgICAgICAgICAgCiAgICAgICAgICAgICBMVmFsdWUgc3RyaW5nID0gbG93 U3RyaW5nKG1fbm9kZS0+Y2hpbGQxKCkpOwogICAgICAgICAgICAgTFZhbHVlIHJlZ0V4cCA9IGxv d0NlbGwobV9ub2RlLT5jaGlsZDIoKSk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9TdHJpbmdQcm90b3R5cGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAJKHJldmlzaW9uIDE5NzQwOCkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTQ0Niw3ICs0NDYsNyBAQCBzdGF0aWMgQUxXQVlTX0lOTElORSBKU1ZhbHVlIGpz U3BsaWNlU3ViCiAgICAgcmV0dXJuIGpzU3RyaW5nKGV4ZWMsIGltcGwucmVsZWFzZSgpKTsKIH0K IAotc3RhdGljIE5FVkVSX0lOTElORSBFbmNvZGVkSlNWYWx1ZSByZW1vdmVVc2luZ1JlZ0V4cFNl YXJjaChFeGVjU3RhdGUqIGV4ZWMsIEpTU3RyaW5nKiBzdHJpbmcsIGNvbnN0IFN0cmluZyYgc291 cmNlLCBSZWdFeHAqIHJlZ0V4cCkKK3N0YXRpYyBBTFdBWVNfSU5MSU5FIEVuY29kZWRKU1ZhbHVl IHJlbW92ZVVzaW5nUmVnRXhwU2VhcmNoKEV4ZWNTdGF0ZSogZXhlYywgSlNTdHJpbmcqIHN0cmlu ZywgY29uc3QgU3RyaW5nJiBzb3VyY2UsIFJlZ0V4cCogcmVnRXhwKQogewogICAgIHNpemVfdCBs YXN0SW5kZXggPSAwOwogICAgIHVuc2lnbmVkIHN0YXJ0UG9zaXRpb24gPSAwOwpAQCAtNTA2LDYg KzUwNiw4IEBAIHN0YXRpYyBBTFdBWVNfSU5MSU5FIEVuY29kZWRKU1ZhbHVlIHJlcGwKICAgICAg ICAgICAgIHJldHVybiByZW1vdmVVc2luZ1JlZ0V4cFNlYXJjaChleGVjLCBzdHJpbmcsIHNvdXJj ZSwgcmVnRXhwKTsKICAgICB9CiAKKyAgICAvLyBGSVhNRTogVGhpcyBpcyB3cm9uZyBiZWNhdXNl IHdlIG1heSBiZSBjYWxsZWQgZGlyZWN0bHkgZnJvbSB0aGUgRlRMLgorICAgIC8vIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTQ4NzQKICAgICBSZWdFeHBDb25zdHJ1 Y3RvciogcmVnRXhwQ29uc3RydWN0b3IgPSBleGVjLT5sZXhpY2FsR2xvYmFsT2JqZWN0KCktPnJl Z0V4cENvbnN0cnVjdG9yKCk7CiAKICAgICBzaXplX3QgbGFzdEluZGV4ID0gMDsKQEAgLTY2NCw2 ICs2NjYsMjQgQEAgc3RhdGljIEFMV0FZU19JTkxJTkUgRW5jb2RlZEpTVmFsdWUgcmVwbAogICAg IHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNTcGxpY2VTdWJzdHJpbmdzV2l0aFNlcGFyYXRvcnMo ZXhlYywgc3RyaW5nLCBzb3VyY2UsIHNvdXJjZVJhbmdlcy5kYXRhKCksIHNvdXJjZVJhbmdlcy5z aXplKCksIHJlcGxhY2VtZW50cy5kYXRhKCksIHJlcGxhY2VtZW50cy5zaXplKCkpKTsKIH0KIAor RW5jb2RlZEpTVmFsdWUgSklUX09QRVJBVElPTiBvcGVyYXRpb25TdHJpbmdQcm90b0Z1bmNSZXBs YWNlUmVnRXhwRW1wdHlTdHIoCisgICAgRXhlY1N0YXRlKiBleGVjLCBKU1N0cmluZyogdGhpc1Zh bHVlLCBSZWdFeHBPYmplY3QqIHNlYXJjaFZhbHVlKQoreworICAgIFJlZ0V4cCogcmVnRXhwID0g c2VhcmNoVmFsdWUtPnJlZ0V4cCgpOworICAgIGlmIChyZWdFeHAtPmdsb2JhbCgpKSB7CisgICAg ICAgIC8vIEVTNS4xIDE1LjUuNC4xMCBzdGVwIDguYS4KKyAgICAgICAgc2VhcmNoVmFsdWUtPnNl dExhc3RJbmRleChleGVjLCAwKTsKKyAgICAgICAgaWYgKGV4ZWMtPmhhZEV4Y2VwdGlvbigpKQor ICAgICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKKyAgICAg ICAgcmV0dXJuIHJlbW92ZVVzaW5nUmVnRXhwU2VhcmNoKGV4ZWMsIHRoaXNWYWx1ZSwgdGhpc1Zh bHVlLT52YWx1ZShleGVjKSwgcmVnRXhwKTsKKyAgICB9CisKKyAgICBDYWxsRGF0YSBjYWxsRGF0 YTsKKyAgICBTdHJpbmcgcmVwbGFjZW1lbnRTdHJpbmcgPSBlbXB0eVN0cmluZygpOworICAgIHJl dHVybiByZXBsYWNlVXNpbmdSZWdFeHBTZWFyY2goCisgICAgICAgIGV4ZWMsIHRoaXNWYWx1ZSwg c2VhcmNoVmFsdWUsIGNhbGxEYXRhLCBDYWxsVHlwZU5vbmUsIHJlcGxhY2VtZW50U3RyaW5nLCBK U1ZhbHVlKCkpOworfQorCiBFbmNvZGVkSlNWYWx1ZSBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvblN0 cmluZ1Byb3RvRnVuY1JlcGxhY2VSZWdFeHBTdHJpbmcoCiAgICAgRXhlY1N0YXRlKiBleGVjLCBK U1N0cmluZyogdGhpc1ZhbHVlLCBSZWdFeHBPYmplY3QqIHNlYXJjaFZhbHVlLCBKU1N0cmluZyog cmVwbGFjZVN0cmluZykKIHsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0 cmluZ1Byb3RvdHlwZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL1N0cmluZ1Byb3RvdHlwZS5oCShyZXZpc2lvbiAxOTc0MDgpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9TdHJpbmdQcm90b3R5cGUuaAkod29ya2luZyBjb3B5KQpAQCAtNTQs MTEgKzU0LDEzIEBAIHByaXZhdGU6CiB9OwogCiBFbmNvZGVkSlNWYWx1ZSBKSVRfT1BFUkFUSU9O IG9wZXJhdGlvblN0cmluZ1Byb3RvRnVuY1JlcGxhY2VHZW5lcmljKAotICAgIEV4ZWNTdGF0ZSog ZXhlYywgRW5jb2RlZEpTVmFsdWUgdGhpc1ZhbHVlLCBFbmNvZGVkSlNWYWx1ZSBzZWFyY2hWYWx1 ZSwKLSAgICBFbmNvZGVkSlNWYWx1ZSByZXBsYWNlVmFsdWUpOworICAgIEV4ZWNTdGF0ZSosIEVu Y29kZWRKU1ZhbHVlIHRoaXNWYWx1ZSwgRW5jb2RlZEpTVmFsdWUgc2VhcmNoVmFsdWUsIEVuY29k ZWRKU1ZhbHVlIHJlcGxhY2VWYWx1ZSk7CisKK0VuY29kZWRKU1ZhbHVlIEpJVF9PUEVSQVRJT04g b3BlcmF0aW9uU3RyaW5nUHJvdG9GdW5jUmVwbGFjZVJlZ0V4cEVtcHR5U3RyKAorICAgIEV4ZWNT dGF0ZSosIEpTU3RyaW5nKiB0aGlzVmFsdWUsIFJlZ0V4cE9iamVjdCogc2VhcmNoVmFsdWUpOwog CiBFbmNvZGVkSlNWYWx1ZSBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvblN0cmluZ1Byb3RvRnVuY1Jl cGxhY2VSZWdFeHBTdHJpbmcoCi0gICAgRXhlY1N0YXRlKiBleGVjLCBKU1N0cmluZyogdGhpc1Zh bHVlLCBSZWdFeHBPYmplY3QqIHNlYXJjaFZhbHVlLCBKU1N0cmluZyogcmVwbGFjZVZhbHVlKTsK KyAgICBFeGVjU3RhdGUqLCBKU1N0cmluZyogdGhpc1ZhbHVlLCBSZWdFeHBPYmplY3QqIHNlYXJj aFZhbHVlLCBKU1N0cmluZyogcmVwbGFjZVZhbHVlKTsKIAogfSAvLyBuYW1lc3BhY2UgSlNDCiAK