154858 2016-03-01 07:06:00 -0800 Disable FTL JIT testing on 32-bit JSC tester bots 2016-07-20 02:17:57 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 154964 154967 1 ossy webkit-unassigned ap benjamin commit-queue darin fpizlo ggaren keith_miller lforschler mark.lam msaboff ossy rniwa saam oldest_to_newest 1169430 0 ossy 2016-03-01 07:06:00 -0800 Now --ftl-jit is passed to run-jsc-stress-tests on these bots (by run-javascriptcore-tests): - Apple El Capitan 32-bit JSC (BuildAndTest) - Apple Yosemite 32-bit JSC (BuildAndTest) There is no reason to run 30k tests instead of 17k since there is no FTL JIT on 32 bit architectures. 1169431 1 272563 ossy 2016-03-01 07:06:53 -0800 Created attachment 272563 Patch 1169721 2 ossy 2016-03-01 21:33:31 -0800 ping 1169743 3 ap 2016-03-01 22:26:51 -0800 Shouldn't this behavior be baked in run-javascriptcore-tests? This combination is never useful, not just on the bots. 1169763 4 272563 commit-queue 2016-03-01 22:58:23 -0800 Comment on attachment 272563 Patch Clearing flags on attachment: 272563 Committed r197442: <http://trac.webkit.org/changeset/197442> 1169764 5 commit-queue 2016-03-01 22:58:27 -0800 All reviewed patches have been landed. Closing bug. 1169781 6 ossy 2016-03-02 00:49:47 -0800 (In reply to comment #3) > Shouldn't this behavior be baked in run-javascriptcore-tests? This > combination is never useful, not just on the bots. It would be better ... but I haven't found any simple option in run-javascriptcore-tests and webktidirs.pm to determine if we build Apple Mac x86 JSC. But I'll be happy to review any patch replaces this with a better fix in run-javascriptcore-tests. 1169783 7 ossy 2016-03-02 00:51:09 -0800 It seems automatical buildbot master restart still doesn't work. :( Could you possibly restart the master manually? 1169839 8 ap 2016-03-02 09:46:17 -0800 > It seems automatical buildbot master restart still doesn't work. :( It's not supposed to, as it's a fairly dangerous operation, so it's better if someone with direct access to the server is around to perform it. 1169841 9 ap 2016-03-02 09:48:49 -0800 > I haven't found any simple option in run-javascriptcore-tests and webktidirs.pm I do not know how to best do that, but I'm sure that someone on the CC list does. 1169846 10 ossy 2016-03-02 09:55:44 -0800 (In reply to comment #8) > > It seems automatical buildbot master restart still doesn't work. :( > > It's not supposed to, as it's a fairly dangerous operation, so it's better > if someone with direct access to the server is around to perform it. Previously it worked properly. Nowadays all webkitpy and BuildSlaveSupport change triggers restart except master.cfg and config.json. (bug107052) I think it can be dangerous only if folks land master.cfg changes blindly without local testing or at least unit testing. But in this case an immediate rollout would fix the master without direct access to the server. 1169909 11 keith_miller 2016-03-02 12:58:58 -0800 (In reply to comment #9) > > I haven't found any simple option in run-javascriptcore-tests and webktidirs.pm > > I do not know how to best do that, but I'm sure that someone on the CC list > does. I don't think there is any current way to know if FTL is enabled. One solution would be to have the jsc binary have some option that prints information about the build e.g. if FTL/DFG are enabled. Then run-javascriptcore-tests could just not run the modes relevant to those builds. I'm not sure that's a high priority to implement but maybe it's something we should consider in the future. A quicker, less general fix would be to have run-javascriptcore-tests run the file command on the jsc binary and not run FTL tests if the binary is 32-bit. 1170129 12 ossy 2016-03-02 23:42:30 -0800 Ping for master restart. 1170158 13 rniwa 2016-03-03 01:44:41 -0800 (In reply to comment #12) > Ping for master restart. Done that. 1170226 14 commit-queue 2016-03-03 09:26:02 -0800 Re-opened since this is blocked by bug 154967 1170233 15 ossy 2016-03-03 09:28:32 -0800 I won't have time for it, feel free to pick it up if you are interested in 80 mins runtime instead of 110 mins on 32 bit bots. 1170235 16 ap 2016-03-03 09:29:58 -0800 Rolled out in r197442, so the master needs to be restarted again. 1212701 17 ossy 2016-07-20 02:17:57 -0700 Close as resolved/wontfix, because it won't be possible after https://trac.webkit.org/changeset/203440. 272563 2016-03-01 07:06:53 -0800 2016-03-01 22:58:23 -0800 Patch bug-154858-20160301070637.patch text/plain 1593 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3Mzk5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWExZDcyMjY2YjI5ZGNhNjVlM2NjOTg2NzA3ZjA3ZGFi YzYyZThkMC4uMGMwNDdiY2MxNjZlNWQwNGYzMDkwY2M2ZDY0YWU5MzVlYmVkY2VhZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE2LTAzLTAxICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgRGlzYWJsZSBGVEwgSklUIHRlc3Rpbmcgb24gMzItYml0IEpTQyB0ZXN0ZXIgYm90 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0ODU4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWls ZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnOgorICAgICAg ICAoUnVuMzJiaXRKU0NUZXN0cyk6CisKIDIwMTYtMDItMjkgIENocmlzIER1bWV6ICA8Y2R1bWV6 QGFwcGxlLmNvbT4KIAogICAgICAgICBIYXZlIHBhcnNlSFRNTEludGVnZXIoKSAvIHBhcnNlSFRN TE5vbk5lZ2F0aXZlSW50ZWdlcigpIHVzZSBXVEY6Ok9wdGlvbmFsCmRpZmYgLS1naXQgYS9Ub29s cy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnIGIv VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNm ZwppbmRleCBhODQzMTFkMjBjYTRiYWI5YzkxNmQwYzQ5NTIzYjY5NWRjZTBkNTM1Li5kYTI4MDk2 OWVlYmNkNzE2OTAwMTFhMWEwODVjMTFkMWJkODEwMzMzIDEwMDY0NAotLS0gYS9Ub29scy9CdWls ZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCisrKyBiL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcK QEAgLTUyNiw3ICs1MjYsNyBAQCBjbGFzcyBSdW4zMmJpdEpTQ1Rlc3RzKFRlc3RXaXRoRmFpbHVy ZUNvdW50KToKICAgICBuYW1lID0gIndlYmtpdC0zMmJpdC1qc2MtdGVzdCIKICAgICBkZXNjcmlw dGlvbiA9IFsiMzJiaXQtanNjLXRlc3RzIHJ1bm5pbmciXQogICAgIGRlc2NyaXB0aW9uRG9uZSA9 IFsiMzJiaXQtanNjLXRlc3RzIl0KLSAgICBjb21tYW5kID0gWyJwZXJsIiwgIi4vVG9vbHMvU2Ny aXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMiLCAiLS0zMi1iaXQiLCAiLS1uby1idWlsZCIs IFdpdGhQcm9wZXJ0aWVzKCItLSUoY29uZmlndXJhdGlvbilzIildCisgICAgY29tbWFuZCA9IFsi cGVybCIsICIuL1Rvb2xzL1NjcmlwdHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzIiwgIi0tMzIt Yml0IiwgIi0tbm8tZnRsLWppdCIsICItLW5vLWJ1aWxkIiwgV2l0aFByb3BlcnRpZXMoIi0tJShj b25maWd1cmF0aW9uKXMiKV0KICAgICBmYWlsZWRUZXN0c0Zvcm1hdFN0cmluZyA9ICIlZCByZWdy ZXNzaW9uJXMgZm91bmQuIgogCiAgICAgZGVmIGNvdW50RmFpbHVyZXMoc2VsZiwgY21kKToK