154833 2016-02-29 13:30:53 -0800 OverridesHasInstance constant folding is wrong 2016-02-29 14:45:14 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller keith_miller commit-queue mark.lam msaboff saam oldest_to_newest 1169246 0 keith_miller 2016-02-29 13:30:53 -0800 OverridesHasInstance constant folding is wrong 1169250 1 272514 keith_miller 2016-02-29 13:41:59 -0800 Created attachment 272514 Patch 1169251 2 272514 mark.lam 2016-02-29 13:45:58 -0800 Comment on attachment 272514 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272514&action=review > Source/JavaScriptCore/ChangeLog:10 > + moved to the StrengthReductionPhase. Normally, such an optimazation would be typo: optimazation => optimization 1169258 3 272514 keith_miller 2016-02-29 13:52:34 -0800 Comment on attachment 272514 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272514&action=review >> Source/JavaScriptCore/ChangeLog:10 >> + moved to the StrengthReductionPhase. Normally, such an optimazation would be > > typo: optimazation => optimization Fixed 1169276 4 272514 commit-queue 2016-02-29 14:45:10 -0800 Comment on attachment 272514 Patch Clearing flags on attachment: 272514 Committed r197370: <http://trac.webkit.org/changeset/197370> 1169277 5 commit-queue 2016-02-29 14:45:14 -0800 All reviewed patches have been landed. Closing bug. 272514 2016-02-29 13:41:59 -0800 2016-02-29 14:45:10 -0800 Patch bug-154833-20160229134143.patch text/plain 4688 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3MzUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 Y2VjZTJmZTdjYjU3NTE5MTgwOGRhMjNkMTQ2ZDU2MTFlYWYwNGVjLi4wZDI0N2QxMTdhN2QxMThm ZGJjZDIxZjNiMGFjYjMzMmFjMmQ2ZGU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNyBAQAorMjAxNi0wMi0yOSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBPdmVycmlkZXNIYXNJbnN0YW5jZSBjb25zdGFudCBmb2xkaW5nIGlz IHdyb25nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTQ4MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbiBvZiBPdmVycmlkZXNIYXNJbnN0YW5jZSBjb25zdGFu dCBmb2xkaW5nCisgICAgICAgIGlzIGluY29ycmVjdC4gU2luY2UgaXQgcmVsaWVzIG9uIE9TUiBl eGl0IGluZm9ybWF0aW9uIGl0IGhhcyBiZWVuCisgICAgICAgIG1vdmVkIHRvIHRoZSBTdHJlbmd0 aFJlZHVjdGlvblBoYXNlLiBOb3JtYWxseSwgc3VjaCBhbiBvcHRpbWF6YXRpb24gd291bGQgYmUK KyAgICAgICAgcHV0IGluIEZpeHVwUGhhc2UsIGhvd2V2ZXIsIHRoZXJlIGFyZSBhIG51bWJlciBv ZiBjYXNlcyB3aGVyZSB3ZSBkb24ndAorICAgICAgICBkZXRlcm1pbmUgYW4gZWRnZSBvZiBPdmVy cmlkZXNIYXNJbnN0YW5jZSBpcyBhIGNvbnN0YW50IHVudGlsIGFmdGVyIGZpeHVwLgorICAgICAg ICBQZXJmb3JtaW5nIHRoZSBvcHRpbWl6YXRpb24gZHVyaW5nIFN0cmVuZ3RoUmVkdWN0aW9uUGhh c2UgbWVhbnMgd2UgY2FuIGRlZmVyCisgICAgICAgIG91ciBkZWNpc2lvbiB1bnRpbCBsYXRlci4K KworICAgICAgICBJbiB0aGUgZnV0dXJlIHdlIHNob3VsZCBjb25zaWRlciBjcmVhdGluZyBhIHZl cnNpb24gb2YgdGhpcyBvcHRpbWl6YXRpb24KKyAgICAgICAgdGhhdCBkb2VzIG5vdCBkZXBlbmQg b24gT1NSIGV4aXQgaW5mb3JtYXRpb24gYW5kIG1vdmUgdGhlIG9wdGltaXphdGlvbiBiYWNrCisg ICAgICAgIHRvIENvbnN0YW50Rm9sZGluZ1BoYXNlLgorCisgICAgICAgICogZGZnL0RGR0NvbnN0 YW50Rm9sZGluZ1BoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpDb25zdGFudEZvbGRpbmdQ aGFzZTo6Zm9sZENvbnN0YW50cyk6IERlbGV0ZWQuCisgICAgICAgICogZGZnL0RGR1N0cmVuZ3Ro UmVkdWN0aW9uUGhhc2UuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlN0cmVuZ3RoUmVkdWN0aW9u UGhhc2U6OmhhbmRsZU5vZGUpOgorCiAyMDE2LTAyLTI4ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5n QGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIEpTRnVuY3Rpb24ubmFtZSBhbGxvY2F0aW9uIGZ1 bGx5IGxhenkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0NvbnN0 YW50Rm9sZGluZ1BoYXNlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ29uc3Rh bnRGb2xkaW5nUGhhc2UuY3BwCmluZGV4IGY1MzIwOWI3ZGE3YTg5MTg3MTYwYzE0OGQ4NzRmN2Qw MDc3MTIyNWMuLmU1YmU4ZWZiNTU2ZDE3ZjMwNGNhMmZlMTViZWUzYTlmNjdmZjMwYmUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ29uc3RhbnRGb2xkaW5nUGhhc2Uu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ29uc3RhbnRGb2xkaW5nUGhh c2UuY3BwCkBAIC01NTMsMjQgKzU1Myw2IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAgICAgYnJl YWs7CiAgICAgICAgICAgICB9CiAKLSAgICAgICAgICAgIGNhc2UgT3ZlcnJpZGVzSGFzSW5zdGFu Y2U6IHsKLSAgICAgICAgICAgICAgICBpZiAoIW5vZGUtPmNoaWxkMigpLm5vZGUoKS0+aXNDZWxs Q29uc3RhbnQoKSkKLSAgICAgICAgICAgICAgICAgICAgYnJlYWs7Ci0KLSAgICAgICAgICAgICAg ICBpZiAobm9kZS0+Y2hpbGQyKCkubm9kZSgpLT5hc0NlbGwoKSAhPSBtX2dyYXBoLmdsb2JhbE9i amVjdEZvcihub2RlLT5vcmlnaW4uc2VtYW50aWMpLT5mdW5jdGlvblByb3RvSGFzSW5zdGFuY2VT eW1ib2xGdW5jdGlvbigpKSB7Ci0gICAgICAgICAgICAgICAgICAgIG1fZ3JhcGguY29udmVydFRv Q29uc3RhbnQobm9kZSwganNCb29sZWFuKHRydWUpKTsKLSAgICAgICAgICAgICAgICAgICAgY2hh bmdlZCA9IHRydWU7Ci0KLSAgICAgICAgICAgICAgICB9IGVsc2UgaWYgKCFtX2dyYXBoLmhhc0V4 aXRTaXRlKG5vZGUtPm9yaWdpbi5zZW1hbnRpYywgQmFkVHlwZUluZm9GbGFncykpIHsKLSAgICAg ICAgICAgICAgICAgICAgLy8gV2Ugb3B0aW1pc3RpY2FsbHkgYXNzdW1lIHRoYXQgd2Ugd2lsbCBu b3Qgc2VlIGEgZnVuY3Rpb24gdGhhdCBoYXMgYSBjdXN0b20gaW5zdGFuY2VvZiBvcGVyYXRpb24g YXMgdGhleSBzaG91bGQgYmUgcmFyZS4KLSAgICAgICAgICAgICAgICAgICAgbV9pbnNlcnRpb25T ZXQuaW5zZXJ0Tm9kZShpbmRleEluQmxvY2ssIFNwZWNOb25lLCBDaGVja1R5cGVJbmZvRmxhZ3Ms IG5vZGUtPm9yaWdpbiwgT3BJbmZvKEltcGxlbWVudHNEZWZhdWx0SGFzSW5zdGFuY2UpLCBFZGdl KG5vZGUtPmNoaWxkMSgpLm5vZGUoKSwgQ2VsbFVzZSkpOwotICAgICAgICAgICAgICAgICAgICBt X2dyYXBoLmNvbnZlcnRUb0NvbnN0YW50KG5vZGUsIGpzQm9vbGVhbihmYWxzZSkpOwotICAgICAg ICAgICAgICAgICAgICBjaGFuZ2VkID0gdHJ1ZTsKLSAgICAgICAgICAgICAgICB9Ci0gICAgICAg ICAgICAgICAgCi0gICAgICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgICAgICB9Ci0KICAgICAg ICAgICAgIGNhc2UgQ2hlY2s6IHsKICAgICAgICAgICAgICAgICBhbHJlYWR5SGFuZGxlZCA9IHRy dWU7CiAgICAgICAgICAgICAgICAgbV9pbnRlcnByZXRlci5leGVjdXRlKGluZGV4SW5CbG9jayk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1N0cmVuZ3RoUmVkdWN0 aW9uUGhhc2UuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTdHJlbmd0aFJlZHVj dGlvblBoYXNlLmNwcAppbmRleCA2MmI0NTk0N2NlNzBkYThjNTJiNTI0ZThiYmM0ZWJjZGUyNzk5 OTVkLi4xNGFkNzllNmM4YzMzMjE2MTQwNGZmMTBkNjdlZDc2MWMzZTlkYWFhIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1N0cmVuZ3RoUmVkdWN0aW9uUGhhc2UuY3Bw CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3RyZW5ndGhSZWR1Y3Rpb25QaGFz ZS5jcHAKQEAgLTI1NSw2ICsyNTUsMjYgQEAgcHJpdmF0ZToKICAgICAgICAgICAgIG1fY2hhbmdl ZCA9IHRydWU7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQorCisgICAgICAgIC8vIEZJ WE1FOiB3ZSBzaG91bGQgcHJvYmFibHkgZG8gdGhpcyBpbiBjb25zdGFudCBmb2xkaW5nIGJ1dCB0 aGlzIGN1cnJlbnRseSByZWxpZXMgb24gYW4gT1NSIGV4aXQgcnVsZS4KKyAgICAgICAgLy8gaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDgzMgorICAgICAgICBjYXNl IE92ZXJyaWRlc0hhc0luc3RhbmNlOiB7CisgICAgICAgICAgICBpZiAoIW1fbm9kZS0+Y2hpbGQy KCkubm9kZSgpLT5pc0NlbGxDb25zdGFudCgpKQorICAgICAgICAgICAgICAgIGJyZWFrOworCisg ICAgICAgICAgICBpZiAobV9ub2RlLT5jaGlsZDIoKS5ub2RlKCktPmFzQ2VsbCgpICE9IG1fZ3Jh cGguZ2xvYmFsT2JqZWN0Rm9yKG1fbm9kZS0+b3JpZ2luLnNlbWFudGljKS0+ZnVuY3Rpb25Qcm90 b0hhc0luc3RhbmNlU3ltYm9sRnVuY3Rpb24oKSkgeworICAgICAgICAgICAgICAgIG1fZ3JhcGgu Y29udmVydFRvQ29uc3RhbnQobV9ub2RlLCBqc0Jvb2xlYW4odHJ1ZSkpOworICAgICAgICAgICAg ICAgIG1fY2hhbmdlZCA9IHRydWU7CisKKyAgICAgICAgICAgIH0gZWxzZSBpZiAoIW1fZ3JhcGgu aGFzRXhpdFNpdGUobV9ub2RlLT5vcmlnaW4uc2VtYW50aWMsIEJhZFR5cGVJbmZvRmxhZ3MpKSB7 CisgICAgICAgICAgICAgICAgLy8gV2Ugb3B0aW1pc3RpY2FsbHkgYXNzdW1lIHRoYXQgd2Ugd2ls bCBub3Qgc2VlIGEgZnVuY3Rpb24gdGhhdCBoYXMgYSBjdXN0b20gaW5zdGFuY2VvZiBvcGVyYXRp b24gYXMgdGhleSBzaG91bGQgYmUgcmFyZS4KKyAgICAgICAgICAgICAgICBtX2luc2VydGlvblNl dC5pbnNlcnROb2RlKG1fbm9kZUluZGV4LCBTcGVjTm9uZSwgQ2hlY2tUeXBlSW5mb0ZsYWdzLCBt X25vZGUtPm9yaWdpbiwgT3BJbmZvKEltcGxlbWVudHNEZWZhdWx0SGFzSW5zdGFuY2UpLCBFZGdl KG1fbm9kZS0+Y2hpbGQxKCkubm9kZSgpLCBDZWxsVXNlKSk7CisgICAgICAgICAgICAgICAgbV9n cmFwaC5jb252ZXJ0VG9Db25zdGFudChtX25vZGUsIGpzQm9vbGVhbihmYWxzZSkpOworICAgICAg ICAgICAgICAgIG1fY2hhbmdlZCA9IHRydWU7CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAg IGJyZWFrOworICAgICAgICB9CiAgICAgICAgICAgICAKICAgICAgICAgZGVmYXVsdDoKICAgICAg ICAgICAgIGJyZWFrOwo=