154824 2016-02-29 10:37:41 -0800 Use WTF::Optional for HTMLOListElement::m_start 2016-02-29 16:32:32 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue darin esprehn+autocc gyuyoung.kim kling rniwa sam oldest_to_newest 1169195 0 cdumez 2016-02-29 10:37:41 -0800 Use WTF::Optional for HTMLOListElement::m_start 1169196 1 272500 cdumez 2016-02-29 10:38:58 -0800 Created attachment 272500 Patch 1169198 2 272501 cdumez 2016-02-29 10:39:52 -0800 Created attachment 272501 Patch 1169237 3 272501 kling 2016-02-29 12:43:20 -0800 Comment on attachment 272501 Patch r=me 1169247 4 272501 commit-queue 2016-02-29 13:32:20 -0800 Comment on attachment 272501 Patch Clearing flags on attachment: 272501 Committed r197364: <http://trac.webkit.org/changeset/197364> 1169248 5 commit-queue 2016-02-29 13:32:25 -0800 All reviewed patches have been landed. Closing bug. 1169300 6 darin 2016-02-29 16:10:53 -0800 Now we just have to change those parseHTML functions to return an Optional<> rather than returning a boolean and using an out argument for the parsed values. 1169309 7 cdumez 2016-02-29 16:32:32 -0800 (In reply to comment #6) > Now we just have to change those parseHTML functions to return an Optional<> > rather than returning a boolean and using an out argument for the parsed > values. Ah, that sounds good indeed :) 272500 2016-02-29 10:38:58 -0800 2016-02-29 10:39:50 -0800 Patch bug-154824-20160229103842.patch text/plain 3302 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3MzU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmQ2OTk4N2IwZDEyMjJi NjE5MDFiNTI0NGNlMDg1YmVlNzM1Nzk0My4uNzI0ZDRlZTZkYzU5NjI5NzkxYmU3MmIxYWEyYmJk NzJiYmZiNGNkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE2LTAyLTI5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgVXNlIFdURjo6T3B0aW9uYWwg Zm9yIEhUTUxPTGlzdEVsZW1lbnQ6Om1fc3RhcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDgyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFVzZSBXVEY6Ok9wdGlvbmFsIGZvciBIVE1MT0xpc3RFbGVt ZW50OjptX3N0YXJ0LgorCisgICAgICAgICogaHRtbC9IVE1MT0xpc3RFbGVtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxPTGlzdEVsZW1lbnQ6OnBhcnNlQXR0cmlidXRlKToKKyAgICAg ICAgKFdlYkNvcmU6OkhUTUxPTGlzdEVsZW1lbnQ6OkhUTUxPTGlzdEVsZW1lbnQpOiBEZWxldGVk LgorICAgICAgICAqIGh0bWwvSFRNTE9MaXN0RWxlbWVudC5oOgorCisyMDE2LTAyLTI5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKICAgICAgICAgVXNlIEhUTUwgcGFyc2luZyBy dWxlcyBmb3IgdGV4dGFyZWEubWF4TGVuZ3RoCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTQ4MDUKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MT0xpc3RFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE9MaXN0 RWxlbWVudC5jcHAKaW5kZXggNmNiMTk3NzMxY2FhZmRhY2M4YzM5NDYyMzBlNzlmYTI4OTgwNjhi OC4uNGFjYzYxOWU5MmQ5Yzk1NzU3ZjcwYjdkNGFkNjU1NzkxOGQwNjU4MyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MT0xpc3RFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxPTGlzdEVsZW1lbnQuY3BwCkBAIC0zNSw5ICszNSw3IEBAIHVzaW5nIG5h bWVzcGFjZSBIVE1MTmFtZXM7CiAKIEhUTUxPTGlzdEVsZW1lbnQ6OkhUTUxPTGlzdEVsZW1lbnQo Y29uc3QgUXVhbGlmaWVkTmFtZSYgdGFnTmFtZSwgRG9jdW1lbnQmIGRvY3VtZW50KQogICAgIDog SFRNTEVsZW1lbnQodGFnTmFtZSwgZG9jdW1lbnQpCi0gICAgLCBtX3N0YXJ0KDB4QkFEQkVFRikK ICAgICAsIG1faXRlbUNvdW50KDApCi0gICAgLCBtX2hhc0V4cGxpY2l0U3RhcnQoZmFsc2UpCiAg ICAgLCBtX2lzUmV2ZXJzZWQoZmFsc2UpCiAgICAgLCBtX3Nob3VsZFJlY2FsY3VsYXRlSXRlbUNv dW50KGZhbHNlKQogewpAQCAtODIsOSArODAsMTEgQEAgdm9pZCBIVE1MT0xpc3RFbGVtZW50Ojpw YXJzZUF0dHJpYnV0ZShjb25zdCBRdWFsaWZpZWROYW1lJiBuYW1lLCBjb25zdCBBdG9taWNTdHIK IHsKICAgICBpZiAobmFtZSA9PSBzdGFydEF0dHIpIHsKICAgICAgICAgaW50IG9sZFN0YXJ0ID0g c3RhcnQoKTsKLSAgICAgICAgbV9oYXNFeHBsaWNpdFN0YXJ0ID0gcGFyc2VIVE1MSW50ZWdlcih2 YWx1ZSwgbV9zdGFydCk7Ci0gICAgICAgIGlmICghbV9oYXNFeHBsaWNpdFN0YXJ0KQotICAgICAg ICAgICAgbV9zdGFydCA9IDB4QkFEQkVFRjsKKyAgICAgICAgaW50IHBhcnNlZFN0YXJ0OworICAg ICAgICBpZiAocGFyc2VIVE1MSW50ZWdlcih2YWx1ZSwgcGFyc2VkU3RhcnQpKQorICAgICAgICAg ICAgbV9zdGFydCA9IHBhcnNlZFN0YXJ0OworICAgICAgICBlbHNlCisgICAgICAgICAgICBtX3N0 YXJ0ID0gTnVsbG9wdDsKICAgICAgICAgaWYgKG9sZFN0YXJ0ID09IHN0YXJ0KCkpCiAgICAgICAg ICAgICByZXR1cm47CiAgICAgICAgIHVwZGF0ZUl0ZW1WYWx1ZXMoKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTE9MaXN0RWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MT0xpc3RFbGVtZW50LmgKaW5kZXggNjg5MmE4ZTc1YmM0NDI2MGU3YmUzZDIyYTNhMzYz NWM4YWRhY2U2Ni4uN2JjODY3NjUxNTUzYWFhODA3ZTgyMzg5ZGU2MDNjOTE1NmZiNWFlYSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MT0xpc3RFbGVtZW50LmgKKysrIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MT0xpc3RFbGVtZW50LmgKQEAgLTI0LDYgKzI0LDcgQEAKICNk ZWZpbmUgSFRNTE9MaXN0RWxlbWVudF9oCiAKICNpbmNsdWRlICJIVE1MRWxlbWVudC5oIgorI2lu Y2x1ZGUgPHd0Zi9PcHRpb25hbC5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKQEAgLTMyLDcg KzMzLDcgQEAgcHVibGljOgogICAgIHN0YXRpYyBSZWY8SFRNTE9MaXN0RWxlbWVudD4gY3JlYXRl KERvY3VtZW50Jik7CiAgICAgc3RhdGljIFJlZjxIVE1MT0xpc3RFbGVtZW50PiBjcmVhdGUoY29u c3QgUXVhbGlmaWVkTmFtZSYsIERvY3VtZW50Jik7CiAKLSAgICBpbnQgc3RhcnQoKSBjb25zdCB7 IHJldHVybiBtX2hhc0V4cGxpY2l0U3RhcnQgPyBtX3N0YXJ0IDogKG1faXNSZXZlcnNlZCA/IGl0 ZW1Db3VudCgpIDogMSk7IH0KKyAgICBpbnQgc3RhcnQoKSBjb25zdCB7IHJldHVybiBtX3N0YXJ0 ID8gbV9zdGFydC52YWx1ZSgpIDogKG1faXNSZXZlcnNlZCA/IGl0ZW1Db3VudCgpIDogMSk7IH0K ICAgICB2b2lkIHNldFN0YXJ0KGludCk7CiAKICAgICBib29sIGlzUmV2ZXJzZWQoKSBjb25zdCB7 IHJldHVybiBtX2lzUmV2ZXJzZWQ7IH0KQEAgLTU3LDEwICs1OCw5IEBAIHByaXZhdGU6CiAgICAg dmlydHVhbCBib29sIGlzUHJlc2VudGF0aW9uQXR0cmlidXRlKGNvbnN0IFF1YWxpZmllZE5hbWUm KSBjb25zdCBvdmVycmlkZTsKICAgICB2aXJ0dWFsIHZvaWQgY29sbGVjdFN0eWxlRm9yUHJlc2Vu dGF0aW9uQXR0cmlidXRlKGNvbnN0IFF1YWxpZmllZE5hbWUmLCBjb25zdCBBdG9taWNTdHJpbmcm LCBNdXRhYmxlU3R5bGVQcm9wZXJ0aWVzJikgb3ZlcnJpZGU7CiAKLSAgICBpbnQgbV9zdGFydDsK KyAgICBPcHRpb25hbDxpbnQ+IG1fc3RhcnQ7CiAgICAgdW5zaWduZWQgbV9pdGVtQ291bnQ7CiAK LSAgICBib29sIG1faGFzRXhwbGljaXRTdGFydCA6IDE7CiAgICAgYm9vbCBtX2lzUmV2ZXJzZWQg OiAxOwogICAgIGJvb2wgbV9zaG91bGRSZWNhbGN1bGF0ZUl0ZW1Db3VudCA6IDE7CiB9Owo= 272501 2016-02-29 10:39:52 -0800 2016-02-29 13:32:20 -0800 Patch bug-154824-20160229103936.patch text/plain 3237 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3MzU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmQ2OTk4N2IwZDEyMjJi NjE5MDFiNTI0NGNlMDg1YmVlNzM1Nzk0My4uOGU4NWQ5NjUyOTJjMTQ5NmIwNGViYzMzYTNhYjgx OWE5MDcxYjI3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE2LTAyLTI5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgVXNlIFdURjo6T3B0aW9uYWwg Zm9yIEhUTUxPTGlzdEVsZW1lbnQ6Om1fc3RhcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDgyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFVzZSBXVEY6Ok9wdGlvbmFsIGZvciBIVE1MT0xpc3RFbGVt ZW50OjptX3N0YXJ0LgorCisgICAgICAgICogaHRtbC9IVE1MT0xpc3RFbGVtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxPTGlzdEVsZW1lbnQ6OnBhcnNlQXR0cmlidXRlKToKKyAgICAg ICAgKiBodG1sL0hUTUxPTGlzdEVsZW1lbnQuaDoKKworMjAxNi0wMi0yOSAgQ2hyaXMgRHVtZXog IDxjZHVtZXpAYXBwbGUuY29tPgorCiAgICAgICAgIFVzZSBIVE1MIHBhcnNpbmcgcnVsZXMgZm9y IHRleHRhcmVhLm1heExlbmd0aAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTU0ODA1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TE9MaXN0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxPTGlzdEVsZW1lbnQu Y3BwCmluZGV4IDZjYjE5NzczMWNhYWZkYWNjOGMzOTQ2MjMwZTc5ZmEyODk4MDY4YjguLjRhY2M2 MTllOTJkOWM5NTc1N2Y3MGI3ZDRhZDY1NTc5MThkMDY1ODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTE9MaXN0RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MT0xpc3RFbGVtZW50LmNwcApAQCAtMzUsOSArMzUsNyBAQCB1c2luZyBuYW1lc3BhY2Ug SFRNTE5hbWVzOwogCiBIVE1MT0xpc3RFbGVtZW50OjpIVE1MT0xpc3RFbGVtZW50KGNvbnN0IFF1 YWxpZmllZE5hbWUmIHRhZ05hbWUsIERvY3VtZW50JiBkb2N1bWVudCkKICAgICA6IEhUTUxFbGVt ZW50KHRhZ05hbWUsIGRvY3VtZW50KQotICAgICwgbV9zdGFydCgweEJBREJFRUYpCiAgICAgLCBt X2l0ZW1Db3VudCgwKQotICAgICwgbV9oYXNFeHBsaWNpdFN0YXJ0KGZhbHNlKQogICAgICwgbV9p c1JldmVyc2VkKGZhbHNlKQogICAgICwgbV9zaG91bGRSZWNhbGN1bGF0ZUl0ZW1Db3VudChmYWxz ZSkKIHsKQEAgLTgyLDkgKzgwLDExIEBAIHZvaWQgSFRNTE9MaXN0RWxlbWVudDo6cGFyc2VBdHRy aWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSwgY29uc3QgQXRvbWljU3RyCiB7CiAgICAg aWYgKG5hbWUgPT0gc3RhcnRBdHRyKSB7CiAgICAgICAgIGludCBvbGRTdGFydCA9IHN0YXJ0KCk7 Ci0gICAgICAgIG1faGFzRXhwbGljaXRTdGFydCA9IHBhcnNlSFRNTEludGVnZXIodmFsdWUsIG1f c3RhcnQpOwotICAgICAgICBpZiAoIW1faGFzRXhwbGljaXRTdGFydCkKLSAgICAgICAgICAgIG1f c3RhcnQgPSAweEJBREJFRUY7CisgICAgICAgIGludCBwYXJzZWRTdGFydDsKKyAgICAgICAgaWYg KHBhcnNlSFRNTEludGVnZXIodmFsdWUsIHBhcnNlZFN0YXJ0KSkKKyAgICAgICAgICAgIG1fc3Rh cnQgPSBwYXJzZWRTdGFydDsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgbV9zdGFydCA9IE51 bGxvcHQ7CiAgICAgICAgIGlmIChvbGRTdGFydCA9PSBzdGFydCgpKQogICAgICAgICAgICAgcmV0 dXJuOwogICAgICAgICB1cGRhdGVJdGVtVmFsdWVzKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxPTGlzdEVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE9M aXN0RWxlbWVudC5oCmluZGV4IDY4OTJhOGU3NWJjNDQyNjBlN2JlM2QyMmEzYTM2MzVjOGFkYWNl NjYuLjdiYzg2NzY1MTU1M2FhYTgwN2U4MjM4OWRlNjAzYzkxNTZmYjVhZWEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE9MaXN0RWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE9MaXN0RWxlbWVudC5oCkBAIC0yNCw2ICsyNCw3IEBACiAjZGVmaW5lIEhU TUxPTGlzdEVsZW1lbnRfaAogCiAjaW5jbHVkZSAiSFRNTEVsZW1lbnQuaCIKKyNpbmNsdWRlIDx3 dGYvT3B0aW9uYWwuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC0zMiw3ICszMyw3IEBA IHB1YmxpYzoKICAgICBzdGF0aWMgUmVmPEhUTUxPTGlzdEVsZW1lbnQ+IGNyZWF0ZShEb2N1bWVu dCYpOwogICAgIHN0YXRpYyBSZWY8SFRNTE9MaXN0RWxlbWVudD4gY3JlYXRlKGNvbnN0IFF1YWxp ZmllZE5hbWUmLCBEb2N1bWVudCYpOwogCi0gICAgaW50IHN0YXJ0KCkgY29uc3QgeyByZXR1cm4g bV9oYXNFeHBsaWNpdFN0YXJ0ID8gbV9zdGFydCA6IChtX2lzUmV2ZXJzZWQgPyBpdGVtQ291bnQo KSA6IDEpOyB9CisgICAgaW50IHN0YXJ0KCkgY29uc3QgeyByZXR1cm4gbV9zdGFydCA/IG1fc3Rh cnQudmFsdWUoKSA6IChtX2lzUmV2ZXJzZWQgPyBpdGVtQ291bnQoKSA6IDEpOyB9CiAgICAgdm9p ZCBzZXRTdGFydChpbnQpOwogCiAgICAgYm9vbCBpc1JldmVyc2VkKCkgY29uc3QgeyByZXR1cm4g bV9pc1JldmVyc2VkOyB9CkBAIC01NywxMCArNTgsOSBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwg Ym9vbCBpc1ByZXNlbnRhdGlvbkF0dHJpYnV0ZShjb25zdCBRdWFsaWZpZWROYW1lJikgY29uc3Qg b3ZlcnJpZGU7CiAgICAgdmlydHVhbCB2b2lkIGNvbGxlY3RTdHlsZUZvclByZXNlbnRhdGlvbkF0 dHJpYnV0ZShjb25zdCBRdWFsaWZpZWROYW1lJiwgY29uc3QgQXRvbWljU3RyaW5nJiwgTXV0YWJs ZVN0eWxlUHJvcGVydGllcyYpIG92ZXJyaWRlOwogCi0gICAgaW50IG1fc3RhcnQ7CisgICAgT3B0 aW9uYWw8aW50PiBtX3N0YXJ0OwogICAgIHVuc2lnbmVkIG1faXRlbUNvdW50OwogCi0gICAgYm9v bCBtX2hhc0V4cGxpY2l0U3RhcnQgOiAxOwogICAgIGJvb2wgbV9pc1JldmVyc2VkIDogMTsKICAg ICBib29sIG1fc2hvdWxkUmVjYWxjdWxhdGVJdGVtQ291bnQgOiAxOwogfTsK