154794 2016-02-28 09:15:01 -0800 SVGToOTFFontConversion.cpp does not compile with libstdc++ 4.8 2016-02-28 12:12:04 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen webkit-unassigned commit-queue mcatanzaro mmaxfield ossy oldest_to_newest 1168995 0 annulen 2016-02-28 09:15:01 -0800 Error message produced by clang 3.7 (g++ 4.8 also produces error, but message is less readable): /usr/bin/../lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/stl_algo.h:2266:11: error: no matching function for call to object of type '(lambda at ../../../Source/WebCore/svg/SVGToOTFFontConversion.cpp:756:59)' while (__comp(__pivot, *__last)) ^~~~~~ ../../../Source/WebCore/svg/SVGToOTFFontConversion.cpp:756:59: note: candidate function not viable: 1st argument ('const std::pair<WTF::Vector<unsigned short, 3, WTF::CrashOnOverflow, 16>, unsigned short>') would lose const qualifier std::sort(ligaturePairs.begin(), ligaturePairs.end(), [](LigaturePair& lhs, LigaturePair& rhs) { ^ ../../../Source/WebCore/svg/SVGToOTFFontConversion.cpp:756:59: note: conversion candidate of type 'bool (*)(LigaturePair &, LigaturePair &)' 1168998 1 272457 annulen 2016-02-28 09:37:38 -0800 Created attachment 272457 Patch 1169012 2 272457 commit-queue 2016-02-28 12:11:59 -0800 Comment on attachment 272457 Patch Clearing flags on attachment: 272457 Committed r197298: <http://trac.webkit.org/changeset/197298> 1169013 3 commit-queue 2016-02-28 12:12:04 -0800 All reviewed patches have been landed. Closing bug. 272457 2016-02-28 09:37:38 -0800 2016-02-28 12:11:59 -0800 Patch bug-154794-20160228203721.patch text/plain 1638 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3MjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjZiZjQ1ODA1YzA0MzNl NDliNmUwNGJhM2JlNzY4MTdjNDlhY2E1Ni4uM2Q2MTY1MjljNjM5MTUyNWZhMGY0YTk0NTg3ZmEx NTg4MGQ2MDE3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAyLTI4ICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBTVkdUb09URkZv bnRDb252ZXJzaW9uLmNwcCBkb2VzIG5vdCBjb21waWxlIHdpdGggbGlic3RkYysrIDQuOAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0Nzk0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz IG5lZWRlZC4KKworICAgICAgICAqIHN2Zy9TVkdUb09URkZvbnRDb252ZXJzaW9uLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlNWR1RvT1RGRm9udENvbnZlcnRlcjo6YXBwZW5kTGlnYXR1cmVTdWJ0 YWJsZSk6IEFkZGVkIGNvbnN0CisgICAgICAgIHF1YWxpZmllcnMuCisKIDIwMTYtMDItMjcgIENo cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBQcmV2ZW50IGNyb3NzLW9y aWdpbiBhY2Nlc3MgdG8gTG9jYXRpb24uYXNzaWduKCkgLyBMb2NhdGlvbi5yZWxvYWQoKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1RvT1RGRm9udENvbnZlcnNpb24uY3BwIGIv U291cmNlL1dlYkNvcmUvc3ZnL1NWR1RvT1RGRm9udENvbnZlcnNpb24uY3BwCmluZGV4IDhjMTBi MTQ5MTAxMDIyZmE4ZTgxMGE2MTBiNmEwYTA1YTdkZjFlNmMuLjA2MjBlNzIzZTEwMTlmNThhMTAz NGE1NTdjZjc2NDNlZWJjYmFlYTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdU b09URkZvbnRDb252ZXJzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVG9PVEZG b250Q29udmVyc2lvbi5jcHAKQEAgLTc1Myw3ICs3NTMsNyBAQCB2b2lkIFNWR1RvT1RGRm9udENv bnZlcnRlcjo6YXBwZW5kTGlnYXR1cmVTdWJ0YWJsZShzaXplX3Qgc3VidGFibGVSZWNvcmRMb2Nh dGlvbgogICAgIH0KICAgICBpZiAobGlnYXR1cmVQYWlycy5zaXplKCkgPiBzdGQ6Om51bWVyaWNf bGltaXRzPHVpbnQxNl90Pjo6bWF4KCkpCiAgICAgICAgIGxpZ2F0dXJlUGFpcnMuY2xlYXIoKTsK LSAgICBzdGQ6OnNvcnQobGlnYXR1cmVQYWlycy5iZWdpbigpLCBsaWdhdHVyZVBhaXJzLmVuZCgp LCBbXShMaWdhdHVyZVBhaXImIGxocywgTGlnYXR1cmVQYWlyJiByaHMpIHsKKyAgICBzdGQ6OnNv cnQobGlnYXR1cmVQYWlycy5iZWdpbigpLCBsaWdhdHVyZVBhaXJzLmVuZCgpLCBbXShjb25zdCBM aWdhdHVyZVBhaXImIGxocywgY29uc3QgTGlnYXR1cmVQYWlyJiByaHMpIHsKICAgICAgICAgcmV0 dXJuIGxocy5maXJzdFswXSA8IHJocy5maXJzdFswXTsKICAgICB9KTsKICAgICBWZWN0b3I8c2l6 ZV90PiBvdmVybGFwcGluZ0ZpcnN0R2x5cGhTZWdtZW50TGVuZ3RoczsK