15479 2007-10-12 13:13:29 -0700 SVGStyledElement::resolveStyle(RenderStyle*) must be removed/fixed! 2011-05-12 11:34:40 -0700 1 1 1 Unclassified WebKit SVG 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned commit-queue rwlbuis oldest_to_newest 58378 0 eric 2007-10-12 13:13:29 -0700 SVGStyledElement::resolveStyle(RenderStyle*) must be removed! It shouldn't be necessary now that we have (and use) RenderSVGHiddenContainer (to hold style across things like <defs>). If a filter element doesn't otherwise have style in those cases than it probably isn't "valid" SVG and shouldn't be rendered. It is *possible* that this method may need to exist (to force a manual style resolve for a display:none SVG tree or the like) but in that case it needs to be improved (to walk the whole parent chain instead of the current only check the parent). 402992 1 93312 rwlbuis 2011-05-12 11:21:50 -0700 Created attachment 93312 Remove resolveStyle 403019 2 rwlbuis 2011-05-12 11:34:40 -0700 Committed r86365: <http://trac.webkit.org/changeset/86365> 93312 2011-05-12 11:21:50 -0700 2011-05-12 11:28:13 -0700 Remove resolveStyle resolvestyle.diff text/plain 2086 rwlbuis SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg2MzU5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDUtMTIgIFJvYiBCdWlz ICA8cmJ1aXNAcmltLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBTVkdTdHlsZWRFbGVtZW50OjpyZXNvbHZlU3R5bGUoUmVuZGVyU3R5bGUqKSBt dXN0IGJlIHJlbW92ZWQvZml4ZWQhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTQ3OQorCisgICAgICAgIEZpbmFsbHkgcmVtb3ZlIHJlc29sdmVTdHls ZSwgaXQgaXMgbm90IHVzZWQgYW55bW9yZS4KKworICAgICAgICAqIHN2Zy9TVkdTdHlsZWRFbGVt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR1N0eWxlZEVsZW1lbnQ6OmNoaWxkcmVuQ2hh bmdlZCk6CisgICAgICAgICogc3ZnL1NWR1N0eWxlZEVsZW1lbnQuaDoKKwogMjAxMS0wNS0xMiAg TGV2aSBXZWludHJhdWIgIDxsZXZpd0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgU2ltb24gRnJhc2VyLgpJbmRleDogU291cmNlL1dlYkNvcmUvc3ZnL1NWR1N0eWxlZEVsZW1l bnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZHU3R5bGVkRWxlbWVudC5o CShyZXZpc2lvbiA4NjM1MykKKysrIFNvdXJjZS9XZWJDb3JlL3N2Zy9TVkdTdHlsZWRFbGVtZW50 LmgJKHdvcmtpbmcgY29weSkKQEAgLTQ2LDkgKzQ2LDYgQEAKIAogICAgIGJvb2wgaXNLbm93bkF0 dHJpYnV0ZShjb25zdCBRdWFsaWZpZWROYW1lJik7CiAKLSAgICAvLyBDZW50cmFsaXplZCBwbGFj ZSB0byBmb3JjZSBhIG1hbnVhbCBzdHlsZSByZXNvbHV0aW9uLiBIYWNreSBidXQgbmVlZGVkIGZv ciBub3cuCi0gICAgUGFzc1JlZlB0cjxSZW5kZXJTdHlsZT4gcmVzb2x2ZVN0eWxlKFJlbmRlclN0 eWxlKiBwYXJlbnRTdHlsZSk7Ci0KICAgICBib29sIGluc3RhbmNlVXBkYXRlc0Jsb2NrZWQoKSBj b25zdDsKICAgICB2b2lkIHNldEluc3RhbmNlVXBkYXRlc0Jsb2NrZWQoYm9vbCk7CiAKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3N2Zy9TVkdTdHlsZWRFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9zdmcvU1ZHU3R5bGVkRWxlbWVudC5jcHAJKHJldmlzaW9uIDg2MzUzKQor KysgU291cmNlL1dlYkNvcmUvc3ZnL1NWR1N0eWxlZEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yNSw3ICsyNSw2IEBACiAKICNpbmNsdWRlICJBdHRyLmgiCiAjaW5jbHVkZSAiQ1NTUGFy c2VyLmgiCi0jaW5jbHVkZSAiQ1NTU3R5bGVTZWxlY3Rvci5oIgogI2luY2x1ZGUgIkRvY3VtZW50 LmgiCiAjaW5jbHVkZSAiSFRNTE5hbWVzLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1TdHJpbmcuaCIK QEAgLTQwNSwxMyArNDA0LDYgQEAKICAgICAgICAgU1ZHRWxlbWVudEluc3RhbmNlOjppbnZhbGlk YXRlQWxsSW5zdGFuY2VzT2ZFbGVtZW50KHRoaXMpOwogfQogCi1QYXNzUmVmUHRyPFJlbmRlclN0 eWxlPiBTVkdTdHlsZWRFbGVtZW50OjpyZXNvbHZlU3R5bGUoUmVuZGVyU3R5bGUqIHBhcmVudFN0 eWxlKQotewotICAgIGlmIChyZW5kZXJlcigpKQotICAgICAgICByZXR1cm4gcmVuZGVyZXIoKS0+ c3R5bGUoKTsKLSAgICByZXR1cm4gZG9jdW1lbnQoKS0+c3R5bGVTZWxlY3RvcigpLT5zdHlsZUZv ckVsZW1lbnQodGhpcywgcGFyZW50U3R5bGUpOwotfQotCiBQYXNzUmVmUHRyPENTU1ZhbHVlPiBT VkdTdHlsZWRFbGVtZW50OjpnZXRQcmVzZW50YXRpb25BdHRyaWJ1dGUoY29uc3QgU3RyaW5nJiBu YW1lKQogewogICAgIGlmICghYXR0cmlidXRlTWFwKCkpCg==