154751 2016-02-26 14:03:25 -0800 Reduce direct callers of Structure::findStructuresAndMapForMaterialization 2016-02-26 14:58:53 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1168670 0 joepeck 2016-02-26 14:03:25 -0800 * SUMMARY Reduce direct callers of Structure::findStructuresAndMapForMaterialization. Structure::findStructuresAndMapForMaterialization has a very subtle locking contract. Most places that use it, simply want to iterate over all of the properties of the structure. For that, we can use Structure::forEachPropertyConcurrently. Here the code was identical, so just share the code. 1168674 1 272368 joepeck 2016-02-26 14:04:47 -0800 Created attachment 272368 [PATCH] Proposed Fix 1168677 2 272368 mark.lam 2016-02-26 14:10:15 -0800 Comment on attachment 272368 [PATCH] Proposed Fix r=me 1168706 3 272368 commit-queue 2016-02-26 14:58:48 -0800 Comment on attachment 272368 [PATCH] Proposed Fix Clearing flags on attachment: 272368 Committed r197210: <http://trac.webkit.org/changeset/197210> 1168707 4 commit-queue 2016-02-26 14:58:53 -0800 All reviewed patches have been landed. Closing bug. 272368 2016-02-26 14:04:47 -0800 2016-02-26 14:58:48 -0800 [PATCH] Proposed Fix proposed-fix.patch text/plain 2325 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDE0OGM2ZDguLjYwOTM0MzQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTAyLTI2ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgUmVkdWNlIGRpcmVjdCBjYWxsZXJz IG9mIFN0cnVjdHVyZTo6ZmluZFN0cnVjdHVyZXNBbmRNYXBGb3JNYXRlcmlhbGl6YXRpb24KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDc1MQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcnVudGltZS9T dHJ1Y3R1cmUuY3BwOgorICAgICAgICAoSlNDOjpTdHJ1Y3R1cmU6OnRvU3RydWN0dXJlU2hhcGUp OgorICAgICAgICBUaGlzIHByb3BlcnR5IG5hbWUgaXRlcmF0aW9uIGlzIGlkZW50aWNhbCB0byBT dHJ1Y3R1cmU6OmZvckVhY2hQcm9wZXJ0eUNvbmN1cnJlbnRseS4KKyAgICAgICAgU2hhcmUgdGhl IGNvZGUgYW5kIHJlZHVjZSBjYWxsZXJzIHRvIHRoZSBzdWJ0bGUgZmluZFN0cnVjdHVyZXNBbmRN YXBGb3JNYXRlcmlhbGl6YXRpb24uCisKIDIwMTYtMDItMTkgIEpvc2VwaCBQZWNvcmFybyAgPHBl Y29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBDb2RlQmxvY2sgYWx3YXlzIHZpc2l0cyBpdHMg dW5saW5rZWQgY29kZSB0d2ljZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvU3RydWN0dXJlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVj dHVyZS5jcHAKaW5kZXggNDk3YmNjYi4uY2MxNjE2NyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9TdHJ1Y3R1cmUuY3BwCkBAIC0xMTU1LDI0ICsxMTU1LDExIEBAIFBhc3NSZWZQ dHI8U3RydWN0dXJlU2hhcGU+IFN0cnVjdHVyZTo6dG9TdHJ1Y3R1cmVTaGFwZShKU1ZhbHVlIHZh bHVlKQogICAgIFN0cnVjdHVyZSogY3VyU3RydWN0dXJlID0gdGhpczsKICAgICBKU1ZhbHVlIGN1 clZhbHVlID0gdmFsdWU7CiAgICAgd2hpbGUgKGN1clN0cnVjdHVyZSkgewotICAgICAgICBWZWN0 b3I8U3RydWN0dXJlKiwgOD4gc3RydWN0dXJlczsKLSAgICAgICAgU3RydWN0dXJlKiBzdHJ1Y3R1 cmU7Ci0gICAgICAgIFByb3BlcnR5VGFibGUqIHRhYmxlOwotCi0gICAgICAgIGN1clN0cnVjdHVy ZS0+ZmluZFN0cnVjdHVyZXNBbmRNYXBGb3JNYXRlcmlhbGl6YXRpb24oc3RydWN0dXJlcywgc3Ry dWN0dXJlLCB0YWJsZSk7Ci0gICAgICAgIGlmICh0YWJsZSkgewotICAgICAgICAgICAgUHJvcGVy dHlUYWJsZTo6aXRlcmF0b3IgaXRlciA9IHRhYmxlLT5iZWdpbigpOwotICAgICAgICAgICAgUHJv cGVydHlUYWJsZTo6aXRlcmF0b3IgZW5kID0gdGFibGUtPmVuZCgpOwotICAgICAgICAgICAgZm9y ICg7IGl0ZXIgIT0gZW5kOyArK2l0ZXIpCi0gICAgICAgICAgICAgICAgY3VyU2hhcGUtPmFkZFBy b3BlcnR5KCppdGVyLT5rZXkpOwotICAgICAgICAgICAgCi0gICAgICAgICAgICBzdHJ1Y3R1cmUt Pm1fbG9jay51bmxvY2soKTsKLSAgICAgICAgfQotICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSBz dHJ1Y3R1cmVzLnNpemUoKTsgaS0tOykgewotICAgICAgICAgICAgU3RydWN0dXJlKiBzdHJ1Y3R1 cmUgPSBzdHJ1Y3R1cmVzW2ldOwotICAgICAgICAgICAgaWYgKHN0cnVjdHVyZS0+bV9uYW1lSW5Q cmV2aW91cykKLSAgICAgICAgICAgICAgICBjdXJTaGFwZS0+YWRkUHJvcGVydHkoKnN0cnVjdHVy ZS0+bV9uYW1lSW5QcmV2aW91cyk7Ci0gICAgICAgIH0KKyAgICAgICAgY3VyU3RydWN0dXJlLT5m b3JFYWNoUHJvcGVydHlDb25jdXJyZW50bHkoCisgICAgICAgICAgICBbJl0gKGNvbnN0IFByb3Bl cnR5TWFwRW50cnkmIGVudHJ5KSAtPiBib29sIHsKKyAgICAgICAgICAgICAgICBjdXJTaGFwZS0+ YWRkUHJvcGVydHkoKmVudHJ5LmtleSk7CisgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7Cisg ICAgICAgICAgICB9KTsKIAogICAgICAgICBpZiAoSlNPYmplY3QqIGN1ck9iamVjdCA9IGN1clZh bHVlLmdldE9iamVjdCgpKQogICAgICAgICAgICAgY3VyU2hhcGUtPnNldENvbnN0cnVjdG9yTmFt ZShKU09iamVjdDo6Y2FsY3VsYXRlZENsYXNzTmFtZShjdXJPYmplY3QpKTsK