154748 2016-02-26 13:47:35 -0800 storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange.html flaky on mac-wk2 2016-03-21 15:57:58 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 149117 154968 1 ryanhaddad beidson achristensen alecflett ap beidson commit-queue jsbell oldest_to_newest 1168662 0 ryanhaddad 2016-02-26 13:47:35 -0800 storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange.html flaky on mac-wk2 Most recent failure: <https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK2%20(Tests)/r197193%20(12346)/results.html> Flakiness dashboard: <https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Findexeddb%2Fdeletedatabase-delayed-by-open-and-versionchange.html> --- /Volumes/Data/slave/yosemite-release-tests-wk2/build/layout-test-results/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt +++ /Volumes/Data/slave/yosemite-release-tests-wk2/build/layout-test-results/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-actual.txt @@ -22,7 +22,7 @@ versionChangeComplete = true onOpenSuccess(): -PASS blockedCalled is true +FAIL blockedCalled should be true. Threw exception ReferenceError: Can't find variable: blockedCalled h = event.target.result h.close() 1168686 1 beidson 2016-02-26 14:16:12 -0800 (In reply to comment #0) > onOpenSuccess(): > -PASS blockedCalled is true > +FAIL blockedCalled should be true. Threw exception ReferenceError: Can't > find variable: blockedCalled > h = event.target.result > h.close() That is... just nuts. 1169323 2 ryanhaddad 2016-02-29 17:16:55 -0800 Marked this test as flaky in <http://trac.webkit.org/projects/webkit/changeset/197377> 1170262 3 beidson 2016-03-03 10:24:08 -0800 Ahhh. Okay, understood. This is just a timing problem in the test. In WK2, due to IPC variability, it *is* actually possible for the open + versionChange request to complete before the deleteRequest is even serviced, so it never gets blocked. We could change the test to extend the versionChange transaction until *after* blockedCalled is true, which will make it predictable. 1176869 4 274628 beidson 2016-03-21 15:39:01 -0700 Created attachment 274628 Patch v1 1176870 5 beidson 2016-03-21 15:57:58 -0700 http://trac.webkit.org/changeset/198504 274628 2016-03-21 15:39:01 -0700 2016-03-21 15:41:34 -0700 Patch v1 patch text/plain 3984 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmZWY5ZDJlLi44OGQ4NDQ5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTYtMDMt MjEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIHN0b3JhZ2Uv aW5kZXhlZGRiL2RlbGV0ZWRhdGFiYXNlLWRlbGF5ZWQtYnktb3Blbi1hbmQtdmVyc2lvbmNoYW5n ZS5odG1sIGZsYWt5IG9uIG1hYy13azIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTQ3NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOgorICAgICAg ICAqIHN0b3JhZ2UvaW5kZXhlZGRiL2RlbGV0ZWRhdGFiYXNlLWRlbGF5ZWQtYnktb3Blbi1hbmQt dmVyc2lvbmNoYW5nZS1leHBlY3RlZC50eHQ6CisgICAgICAgICogc3RvcmFnZS9pbmRleGVkZGIv ZGVsZXRlZGF0YWJhc2UtZGVsYXllZC1ieS1vcGVuLWFuZC12ZXJzaW9uY2hhbmdlLXByaXZhdGUt ZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9kZWxl dGVkYXRhYmFzZS1kZWxheWVkLWJ5LW9wZW4tYW5kLXZlcnNpb25jaGFuZ2UuanM6CisKIDIwMTYt MDItMDMgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAg ICAgW2Nzcy1ncmlkXSBGaXggcGVyY2VudGFnZSB0cmFja3MnIHNpemUgY29tcHV0YXRpb24gaW4g Z3JpZHMgd2l0aCBndXR0ZXJzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMv VGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRp b25zCmluZGV4IGMyYTAzMjAuLmFlMTFiOTggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9U ZXN0RXhwZWN0YXRpb25zCkBAIC0xMzI1LDggKzEzMjUsNiBAQCB3ZWJraXQub3JnL2IvMTU0NzUz IGpzL2Jhc2ljLW1hcC5odG1sIFsgU2tpcCBdCiBhY2Nlc3NpYmlsaXR5L21hYy9zZWxlY3Rpb24t ZWxlbWVudC10YWJiaW5nLXRvLWxpbmsuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiBhY2Nlc3NpYmls aXR5L21hYy9zZWxlY3Rpb24tbm90aWZpY2F0aW9uLWZvY3VzLWNoYW5nZS5odG1sIFsgUGFzcyBG YWlsdXJlIF0KIAotd2Via2l0Lm9yZy9iLzE1NDc0OCBzdG9yYWdlL2luZGV4ZWRkYi9kZWxldGVk YXRhYmFzZS1kZWxheWVkLWJ5LW9wZW4tYW5kLXZlcnNpb25jaGFuZ2UuaHRtbCBbIFBhc3MgRmFp bHVyZSBdCi0KIHdlYmtpdC5vcmcvYi8xNTI1MDYgd2ViZ2wvMS4wLjIvY29uZm9ybWFuY2UvZXh0 ZW5zaW9ucy9nZXQtZXh0ZW5zaW9uLmh0bWwgWyBQYXNzIFRpbWVvdXQgXQogCiB3ZWJraXQub3Jn L2IvMTU0NzA5IFsgRWxDYXBpdGFuKyBdIGZhc3QvdGV4dC9jcmFzaC1jb21wbGV4LXRleHQtc3Vy cm9nYXRlLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3Rv cmFnZS9pbmRleGVkZGIvZGVsZXRlZGF0YWJhc2UtZGVsYXllZC1ieS1vcGVuLWFuZC12ZXJzaW9u Y2hhbmdlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2RlbGV0 ZWRhdGFiYXNlLWRlbGF5ZWQtYnktb3Blbi1hbmQtdmVyc2lvbmNoYW5nZS1leHBlY3RlZC50eHQK aW5kZXggNGU2OWQxNC4uYTBhNTg0YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9p bmRleGVkZGIvZGVsZXRlZGF0YWJhc2UtZGVsYXllZC1ieS1vcGVuLWFuZC12ZXJzaW9uY2hhbmdl LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9kZWxldGVk YXRhYmFzZS1kZWxheWVkLWJ5LW9wZW4tYW5kLXZlcnNpb25jaGFuZ2UtZXhwZWN0ZWQudHh0CkBA IC0xMSw2ICsxMSw4IEBAIGluZGV4ZWREQi5vcGVuKGRibmFtZSkKIHByZXBhcmVEYXRhYmFzZSgp OgogdmVyc2lvbkNoYW5nZUNvbXBsZXRlID0gZmFsc2UKIGggPSBldmVudC50YXJnZXQucmVzdWx0 CitibG9ja2VkQ2FsbGVkID0gZmFsc2UKK2guY3JlYXRlT2JqZWN0U3RvcmUoJ3Rlc3RPYmplY3RT dG9yZScpLnB1dCgnYmFyJywgJ2ZvbycpCiBpbmRleGVkREIuZGVsZXRlRGF0YWJhc2UoZGJuYW1l KQogCiBvblZlcnNpb25DaGFuZ2UoKToKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0b3JhZ2Uv aW5kZXhlZGRiL2RlbGV0ZWRhdGFiYXNlLWRlbGF5ZWQtYnktb3Blbi1hbmQtdmVyc2lvbmNoYW5n ZS1wcml2YXRlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2Rl bGV0ZWRhdGFiYXNlLWRlbGF5ZWQtYnktb3Blbi1hbmQtdmVyc2lvbmNoYW5nZS1wcml2YXRlLWV4 cGVjdGVkLnR4dAppbmRleCA0ZTY5ZDE0Li5hMGE1ODRiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9zdG9yYWdlL2luZGV4ZWRkYi9kZWxldGVkYXRhYmFzZS1kZWxheWVkLWJ5LW9wZW4tYW5kLXZl cnNpb25jaGFuZ2UtcHJpdmF0ZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvc3RvcmFn ZS9pbmRleGVkZGIvZGVsZXRlZGF0YWJhc2UtZGVsYXllZC1ieS1vcGVuLWFuZC12ZXJzaW9uY2hh bmdlLXByaXZhdGUtZXhwZWN0ZWQudHh0CkBAIC0xMSw2ICsxMSw4IEBAIGluZGV4ZWREQi5vcGVu KGRibmFtZSkKIHByZXBhcmVEYXRhYmFzZSgpOgogdmVyc2lvbkNoYW5nZUNvbXBsZXRlID0gZmFs c2UKIGggPSBldmVudC50YXJnZXQucmVzdWx0CitibG9ja2VkQ2FsbGVkID0gZmFsc2UKK2guY3Jl YXRlT2JqZWN0U3RvcmUoJ3Rlc3RPYmplY3RTdG9yZScpLnB1dCgnYmFyJywgJ2ZvbycpCiBpbmRl eGVkREIuZGVsZXRlRGF0YWJhc2UoZGJuYW1lKQogCiBvblZlcnNpb25DaGFuZ2UoKToKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9kZWxldGVkYXRh YmFzZS1kZWxheWVkLWJ5LW9wZW4tYW5kLXZlcnNpb25jaGFuZ2UuanMgYi9MYXlvdXRUZXN0cy9z dG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMvZGVsZXRlZGF0YWJhc2UtZGVsYXllZC1ieS1vcGVu LWFuZC12ZXJzaW9uY2hhbmdlLmpzCmluZGV4IGJlYWVjZTguLmVlNzliZWQgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9kZWxldGVkYXRhYmFzZS1k ZWxheWVkLWJ5LW9wZW4tYW5kLXZlcnNpb25jaGFuZ2UuanMKKysrIGIvTGF5b3V0VGVzdHMvc3Rv cmFnZS9pbmRleGVkZGIvcmVzb3VyY2VzL2RlbGV0ZWRhdGFiYXNlLWRlbGF5ZWQtYnktb3Blbi1h bmQtdmVyc2lvbmNoYW5nZS5qcwpAQCAtMTIsNyArMTIsMTEgQEAgZnVuY3Rpb24gcHJlcGFyZURh dGFiYXNlKGV2dCkKICAgICBwcmVhbWJsZShldnQpOwogICAgIGV2YWxBbmRMb2coInZlcnNpb25D aGFuZ2VDb21wbGV0ZSA9IGZhbHNlIik7CiAgICAgZXZhbEFuZExvZygiaCA9IGV2ZW50LnRhcmdl dC5yZXN1bHQiKTsKKyAgICBldmFsQW5kTG9nKCJibG9ja2VkQ2FsbGVkID0gZmFsc2UiKTsKIAor ICAgIC8vIE1ha2UgdGhpcyB1cGdyYWRlIHRyYW5zYWN0aW9uIHRha2UgbG9uZ2VyIHNvIHRoZSBk ZWxldGVEYXRhYmFzZSByZXF1ZXN0IHdpbGwgYWx3YXlzIGhhdmUgYSBjaGFuY2UgdG8gYmUgYmxv Y2tlZC4KKyAgICBldmFsQW5kTG9nKCJoLmNyZWF0ZU9iamVjdFN0b3JlKCd0ZXN0T2JqZWN0U3Rv cmUnKS5wdXQoJ2JhcicsICdmb28nKSIpOworICAgICAgICAKICAgICBoLm9udmVyc2lvbmNoYW5n ZSA9IGZ1bmN0aW9uIG9uVmVyc2lvbkNoYW5nZShldnQpIHsKICAgICAgICAgcHJlYW1ibGUoZXZ0 KTsKICAgICAgICAgc2hvdWxkQmUoImV2ZW50LnRhcmdldC52ZXJzaW9uIiwgIjEiKTsK