154747 2016-02-26 13:39:54 -0800 storage/indexeddb/delete-in-upgradeneeded-close-in-open-success.html flaky on mac-wk2 2016-03-03 11:46:20 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Mac Unspecified RESOLVED FIXED P2 Normal --- 149117 154968 1 ryanhaddad beidson achristensen alecflett beidson commit-queue jsbell oldest_to_newest 1168658 0 ryanhaddad 2016-02-26 13:39:54 -0800 storage/indexeddb/delete-in-upgradeneeded-close-in-open-success.html flaky on mac-wk2 Most recent failure: <https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r197191%20(3257)/results.html> Flakiness dashboard: <https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=storage%2Findexeddb%2Fdelete-in-upgradeneeded-close-in-open-success.html> --- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt +++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-actual.txt @@ -24,15 +24,15 @@ PASS event.newVersion is null sawVersionChange = true -deleteBlockedCallback(): -PASS sawVersionChange is true -sawDeleteBlocked = true - openSuccess(): PASS sawUpgradeNeeded is true db = event.target.result PASS db.version is 1 db.close() + +deleteBlockedCallback(): +PASS sawVersionChange is true +sawDeleteBlocked = true deleteSuccessCallback(): PASS sawVersionChange is true 1170246 1 beidson 2016-03-03 09:53:38 -0800 This callback coming out of order like this is okay. Makes sense that it's WK2-only, since WK1 has a much more well defined order with the thread-hopping versus process hopping. Easy fix to the test to make it determinate. 1170247 2 272760 beidson 2016-03-03 09:58:11 -0800 Created attachment 272760 Patch v1 1170297 3 272760 commit-queue 2016-03-03 11:46:16 -0800 Comment on attachment 272760 Patch v1 Clearing flags on attachment: 272760 Committed r197513: <http://trac.webkit.org/changeset/197513> 1170298 4 commit-queue 2016-03-03 11:46:20 -0800 All reviewed patches have been landed. Closing bug. 272760 2016-03-03 09:58:11 -0800 2016-03-03 11:46:16 -0800 Patch v1 patch text/plain 3270 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4Njc4Y2VkLi5kM2EzNzZiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTYtMDMt MDMgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIHN0b3JhZ2Uv aW5kZXhlZGRiL2RlbGV0ZS1pbi11cGdyYWRlbmVlZGVkLWNsb3NlLWluLW9wZW4tc3VjY2Vzcy5o dG1sIGZsYWt5IG9uIG1hYy13azIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTQ3NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKyAgICAgICAgCisgICAgICAgIFRoaXMgY2FsbGJhY2sgY29taW5nIG91dCBvZiBvcmRlciBs aWtlIHRoaXMgaXMgb2theSwgc28gdGhlIHRlc3Qgc2hvdWxkIGp1c3QgYWxsb3cgaXQuCisKKyAg ICAgICAgSXQgbWFrZXMgc2Vuc2UgdGhhdCB0aGUgZmxha2UgaXMgV0syLW9ubHksIHNpbmNlIFdL MSBoYXMgYSBtdWNoIG1vcmUgd2VsbCBkZWZpbmVkIG9yZGVyIAorICAgICAgICB3aXRoIHRocmVh ZC1ob3BwaW5nIHZlcnN1cyBwcm9jZXNzLWhvcHBpbmcuCisKKyAgICAgICAgKiBzdG9yYWdlL2lu ZGV4ZWRkYi9kZWxldGUtaW4tdXBncmFkZW5lZWRlZC1jbG9zZS1pbi1vcGVuLXN1Y2Nlc3MtZXhw ZWN0ZWQudHh0OgorICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL2RlbGV0ZS1pbi11cGdyYWRl bmVlZGVkLWNsb3NlLWluLW9wZW4tc3VjY2Vzcy1wcml2YXRlLWV4cGVjdGVkLnR4dDoKKyAgICAg ICAgKiBzdG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMvZGVsZXRlLWluLXVwZ3JhZGVuZWVkZWQt Y2xvc2UtaW4tb3Blbi1zdWNjZXNzLmpzOgorCiAyMDE2LTAzLTAzICBKYXZpZXIgRmVybmFuZGV6 ICA8amZlcm5hbmRlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtDU1MgQm94IEFsaWdubWVudF0g TmV3IENTUyBWYWx1ZSAnbm9ybWFsJyBmb3IgQ29udGVudCBBbGlnbm1lbnQKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2RlbGV0ZS1pbi11cGdyYWRlbmVlZGVkLWNs b3NlLWluLW9wZW4tc3VjY2Vzcy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2lu ZGV4ZWRkYi9kZWxldGUtaW4tdXBncmFkZW5lZWRlZC1jbG9zZS1pbi1vcGVuLXN1Y2Nlc3MtZXhw ZWN0ZWQudHh0CmluZGV4IGY3OGQ3NTUuLjhiODYwNWUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L3N0b3JhZ2UvaW5kZXhlZGRiL2RlbGV0ZS1pbi11cGdyYWRlbmVlZGVkLWNsb3NlLWluLW9wZW4t c3VjY2Vzcy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIv ZGVsZXRlLWluLXVwZ3JhZGVuZWVkZWQtY2xvc2UtaW4tb3Blbi1zdWNjZXNzLWV4cGVjdGVkLnR4 dApAQCAtMjQsMTAgKzI0LDYgQEAgUEFTUyBldmVudC5vbGRWZXJzaW9uIGlzIDEKIFBBU1MgZXZl bnQubmV3VmVyc2lvbiBpcyBudWxsCiBzYXdWZXJzaW9uQ2hhbmdlID0gdHJ1ZQogCi1kZWxldGVC bG9ja2VkQ2FsbGJhY2soKToKLVBBU1Mgc2F3VmVyc2lvbkNoYW5nZSBpcyB0cnVlCi1zYXdEZWxl dGVCbG9ja2VkID0gdHJ1ZQotCiBvcGVuU3VjY2VzcygpOgogUEFTUyBzYXdVcGdyYWRlTmVlZGVk IGlzIHRydWUKIGRiID0gZXZlbnQudGFyZ2V0LnJlc3VsdApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvc3RvcmFnZS9pbmRleGVkZGIvZGVsZXRlLWluLXVwZ3JhZGVuZWVkZWQtY2xvc2UtaW4tb3Bl bi1zdWNjZXNzLXByaXZhdGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRl eGVkZGIvZGVsZXRlLWluLXVwZ3JhZGVuZWVkZWQtY2xvc2UtaW4tb3Blbi1zdWNjZXNzLXByaXZh dGUtZXhwZWN0ZWQudHh0CmluZGV4IGY3OGQ3NTUuLjhiODYwNWUgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2RlbGV0ZS1pbi11cGdyYWRlbmVlZGVkLWNsb3NlLWlu LW9wZW4tc3VjY2Vzcy1wcml2YXRlLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9zdG9y YWdlL2luZGV4ZWRkYi9kZWxldGUtaW4tdXBncmFkZW5lZWRlZC1jbG9zZS1pbi1vcGVuLXN1Y2Nl c3MtcHJpdmF0ZS1leHBlY3RlZC50eHQKQEAgLTI0LDEwICsyNCw2IEBAIFBBU1MgZXZlbnQub2xk VmVyc2lvbiBpcyAxCiBQQVNTIGV2ZW50Lm5ld1ZlcnNpb24gaXMgbnVsbAogc2F3VmVyc2lvbkNo YW5nZSA9IHRydWUKIAotZGVsZXRlQmxvY2tlZENhbGxiYWNrKCk6Ci1QQVNTIHNhd1ZlcnNpb25D aGFuZ2UgaXMgdHJ1ZQotc2F3RGVsZXRlQmxvY2tlZCA9IHRydWUKLQogb3BlblN1Y2Nlc3MoKToK IFBBU1Mgc2F3VXBncmFkZU5lZWRlZCBpcyB0cnVlCiBkYiA9IGV2ZW50LnRhcmdldC5yZXN1bHQK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9kZWxl dGUtaW4tdXBncmFkZW5lZWRlZC1jbG9zZS1pbi1vcGVuLXN1Y2Nlc3MuanMgYi9MYXlvdXRUZXN0 cy9zdG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMvZGVsZXRlLWluLXVwZ3JhZGVuZWVkZWQtY2xv c2UtaW4tb3Blbi1zdWNjZXNzLmpzCmluZGV4IDQwNjExNWYuLjYyYWNmNzYgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9kZWxldGUtaW4tdXBncmFk ZW5lZWRlZC1jbG9zZS1pbi1vcGVuLXN1Y2Nlc3MuanMKKysrIGIvTGF5b3V0VGVzdHMvc3RvcmFn ZS9pbmRleGVkZGIvcmVzb3VyY2VzL2RlbGV0ZS1pbi11cGdyYWRlbmVlZGVkLWNsb3NlLWluLW9w ZW4tc3VjY2Vzcy5qcwpAQCAtNjIsOSArNjIsOSBAQCBmdW5jdGlvbiB2ZXJzaW9uQ2hhbmdlQ2Fs bGJhY2soZXZ0KQogCiBmdW5jdGlvbiBkZWxldGVCbG9ja2VkQ2FsbGJhY2soZXZ0KQogewotICAg IHByZWFtYmxlKGV2dCk7Ci0gICAgc2hvdWxkQmVUcnVlKCJzYXdWZXJzaW9uQ2hhbmdlIik7Ci0g ICAgZXZhbEFuZExvZygic2F3RGVsZXRlQmxvY2tlZCA9IHRydWUiKTsKKyAgICBpZiAoIXNhd1Zl cnNpb25DaGFuZ2UpCisgICAgICAgIGRlYnVnKCJkZWxldGVCbG9ja2VkQ2FsbGJhY2sgd2FzIGNh bGxlZCAqYmVmb3JlKiB2ZXJzaW9uQ2hhbmdlQ2FsbGJhY2ssIHdoaWNoIGlzIHdyb25nIik7Cisg ICAgZXZhbCgic2F3RGVsZXRlQmxvY2tlZCA9IHRydWUiKTsKIH0KIAogZnVuY3Rpb24gZGVsZXRl U3VjY2Vzc0NhbGxiYWNrKGV2dCkK