154745 2016-02-26 13:28:23 -0800 Add Proxy tests for exceptions that depend on an object being non-extensible and having configurable properties 2019-06-10 20:07:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 saam saam ashvayka benjamin fpizlo ggaren gskachkov keith_miller mark.lam msaboff oliver sukolsak ysuzuki oldest_to_newest 1168654 0 saam 2016-02-26 13:28:23 -0800 I missed writing some of these tests because I didn't realize you could easily make an object get into this state. But it's super easy. Object.preventExtensions puts an object into this state. 1170510 1 fpizlo 2016-03-03 21:20:56 -0800 This is referenced from this commit: http://trac.webkit.org/changeset/197539. That suggests that maybe that commit should have referenced a different bug? 1170534 2 saam 2016-03-03 23:15:50 -0800 (In reply to comment #1) > This is referenced from this commit: http://trac.webkit.org/changeset/197539. > > That suggests that maybe that commit should have referenced a different bug? Yeah it definitely should have. That was a mistake on my end. Is it worth going back and editing the change log? 1543580 3 ashvayka 2019-06-10 20:07:23 -0700 Test262 has complete coverage of internal methods invariants being validated by proxies, including non-extensible targets and non-configurable properties. Just a few of them: https://test262.report/browse/built-ins/Proxy/defineProperty/targetdesc-configurable-desc-not-configurable.js https://test262.report/browse/built-ins/Proxy/defineProperty/targetdesc-undefined-target-is-not-extensible.js https://test262.report/browse/built-ins/Proxy/set/target-property-is-not-configurable-not-writable-not-equal-to-v.js https://test262.report/browse/built-ins/Proxy/set/return-true-target-property-is-not-configurable.js https://test262.report/browse/built-ins/Proxy/isExtensible/return-is-different-from-target.js