154731 2016-02-26 10:15:50 -0800 Initialize LocaleICU data members in header 2016-02-26 12:47:21 -0800 1 1 1 Unclassified WebKit Platform Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 olivier.blin webkit-unassigned annulen commit-queue darin mcatanzaro zan oldest_to_newest 1168555 0 olivier.blin 2016-02-26 10:15:50 -0800 LocaleICU data members should be initialized in the header, to avoid conditional initialization lines in the constructor, as suggested by Darin in bug 154484. 1168559 1 272335 olivier.blin 2016-02-26 10:29:42 -0800 Created attachment 272335 Patch 1168630 2 272335 commit-queue 2016-02-26 12:47:18 -0800 Comment on attachment 272335 Patch Clearing flags on attachment: 272335 Committed r197193: <http://trac.webkit.org/changeset/197193> 1168631 3 commit-queue 2016-02-26 12:47:21 -0800 All reviewed patches have been landed. Closing bug. 272335 2016-02-26 10:29:42 -0800 2016-02-26 12:47:18 -0800 Patch bug-154731-20160226192924.patch text/plain 3062 olivier.blin U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3MTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODFiMGU1NmQ1MmI0ZWU2 ODE5NGU5NDk3MGIyNzUxZjljYmVkYzJjNC4uMTJhYmI3Yzg1YzI2NmQ2Y2Y5YzBiOTIyNDY0MTUw Njc3ZTZkZjJkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTAyLTI2ICBPbGl2 aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5jb20+CisKKyAgICAgICAgSW5pdGlh bGl6ZSBMb2NhbGVJQ1UgZGF0YSBtZW1iZXJzIGluIGhlYWRlcgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU0NzMxCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTG9jYWxlSUNVIGRhdGEgbWVtYmVycyBzaG91 bGQgYmUgaW5pdGlhbGl6ZWQgaW4gdGhlIGhlYWRlciwgdG8KKyAgICAgICAgYXZvaWQgY29uZGl0 aW9uYWwgaW5pdGlhbGl6YXRpb24gbGluZXMgaW4gdGhlIGNvbnN0cnVjdG9yLCBhcworICAgICAg ICBzdWdnZXN0ZWQgYnkgRGFyaW4gaW4gYnVnIDE1NDQ4NC4KKworICAgICAgICAqIHBsYXRmb3Jt L3RleHQvTG9jYWxlSUNVLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxvY2FsZUlDVTo6TG9jYWxl SUNVKTogRGVsZXRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L0xvY2FsZUlDVS5oOgorCiAy MDE2LTAyLTI2ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVH UkVTU0lPTiAoMTg4NjExKTogU2VhcmNoIGZpZWxkIENhbmNlbCBidXR0b24gc2hvdWxkIG5vdCBv dmVybGFwIHNlYXJjaCB0ZXh0IG9uIGV4dGVuc2lvbnMgcGFnZS4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxlSUNVLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL3RleHQvTG9jYWxlSUNVLmNwcAppbmRleCBkZmE2ODhjYTNmNjZmMThiZjhkN2VjODBh N2NhNjljZGZmOWEwOTBiLi40YjhlOTYyZWZkYzlmOGZiOGI4OTE3MjU5MGFlZjJiYzhlMzllODc5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0xvY2FsZUlDVS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGVJQ1UuY3BwCkBAIC01MCwx NyArNTAsNiBAQCBzdGQ6OnVuaXF1ZV9wdHI8TG9jYWxlPiBMb2NhbGU6OmNyZWF0ZShjb25zdCBB dG9taWNTdHJpbmcmIGxvY2FsZSkKIAogTG9jYWxlSUNVOjpMb2NhbGVJQ1UoY29uc3QgY2hhciog bG9jYWxlKQogICAgIDogbV9sb2NhbGUobG9jYWxlKQotI2lmICFVQ09ORklHX05PX0ZPUk1BVFRJ TkcKLSAgICAsIG1fbnVtYmVyRm9ybWF0KDApCi0gICAgLCBtX2RpZENyZWF0ZURlY2ltYWxGb3Jt YXQoZmFsc2UpCi0jZW5kaWYKLSNpZiBFTkFCTEUoREFURV9BTkRfVElNRV9JTlBVVF9UWVBFUykK LSAgICAsIG1fc2hvcnREYXRlRm9ybWF0KDApCi0gICAgLCBtX21lZGl1bVRpbWVGb3JtYXQoMCkK LSAgICAsIG1fc2hvcnRUaW1lRm9ybWF0KDApCi0gICAgLCBtX2RpZENyZWF0ZVNob3J0RGF0ZUZv cm1hdChmYWxzZSkKLSAgICAsIG1fZGlkQ3JlYXRlVGltZUZvcm1hdChmYWxzZSkKLSNlbmRpZgog ewogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0xvY2FsZUlD VS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGVJQ1UuaAppbmRleCBhY2Vm MTUyOTk0NDUzNjE4NTFiZDY0NDViOWFjNDlkYTcxZDkyZTYxLi4wZjA3YjUwNTg4YTY0MDVjYWYy NTZmYjg2MDUxY2I5YjMwNGMxZjFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS90ZXh0L0xvY2FsZUlDVS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9j YWxlSUNVLmgKQEAgLTgxLDggKzgxLDggQEAgcHJpdmF0ZToKICAgICBDU3RyaW5nIG1fbG9jYWxl OwogCiAjaWYgIVVDT05GSUdfTk9fRk9STUFUVElORwotICAgIFVOdW1iZXJGb3JtYXQqIG1fbnVt YmVyRm9ybWF0OwotICAgIGJvb2wgbV9kaWRDcmVhdGVEZWNpbWFsRm9ybWF0OworICAgIFVOdW1i ZXJGb3JtYXQqIG1fbnVtYmVyRm9ybWF0IHsgbnVsbHB0ciB9OworICAgIGJvb2wgbV9kaWRDcmVh dGVEZWNpbWFsRm9ybWF0IHsgZmFsc2UgfTsKICNlbmRpZgogCiAjaWYgRU5BQkxFKERBVEVfQU5E X1RJTUVfSU5QVVRfVFlQRVMpCkBAIC05NCwxNSArOTQsMTUgQEAgcHJpdmF0ZToKICAgICBTdHJp bmcgbV90aW1lRm9ybWF0V2l0aG91dFNlY29uZHM7CiAgICAgU3RyaW5nIG1fZGF0ZVRpbWVGb3Jt YXRXaXRoU2Vjb25kczsKICAgICBTdHJpbmcgbV9kYXRlVGltZUZvcm1hdFdpdGhvdXRTZWNvbmRz OwotICAgIFVEYXRlRm9ybWF0KiBtX3Nob3J0RGF0ZUZvcm1hdDsKLSAgICBVRGF0ZUZvcm1hdCog bV9tZWRpdW1UaW1lRm9ybWF0OwotICAgIFVEYXRlRm9ybWF0KiBtX3Nob3J0VGltZUZvcm1hdDsK KyAgICBVRGF0ZUZvcm1hdCogbV9zaG9ydERhdGVGb3JtYXQgeyBudWxscHRyIH07CisgICAgVURh dGVGb3JtYXQqIG1fbWVkaXVtVGltZUZvcm1hdCB7IG51bGxwdHIgfTsKKyAgICBVRGF0ZUZvcm1h dCogbV9zaG9ydFRpbWVGb3JtYXQgeyBudWxscHRyIH07CiAgICAgVmVjdG9yPFN0cmluZz4gbV9z aG9ydE1vbnRoTGFiZWxzOwogICAgIFZlY3RvcjxTdHJpbmc+IG1fc3RhbmRBbG9uZU1vbnRoTGFi ZWxzOwogICAgIFZlY3RvcjxTdHJpbmc+IG1fc2hvcnRTdGFuZEFsb25lTW9udGhMYWJlbHM7CiAg ICAgVmVjdG9yPFN0cmluZz4gbV90aW1lQU1QTUxhYmVsczsKLSAgICBib29sIG1fZGlkQ3JlYXRl U2hvcnREYXRlRm9ybWF0OwotICAgIGJvb2wgbV9kaWRDcmVhdGVUaW1lRm9ybWF0OworICAgIGJv b2wgbV9kaWRDcmVhdGVTaG9ydERhdGVGb3JtYXQgeyBmYWxzZSB9OworICAgIGJvb2wgbV9kaWRD cmVhdGVUaW1lRm9ybWF0IHsgZmFsc2UgfTsKICNlbmRpZgogfTsKIAo=